Remove redundant references to AppSec

This scoping is now hoisted to the namespace.

lib/datadog/kit/appsec/events.rb

@@ -8,8 +8,8 @@ module Kit
     module AppSec
       # Tracking events
       module Events
-        APPSEC_LOGIN_SUCCESS_EVENT = 'users.login.success'
-        APPSEC_LOGIN_FAILURE_EVENT = 'users.login.failure'
+        LOGIN_SUCCESS_EVENT = 'users.login.success'
+        LOGIN_FAILURE_EVENT = 'users.login.failure'
 
         # Attach login success event information to the trace
         #
@@ -21,7 +21,7 @@ module Events
         # @param others [Hash<String || Symbol, String>] Additional free-form
         #   event information to attach to the trace.
         def self.track_login_success(trace, user:, **others)
-          track(:appsec, APPSEC_LOGIN_SUCCESS_EVENT, trace, **others)
+          track(LOGIN_SUCCESS_EVENT, trace, **others)
 
           user_options = user.dup
           user_id = user.delete(:id)
@@ -41,7 +41,7 @@ def self.track_login_success(trace, user:, **others)
         # @param others [Hash<String || Symbol, String>] Additional free-form
         #   event information to attach to the trace.
         def self.track_login_failure(trace, user_id:, user_exists:, **others)
-          track(:appsec, APPSEC_LOGIN_FAILURE_EVENT, trace, **others)
+          track(LOGIN_FAILURE_EVENT, trace, **others)
 
           raise ArgumentError, 'user_id cannot be nil' if user_id.nil?
 
@@ -53,18 +53,13 @@ def self.track_login_failure(trace, user_id:, user_exists:, **others)
         #
         # This method is experimental and may change in the future.
         #
-        # @param namespace [Symbol] Mandatory. Event namespace. Only :appsec is supported.
         # @param event [String] Mandatory. Event code.
         # @param trace [TraceOperation] Trace to attach data to.
         # @param others [Hash<Symbol, String>] Additional free-form
         #   event information to attach to the trace. Key must not
         #   be :track.
-        def self.track(namespace, event, trace, **others)
-          if namespace.to_sym != :appsec
-            raise ArgumentError, "namespace cannot be #{namespace.inspect}, only :appsec is allowed"
-          end
-
-          trace.set_tag("#{namespace}.events.#{event}.track", 'true')
+        def self.track(event, trace, **others)
+          trace.set_tag("appsec.events.#{event}.track", 'true')
 
           others.each do |k, v|
             raise ArgumentError, 'key cannot be :track' if k.to_sym == :track

sig/datadog/kit/appsec/events.rbs

@@ -2,14 +2,14 @@ module Datadog
   module Kit
     module AppSec
       module Events
-        APPSEC_LOGIN_SUCCESS_EVENT: ::String
-        APPSEC_LOGIN_FAILURE_EVENT: ::String
+        LOGIN_SUCCESS_EVENT: ::String
+        LOGIN_FAILURE_EVENT: ::String
 
         def self.track_login_success: (Datadog::Tracing::TraceOperation trace, user: Hash[::Symbol, ::String | nil], **::Hash[::Symbol, ::String | nil] others) -> void
 
         def self.track_login_failure: (Datadog::Tracing::TraceOperation trace, user_id: ::String, user_exists: bool, **::Hash[::Symbol, ::String | nil] others) -> void
 
-        def self.track: (::Symbol namespace, ::String | ::Symbol event, Datadog::Tracing::TraceOperation trace, **::Hash[::Symbol, ::String | nil] others) -> void
+        def self.track: (::String | ::Symbol event, Datadog::Tracing::TraceOperation trace, **::Hash[::Symbol, ::String | nil] others) -> void
       end
     end
   end

spec/datadog/kit/appsec/events_spec.rb

@@ -74,23 +74,16 @@
   end
 
   describe '#track' do
-    it 'rejects unexpected namespaces' do
-      trace_op.measure('root') do
-        expect { described_class.track(:foo, 'bar', trace_op) }.to raise_error ArgumentError, /namespace cannot be/
-      end
-      expect(meta).to_not include('foo.events.bar.track' => 'true')
-    end
-
     it 'sets event tracking key on trace' do
       trace_op.measure('root') do
-        described_class.track(:appsec, 'foo', trace_op)
+        described_class.track('foo', trace_op)
       end
       expect(meta).to include('appsec.events.foo.track' => 'true')
     end
 
     it 'sets other keys on trace' do
       trace_op.measure('root') do
-        described_class.track(:appsec, 'foo', trace_op, bar: 'baz')
+        described_class.track('foo', trace_op, bar: 'baz')
       end
       expect(meta).to include('appsec.events.foo.bar' => 'baz')
     end