Merge pull request #2013 from DataDog/ivoanjo/prof-5111-align-pid-tags

Rename profiling `pid` tag to `process_id` to align with other products
DataDog · May 12, 2022 · 7367ecf · 7367ecf
2 parents 8dda976 + ff9ed05
commit 7367ecf
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 3 deletions.
diff --git a/lib/datadog/profiling/ext.rb b/lib/datadog/profiling/ext.rb
@@ -30,7 +30,7 @@ module HTTP
           FORM_FIELD_TAG_ENV = 'env'.freeze
           FORM_FIELD_TAG_HOST = 'host'.freeze
           FORM_FIELD_TAG_LANGUAGE = 'language'.freeze
-          FORM_FIELD_TAG_PID = 'pid'.freeze
+          FORM_FIELD_TAG_PID = 'process_id'.freeze
           FORM_FIELD_TAG_PROFILER_VERSION = 'profiler_version'.freeze
           FORM_FIELD_TAG_RUNTIME = 'runtime'.freeze
           FORM_FIELD_TAG_RUNTIME_ENGINE = 'runtime_engine'.freeze

diff --git a/spec/datadog/profiling/transport/http/adapters/net_integration_spec.rb b/spec/datadog/profiling/transport/http/adapters/net_integration_spec.rb
@@ -114,7 +114,7 @@
           /runtime_engine:#{Datadog::Core::Environment::Ext::LANG_ENGINE}/o,
           /runtime_platform:#{Datadog::Core::Environment::Ext::LANG_PLATFORM}/o,
           /runtime_version:#{Datadog::Core::Environment::Ext::LANG_VERSION}/o,
-          /pid:#{Process.pid}/o,
+          /process_id:#{Process.pid}/o,
           /profiler_version:#{Datadog::Core::Environment::Ext::TRACER_VERSION}/o,
           /language:ruby/o,
           'test_tag:test_value'

diff --git a/spec/datadog/profiling/transport/http/api/endpoint_spec.rb b/spec/datadog/profiling/transport/http/api/endpoint_spec.rb
@@ -69,7 +69,7 @@
             "runtime_engine:#{flush.runtime_engine}",
             "runtime_platform:#{flush.runtime_platform}",
             "runtime_version:#{flush.runtime_version}",
-            "pid:#{Process.pid}",
+            "process_id:#{Process.pid}",
             "profiler_version:#{flush.profiler_version}",
             "language:#{flush.language}",
             "host:#{flush.host}"