Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ci_visibility): support pytest 8.0.0 [backport 2.6] #8475

Merged
merged 1 commit into from
Feb 21, 2024

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Feb 21, 2024

Backport 78d5b98 from #8357 to 2.6.

Addresses #8220 and fixes an issue with pytest 8.x and above
(brought by pytest-dev/pytest#11137 ) where pytest.Package objects no longer have an attached module attribute.

This also changes the testing matrix to include version ~=8.0, but maintains ~=7.0 as a separate testing environment.

Checklist

  • Change(s) are motivated and described in the PR description
  • Testing strategy is described if automated tests are not included in the PR
  • Risks are described (performance impact, potential for breakage, maintainability)
  • Change is maintainable (easy to change, telemetry, documentation)
  • Library release note guidelines are followed or label changelog/no-changelog is set
  • Documentation is included (in-code, generated user docs, public corp docs)
  • Backport labels are set (if applicable)
  • If this PR changes the public interface, I've notified @DataDog/apm-tees.
  • If change touches code that signs or publishes builds or packages, or handles credentials of any kind, I've requested a review from @DataDog/security-design-and-guidance.

Reviewer Checklist

  • Title is accurate
  • All changes are related to the pull request's stated goal
  • Description motivates each change
  • Avoids breaking API changes
  • Testing strategy adequately addresses listed risks
  • Change is maintainable (easy to change, telemetry, documentation)
  • Release note makes sense to a user of the library
  • Author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment
  • Backport labels are set in a manner that is consistent with the release branch maintenance policy

Addresses #8220 and fixes
an issue with `pytest` `8.x` and above
(brought by pytest-dev/pytest#11137 ) where
`pytest.Package` objects no longer have an attached `module` attribute.

This also changes the testing matrix to include version `~=8.0`, but
maintains `~=7.0` as a separate testing environment.

## Checklist

- [x] Change(s) are motivated and described in the PR description
- [x] Testing strategy is described if automated tests are not included
in the PR
- [x] Risks are described (performance impact, potential for breakage,
maintainability)
- [x] Change is maintainable (easy to change, telemetry, documentation)
- [x] [Library release note
guidelines](https://ddtrace.readthedocs.io/en/stable/releasenotes.html)
are followed or label `changelog/no-changelog` is set
- [x] Documentation is included (in-code, generated user docs, [public
corp docs](https://github.com/DataDog/documentation/))
- [x] Backport labels are set (if
[applicable](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting))
- [x] If this PR changes the public interface, I've notified
`@DataDog/apm-tees`.
- [x] If change touches code that signs or publishes builds or packages,
or handles credentials of any kind, I've requested a review from
`@DataDog/security-design-and-guidance`.

## Reviewer Checklist

- [x] Title is accurate
- [x] All changes are related to the pull request's stated goal
- [x] Description motivates each change
- [x] Avoids breaking
[API](https://ddtrace.readthedocs.io/en/stable/versioning.html#interfaces)
changes
- [x] Testing strategy adequately addresses listed risks
- [x] Change is maintainable (easy to change, telemetry, documentation)
- [x] Release note makes sense to a user of the library
- [x] Author has acknowledged and discussed the performance implications
of this PR as reported in the benchmarks PR comment
- [x] Backport labels are set in a manner that is consistent with the
[release branch maintenance
policy](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting)

---------

Co-authored-by: Munir Abdinur <[email protected]>
(cherry picked from commit 78d5b98)
@datadog-dd-trace-py-rkomorn
Copy link

Datadog Report

Branch report: backport-8357-to-2.6
Commit report: 2ebae09
Test service: dd-trace-py

✅ 0 Failed, 171460 Passed, 1015 Skipped, 11h 53m 29.16s Total duration (34m 40.9s time saved)

@pr-commenter
Copy link

pr-commenter bot commented Feb 21, 2024

Benchmarks

Benchmark execution time: 2024-02-21 17:58:31

Comparing candidate commit 2ebae09 in PR branch backport-8357-to-2.6 with baseline commit d3c559b in branch 2.6.

Found 1 performance improvements and 0 performance regressions! Performance is the same for 194 metrics, 9 unstable metrics.

scenario:flasksimple-debugger

  • 🟩 execution_time [-379.591µs; -331.635µs] or [-5.711%; -4.989%]

@mabdinur mabdinur closed this Feb 21, 2024
@mabdinur mabdinur reopened this Feb 21, 2024
@mabdinur mabdinur enabled auto-merge (squash) February 21, 2024 19:23
@mabdinur mabdinur merged commit 8d2e0c0 into 2.6 Feb 21, 2024
129 checks passed
@mabdinur mabdinur deleted the backport-8357-to-2.6 branch February 21, 2024 20:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants