Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(setup): out-of-memory error [backport 1.18] #6804

Merged
merged 2 commits into from
Sep 1, 2023

Conversation

github-actions[bot]
Copy link
Contributor

Backport 07f59ac from #6792 to 1.18.

When running setup.py extensions with the CMake parameter "-j", it could potentially raise an out-of-memory error. If someone wants to expedite the ddtrace installation, they should manually set the "CMAKE_BUILD_PARALLEL_LEVEL" environment variable.

Checklist

  • Change(s) are motivated and described in the PR description.
  • Testing strategy is described if automated tests are not included in the PR.
  • Risk is outlined (performance impact, potential for breakage, maintainability, etc).
  • Change is maintainable (easy to change, telemetry, documentation).
  • Library release note guidelines are followed. If no release note is required, add label changelog/no-changelog.
  • Documentation is included (in-code, generated user docs, public corp docs).
  • Backport labels are set (if applicable)

Reviewer Checklist

  • Title is accurate.
  • No unnecessary changes are introduced.
  • Description motivates each change.
  • Avoids breaking API changes unless absolutely necessary.
  • Testing strategy adequately addresses listed risk(s).
  • Change is maintainable (easy to change, telemetry, documentation).
  • Release note makes sense to a user of the library.
  • Reviewer has explicitly acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment.
  • Backport labels are set in a manner that is consistent with the release branch maintenance policy

When running setup.py extensions with the CMake parameter "-j", it could
potentially raise an out-of-memory error. If someone wants to expedite
the ddtrace installation, they should manually set the
"CMAKE_BUILD_PARALLEL_LEVEL" environment variable.
## Checklist

- [X] Change(s) are motivated and described in the PR description.
- [X] Testing strategy is described if automated tests are not included
in the PR.
- [X] Risk is outlined (performance impact, potential for breakage,
maintainability, etc).
- [X] Change is maintainable (easy to change, telemetry, documentation).
- [X] [Library release note
guidelines](https://ddtrace.readthedocs.io/en/stable/releasenotes.html)
are followed. If no release note is required, add label
`changelog/no-changelog`.
- [X] Documentation is included (in-code, generated user docs, [public
corp docs](https://github.com/DataDog/documentation/)).
- [X] Backport labels are set (if
[applicable](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting))

## Reviewer Checklist

- [x] Title is accurate.
- [x] No unnecessary changes are introduced.
- [x] Description motivates each change.
- [x] Avoids breaking
[API](https://ddtrace.readthedocs.io/en/stable/versioning.html#interfaces)
changes unless absolutely necessary.
- [x] Testing strategy adequately addresses listed risk(s).
- [x] Change is maintainable (easy to change, telemetry, documentation).
- [x] Release note makes sense to a user of the library.
- [x] Reviewer has explicitly acknowledged and discussed the performance
implications of this PR as reported in the benchmarks PR comment.
- [x] Backport labels are set in a manner that is consistent with the
[release branch maintenance
policy](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting)

(cherry picked from commit 07f59ac)
@github-actions github-actions bot requested review from a team as code owners August 31, 2023 07:25
@github-actions github-actions bot requested a review from P403n1x87 August 31, 2023 07:25
@github-actions github-actions bot added the ASM Application Security Monitoring label Aug 31, 2023
@pr-commenter
Copy link

pr-commenter bot commented Aug 31, 2023

Benchmarks

Benchmark execution time: 2023-08-31 10:11:06

Comparing candidate commit 7da70de in PR branch backport-6792-to-1.18 with baseline commit 9c036b7 in branch 1.18.

Found 1 performance improvements and 0 performance regressions! Performance is the same for 93 metrics, 0 unstable metrics.

scenario:samplingrules-high_match

  • 🟩 max_rss_usage [-703.876KB; -609.711KB] or [-2.483%; -2.151%]

@avara1986 avara1986 enabled auto-merge (squash) September 1, 2023 09:52
@avara1986 avara1986 merged commit 67dc041 into 1.18 Sep 1, 2023
@avara1986 avara1986 deleted the backport-6792-to-1.18 branch September 1, 2023 09:54
@github-actions github-actions bot added this to the v1.18.4 milestone Sep 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ASM Application Security Monitoring
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants