Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci(telemetry): fix failing instrumentation telemetry test [backport to 1.18] #6779

Merged
merged 1 commit into from
Aug 28, 2023

Conversation

mabdinur
Copy link
Contributor

@mabdinur mabdinur commented Aug 28, 2023

Test failure was introduced in 619c4bf

This fix was cherry-picked from the following commit: e738aa9

Checklist

  • Change(s) are motivated and described in the PR description.
  • Testing strategy is described if automated tests are not included in the PR.
  • Risk is outlined (performance impact, potential for breakage, maintainability, etc).
  • Change is maintainable (easy to change, telemetry, documentation).
  • Library release note guidelines are followed. If no release note is required, add label changelog/no-changelog.
  • Documentation is included (in-code, generated user docs, public corp docs).
  • Backport labels are set (if applicable)

Reviewer Checklist

  • Title is accurate.
  • No unnecessary changes are introduced.
  • Description motivates each change.
  • Avoids breaking API changes unless absolutely necessary.
  • Testing strategy adequately addresses listed risk(s).
  • Change is maintainable (easy to change, telemetry, documentation).
  • Release note makes sense to a user of the library.
  • Reviewer has explicitly acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment.
  • Backport labels are set in a manner that is consistent with the release branch maintenance policy
  • If this PR touches code that signs or publishes builds or packages, or handles credentials of any kind, I've requested a review from @DataDog/security-design-and-guidance.
  • This PR doesn't touch any of that.

@mabdinur mabdinur requested review from a team as code owners August 28, 2023 21:17
@mabdinur mabdinur enabled auto-merge (squash) August 28, 2023 21:31
@mabdinur mabdinur changed the title ci(telemetry): fix failing instrumentation telemetry test ci(telemetry): fix failing instrumentation telemetry test [backport to 1.18] Aug 28, 2023
@mabdinur mabdinur added the changelog/no-changelog A changelog entry is not required for this PR. label Aug 28, 2023
@mabdinur mabdinur merged commit 9a39c3a into 1.18 Aug 28, 2023
@mabdinur mabdinur deleted the munir/fix-failing-telemetry-test branch August 28, 2023 21:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog/no-changelog A changelog entry is not required for this PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants