Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(pymongo): update pymongo integration for compatibility with 4.5.x [backport 1.18] #6775

Merged
merged 3 commits into from
Aug 28, 2023

Conversation

github-actions[bot]
Copy link
Contributor

Backport 1a3c424 from #6736 to 1.18.

Pymongo 4.5.0 changed the name of the get_socket function on which our integration is based. This pull request adapts the integration to work with version 4.5.0 by changing the expected function name based on the version.

Fixes #6723

Checklist

  • Change(s) are motivated and described in the PR description.
  • Testing strategy is described if automated tests are not included in the PR.
  • Risk is outlined (performance impact, potential for breakage, maintainability, etc).
  • Change is maintainable (easy to change, telemetry, documentation).
  • Library release note guidelines are followed. If no release note is required, add label changelog/no-changelog.
  • Documentation is included (in-code, generated user docs, public corp docs).
  • Backport labels are set (if applicable)

Reviewer Checklist

  • Title is accurate.
  • No unnecessary changes are introduced.
  • Description motivates each change.
  • Avoids breaking API changes unless absolutely necessary.
  • Testing strategy adequately addresses listed risk(s).
  • Change is maintainable (easy to change, telemetry, documentation).
  • Release note makes sense to a user of the library.
  • Reviewer has explicitly acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment.
  • Backport labels are set in a manner that is consistent with the release branch maintenance policy

….x (#6736)

Pymongo 4.5.0 [changed the
name](mongodb/mongo-python-driver#1329) of the
`get_socket` function on which our integration is based. This pull
request adapts the integration to work with version 4.5.0 by changing
the expected function name based on the version.

Fixes #6723

## Checklist

- [x] Change(s) are motivated and described in the PR description.
- [x] Testing strategy is described if automated tests are not included
in the PR.
- [x] Risk is outlined (performance impact, potential for breakage,
maintainability, etc).
- [x] Change is maintainable (easy to change, telemetry, documentation).
- [x] [Library release note
guidelines](https://ddtrace.readthedocs.io/en/stable/releasenotes.html)
are followed. If no release note is required, add label
`changelog/no-changelog`.
- [x] Documentation is included (in-code, generated user docs, [public
corp docs](https://github.com/DataDog/documentation/)).
- [x] Backport labels are set (if
[applicable](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting))

## Reviewer Checklist

- [x] Title is accurate.
- [x] No unnecessary changes are introduced.
- [x] Description motivates each change.
- [x] Avoids breaking
[API](https://ddtrace.readthedocs.io/en/stable/versioning.html#interfaces)
changes unless absolutely necessary.
- [x] Testing strategy adequately addresses listed risk(s).
- [x] Change is maintainable (easy to change, telemetry, documentation).
- [x] Release note makes sense to a user of the library.
- [x] Reviewer has explicitly acknowledged and discussed the performance
implications of this PR as reported in the benchmarks PR comment.
- [x] Backport labels are set in a manner that is consistent with the
[release branch maintenance
policy](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting)

---------

Co-authored-by: Teague Bick <[email protected]>
(cherry picked from commit 1a3c424)
@github-actions github-actions bot requested review from a team as code owners August 28, 2023 16:24
@pr-commenter
Copy link

pr-commenter bot commented Aug 28, 2023

Benchmarks

Benchmark execution time: 2023-08-28 17:06:37

Comparing candidate commit 1d26dd1 in PR branch backport-6736-to-1.18 with baseline commit fd669cf in branch 1.18.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 86 metrics, 0 unstable metrics.

@mabdinur mabdinur closed this Aug 28, 2023
@mabdinur mabdinur reopened this Aug 28, 2023
@mabdinur mabdinur enabled auto-merge (squash) August 28, 2023 17:35
@mabdinur mabdinur merged commit 530b3dc into 1.18 Aug 28, 2023
@mabdinur mabdinur deleted the backport-6736-to-1.18 branch August 28, 2023 18:25
@github-actions github-actions bot added this to the v1.18.3 milestone Aug 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants