Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(rcm): get connection on every request #6753

Merged

Conversation

P403n1x87
Copy link
Contributor

@P403n1x87 P403n1x87 commented Aug 24, 2023

We get the connection on every request to ensure that the agent is actually still available. If not, we might be attempting to read from an invalid connection, causing the I/O operation to block.

Checklist

  • Change(s) are motivated and described in the PR description.
  • Testing strategy is described if automated tests are not included in the PR.
  • Risk is outlined (performance impact, potential for breakage, maintainability, etc).
  • Change is maintainable (easy to change, telemetry, documentation).
  • Library release note guidelines are followed. If no release note is required, add label changelog/no-changelog.
  • Documentation is included (in-code, generated user docs, public corp docs).
  • Backport labels are set (if applicable)

Reviewer Checklist

  • Title is accurate.
  • No unnecessary changes are introduced.
  • Description motivates each change.
  • Avoids breaking API changes unless absolutely necessary.
  • Testing strategy adequately addresses listed risk(s).
  • Change is maintainable (easy to change, telemetry, documentation).
  • Release note makes sense to a user of the library.
  • Reviewer has explicitly acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment.
  • Backport labels are set in a manner that is consistent with the release branch maintenance policy
  • If this PR touches code that signs or publishes builds or packages, or handles credentials of any kind, I've requested a review from @DataDog/security-design-and-guidance.
  • This PR doesn't touch any of that.

We get the connection on every request to ensure that the agent is
actually still available. If not, we might be attempting to read
from an invalid connection, causing the I/O operation to block.
@P403n1x87 P403n1x87 added the changelog/no-changelog A changelog entry is not required for this PR. label Aug 24, 2023
@P403n1x87 P403n1x87 marked this pull request as ready for review August 24, 2023 21:35
@P403n1x87 P403n1x87 requested review from a team as code owners August 24, 2023 21:35
@P403n1x87 P403n1x87 enabled auto-merge (squash) August 25, 2023 13:13
@P403n1x87 P403n1x87 merged commit f673d29 into DataDog:1.x Aug 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog/no-changelog A changelog entry is not required for this PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants