-
Notifications
You must be signed in to change notification settings - Fork 417
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: move some functions to a new appsec/_capabilities.py file to avoid cyclic imports #6700
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…clic imports Signed-off-by: Juanjo Alvarez <[email protected]>
juanjux
added
changelog/no-changelog
A changelog entry is not required for this PR.
ASM
Application Security Monitoring
labels
Aug 21, 2023
Signed-off-by: Juanjo Alvarez <[email protected]>
…ic-import # Conflicts: # ddtrace/appsec/utils.py
Signed-off-by: Juanjo Alvarez <[email protected]>
juanjux
changed the title
Move some functions to a new appsec/_capabilities.py file to avoid cyclic imports
chore: move some functions to a new appsec/_capabilities.py file to avoid cyclic imports
Aug 21, 2023
avara1986
previously approved these changes
Aug 21, 2023
Signed-off-by: Juanjo Alvarez <[email protected]>
juanjux
force-pushed
the
juanjux/fix-utils-cyclic-import
branch
from
August 21, 2023 09:48
6db9562
to
cac41a8
Compare
avara1986
previously approved these changes
Aug 21, 2023
BenchmarksBenchmark execution time: 2023-08-21 12:48:16 Comparing candidate commit 27e01d9 in PR branch Found 1 performance improvements and 0 performance regressions! Performance is the same for 93 metrics, 0 unstable metrics. scenario:flasksimple-appsec-telemetry
|
Signed-off-by: Juanjo Alvarez <[email protected]>
Signed-off-by: Juanjo Alvarez <[email protected]>
Signed-off-by: Juanjo Alvarez <[email protected]>
avara1986
approved these changes
Aug 21, 2023
emmettbutler
approved these changes
Aug 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
ASM
Application Security Monitoring
changelog/no-changelog
A changelog entry is not required for this PR.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a potencial cyclic import when importing
appsec.utils._appsec_rc_capabilities
.Checklist
changelog/no-changelog
.Reviewer Checklist