Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(gunicorn): add tests #4776

Merged
merged 12 commits into from
Dec 20, 2022
Merged

chore(gunicorn): add tests #4776

merged 12 commits into from
Dec 20, 2022

Conversation

Kyle-Verhoog
Copy link
Member

Add testing support for gunicorn. While documentation has been provided for using ddtrace with gunicorn, there were no tests ensuring that the library actually works with it.

Reviewer Checklist

  • Title is accurate.
  • Description motivates each change.
  • No unnecessary changes were introduced in this PR.
  • Avoid breaking API changes unless absolutely necessary.
  • Tests provided or description of manual testing performed is included in the code or PR.
  • Release note has been added and follows the library release note guidelines, or else changelog/no-changelog label added.
  • All relevant GitHub issues are correctly linked.
  • Backports are identified and tagged with Mergifyio.

@Kyle-Verhoog Kyle-Verhoog requested a review from a team as a code owner December 12, 2022 23:07
@Kyle-Verhoog Kyle-Verhoog added the changelog/no-changelog A changelog entry is not required for this PR. label Dec 12, 2022
@Kyle-Verhoog
chore(gunicorn): add tests
41fa8d4 
Add testing support for gunicorn. While documentation has been provided
for using ddtrace with gunicorn, there were no tests ensuring that the
library actually works with it.
P403n1x87
P403n1x87 reviewed Dec 19, 2022
View reviewed changes
riotfile.py Show resolved Hide resolved
P403n1x87
P403n1x87 reviewed Dec 19, 2022
View reviewed changes
Copy link
Contributor

@P403n1x87 P403n1x87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one question otherwise LGTM! 💪

@Yun-Kim Yun-Kim merged commit e9f7a87 into 1.x Dec 20, 2022
@Yun-Kim Yun-Kim deleted the gunicorn-fixture branch December 20, 2022 15:39
@github-actions github-actions bot added this to the v1.8.0 milestone Dec 20, 2022
This was referenced Dec 20, 2022
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Yun-Kim Yun-Kim Yun-Kim approved these changes

@P403n1x87 P403n1x87 P403n1x87 approved these changes

Assignees
No one assigned
Labels
changelog/no-changelog A changelog entry is not required for this PR.
Projects
None yet
Milestone
v1.8.0
Development

Successfully merging this pull request may close these issues.
3 participants
@Kyle-Verhoog @P403n1x87 @Yun-Kim