chore(lib-injection): use non-root user in image #4490
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kyle-Verhoog
force-pushed
the
lib-injection-user
branch
from
b187dad
to
e28387b
Compare
ahmed-mez
previously approved these changes
Nov 8, 2022
brettlangdon
previously approved these changes
Nov 8, 2022
Kyle-Verhoog
dismissed stale reviews from brettlangdon and ahmed-mez
via
8f853be
Kyle-Verhoog
force-pushed
the
lib-injection-user
branch
from
dd61aaf
to
8f853be
Compare
Containers using the root user can be blocked in Kubernetes which makes our lib injection image incompatible with certain Kubernetes configurations. The solution is to simply add and use a non-root user in the image.
Kyle-Verhoog
force-pushed
the
lib-injection-user
branch
from
8f853be
to
f864d18
Compare
mabdinur
approved these changes
Nov 8, 2022
majorgreys
approved these changes
Nov 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Containers using the root user can be blocked in Kubernetes which makes our lib injection image incompatible with certain Kubernetes configurations.
The solution is to simply add and use a non-root user in the image.
Follows the suggested user configuration mentioned here:
mhart/alpine-node#48 (comment) and supported by this write up.
Resolves #4476
Reviewer Checklist
changelog/no-changeloglabel added.