Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: enable ModuleWatchdog globally #4098

Merged
merged 5 commits into from
Aug 18, 2022
Merged

chore: enable ModuleWatchdog globally #4098

merged 5 commits into from
Aug 18, 2022

Conversation

P403n1x87
Copy link
Contributor

@P403n1x87 P403n1x87 commented Aug 16, 2022 •
edited
Loading

Description

This change installs an instance of the ModuleWatchdog for registering module import hooks.

Checklist

Reviewer Checklist

  • Title is accurate.
  • Description motivates each change.
  • No unnecessary changes were introduced in this PR.
  • PR cannot be broken up into smaller PRs.
  • Avoid breaking API changes unless absolutely necessary.
  • Tests provided or description of manual testing performed is included in the code or PR.
  • Release note has been added for fixes and features, or else changelog/no-changelog label added.
  • All relevant GitHub issues are correctly linked.
  • Backports are identified and tagged with Mergifyio.
  • Add to milestone.

@P403n1x87 P403n1x87 added the changelog/no-changelog A changelog entry is not required for this PR. label Aug 16, 2022
@P403n1x87 P403n1x87 requested a review from a team as a code owner August 16, 2022 13:20
brettlangdon
brettlangdon reviewed Aug 16, 2022
View reviewed changes
tests/internal/test_module.py Outdated Show resolved Hide resolved
tests/internal/test_module.py Outdated Show resolved Hide resolved
@P403n1x87
chore: enable ModuleWatchdog globally
fad2344 
This change installs an instance of the ModuleWatchodog for registering
module import hooks.
@P403n1x87 P403n1x87 force-pushed the chore/enable-module-watchdog branch from 72f7f8e to fad2344 Compare August 16, 2022 13:25
@P403n1x87
chore: enable ModuleWatchdog globally
80d0e8e 
This change installs an instance of the ModuleWatchodog for registering
module import hooks.
@P403n1x87 P403n1x87 force-pushed the chore/enable-module-watchdog branch from fad2344 to 80d0e8e Compare August 17, 2022 09:13
@P403n1x87 P403n1x87 mentioned this pull request Aug 17, 2022
Merged
14 tasks
@P403n1x87 P403n1x87 requested review from brettlangdon and a team August 17, 2022 18:00
@mergify mergify bot merged commit 81548b9 into DataDog:1.x Aug 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mabdinur mabdinur mabdinur approved these changes

@jd jd jd approved these changes

@brettlangdon brettlangdon Awaiting requested review from brettlangdon

Assignees
No one assigned
Labels
changelog/no-changelog A changelog entry is not required for this PR.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@P403n1x87 @jd @brettlangdon @mabdinur