-
Notifications
You must be signed in to change notification settings - Fork 418
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(internal): handle additional attributes in module watchdog #4049
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PEP 302 documents the optional method get_data for the loader. This change adds support for that method to the module watchdog import hook system.
P403n1x87
added
the
changelog/no-changelog
A changelog entry is not required for this PR.
label
Aug 4, 2022
mabdinur
previously approved these changes
Aug 4, 2022
mabdinur
reviewed
Aug 4, 2022
Codecov Report
@@ Coverage Diff @@
## 1.x #4049 +/- ##
==========================================
- Coverage 79.86% 79.10% -0.77%
==========================================
Files 717 718 +1
Lines 56347 56717 +370
==========================================
- Hits 45004 44865 -139
- Misses 11343 11852 +509
📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
P403n1x87
changed the title
chore(internal): handle get_data in module watchdog
chore(internal): handle additional attributes in module watchdog
Aug 10, 2022
14 tasks
mabdinur
approved these changes
Aug 10, 2022
brettlangdon
approved these changes
Aug 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
PEP 302 documents additional optional methods for the loader. This change adds support for them by proxying attribute requests to the underlying loader instance, when not specifically overridden. The
__class__
attribute is also handled specially to allowisinstance
to believe that instances of the module watchdog loader are also instances of the underlying actual loader. This is required by some tools, e.g.slotscheck
, that can handle only certain known types of loader (e.g. those that come with the Python stdlib).Checklist
feat
andfix
pull requests.Reviewer Checklist
changelog/no-changelog
label added.