-
Notifications
You must be signed in to change notification settings - Fork 410
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(asm): add a ctypes based ddprof module #11157
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: Juanjo Alvarez <[email protected]>
Signed-off-by: Juanjo Alvarez <[email protected]>
Signed-off-by: Juanjo Alvarez <[email protected]>
Signed-off-by: Juanjo Alvarez <[email protected]>
Signed-off-by: Juanjo Alvarez <[email protected]>
Signed-off-by: Juanjo Alvarez <[email protected]>
Signed-off-by: Juanjo Alvarez <[email protected]>
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, maybe you can add some example script that calls start_profiling
and stop_profiling
to showcase the usage
Signed-off-by: Juanjo Alvarez <[email protected]>
BenchmarksBenchmark execution time: 2024-10-25 15:00:48 Comparing candidate commit 2480b57 in PR branch Found 5 performance improvements and 0 performance regressions! Performance is the same for 383 metrics, 2 unstable metrics. scenario:iast_aspects-format_map_aspect
scenario:iast_aspects-ospathbasename_aspect
scenario:iast_aspects-ospathdirname_aspect
scenario:iast_aspects-ospathsplit_aspect
scenario:iast_aspects-split_aspect
|
Should it be used as the following?
|
That's right (stop profiling has a parameter for the timeout to wait in milliseconds). There is not much complication on it. |
Signed-off-by: Juanjo Alvarez <[email protected]>
Signed-off-by: Juanjo Alvarez <[email protected]>
Datadog ReportBranch report: ✅ 0 Failed, 1286 Passed, 0 Skipped, 29m 44.22s Total duration (7m 55.54s time saved) |
Signed-off-by: Juanjo Alvarez <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is exactly why we build libdd_profiling.so and it's really exciting to see it used!
Signed-off-by: Juanjo Alvarez <[email protected]>
Add a small and private ctypes-based
_ddprof
module and a script to download the.so
binary (including it is not an option since it's 17mb) to ease using ddprof start and stop functions to profile specific parts of the tracer.Signed-off-by: Juanjo Alvarez [email protected]## Checklist
Reviewer Checklist