-
Notifications
You must be signed in to change notification settings - Fork 410
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(iast): remove DD_IAST_TELEMETRY_VERBOSITY env var usage #11155
base: main
Are you sure you want to change the base?
Conversation
|
BenchmarksBenchmark execution time: 2024-10-25 13:12:04 Comparing candidate commit 85df159 in PR branch Found 0 performance improvements and 0 performance regressions! Performance is the same for 388 metrics, 2 unstable metrics. |
@@ -80,7 +65,7 @@ def _set_iast_error_metric(msg: Text) -> None: | |||
} | |||
telemetry.telemetry_writer.add_log(TELEMETRY_LOG_LEVEL.ERROR, msg, stack_trace=stack_trace, tags=tags) | |||
except Exception: | |||
log.warning("Error reporting ASM logs metrics", exc_info=True) | |||
log.warning("[IAST] Error reporting logs metrics", exc_info=True) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Silly question... 😅 Generally speaking, is the scope hierarchy:
AppSec > ASM > IAST ?
So this change is narrowing the scope of the warning log from ASM -> IAST?
Code Security: Remove internal usage of
DD_IAST_TELEMETRY_VERBOSITY
env var using theasm_config
valueChecklist
Reviewer Checklist