-
Notifications
You must be signed in to change notification settings - Fork 416
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[enhancement] aiohttp client tracing #285
Comments
feel free to assign to me because I need to use this soon. Will be part of my larger asyncio PR: #248 |
Thanks for reporting this improvement! I think you can make an instrumentation for the underlying request, just working on the client right? something similar has been done for the built-in |
aiobotocore uses aiohttp, so by adding this we'd trace all the retries. Thanks for the hints. botocore uses a vendored requests so we'd have to be careful about supporting that. |
Great! Thank you for all those contributions for |
ping ping ;) #294 |
hey @thehesiod, I will close this issue for now since we have #294 to track this work. |
This would be useful not only for the obvious reasons of being able to trace aiohttp client queries, however has side-benefits like tracing each request made from aiobotocore.
I'm adding this as a issue because I just found that botocore/aiobotocore doesn't trace the underlying retry requests, and right now only convey back the information from the last request. This is useful in our case because we want to log the request IDs of AWS requests that timed out so we can open a support case.
The text was updated successfully, but these errors were encountered: