-
Notifications
You must be signed in to change notification settings - Fork 312
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
don't clobber manually-installed tracer with SSI #4300
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Overall package sizeSelf size: 6.48 MB Dependency sizes
🤖 This report was automatically generated by heaviest-objects-in-the-universe |
bengl
force-pushed
the
bengl/no-ssi-clobber
branch
from
May 14, 2024 04:12
5b736ed
to
63f897c
Compare
bengl
changed the title
don\'t clobber manually-installed tracer with SSI
don't clobber manually-installed tracer with SSI
May 14, 2024
bengl
force-pushed
the
bengl/no-ssi-clobber
branch
from
May 14, 2024 04:18
63f897c
to
97746ae
Compare
bengl
force-pushed
the
bengl/no-ssi-clobber
branch
2 times, most recently
from
May 14, 2024 04:27
6946228
to
93a55ac
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4300 +/- ##
==========================================
+ Coverage 86.09% 87.07% +0.97%
==========================================
Files 245 245
Lines 10345 10343 -2
Branches 33 33
==========================================
+ Hits 8907 9006 +99
+ Misses 1438 1337 -101 ☔ View full report in Codecov by Sentry. |
Qard
previously approved these changes
May 14, 2024
rochdev
reviewed
May 14, 2024
bengl
force-pushed
the
bengl/no-ssi-clobber
branch
from
May 14, 2024 21:25
93a55ac
to
dc09f8c
Compare
rochdev
approved these changes
May 15, 2024
Qard
approved these changes
May 15, 2024
szegedi
approved these changes
May 15, 2024
bengl
force-pushed
the
bengl/no-ssi-clobber
branch
from
May 16, 2024 17:33
dc09f8c
to
050cd1b
Compare
khanayan123
pushed a commit
that referenced
this pull request
May 16, 2024
khanayan123
pushed a commit
that referenced
this pull request
May 16, 2024
khanayan123
pushed a commit
that referenced
this pull request
May 17, 2024
khanayan123
pushed a commit
that referenced
this pull request
May 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Stops SSI-installed tracer from clobbering manually-installed tracer.
Motivation
A manually-installed tracer shouldn't be interfered with by SSI.