-
Notifications
You must be signed in to change notification settings - Fork 306
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix timeouts from aws-sdk kinesis tests #3910
Conversation
Overall package sizeSelf size: 5.82 MB Dependency sizes
🤖 This report was automatically generated by heaviest-objects-in-the-universe |
7f92980
to
175f2af
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3910 +/- ##
=======================================
Coverage 84.70% 84.70%
=======================================
Files 237 237
Lines 10147 10147
Branches 33 33
=======================================
Hits 8595 8595
Misses 1552 1552 ☔ View full report in Codecov by Sentry. |
BenchmarksBenchmark execution time: 2023-12-28 16:13:50 Comparing candidate commit 35a5bed in PR branch Found 1 performance improvements and 0 performance regressions! Performance is the same for 520 metrics, 11 unstable metrics. scenario:plugin-graphql-with-depth-off-18
|
175f2af
to
307d4cd
Compare
307d4cd
to
35a5bed
Compare
Reverts a change made in 68f2d61 |
Part of a change, anyway. The |
What does this PR do?
Not sure why the timeout was being adjusted back down from unlimited, but leaving it unlimited should allow kinesis to actually finish creating the stream...
Motivation
aws-sdk
has been a continuous pain in the quest for green CI. 😅Security
Datadog employees:
@DataDog/security-design-and-guidance
.