-
Notifications
You must be signed in to change notification settings - Fork 306
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix integration tests by pinned chai to v4 as v5 went ESM-only #3909
Conversation
Overall package sizeSelf size: 5.82 MB Dependency sizes
🤖 This report was automatically generated by heaviest-objects-in-the-universe |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3909 +/- ##
=======================================
Coverage 84.68% 84.68%
=======================================
Files 237 237
Lines 10137 10137
Branches 33 33
=======================================
Hits 8585 8585
Misses 1552 1552 ☔ View full report in Codecov by Sentry. |
50bce35
to
49b15d1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the fix !
BenchmarksBenchmark execution time: 2023-12-28 14:43:36 Comparing candidate commit 49b15d1 in PR branch Found 1 performance improvements and 0 performance regressions! Performance is the same for 517 metrics, 14 unstable metrics. scenario:plugin-q-with-tracer-16
|
What does this PR do?
Fixes the integration tests for ci-app as chai just released an ESM-only major release and we weren't pinning to any particular range.
Motivation
Continuing the battle against red CI. ⚔️
Security
Datadog employees:
@DataDog/security-design-and-guidance
.