Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[profiling] Fix compatibility with node < 14.18 #3908

Merged
merged 2 commits into from
Dec 28, 2023
Merged

Conversation

nsavoire
Copy link
Collaborator

@nsavoire nsavoire commented Dec 28, 2023

What does this PR do?

Node 14 versions prior to 14.18 do not support require statements with node: prefix.

Security

Datadog employees:

  • If this PR touches code that signs or publishes builds or packages, or handles credentials of any kind, I've requested a review from @DataDog/security-design-and-guidance.
  • This PR doesn't touch any of that.

Unsure? Have a question? Request a review!

Node 14 versions prior to 14.18 do not support require statements with
`node:` prefix.
@nsavoire nsavoire requested a review from a team as a code owner December 28, 2023 13:13
Copy link

github-actions bot commented Dec 28, 2023

Overall package size

Self size: 5.82 MB
Deduped: 61.23 MB
No deduping: 61.99 MB

Dependency sizes

name version self size total size
@datadog/native-iast-taint-tracking 1.6.4 16.43 MB 16.44 MB
@datadog/native-appsec 6.0.0 14.48 MB 14.48 MB
@datadog/pprof 4.1.0 9.36 MB 10.21 MB
protobufjs 7.2.5 2.77 MB 6.56 MB
@datadog/native-iast-rewriter 2.2.2 2.29 MB 2.37 MB
@opentelemetry/core 1.14.0 872.87 kB 1.47 MB
@datadog/native-metrics 2.0.0 898.77 kB 1.3 MB
@opentelemetry/api 1.4.1 780.32 kB 780.32 kB
import-in-the-middle 1.4.2 41.4 kB 704.79 kB
pprof-format 2.0.7 588.12 kB 588.12 kB
msgpack-lite 0.1.26 201.16 kB 281.59 kB
opentracing 0.14.7 194.81 kB 194.81 kB
semver 7.5.4 93.4 kB 123.8 kB
@datadog/sketches-js 2.1.0 109.9 kB 109.9 kB
lodash.sortby 4.7.0 75.76 kB 75.76 kB
lru-cache 7.14.0 74.95 kB 74.95 kB
ipaddr.js 2.1.0 60.23 kB 60.23 kB
ignore 5.2.4 51.22 kB 51.22 kB
int64-buffer 0.1.10 49.18 kB 49.18 kB
istanbul-lib-coverage 3.2.0 29.34 kB 29.34 kB
lodash.uniq 4.5.0 25.01 kB 25.01 kB
tlhunter-sorted-set 0.1.0 24.94 kB 24.94 kB
limiter 1.1.5 23.17 kB 23.17 kB
dc-polyfill 0.1.2 22.77 kB 22.77 kB
retry 0.13.1 18.85 kB 18.85 kB
lodash.kebabcase 4.1.1 17.75 kB 17.75 kB
node-abort-controller 3.1.1 16.89 kB 16.89 kB
lodash.pick 4.4.0 16.33 kB 16.33 kB
jest-docblock 29.7.0 8.99 kB 12.76 kB
crypto-randomuuid 1.0.0 11.18 kB 11.18 kB
path-to-regexp 0.1.7 6.78 kB 6.78 kB
koalas 1.0.2 6.47 kB 6.47 kB
methods 1.1.2 5.29 kB 5.29 kB
module-details-from-path 1.0.3 4.47 kB 4.47 kB

🤖 This report was automatically generated by heaviest-objects-in-the-universe

@nsavoire nsavoire added bug Something isn't working profiling labels Dec 28, 2023
Copy link

codecov bot commented Dec 28, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (6e359f0) 84.68% compared to head (8744e87) 84.68%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3908   +/-   ##
=======================================
  Coverage   84.68%   84.68%           
=======================================
  Files         237      237           
  Lines       10137    10137           
  Branches       33       33           
=======================================
  Hits         8585     8585           
  Misses       1552     1552           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nsavoire nsavoire changed the title Fix compatibility with node < 14.18 [profiling] Fix compatibility with node < 14.18 Dec 28, 2023
@pr-commenter
Copy link

pr-commenter bot commented Dec 28, 2023

Benchmarks

Benchmark execution time: 2023-12-28 15:02:14

Comparing candidate commit 8744e87 in PR branch nsavoire/fix_node_14 with baseline commit 6e359f0 in branch master.

Found 1 performance improvements and 0 performance regressions! Performance is the same for 518 metrics, 13 unstable metrics.

scenario:plugin-q-with-tracer-16

  • 🟩 instructions [-185.7M instructions; -125.5M instructions] or [-10.186%; -6.882%]

@nsavoire nsavoire merged commit a8522e7 into master Dec 28, 2023
124 of 158 checks passed
@nsavoire nsavoire deleted the nsavoire/fix_node_14 branch December 28, 2023 15:25
khanayan123 pushed a commit that referenced this pull request Jan 2, 2024
Node 14 versions prior to 14.18 do not support require statements with
`node:` prefix.
khanayan123 pushed a commit that referenced this pull request Jan 2, 2024
Node 14 versions prior to 14.18 do not support require statements with
`node:` prefix.
khanayan123 pushed a commit that referenced this pull request Jan 2, 2024
Node 14 versions prior to 14.18 do not support require statements with
`node:` prefix.
khanayan123 pushed a commit that referenced this pull request Jan 2, 2024
Node 14 versions prior to 14.18 do not support require statements with
`node:` prefix.
khanayan123 pushed a commit that referenced this pull request Jan 2, 2024
Node 14 versions prior to 14.18 do not support require statements with
`node:` prefix.
khanayan123 pushed a commit that referenced this pull request Jan 2, 2024
Node 14 versions prior to 14.18 do not support require statements with
`node:` prefix.
This was referenced Jan 2, 2024
khanayan123 pushed a commit that referenced this pull request Jan 4, 2024
Node 14 versions prior to 14.18 do not support require statements with
`node:` prefix.
khanayan123 pushed a commit that referenced this pull request Jan 4, 2024
Node 14 versions prior to 14.18 do not support require statements with
`node:` prefix.
khanayan123 pushed a commit that referenced this pull request Jan 4, 2024
Node 14 versions prior to 14.18 do not support require statements with
`node:` prefix.
khanayan123 pushed a commit that referenced this pull request Jan 4, 2024
Node 14 versions prior to 14.18 do not support require statements with
`node:` prefix.
This was referenced Jan 4, 2024
khanayan123 pushed a commit that referenced this pull request Jan 4, 2024
Node 14 versions prior to 14.18 do not support require statements with
`node:` prefix.
khanayan123 pushed a commit that referenced this pull request Jan 4, 2024
Node 14 versions prior to 14.18 do not support require statements with
`node:` prefix.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working profiling semver-minor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants