Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

simplify ci build for aerospike #3886

Merged
merged 18 commits into from
Dec 27, 2023

Conversation

khanayan123
Copy link
Collaborator

@khanayan123 khanayan123 commented Dec 14, 2023

What does this PR do?

Refactors aerospike github action build

Motivation

Aerospike ci build was hard to read since it had too many if statements and steps

Copy link

github-actions bot commented Dec 14, 2023

Overall package size

Self size: 5.74 MB
Deduped: 61.85 MB
No deduping: 62.61 MB

Dependency sizes

name version self size total size
@datadog/native-iast-taint-tracking 1.6.4 16.43 MB 16.44 MB
@datadog/native-appsec 5.0.0 15.16 MB 15.17 MB
@datadog/pprof 4.1.0 9.36 MB 10.21 MB
protobufjs 7.2.5 2.77 MB 6.56 MB
@datadog/native-iast-rewriter 2.2.2 2.29 MB 2.37 MB
@opentelemetry/core 1.14.0 872.87 kB 1.47 MB
@datadog/native-metrics 2.0.0 898.77 kB 1.3 MB
@opentelemetry/api 1.4.1 780.32 kB 780.32 kB
import-in-the-middle 1.4.2 41.4 kB 704.79 kB
pprof-format 2.0.7 588.12 kB 588.12 kB
msgpack-lite 0.1.26 201.16 kB 281.59 kB
opentracing 0.14.7 194.81 kB 194.81 kB
semver 7.5.4 93.4 kB 123.8 kB
@datadog/sketches-js 2.1.0 109.9 kB 109.9 kB
lodash.sortby 4.7.0 75.76 kB 75.76 kB
lru-cache 7.14.0 74.95 kB 74.95 kB
ipaddr.js 2.1.0 60.23 kB 60.23 kB
ignore 5.2.4 51.22 kB 51.22 kB
int64-buffer 0.1.10 49.18 kB 49.18 kB
istanbul-lib-coverage 3.2.0 29.34 kB 29.34 kB
lodash.uniq 4.5.0 25.01 kB 25.01 kB
tlhunter-sorted-set 0.1.0 24.94 kB 24.94 kB
limiter 1.1.5 23.17 kB 23.17 kB
dc-polyfill 0.1.2 22.77 kB 22.77 kB
retry 0.13.1 18.85 kB 18.85 kB
lodash.kebabcase 4.1.1 17.75 kB 17.75 kB
node-abort-controller 3.1.1 16.89 kB 16.89 kB
lodash.pick 4.4.0 16.33 kB 16.33 kB
jest-docblock 29.7.0 8.99 kB 12.76 kB
crypto-randomuuid 1.0.0 11.18 kB 11.18 kB
path-to-regexp 0.1.7 6.78 kB 6.78 kB
koalas 1.0.2 6.47 kB 6.47 kB
methods 1.1.2 5.29 kB 5.29 kB
module-details-from-path 1.0.3 4.47 kB 4.47 kB

🤖 This report was automatically generated by heaviest-objects-in-the-universe

Copy link

codecov bot commented Dec 14, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (f882cf4) 84.59% compared to head (556371c) 84.59%.
Report is 10 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3886   +/-   ##
=======================================
  Coverage   84.59%   84.59%           
=======================================
  Files         234      234           
  Lines        9815     9815           
  Branches       33       33           
=======================================
  Hits         8303     8303           
  Misses       1512     1512           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pr-commenter
Copy link

pr-commenter bot commented Dec 14, 2023

Benchmarks

Benchmark execution time: 2023-12-18 15:21:14

Comparing candidate commit 556371c in PR branch khanayan123/simplify-aerospike-ci-build with baseline commit f882cf4 in branch master.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 518 metrics, 14 unstable metrics.

@khanayan123 khanayan123 force-pushed the khanayan123/simplify-aerospike-ci-build branch from 3c428b1 to b945c4f Compare December 15, 2023 21:01
@khanayan123 khanayan123 marked this pull request as ready for review December 15, 2023 21:01
@khanayan123 khanayan123 requested a review from a team as a code owner December 15, 2023 21:01
@tlhunter
Copy link
Member

Is this CI behavior expected? v3 doesn't run in master (probably correct), v4 runs, v5 runs the tests as part of an install step:

Screenshot 2023-12-15 at 13 21 25
Screenshot 2023-12-15 at 13 20 56
Screenshot 2023-12-15 at 13 21 11

@khanayan123
Copy link
Collaborator Author

Is this CI behavior expected? v3 doesn't run in master (probably correct), v4 runs, v5 runs the tests as part of an install step:

Screenshot 2023-12-15 at 13 21 25 Screenshot 2023-12-15 at 13 20 56 Screenshot 2023-12-15 at 13 21 11

Yes it's expected behavior, aerospike-3 should only run on v3 of the tracer and the install + tests step is combined so that I don't have to check for package version twice. although maybe 2 if statements is not too bad, so I can separate the two steps if you perfer that

@khanayan123 khanayan123 merged commit 624930c into master Dec 27, 2023
108 of 110 checks passed
@khanayan123 khanayan123 deleted the khanayan123/simplify-aerospike-ci-build branch December 27, 2023 20:22
khanayan123 added a commit that referenced this pull request Jan 2, 2024
* simplify ci build for aerospike
khanayan123 added a commit that referenced this pull request Jan 2, 2024
* simplify ci build for aerospike
khanayan123 added a commit that referenced this pull request Jan 2, 2024
* simplify ci build for aerospike
khanayan123 added a commit that referenced this pull request Jan 2, 2024
* simplify ci build for aerospike
khanayan123 added a commit that referenced this pull request Jan 2, 2024
* simplify ci build for aerospike
khanayan123 added a commit that referenced this pull request Jan 2, 2024
* simplify ci build for aerospike
khanayan123 added a commit that referenced this pull request Jan 4, 2024
* simplify ci build for aerospike
khanayan123 added a commit that referenced this pull request Jan 4, 2024
* simplify ci build for aerospike
khanayan123 added a commit that referenced this pull request Jan 4, 2024
* simplify ci build for aerospike
khanayan123 added a commit that referenced this pull request Jan 4, 2024
* simplify ci build for aerospike
khanayan123 added a commit that referenced this pull request Jan 4, 2024
* simplify ci build for aerospike
khanayan123 added a commit that referenced this pull request Jan 4, 2024
* simplify ci build for aerospike
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants