-
Notifications
You must be signed in to change notification settings - Fork 306
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
simplify ci build for aerospike #3886
Conversation
Overall package sizeSelf size: 5.74 MB Dependency sizes
🤖 This report was automatically generated by heaviest-objects-in-the-universe |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3886 +/- ##
=======================================
Coverage 84.59% 84.59%
=======================================
Files 234 234
Lines 9815 9815
Branches 33 33
=======================================
Hits 8303 8303
Misses 1512 1512 ☔ View full report in Codecov by Sentry. |
BenchmarksBenchmark execution time: 2023-12-18 15:21:14 Comparing candidate commit 556371c in PR branch Found 0 performance improvements and 0 performance regressions! Performance is the same for 518 metrics, 14 unstable metrics. |
3c428b1
to
b945c4f
Compare
Yes it's expected behavior, aerospike-3 should only run on v3 of the tracer and the install + tests step is combined so that I don't have to check for package version twice. although maybe 2 if statements is not too bad, so I can separate the two steps if you perfer that |
* simplify ci build for aerospike
* simplify ci build for aerospike
* simplify ci build for aerospike
* simplify ci build for aerospike
* simplify ci build for aerospike
* simplify ci build for aerospike
* simplify ci build for aerospike
* simplify ci build for aerospike
* simplify ci build for aerospike
* simplify ci build for aerospike
* simplify ci build for aerospike
* simplify ci build for aerospike
What does this PR do?
Refactors aerospike github action build
Motivation
Aerospike ci build was hard to read since it had too many if statements and steps