Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix release scripts #3723

Merged
merged 1 commit into from
Oct 17, 2023
Merged

Conversation

juan-fernandez
Copy link
Collaborator

@juan-fernandez juan-fernandez commented Oct 17, 2023

What does this PR do?

Inspired by #3697

Add permissions: contents for pushing a tag.

It seems it's required for pushing tags (though docs are not very clear): https://docs.github.com/en/actions/using-jobs/assigning-permissions-to-jobs#overview

Motivation

git tag is currently failing in release scripts: https://github.com/DataDog/dd-trace-js/actions/runs/6546633135/job/17777473091

@juan-fernandez juan-fernandez marked this pull request as ready for review October 17, 2023 13:12
@juan-fernandez juan-fernandez requested a review from a team as a code owner October 17, 2023 13:12
@github-actions
Copy link

Overall package size

Self size: 5.38 MB
Deduped: 58.44 MB
No deduping: 58.61 MB

Dependency sizes

name version self size total size
@datadog/native-iast-taint-tracking 1.6.1 14.96 MB 14.97 MB
@datadog/native-appsec 4.0.0 14.83 MB 14.83 MB
@datadog/pprof 4.0.0 8.25 MB 9.1 MB
protobufjs 7.2.4 2.74 MB 6.52 MB
@datadog/native-iast-rewriter 2.1.3 2.23 MB 2.32 MB
@opentelemetry/core 1.14.0 872.87 kB 1.47 MB
@datadog/native-metrics 2.0.0 898.77 kB 1.3 MB
@opentelemetry/api 1.4.1 780.32 kB 780.32 kB
import-in-the-middle 1.4.2 41.4 kB 704.79 kB
msgpack-lite 0.1.26 201.16 kB 281.59 kB
opentracing 0.14.7 194.81 kB 194.81 kB
semver 7.5.4 93.4 kB 123.8 kB
@datadog/sketches-js 2.1.0 109.9 kB 109.9 kB
lodash.sortby 4.7.0 75.76 kB 75.76 kB
lru-cache 7.14.0 74.95 kB 74.95 kB
ipaddr.js 2.1.0 60.23 kB 60.23 kB
ignore 5.2.4 51.22 kB 51.22 kB
int64-buffer 0.1.10 49.18 kB 49.18 kB
istanbul-lib-coverage 3.2.0 29.34 kB 29.34 kB
lodash.uniq 4.5.0 25.01 kB 25.01 kB
limiter 1.1.5 23.17 kB 23.17 kB
retry 0.13.1 18.85 kB 18.85 kB
lodash.kebabcase 4.1.1 17.75 kB 17.75 kB
node-abort-controller 3.1.1 16.89 kB 16.89 kB
lodash.pick 4.4.0 16.33 kB 16.33 kB
jest-docblock 29.7.0 8.99 kB 12.76 kB
crypto-randomuuid 1.0.0 11.18 kB 11.18 kB
diagnostics_channel 1.1.0 7.07 kB 7.07 kB
path-to-regexp 0.1.7 6.78 kB 6.78 kB
koalas 1.0.2 6.47 kB 6.47 kB
methods 1.1.2 5.29 kB 5.29 kB
module-details-from-path 1.0.3 4.47 kB 4.47 kB

🤖 This report was automatically generated by heaviest-objects-in-the-universe

@codecov
Copy link

codecov bot commented Oct 17, 2023

Codecov Report

Merging #3723 (207819f) into master (733fec7) will decrease coverage by 0.16%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #3723      +/-   ##
==========================================
- Coverage   85.05%   84.89%   -0.16%     
==========================================
  Files         225      223       -2     
  Lines        9238     9063     -175     
  Branches       33       33              
==========================================
- Hits         7857     7694     -163     
+ Misses       1381     1369      -12     

see 2 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@pr-commenter
Copy link

pr-commenter bot commented Oct 17, 2023

Benchmarks

Benchmark execution time: 2023-10-17 13:18:12

Comparing candidate commit 207819f in PR branch juan-fernandez/fix-release-scripts with baseline commit 733fec7 in branch master.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 479 metrics, 13 unstable metrics.

@juan-fernandez juan-fernandez merged commit 53438db into master Oct 17, 2023
114 of 116 checks passed
@juan-fernandez juan-fernandez deleted the juan-fernandez/fix-release-scripts branch October 17, 2023 13:34
szegedi pushed a commit that referenced this pull request Oct 17, 2023
@szegedi szegedi mentioned this pull request Oct 17, 2023
szegedi pushed a commit that referenced this pull request Oct 17, 2023
@szegedi szegedi mentioned this pull request Oct 17, 2023
szegedi pushed a commit that referenced this pull request Oct 17, 2023
szegedi pushed a commit that referenced this pull request Oct 17, 2023
khanayan123 pushed a commit that referenced this pull request Jan 2, 2024
khanayan123 pushed a commit that referenced this pull request Jan 2, 2024
khanayan123 pushed a commit that referenced this pull request Jan 2, 2024
khanayan123 pushed a commit that referenced this pull request Jan 2, 2024
khanayan123 pushed a commit that referenced this pull request Jan 2, 2024
khanayan123 pushed a commit that referenced this pull request Jan 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants