-
Notifications
You must be signed in to change notification settings - Fork 306
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix release scripts #3723
Fix release scripts #3723
Conversation
Overall package sizeSelf size: 5.38 MB Dependency sizes
🤖 This report was automatically generated by heaviest-objects-in-the-universe |
Codecov Report
@@ Coverage Diff @@
## master #3723 +/- ##
==========================================
- Coverage 85.05% 84.89% -0.16%
==========================================
Files 225 223 -2
Lines 9238 9063 -175
Branches 33 33
==========================================
- Hits 7857 7694 -163
+ Misses 1381 1369 -12 see 2 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
BenchmarksBenchmark execution time: 2023-10-17 13:18:12 Comparing candidate commit 207819f in PR branch Found 0 performance improvements and 0 performance regressions! Performance is the same for 479 metrics, 13 unstable metrics. |
What does this PR do?
Inspired by #3697
Add
permissions: contents
for pushing a tag.It seems it's required for pushing tags (though docs are not very clear): https://docs.github.com/en/actions/using-jobs/assigning-permissions-to-jobs#overview
Motivation
git tag
is currently failing in release scripts: https://github.com/DataDog/dd-trace-js/actions/runs/6546633135/job/17777473091