-
Notifications
You must be signed in to change notification settings - Fork 306
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable appsec telemetry before waf init #3693
Conversation
Overall package sizeSelf size: 5.37 MB Dependency sizes
🤖 This report was automatically generated by heaviest-objects-in-the-universe |
Codecov Report
@@ Coverage Diff @@
## master #3693 +/- ##
==========================================
+ Coverage 85.02% 87.73% +2.71%
==========================================
Files 224 220 -4
Lines 9220 8690 -530
Branches 33 33
==========================================
- Hits 7839 7624 -215
+ Misses 1381 1066 -315
... and 9 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
BenchmarksBenchmark execution time: 2023-10-10 09:28:34 Comparing candidate commit 320df9f in PR branch Found 0 performance improvements and 0 performance regressions! Performance is the same for 420 metrics, 12 unstable metrics. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Write a test then we can merge
afterEach(() => { | ||
appsec.disable() | ||
|
||
appsecNamespace.reset() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think that we should do it also beforeEach
, can other non related test increment the waf.init
metric and break these tests?
config = new Config({ | ||
appsec: { | ||
enabled: true | ||
} | ||
}) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
that's already done line 38 no ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The waf doesn't validate the rules provided in line 38...
* Enable appsec telemetry before waf init * test reportWafInit is called when enabling appsec
* Enable appsec telemetry before waf init * test reportWafInit is called when enabling appsec
* Enable appsec telemetry before waf init * test reportWafInit is called when enabling appsec
* Enable appsec telemetry before waf init * test reportWafInit is called when enabling appsec
* Enable appsec telemetry before waf init * test reportWafInit is called when enabling appsec
* Enable appsec telemetry before waf init * test reportWafInit is called when enabling appsec
* Enable appsec telemetry before waf init * test reportWafInit is called when enabling appsec
* Enable appsec telemetry before waf init * test reportWafInit is called when enabling appsec
* Enable appsec telemetry before waf init * test reportWafInit is called when enabling appsec
* Enable appsec telemetry before waf init * test reportWafInit is called when enabling appsec
What does this PR do?
Enables appsec telemetry before waf init
Motivation
waf.init
metrics were missingPlugin Checklist
Additional Notes