Enable appsec telemetry before waf init #3693
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Overall package sizeSelf size: 5.37 MB Dependency sizes
🤖 This report was automatically generated by heaviest-objects-in-the-universe |
Codecov Report
@@ Coverage Diff @@
## master #3693 +/- ##
==========================================
+ Coverage 85.02% 87.73% +2.71%
==========================================
Files 224 220 -4
Lines 9220 8690 -530
Branches 33 33
==========================================
- Hits 7839 7624 -215
+ Misses 1381 1066 -315
... and 9 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
BenchmarksBenchmark execution time: 2023-10-10 09:28:34 Comparing candidate commit 320df9f in PR branch Found 0 performance improvements and 0 performance regressions! Performance is the same for 420 metrics, 12 unstable metrics. |
simon-id
requested changes
Oct 9, 2023
uurien
reviewed
Oct 10, 2023
| afterEach(() => { | ||
| appsec.disable() | ||
|
|
||
| appsecNamespace.reset() |
There was a problem hiding this comment.
I think that we should do it also beforeEach, can other non related test increment the waf.init metric and break these tests?
simon-id
reviewed
Oct 10, 2023
Comment on lines
+659
to
+663
| config = new Config({ | ||
| appsec: { | ||
| enabled: true | ||
| } | ||
| }) |
There was a problem hiding this comment.
that's already done line 38 no ?
There was a problem hiding this comment.
The waf doesn't validate the rules provided in line 38...
simon-id
approved these changes
Oct 11, 2023
szegedi
pushed a commit
that referenced
this pull request
Oct 12, 2023
* Enable appsec telemetry before waf init * test reportWafInit is called when enabling appsec
Merged
szegedi
pushed a commit
that referenced
this pull request
Oct 12, 2023
* Enable appsec telemetry before waf init * test reportWafInit is called when enabling appsec
Merged
szegedi
pushed a commit
that referenced
this pull request
Oct 17, 2023
* Enable appsec telemetry before waf init * test reportWafInit is called when enabling appsec
szegedi
pushed a commit
that referenced
this pull request
Oct 17, 2023
* Enable appsec telemetry before waf init * test reportWafInit is called when enabling appsec
khanayan123
pushed a commit
that referenced
this pull request
Jan 2, 2024
* Enable appsec telemetry before waf init * test reportWafInit is called when enabling appsec
khanayan123
pushed a commit
that referenced
this pull request
Jan 2, 2024
* Enable appsec telemetry before waf init * test reportWafInit is called when enabling appsec
khanayan123
pushed a commit
that referenced
this pull request
Jan 2, 2024
* Enable appsec telemetry before waf init * test reportWafInit is called when enabling appsec
khanayan123
pushed a commit
that referenced
this pull request
Jan 2, 2024
* Enable appsec telemetry before waf init * test reportWafInit is called when enabling appsec
khanayan123
pushed a commit
that referenced
this pull request
Jan 2, 2024
* Enable appsec telemetry before waf init * test reportWafInit is called when enabling appsec
khanayan123
pushed a commit
that referenced
this pull request
Jan 2, 2024
* Enable appsec telemetry before waf init * test reportWafInit is called when enabling appsec
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Enables appsec telemetry before waf init
Motivation
waf.initmetrics were missingPlugin Checklist
Additional Notes