Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix memory leak when destroy is called before after on context #203

Merged
merged 1 commit into from
Jul 26, 2018
Merged

fix memory leak when destroy is called before after on context #203

merged 1 commit into from
Jul 26, 2018

Conversation

rochdev
Copy link
Member

@rochdev rochdev commented Jul 26, 2018

This PR fixes memory leaks when the destroy hook is triggered before the after hook. My understanding was that this cannot be the case, but it seems it can happen in some cases (i.e. with promises).

@rochdev rochdev added bug Something isn't working core labels Jul 26, 2018
@rochdev rochdev added this to the 0.5.2 milestone Jul 26, 2018
@rochdev
Copy link
Member Author

rochdev commented Jul 26, 2018

This should address #197 and #201

dd-caleb
dd-caleb approved these changes Jul 26, 2018
View reviewed changes
Copy link

@dd-caleb dd-caleb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rochdev rochdev merged commit 942d4ec into master Jul 26, 2018
@rochdev rochdev deleted the fix-context-leak branch July 26, 2018 18:06
This was referenced Jul 27, 2018
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dd-caleb dd-caleb dd-caleb approved these changes

@alxch- alxch- alxch- approved these changes

Assignees
No one assigned
Labels
bug Something isn't working core
Projects
None yet
Milestone
0.5.2
Development

Successfully merging this pull request may close these issues.
3 participants
@rochdev @alxch- @dd-caleb