-
Notifications
You must be signed in to change notification settings - Fork 306
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Include the extra services found in spans in the remote config client…
… request payloads [APPSEC-9476] (#3635) * Register and send extra services found in spans
- Loading branch information
Showing
6 changed files
with
115 additions
and
5 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,24 @@ | ||
'use strict' | ||
|
||
const maxExtraServices = 64 | ||
const extraServices = new Set() | ||
|
||
function getExtraServices () { | ||
return [...extraServices] | ||
} | ||
|
||
function registerExtraService (serviceName) { | ||
if (serviceName && extraServices.size < maxExtraServices) { | ||
extraServices.add(serviceName) | ||
} | ||
} | ||
|
||
function clear () { | ||
extraServices.clear() | ||
} | ||
|
||
module.exports = { | ||
registerExtraService, | ||
getExtraServices, | ||
clear | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
44 changes: 44 additions & 0 deletions
44
packages/dd-trace/test/service-naming/extra-services.spec.js
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,44 @@ | ||
'use strict' | ||
|
||
require('../setup/tap') | ||
|
||
const { expect } = require('chai') | ||
const { registerExtraService, getExtraServices, clear } = require('../../src/service-naming/extra-services') | ||
|
||
describe('Extra services', () => { | ||
beforeEach(clear) | ||
|
||
describe('registerExtraService', () => { | ||
it('should register defined service names', () => { | ||
registerExtraService('service-test') | ||
|
||
expect(getExtraServices()).to.deep.equal(['service-test']) | ||
}) | ||
|
||
it('should not register invalid service names', () => { | ||
registerExtraService() | ||
registerExtraService(null) | ||
registerExtraService('') | ||
|
||
expect(getExtraServices().length).to.equal(0) | ||
}) | ||
|
||
it('should register the same service name only once', () => { | ||
registerExtraService('service-test') | ||
registerExtraService('service-test') | ||
registerExtraService('service-test') | ||
|
||
const extraServices = getExtraServices() | ||
expect(extraServices.length).to.equal(1) | ||
expect(extraServices).to.deep.equal(['service-test']) | ||
}) | ||
|
||
it('should register a max of 64 service names', () => { | ||
for (let i = 0; i < 100; i++) { | ||
registerExtraService(`service-test-${i}`) | ||
} | ||
|
||
expect(getExtraServices().length).to.equal(64) | ||
}) | ||
}) | ||
}) |