Skip to content

Commit

Permalink
feat: Use BinaryValue, not StringValue
Browse files Browse the repository at this point in the history
  • Loading branch information
astuyve committed Mar 1, 2022
1 parent 78b3471 commit 4715db1
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
2 changes: 1 addition & 1 deletion packages/datadog-plugin-aws-sdk/src/services/sns.js
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ class Sns {
const b64EncodedTraceContext = Buffer.from(JSON.stringify(ddInfo), 'ascii').toString('base64')
injectPath.MessageAttributes._datadog = {
DataType: 'Binary',
StringValue: b64EncodedTraceContext
BinaryValue: b64EncodedTraceContext
}
}
}
Expand Down
4 changes: 2 additions & 2 deletions packages/datadog-plugin-aws-sdk/test/sns.spec.js
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,7 @@ describe('Sns', () => {
MessageAttributes: {
'_datadog': {
'DataType': 'Binary',
'StringValue': 'eyJ4LWRhdGFkb2ctdHJhY2UtaWQiOiI0NTY4NTMyMTk2NzY3NzkxNjAiLCJ4LWRhdGFkb2ctcGFyZW50LWlkIjoiNDU2ODUzMjE5Njc2Nzc5MTYwIiwieC1kYXRhZG9nLXNhbXBsaW5nLXByaW9yaXR5IjoiMSJ9'
'BinaryValue': 'eyJ4LWRhdGFkb2ctdHJhY2UtaWQiOiI0NTY4NTMyMTk2NzY3NzkxNjAiLCJ4LWRhdGFkb2ctcGFyZW50LWlkIjoiNDU2ODUzMjE5Njc2Nzc5MTYwIiwieC1kYXRhZG9nLXNhbXBsaW5nLXByaW9yaXR5IjoiMSJ9'
}
},
'TopicArn': 'some ARN'
Expand Down Expand Up @@ -98,7 +98,7 @@ describe('Sns', () => {
MessageAttributes: {
'_datadog': {
'DataType': 'Binary',
'StringValue': 'eyJ4LWRhdGFkb2ctdHJhY2UtaWQiOiI0NTY4NTMyMTk2NzY3NzkxNjAiLCJ4LWRhdGFkb2ctcGFyZW50LWlkIjoiNDU2ODUzMjE5Njc2Nzc5MTYwIiwieC1kYXRhZG9nLXNhbXBsaW5nLXByaW9yaXR5IjoiMSJ9'
'BinaryValue': 'eyJ4LWRhdGFkb2ctdHJhY2UtaWQiOiI0NTY4NTMyMTk2NzY3NzkxNjAiLCJ4LWRhdGFkb2ctcGFyZW50LWlkIjoiNDU2ODUzMjE5Njc2Nzc5MTYwIiwieC1kYXRhZG9nLXNhbXBsaW5nLXByaW9yaXR5IjoiMSJ9'
}
}
},
Expand Down

0 comments on commit 4715db1

Please sign in to comment.