feat: Use base64 encoded JSON and Binary type to avoid message being … (

#1889) * feat: Use base64 encoded JSON and Binary type to avoid message being dropped by filter policies * feat: Use BinaryValue, not StringValue * Feat: AWS automatically base64's the data for us, so we don't want to repeat it
DataDog · Mar 3, 2022 · 3610644 · 3610644
1 parent b273258
commit 3610644
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 6 deletions.
diff --git a/packages/datadog-plugin-aws-sdk/src/services/sns.js b/packages/datadog-plugin-aws-sdk/src/services/sns.js
@@ -38,8 +38,8 @@ class Sns {
       const ddInfo = {}
       tracer.inject(span, 'text_map', ddInfo)
       injectPath.MessageAttributes._datadog = {
-        DataType: 'String',
-        StringValue: JSON.stringify(ddInfo)
+        DataType: 'Binary',
+        BinaryValue: JSON.stringify(ddInfo) // BINARY types are automatically base64 encoded
       }
     }
   }

diff --git a/packages/datadog-plugin-aws-sdk/test/sns.spec.js b/packages/datadog-plugin-aws-sdk/test/sns.spec.js
@@ -65,8 +65,8 @@ describe('Sns', () => {
         Message: 'Here is my sns message',
         MessageAttributes: {
           '_datadog': {
-            'DataType': 'String',
-            'StringValue': '{"x-datadog-trace-id":"456853219676779160","x-datadog-parent-id":"456853219676779160","x-datadog-sampling-priority":"1"}'
+            'DataType': 'Binary',
+            'BinaryValue': '{"x-datadog-trace-id":"456853219676779160","x-datadog-parent-id":"456853219676779160","x-datadog-sampling-priority":"1"}'
           }
         },
         'TopicArn': 'some ARN'
@@ -97,8 +97,8 @@ describe('Sns', () => {
             Message: 'Here is my SNS message',
             MessageAttributes: {
               '_datadog': {
-                'DataType': 'String',
-                'StringValue': '{"x-datadog-trace-id":"456853219676779160","x-datadog-parent-id":"456853219676779160","x-datadog-sampling-priority":"1"}'
+                'DataType': 'Binary',
+                'BinaryValue': '{"x-datadog-trace-id":"456853219676779160","x-datadog-parent-id":"456853219676779160","x-datadog-sampling-priority":"1"}'
               }
             }
           },