[test visibility] Fix cucumber e2e tests (#4654)

DataDog · Sep 5, 2024 · 1c976a9 · 1c976a9
1 parent d20f8b6
commit 1c976a9
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 5 deletions.
diff --git a/integration-tests/cucumber/cucumber.spec.js b/integration-tests/cucumber/cucumber.spec.js
@@ -38,7 +38,8 @@ const {
 } = require('../../packages/dd-trace/src/plugins/util/test')
 
 const isOldNode = semver.satisfies(process.version, '<=16')
-const versions = ['7.0.0', isOldNode ? '9' : 'latest']
+// TODO: change 10 to `latest` when fix is released
+const versions = ['7.0.0', isOldNode ? '9' : '10']
 
 const moduleType = [
   {

diff --git a/integration-tests/selenium/selenium.spec.js b/integration-tests/selenium/selenium.spec.js
@@ -18,7 +18,7 @@ const {
 } = require('../../packages/dd-trace/src/plugins/util/test')
 const { NODE_MAJOR } = require('../../version')
 
-const cucumberVersion = NODE_MAJOR <= 16 ? '9' : 'latest'
+const cucumberVersion = NODE_MAJOR <= 16 ? '9' : '10'
 
 const webAppServer = require('../ci-visibility/web-app-server')
 

diff --git a/packages/datadog-instrumentations/src/cucumber.js b/packages/datadog-instrumentations/src/cucumber.js
@@ -550,7 +550,7 @@ addHook({
 // Test start / finish for newer versions. The only hook executed in workers when in parallel mode
 addHook({
   name: '@cucumber/cucumber',
-  versions: ['>=7.3.0'],
+  versions: ['>=7.3.0 <11.0.0'],
   file: 'lib/runtime/test_case_runner.js'
 }, testCaseHook)
 
@@ -559,7 +559,7 @@ addHook({
 // `getWrappedRunTest` generates suite start and finish events
 addHook({
   name: '@cucumber/cucumber',
-  versions: ['>=7.3.0'],
+  versions: ['>=7.3.0 <11.0.0'],
   file: 'lib/runtime/index.js'
 }, (runtimePackage, frameworkVersion) => {
   shimmer.wrap(runtimePackage.default.prototype, 'runTestCase', runTestCase => getWrappedRunTest(runTestCase))
@@ -588,7 +588,7 @@ addHook({
 // `getWrappedParseWorkerMessage` generates suite finish events
 addHook({
   name: '@cucumber/cucumber',
-  versions: ['>=8.0.0'],
+  versions: ['>=8.0.0 <11.0.0'],
   file: 'lib/runtime/parallel/coordinator.js'
 }, (coordinatorPackage, frameworkVersion) => {
   shimmer.wrap(coordinatorPackage.default.prototype, 'start', start => getWrappedStart(start, frameworkVersion, true))