Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added support for Haystack trace propagation #895

Merged
merged 2 commits into from
Sep 4, 2019
Merged

Added support for Haystack trace propagation #895

merged 2 commits into from
Sep 4, 2019

Conversation

aantono
Copy link
Contributor

@aantono aantono commented Jun 20, 2019

Implementation to support #717

@aantono aantono requested a review from a team as a code owner June 20, 2019 22:30
tylerbenson
tylerbenson approved these changes Jul 17, 2019
View reviewed changes
Copy link
Contributor

@tylerbenson tylerbenson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes look ok to me. Thanks for your contribution!

tylerbenson
tylerbenson suggested changes Jul 17, 2019
View reviewed changes
Copy link
Contributor

@tylerbenson tylerbenson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like the build is failing due to missing test coverage. Please add some tests for the new Codec classes.

@tylerbenson
Copy link
Contributor

@aantono are you able to add those tests or do you need some assistance?

@aantono
Copy link
Contributor Author

aantono commented Sep 1, 2019

@tylerbenson I’ll give it a try this week, will ping you for assistance if I get stuck!

tylerbenson
tylerbenson approved these changes Sep 3, 2019
View reviewed changes
Copy link
Contributor

@tylerbenson tylerbenson left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks for making those changes. Let me know if you plan on making any more changes, otherwise I'll go ahead and merge.

@tylerbenson tylerbenson merged commit b20a32b into DataDog:master Sep 4, 2019
@tylerbenson tylerbenson added this to the 0.33.0 milestone Sep 4, 2019
@tylerbenson tylerbenson added the tag: community Community contribution label Sep 9, 2019
@ldoin ldoin mentioned this pull request Jun 29, 2020
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tylerbenson tylerbenson tylerbenson approved these changes

Assignees
No one assigned
Labels
tag: community Community contribution
Projects
None yet
Milestone
0.33.0
Development

Successfully merging this pull request may close these issues.
2 participants
@aantono @tylerbenson