-
Notifications
You must be signed in to change notification settings - Fork 293
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove unused CI Visibility test fixtures #8246
Open
nikita-tkachenko-datadog
wants to merge
1
commit into
master
Choose a base branch
from
nikita-tkachenko/remove-unused-test-fixtures
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Remove unused CI Visibility test fixtures #8246
nikita-tkachenko-datadog
wants to merge
1
commit into
master
from
nikita-tkachenko/remove-unused-test-fixtures
+0
−1,099
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nikita-tkachenko-datadog
added
comp: testing
Testing
tag: no release notes
Changes to exclude from release notes
type: refactoring
labels
Jan 17, 2025
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 59 metrics, 4 unstable metrics. Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.46.0-SNAPSHOT~be1cc5a904, baseline=1.46.0-SNAPSHOT~fbb36f9b5b
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.055 s) : 0, 1055176
Total [baseline] (10.51 s) : 0, 10509602
Agent [candidate] (1.058 s) : 0, 1058362
Total [candidate] (10.544 s) : 0, 10544373
section appsec
Agent [baseline] (1.191 s) : 0, 1190529
Total [baseline] (10.741 s) : 0, 10741152
Agent [candidate] (1.201 s) : 0, 1200973
Total [candidate] (10.773 s) : 0, 10772629
section iast
Agent [baseline] (1.183 s) : 0, 1183147
Total [baseline] (11.05 s) : 0, 11049952
Agent [candidate] (1.184 s) : 0, 1184108
Total [candidate] (11.005 s) : 0, 11005331
section profiling
Agent [baseline] (1.255 s) : 0, 1255159
Total [baseline] (10.883 s) : 0, 10882728
Agent [candidate] (1.258 s) : 0, 1257604
Total [candidate] (10.893 s) : 0, 10892892
gantt
title petclinic - break down per module: candidate=1.46.0-SNAPSHOT~be1cc5a904, baseline=1.46.0-SNAPSHOT~fbb36f9b5b
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (712.529 ms) : 0, 712529
BytebuddyAgent [candidate] (716.07 ms) : 0, 716070
GlobalTracer [baseline] (256.806 ms) : 0, 256806
GlobalTracer [candidate] (256.551 ms) : 0, 256551
AppSec [baseline] (55.902 ms) : 0, 55902
AppSec [candidate] (56.375 ms) : 0, 56375
Remote Config [baseline] (743.031 µs) : 0, 743
Remote Config [candidate] (734.831 µs) : 0, 735
Telemetry [baseline] (14.235 ms) : 0, 14235
Telemetry [candidate] (13.554 ms) : 0, 13554
section appsec
BytebuddyAgent [baseline] (733.083 ms) : 0, 733083
BytebuddyAgent [candidate] (739.519 ms) : 0, 739519
GlobalTracer [baseline] (252.952 ms) : 0, 252952
GlobalTracer [candidate] (255.383 ms) : 0, 255383
AppSec [baseline] (170.998 ms) : 0, 170998
AppSec [candidate] (172.297 ms) : 0, 172297
Remote Config [baseline] (664.225 µs) : 0, 664
Remote Config [candidate] (669.018 µs) : 0, 669
Telemetry [baseline] (8.217 ms) : 0, 8217
Telemetry [candidate] (8.166 ms) : 0, 8166
IAST [baseline] (19.329 ms) : 0, 19329
IAST [candidate] (19.54 ms) : 0, 19540
section iast
BytebuddyAgent [baseline] (831.843 ms) : 0, 831843
BytebuddyAgent [candidate] (832.418 ms) : 0, 832418
GlobalTracer [baseline] (246.744 ms) : 0, 246744
GlobalTracer [candidate] (247.324 ms) : 0, 247324
AppSec [baseline] (58.284 ms) : 0, 58284
AppSec [candidate] (58.204 ms) : 0, 58204
Remote Config [baseline] (675.592 µs) : 0, 676
Remote Config [candidate] (674.125 µs) : 0, 674
Telemetry [baseline] (8.89 ms) : 0, 8890
Telemetry [candidate] (8.915 ms) : 0, 8915
IAST [baseline] (21.696 ms) : 0, 21696
IAST [candidate] (21.519 ms) : 0, 21519
section profiling
ProfilingAgent [baseline] (94.927 ms) : 0, 94927
ProfilingAgent [candidate] (94.947 ms) : 0, 94947
BytebuddyAgent [baseline] (703.242 ms) : 0, 703242
BytebuddyAgent [candidate] (705.433 ms) : 0, 705433
GlobalTracer [baseline] (350.124 ms) : 0, 350124
GlobalTracer [candidate] (350.961 ms) : 0, 350961
AppSec [baseline] (55.528 ms) : 0, 55528
AppSec [candidate] (54.538 ms) : 0, 54538
Remote Config [baseline] (705.22 µs) : 0, 705
Remote Config [candidate] (720.827 µs) : 0, 721
Telemetry [baseline] (8.79 ms) : 0, 8790
Telemetry [candidate] (8.808 ms) : 0, 8808
Profiling [baseline] (94.951 ms) : 0, 94951
Profiling [candidate] (94.972 ms) : 0, 94972
Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.46.0-SNAPSHOT~be1cc5a904, baseline=1.46.0-SNAPSHOT~fbb36f9b5b
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.074 s) : 0, 1073860
Total [baseline] (8.666 s) : 0, 8666477
Agent [candidate] (1.057 s) : 0, 1056847
Total [candidate] (8.648 s) : 0, 8648015
section iast
Agent [baseline] (1.19 s) : 0, 1190281
Total [baseline] (9.201 s) : 0, 9200767
Agent [candidate] (1.182 s) : 0, 1181777
Total [candidate] (9.222 s) : 0, 9221680
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.189 s) : 0, 1189389
Total [baseline] (9.179 s) : 0, 9179206
Agent [candidate] (1.186 s) : 0, 1186349
Total [candidate] (9.198 s) : 0, 9197972
section iast_TELEMETRY_OFF
Agent [baseline] (1.182 s) : 0, 1181909
Total [baseline] (9.213 s) : 0, 9212741
Agent [candidate] (1.18 s) : 0, 1179732
Total [candidate] (9.205 s) : 0, 9205462
gantt
title insecure-bank - break down per module: candidate=1.46.0-SNAPSHOT~be1cc5a904, baseline=1.46.0-SNAPSHOT~fbb36f9b5b
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (726.879 ms) : 0, 726879
BytebuddyAgent [candidate] (714.87 ms) : 0, 714870
GlobalTracer [baseline] (258.976 ms) : 0, 258976
GlobalTracer [candidate] (256.411 ms) : 0, 256411
AppSec [baseline] (56.143 ms) : 0, 56143
AppSec [candidate] (55.474 ms) : 0, 55474
Remote Config [baseline] (751.516 µs) : 0, 752
Remote Config [candidate] (739.993 µs) : 0, 740
Telemetry [baseline] (15.861 ms) : 0, 15861
Telemetry [candidate] (14.331 ms) : 0, 14331
section iast
BytebuddyAgent [baseline] (837.492 ms) : 0, 837492
BytebuddyAgent [candidate] (830.993 ms) : 0, 830993
GlobalTracer [baseline] (247.876 ms) : 0, 247876
GlobalTracer [candidate] (246.762 ms) : 0, 246762
AppSec [baseline] (58.541 ms) : 0, 58541
AppSec [candidate] (57.924 ms) : 0, 57924
Remote Config [baseline] (678.442 µs) : 0, 678
Remote Config [candidate] (662.908 µs) : 0, 663
Telemetry [baseline] (8.839 ms) : 0, 8839
Telemetry [candidate] (8.814 ms) : 0, 8814
IAST [baseline] (21.625 ms) : 0, 21625
IAST [candidate] (21.568 ms) : 0, 21568
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (836.598 ms) : 0, 836598
BytebuddyAgent [candidate] (833.422 ms) : 0, 833422
GlobalTracer [baseline] (247.981 ms) : 0, 247981
GlobalTracer [candidate] (248.278 ms) : 0, 248278
AppSec [baseline] (58.438 ms) : 0, 58438
AppSec [candidate] (58.361 ms) : 0, 58361
Remote Config [baseline] (683.814 µs) : 0, 684
Remote Config [candidate] (656.242 µs) : 0, 656
Telemetry [baseline] (8.9 ms) : 0, 8900
Telemetry [candidate] (8.812 ms) : 0, 8812
IAST [baseline] (21.708 ms) : 0, 21708
IAST [candidate] (21.74 ms) : 0, 21740
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (830.177 ms) : 0, 830177
BytebuddyAgent [candidate] (829.098 ms) : 0, 829098
GlobalTracer [baseline] (247.893 ms) : 0, 247893
GlobalTracer [candidate] (247.277 ms) : 0, 247277
AppSec [baseline] (58.362 ms) : 0, 58362
AppSec [candidate] (58.247 ms) : 0, 58247
Remote Config [baseline] (677.041 µs) : 0, 677
Remote Config [candidate] (735.387 µs) : 0, 735
Telemetry [baseline] (8.757 ms) : 0, 8757
Telemetry [candidate] (8.647 ms) : 0, 8647
IAST [baseline] (21.019 ms) : 0, 21019
IAST [candidate] (20.752 ms) : 0, 20752
LoadParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 16 unstable metrics. Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.46.0-SNAPSHOT~be1cc5a904, baseline=1.46.0-SNAPSHOT~fbb36f9b5b
dateFormat X
axisFormat %s
section baseline
no_agent (380.648 µs) : 360, 401
. : milestone, 381,
iast (510.767 µs) : 489, 533
. : milestone, 511,
iast_FULL (744.551 µs) : 723, 766
. : milestone, 745,
iast_GLOBAL (558.984 µs) : 537, 581
. : milestone, 559,
iast_HARDCODED_SECRET_DISABLED (505.067 µs) : 484, 527
. : milestone, 505,
iast_INACTIVE (462.487 µs) : 441, 484
. : milestone, 462,
iast_TELEMETRY_OFF (496.078 µs) : 474, 518
. : milestone, 496,
tracing (450.399 µs) : 430, 471
. : milestone, 450,
section candidate
no_agent (385.109 µs) : 365, 405
. : milestone, 385,
iast (507.975 µs) : 486, 529
. : milestone, 508,
iast_FULL (744.399 µs) : 723, 766
. : milestone, 744,
iast_GLOBAL (549.011 µs) : 528, 570
. : milestone, 549,
iast_HARDCODED_SECRET_DISABLED (505.671 µs) : 484, 527
. : milestone, 506,
iast_INACTIVE (463.653 µs) : 442, 485
. : milestone, 464,
iast_TELEMETRY_OFF (498.875 µs) : 477, 521
. : milestone, 499,
tracing (453.616 µs) : 433, 474
. : milestone, 454,
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.46.0-SNAPSHOT~be1cc5a904, baseline=1.46.0-SNAPSHOT~fbb36f9b5b
dateFormat X
axisFormat %s
section baseline
no_agent (1.356 ms) : 1336, 1376
. : milestone, 1356,
appsec (1.759 ms) : 1735, 1783
. : milestone, 1759,
appsec_no_iast (1.742 ms) : 1716, 1767
. : milestone, 1742,
iast (1.536 ms) : 1512, 1560
. : milestone, 1536,
profiling (1.534 ms) : 1510, 1558
. : milestone, 1534,
tracing (1.5 ms) : 1475, 1525
. : milestone, 1500,
section candidate
no_agent (1.359 ms) : 1339, 1380
. : milestone, 1359,
appsec (1.734 ms) : 1710, 1758
. : milestone, 1734,
appsec_no_iast (1.76 ms) : 1734, 1787
. : milestone, 1760,
iast (1.515 ms) : 1490, 1540
. : milestone, 1515,
profiling (1.525 ms) : 1502, 1548
. : milestone, 1525,
tracing (1.5 ms) : 1475, 1525
. : milestone, 1500,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics. Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.46.0-SNAPSHOT~be1cc5a904, baseline=1.46.0-SNAPSHOT~fbb36f9b5b
dateFormat X
axisFormat %s
section baseline
no_agent (1.468 ms) : 1456, 1479
. : milestone, 1468,
appsec (2.354 ms) : 2311, 2398
. : milestone, 2354,
iast (2.096 ms) : 2042, 2150
. : milestone, 2096,
iast_GLOBAL (2.15 ms) : 2095, 2205
. : milestone, 2150,
profiling (1.992 ms) : 1947, 2037
. : milestone, 1992,
tracing (1.935 ms) : 1893, 1977
. : milestone, 1935,
section candidate
no_agent (1.468 ms) : 1456, 1479
. : milestone, 1468,
appsec (2.344 ms) : 2301, 2387
. : milestone, 2344,
iast (2.098 ms) : 2043, 2152
. : milestone, 2098,
iast_GLOBAL (2.147 ms) : 2092, 2203
. : milestone, 2147,
profiling (1.966 ms) : 1922, 2010
. : milestone, 1966,
tracing (1.947 ms) : 1904, 1989
. : milestone, 1947,
Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.46.0-SNAPSHOT~be1cc5a904, baseline=1.46.0-SNAPSHOT~fbb36f9b5b
dateFormat X
axisFormat %s
section baseline
no_agent (15.637 s) : 15637000, 15637000
. : milestone, 15637000,
appsec (15.151 s) : 15151000, 15151000
. : milestone, 15151000,
iast (18.94 s) : 18940000, 18940000
. : milestone, 18940000,
iast_GLOBAL (17.748 s) : 17748000, 17748000
. : milestone, 17748000,
profiling (15.159 s) : 15159000, 15159000
. : milestone, 15159000,
tracing (14.896 s) : 14896000, 14896000
. : milestone, 14896000,
section candidate
no_agent (15.625 s) : 15625000, 15625000
. : milestone, 15625000,
appsec (14.744 s) : 14744000, 14744000
. : milestone, 14744000,
iast (18.184 s) : 18184000, 18184000
. : milestone, 18184000,
iast_GLOBAL (17.801 s) : 17801000, 17801000
. : milestone, 17801000,
profiling (15.701 s) : 15701000, 15701000
. : milestone, 15701000,
tracing (15.061 s) : 15061000, 15061000
. : milestone, 15061000,
|
smola
approved these changes
Jan 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What Does This Do
Removes some CI Visibility test fixtures that are no longer used.
Contributor Checklist
type:
and (comp:
orinst:
) labels in addition to any usefull labelsclose
,fix
or any linking keywords when referencing an issue.Use
solves
instead, and assign the PR milestone to the issue