-
Notifications
You must be signed in to change notification settings - Fork 293
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Decouple test JDK and gradle JDK in testng latestDepTest #8235
Merged
+8
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smola
added
comp: testing
Testing
tag: no release notes
Changes to exclude from release notes
comp: ci visibility
Continuous Integration Visibility
labels
Jan 16, 2025
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 60 metrics, 3 unstable metrics. Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.46.0-SNAPSHOT~d03d201b9b, baseline=1.46.0-SNAPSHOT~f1d359b93f
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.054 s) : 0, 1053780
Total [baseline] (8.638 s) : 0, 8638419
Agent [candidate] (1.055 s) : 0, 1055462
Total [candidate] (8.626 s) : 0, 8626346
section iast
Agent [baseline] (1.184 s) : 0, 1184065
Total [baseline] (9.214 s) : 0, 9214460
Agent [candidate] (1.196 s) : 0, 1196443
Total [candidate] (9.244 s) : 0, 9243665
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.193 s) : 0, 1192585
Total [baseline] (9.198 s) : 0, 9197654
Agent [candidate] (1.192 s) : 0, 1191721
Total [candidate] (9.221 s) : 0, 9220836
section iast_TELEMETRY_OFF
Agent [baseline] (1.185 s) : 0, 1185221
Total [baseline] (9.208 s) : 0, 9207596
Agent [candidate] (1.179 s) : 0, 1179014
Total [candidate] (9.201 s) : 0, 9200676
gantt
title insecure-bank - break down per module: candidate=1.46.0-SNAPSHOT~d03d201b9b, baseline=1.46.0-SNAPSHOT~f1d359b93f
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (712.177 ms) : 0, 712177
BytebuddyAgent [candidate] (713.299 ms) : 0, 713299
GlobalTracer [baseline] (255.059 ms) : 0, 255059
GlobalTracer [candidate] (255.817 ms) : 0, 255817
AppSec [baseline] (57.183 ms) : 0, 57183
AppSec [candidate] (55.462 ms) : 0, 55462
Remote Config [baseline] (710.047 µs) : 0, 710
Remote Config [candidate] (717.77 µs) : 0, 718
Telemetry [baseline] (13.77 ms) : 0, 13770
Telemetry [candidate] (15.143 ms) : 0, 15143
section iast
BytebuddyAgent [baseline] (833.03 ms) : 0, 833030
BytebuddyAgent [candidate] (843.183 ms) : 0, 843183
GlobalTracer [baseline] (247.057 ms) : 0, 247057
GlobalTracer [candidate] (248.35 ms) : 0, 248350
AppSec [baseline] (57.983 ms) : 0, 57983
AppSec [candidate] (58.294 ms) : 0, 58294
IAST [baseline] (21.653 ms) : 0, 21653
IAST [candidate] (21.838 ms) : 0, 21838
Remote Config [baseline] (665.567 µs) : 0, 666
Remote Config [candidate] (682.053 µs) : 0, 682
Telemetry [baseline] (8.737 ms) : 0, 8737
Telemetry [candidate] (8.955 ms) : 0, 8955
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (838.878 ms) : 0, 838878
BytebuddyAgent [candidate] (838.288 ms) : 0, 838288
GlobalTracer [baseline] (248.697 ms) : 0, 248697
GlobalTracer [candidate] (248.482 ms) : 0, 248482
AppSec [baseline] (58.475 ms) : 0, 58475
AppSec [candidate] (58.613 ms) : 0, 58613
IAST [baseline] (21.776 ms) : 0, 21776
IAST [candidate] (21.574 ms) : 0, 21574
Remote Config [baseline] (682.493 µs) : 0, 682
Remote Config [candidate] (690.047 µs) : 0, 690
Telemetry [baseline] (8.937 ms) : 0, 8937
Telemetry [candidate] (8.948 ms) : 0, 8948
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (833.926 ms) : 0, 833926
BytebuddyAgent [candidate] (828.946 ms) : 0, 828946
GlobalTracer [baseline] (247.591 ms) : 0, 247591
GlobalTracer [candidate] (247.108 ms) : 0, 247108
AppSec [baseline] (58.092 ms) : 0, 58092
AppSec [candidate] (57.824 ms) : 0, 57824
IAST [baseline] (21.118 ms) : 0, 21118
IAST [candidate] (20.792 ms) : 0, 20792
Remote Config [baseline] (678.603 µs) : 0, 679
Remote Config [candidate] (661.177 µs) : 0, 661
Telemetry [baseline] (8.79 ms) : 0, 8790
Telemetry [candidate] (8.649 ms) : 0, 8649
Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.46.0-SNAPSHOT~d03d201b9b, baseline=1.46.0-SNAPSHOT~f1d359b93f
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.059 s) : 0, 1058612
Total [baseline] (10.461 s) : 0, 10460917
Agent [candidate] (1.06 s) : 0, 1059535
Total [candidate] (10.51 s) : 0, 10509630
section appsec
Agent [baseline] (1.187 s) : 0, 1186997
Total [baseline] (10.716 s) : 0, 10716417
Agent [candidate] (1.187 s) : 0, 1186727
Total [candidate] (10.731 s) : 0, 10730814
section iast
Agent [baseline] (1.183 s) : 0, 1182620
Total [baseline] (10.977 s) : 0, 10977475
Agent [candidate] (1.181 s) : 0, 1180969
Total [candidate] (11.1 s) : 0, 11100484
section profiling
Agent [baseline] (1.253 s) : 0, 1252539
Total [baseline] (10.787 s) : 0, 10786877
Agent [candidate] (1.268 s) : 0, 1268076
Total [candidate] (10.884 s) : 0, 10883650
gantt
title petclinic - break down per module: candidate=1.46.0-SNAPSHOT~d03d201b9b, baseline=1.46.0-SNAPSHOT~f1d359b93f
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (716.619 ms) : 0, 716619
BytebuddyAgent [candidate] (716.747 ms) : 0, 716747
GlobalTracer [baseline] (256.581 ms) : 0, 256581
GlobalTracer [candidate] (256.314 ms) : 0, 256314
AppSec [baseline] (56.139 ms) : 0, 56139
AppSec [candidate] (55.34 ms) : 0, 55340
Remote Config [baseline] (723.949 µs) : 0, 724
Remote Config [candidate] (715.915 µs) : 0, 716
Telemetry [baseline] (13.561 ms) : 0, 13561
Telemetry [candidate] (15.407 ms) : 0, 15407
section appsec
BytebuddyAgent [baseline] (730.0 ms) : 0, 730000
BytebuddyAgent [candidate] (729.919 ms) : 0, 729919
GlobalTracer [baseline] (252.741 ms) : 0, 252741
GlobalTracer [candidate] (252.503 ms) : 0, 252503
AppSec [baseline] (170.789 ms) : 0, 170789
AppSec [candidate] (170.771 ms) : 0, 170771
IAST [baseline] (19.438 ms) : 0, 19438
IAST [candidate] (19.358 ms) : 0, 19358
Remote Config [baseline] (660.056 µs) : 0, 660
Remote Config [candidate] (664.13 µs) : 0, 664
Telemetry [baseline] (8.172 ms) : 0, 8172
Telemetry [candidate] (8.245 ms) : 0, 8245
section iast
BytebuddyAgent [baseline] (831.653 ms) : 0, 831653
BytebuddyAgent [candidate] (830.821 ms) : 0, 830821
GlobalTracer [baseline] (246.897 ms) : 0, 246897
GlobalTracer [candidate] (246.131 ms) : 0, 246131
AppSec [baseline] (58.115 ms) : 0, 58115
AppSec [candidate] (58.032 ms) : 0, 58032
IAST [baseline] (21.558 ms) : 0, 21558
IAST [candidate] (21.649 ms) : 0, 21649
Remote Config [baseline] (673.754 µs) : 0, 674
Remote Config [candidate] (672.701 µs) : 0, 673
Telemetry [baseline] (8.831 ms) : 0, 8831
Telemetry [candidate] (8.727 ms) : 0, 8727
section profiling
BytebuddyAgent [baseline] (702.22 ms) : 0, 702220
BytebuddyAgent [candidate] (711.557 ms) : 0, 711557
GlobalTracer [baseline] (348.335 ms) : 0, 348335
GlobalTracer [candidate] (354.239 ms) : 0, 354239
AppSec [baseline] (54.863 ms) : 0, 54863
AppSec [candidate] (54.47 ms) : 0, 54470
Remote Config [baseline] (664.548 µs) : 0, 665
Remote Config [candidate] (656.413 µs) : 0, 656
Telemetry [baseline] (8.786 ms) : 0, 8786
Telemetry [candidate] (8.92 ms) : 0, 8920
ProfilingAgent [baseline] (95.843 ms) : 0, 95843
ProfilingAgent [candidate] (96.113 ms) : 0, 96113
Profiling [baseline] (95.867 ms) : 0, 95867
Profiling [candidate] (96.137 ms) : 0, 96137
LoadParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 16 unstable metrics. Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.46.0-SNAPSHOT~d03d201b9b, baseline=1.46.0-SNAPSHOT~f1d359b93f
dateFormat X
axisFormat %s
section baseline
no_agent (377.743 µs) : 357, 398
. : milestone, 378,
iast (511.032 µs) : 489, 533
. : milestone, 511,
iast_FULL (742.309 µs) : 721, 764
. : milestone, 742,
iast_GLOBAL (554.47 µs) : 533, 576
. : milestone, 554,
iast_HARDCODED_SECRET_DISABLED (518.429 µs) : 495, 542
. : milestone, 518,
iast_INACTIVE (460.565 µs) : 439, 482
. : milestone, 461,
iast_TELEMETRY_OFF (491.331 µs) : 470, 513
. : milestone, 491,
tracing (452.798 µs) : 432, 474
. : milestone, 453,
section candidate
no_agent (374.775 µs) : 355, 395
. : milestone, 375,
iast (507.735 µs) : 486, 529
. : milestone, 508,
iast_FULL (743.871 µs) : 722, 766
. : milestone, 744,
iast_GLOBAL (558.089 µs) : 536, 581
. : milestone, 558,
iast_HARDCODED_SECRET_DISABLED (506.171 µs) : 484, 528
. : milestone, 506,
iast_INACTIVE (458.205 µs) : 437, 480
. : milestone, 458,
iast_TELEMETRY_OFF (489.765 µs) : 468, 511
. : milestone, 490,
tracing (450.952 µs) : 430, 472
. : milestone, 451,
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.46.0-SNAPSHOT~d03d201b9b, baseline=1.46.0-SNAPSHOT~f1d359b93f
dateFormat X
axisFormat %s
section baseline
no_agent (1.354 ms) : 1334, 1374
. : milestone, 1354,
appsec (1.755 ms) : 1732, 1778
. : milestone, 1755,
appsec_no_iast (1.727 ms) : 1702, 1752
. : milestone, 1727,
iast (1.507 ms) : 1483, 1532
. : milestone, 1507,
profiling (1.517 ms) : 1494, 1540
. : milestone, 1517,
tracing (1.494 ms) : 1470, 1519
. : milestone, 1494,
section candidate
no_agent (1.366 ms) : 1347, 1386
. : milestone, 1366,
appsec (1.734 ms) : 1710, 1758
. : milestone, 1734,
appsec_no_iast (1.754 ms) : 1731, 1777
. : milestone, 1754,
iast (1.509 ms) : 1484, 1533
. : milestone, 1509,
profiling (1.501 ms) : 1477, 1525
. : milestone, 1501,
tracing (1.491 ms) : 1466, 1517
. : milestone, 1491,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics. Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.46.0-SNAPSHOT~d03d201b9b, baseline=1.46.0-SNAPSHOT~f1d359b93f
dateFormat X
axisFormat %s
section baseline
no_agent (15.461 s) : 15461000, 15461000
. : milestone, 15461000,
appsec (15.16 s) : 15160000, 15160000
. : milestone, 15160000,
iast (18.819 s) : 18819000, 18819000
. : milestone, 18819000,
iast_GLOBAL (17.764 s) : 17764000, 17764000
. : milestone, 17764000,
profiling (15.028 s) : 15028000, 15028000
. : milestone, 15028000,
tracing (15.137 s) : 15137000, 15137000
. : milestone, 15137000,
section candidate
no_agent (14.797 s) : 14797000, 14797000
. : milestone, 14797000,
appsec (15.059 s) : 15059000, 15059000
. : milestone, 15059000,
iast (18.997 s) : 18997000, 18997000
. : milestone, 18997000,
iast_GLOBAL (18.138 s) : 18138000, 18138000
. : milestone, 18138000,
profiling (15.116 s) : 15116000, 15116000
. : milestone, 15116000,
tracing (14.986 s) : 14986000, 14986000
. : milestone, 14986000,
Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.46.0-SNAPSHOT~d03d201b9b, baseline=1.46.0-SNAPSHOT~f1d359b93f
dateFormat X
axisFormat %s
section baseline
no_agent (1.462 ms) : 1451, 1473
. : milestone, 1462,
appsec (2.36 ms) : 2316, 2404
. : milestone, 2360,
iast (2.102 ms) : 2047, 2156
. : milestone, 2102,
iast_GLOBAL (2.15 ms) : 2095, 2206
. : milestone, 2150,
profiling (1.963 ms) : 1919, 2007
. : milestone, 1963,
tracing (1.944 ms) : 1902, 1986
. : milestone, 1944,
section candidate
no_agent (1.464 ms) : 1453, 1476
. : milestone, 1464,
appsec (2.341 ms) : 2297, 2384
. : milestone, 2341,
iast (2.103 ms) : 2048, 2158
. : milestone, 2103,
iast_GLOBAL (2.139 ms) : 2084, 2194
. : milestone, 2139,
profiling (1.957 ms) : 1913, 2001
. : milestone, 1957,
tracing (1.947 ms) : 1904, 1989
. : milestone, 1947,
|
PerfectSlayer
approved these changes
Jan 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
comp: ci visibility
Continuous Integration Visibility
comp: testing
Testing
tag: no release notes
Changes to exclude from release notes
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What Does This Do
Similar to #8234 but for testng. Effectively enabled tests for testng 7.6.0+ in CI.
Motivation
Part of fixes to decouple the JDK used for compile/test from the one used by gradle.
Additional Notes
Contributor Checklist
type:
and (comp:
orinst:
) labels in addition to any usefull labelsclose
,fix
or any linking keywords when referencing an issue.Use
solves
instead, and assign the PR milestone to the issueJira ticket: [PROJ-IDENT]