Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove flakiness from field-injection smoke test #8214

Merged
merged 1 commit into from
Jan 15, 2025
Merged

Remove flakiness from field-injection smoke test #8214

merged 1 commit into from
Jan 15, 2025

Conversation

mcculls
Copy link
Contributor

@mcculls mcculls commented Jan 15, 2025

What Does This Do

Separate stdout from stderr to avoid tracer logging from interfering with smoke-test parsing

Motivation

Avoids tracer logging (which goes to stderr) from interfering with the test application logging. For example an I/O exception stack trace caused by there not being an agent to connect to might break up logging from the test application, making those lines non-parseable and failing the test.

Contributor Checklist

Jira ticket: [PROJ-IDENT]

@mcculls mcculls added comp: testing Testing tag: no release notes Changes to exclude from release notes type: refactoring labels Jan 15, 2025
@mcculls mcculls marked this pull request as ready for review January 15, 2025 20:21
@mcculls mcculls requested a review from a team as a code owner January 15, 2025 20:21
@pr-commenter
Copy link

pr-commenter bot commented Jan 15, 2025

Benchmarks

Startup

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master mcculls/field-injection-smoke-test-fix
git_commit_date 1736952276 1736970646
git_commit_sha 0b1e6ff dabecd5
release_version 1.46.0-SNAPSHOT~0b1e6ff859 1.46.0-SNAPSHOT~dabecd5348
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1736973078 1736973078
ci_job_id 768018855 768018855
ci_pipeline_id 53120485 53120485
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
module Agent Agent
parent None None
variant iast iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 61 metrics, 2 unstable metrics.

Startup time reports for petclinic 
gantt
    title petclinic - global startup overhead: candidate=1.46.0-SNAPSHOT~dabecd5348, baseline=1.46.0-SNAPSHOT~0b1e6ff859

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.056 s) : 0, 1056446
Total [baseline] (10.481 s) : 0, 10480891
Agent [candidate] (1.055 s) : 0, 1054684
Total [candidate] (10.514 s) : 0, 10514265
section appsec
Agent [baseline] (1.19 s) : 0, 1189513
Total [baseline] (10.725 s) : 0, 10725286
Agent [candidate] (1.194 s) : 0, 1193742
Total [candidate] (10.781 s) : 0, 10780562
section iast
Agent [baseline] (1.181 s) : 0, 1180559
Total [baseline] (10.999 s) : 0, 10998783
Agent [candidate] (1.184 s) : 0, 1183876
Total [candidate] (10.983 s) : 0, 10983197
section profiling
Agent [baseline] (1.257 s) : 0, 1257053
Total [baseline] (10.815 s) : 0, 10814599
Agent [candidate] (1.255 s) : 0, 1254946
Total [candidate] (10.871 s) : 0, 10870572
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.056 s -
Agent appsec 1.19 s 133.067 ms (12.6%)
Agent iast 1.181 s 124.113 ms (11.7%)
Agent profiling 1.257 s 200.607 ms (19.0%)
Total tracing 10.481 s -
Total appsec 10.725 s 244.395 ms (2.3%)
Total iast 10.999 s 517.892 ms (4.9%)
Total profiling 10.815 s 333.708 ms (3.2%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.055 s -
Agent appsec 1.194 s 139.058 ms (13.2%)
Agent iast 1.184 s 129.192 ms (12.2%)
Agent profiling 1.255 s 200.262 ms (19.0%)
Total tracing 10.514 s -
Total appsec 10.781 s 266.297 ms (2.5%)
Total iast 10.983 s 468.931 ms (4.5%)
Total profiling 10.871 s 356.306 ms (3.4%) 
gantt
    title petclinic - break down per module: candidate=1.46.0-SNAPSHOT~dabecd5348, baseline=1.46.0-SNAPSHOT~0b1e6ff859

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (714.33 ms) : 0, 714330
BytebuddyAgent [candidate] (714.705 ms) : 0, 714705
GlobalTracer [baseline] (256.734 ms) : 0, 256734
GlobalTracer [candidate] (256.624 ms) : 0, 256624
AppSec [baseline] (56.053 ms) : 0, 56053
AppSec [candidate] (55.361 ms) : 0, 55361
Remote Config [baseline] (726.888 µs) : 0, 727
Remote Config [candidate] (726.353 µs) : 0, 726
Telemetry [baseline] (13.693 ms) : 0, 13693
Telemetry [candidate] (12.256 ms) : 0, 12256
section appsec
BytebuddyAgent [baseline] (731.304 ms) : 0, 731304
BytebuddyAgent [candidate] (733.593 ms) : 0, 733593
GlobalTracer [baseline] (253.321 ms) : 0, 253321
GlobalTracer [candidate] (254.116 ms) : 0, 254116
AppSec [baseline] (171.391 ms) : 0, 171391
AppSec [candidate] (172.166 ms) : 0, 172166
IAST [baseline] (19.308 ms) : 0, 19308
IAST [candidate] (19.71 ms) : 0, 19710
Remote Config [baseline] (667.971 µs) : 0, 668
Remote Config [candidate] (670.057 µs) : 0, 670
Telemetry [baseline] (8.23 ms) : 0, 8230
Telemetry [candidate] (8.287 ms) : 0, 8287
section iast
BytebuddyAgent [baseline] (830.118 ms) : 0, 830118
BytebuddyAgent [candidate] (832.576 ms) : 0, 832576
GlobalTracer [baseline] (246.873 ms) : 0, 246873
GlobalTracer [candidate] (247.368 ms) : 0, 247368
AppSec [baseline] (57.882 ms) : 0, 57882
AppSec [candidate] (57.942 ms) : 0, 57942
IAST [baseline] (21.332 ms) : 0, 21332
IAST [candidate] (21.532 ms) : 0, 21532
Remote Config [baseline] (670.912 µs) : 0, 671
Remote Config [candidate] (667.077 µs) : 0, 667
Telemetry [baseline] (8.75 ms) : 0, 8750
Telemetry [candidate] (8.778 ms) : 0, 8778
section profiling
BytebuddyAgent [baseline] (704.061 ms) : 0, 704061
BytebuddyAgent [candidate] (703.111 ms) : 0, 703111
GlobalTracer [baseline] (350.859 ms) : 0, 350859
GlobalTracer [candidate] (350.687 ms) : 0, 350687
AppSec [baseline] (54.727 ms) : 0, 54727
AppSec [candidate] (54.384 ms) : 0, 54384
Remote Config [baseline] (661.299 µs) : 0, 661
Remote Config [candidate] (654.31 µs) : 0, 654
Telemetry [baseline] (8.857 ms) : 0, 8857
Telemetry [candidate] (8.84 ms) : 0, 8840
ProfilingAgent [baseline] (95.866 ms) : 0, 95866
ProfilingAgent [candidate] (95.313 ms) : 0, 95313
Profiling [baseline] (95.893 ms) : 0, 95893
Profiling [candidate] (95.341 ms) : 0, 95341
Loading
Startup time reports for insecure-bank 
gantt
    title insecure-bank - global startup overhead: candidate=1.46.0-SNAPSHOT~dabecd5348, baseline=1.46.0-SNAPSHOT~0b1e6ff859

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.055 s) : 0, 1055288
Total [baseline] (8.655 s) : 0, 8654640
Agent [candidate] (1.057 s) : 0, 1056634
Total [candidate] (8.665 s) : 0, 8664848
section iast
Agent [baseline] (1.192 s) : 0, 1191763
Total [baseline] (9.263 s) : 0, 9262655
Agent [candidate] (1.186 s) : 0, 1186047
Total [candidate] (9.192 s) : 0, 9192151
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.185 s) : 0, 1185260
Total [baseline] (9.221 s) : 0, 9220781
Agent [candidate] (1.183 s) : 0, 1183292
Total [candidate] (9.202 s) : 0, 9201752
section iast_TELEMETRY_OFF
Agent [baseline] (1.18 s) : 0, 1179831
Total [baseline] (9.231 s) : 0, 9230597
Agent [candidate] (1.177 s) : 0, 1177218
Total [candidate] (9.228 s) : 0, 9228409
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.055 s -
Agent iast 1.192 s 136.476 ms (12.9%)
Agent iast_HARDCODED_SECRET_DISABLED 1.185 s 129.972 ms (12.3%)
Agent iast_TELEMETRY_OFF 1.18 s 124.543 ms (11.8%)
Total tracing 8.655 s -
Total iast 9.263 s 608.015 ms (7.0%)
Total iast_HARDCODED_SECRET_DISABLED 9.221 s 566.141 ms (6.5%)
Total iast_TELEMETRY_OFF 9.231 s 575.957 ms (6.7%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.057 s -
Agent iast 1.186 s 129.413 ms (12.2%)
Agent iast_HARDCODED_SECRET_DISABLED 1.183 s 126.659 ms (12.0%)
Agent iast_TELEMETRY_OFF 1.177 s 120.584 ms (11.4%)
Total tracing 8.665 s -
Total iast 9.192 s 527.304 ms (6.1%)
Total iast_HARDCODED_SECRET_DISABLED 9.202 s 536.904 ms (6.2%)
Total iast_TELEMETRY_OFF 9.228 s 563.561 ms (6.5%) 
gantt
    title insecure-bank - break down per module: candidate=1.46.0-SNAPSHOT~dabecd5348, baseline=1.46.0-SNAPSHOT~0b1e6ff859

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (713.9 ms) : 0, 713900
BytebuddyAgent [candidate] (714.807 ms) : 0, 714807
GlobalTracer [baseline] (255.931 ms) : 0, 255931
GlobalTracer [candidate] (256.642 ms) : 0, 256642
AppSec [baseline] (55.337 ms) : 0, 55337
AppSec [candidate] (55.52 ms) : 0, 55520
Remote Config [baseline] (716.422 µs) : 0, 716
Remote Config [candidate] (721.748 µs) : 0, 722
Telemetry [baseline] (14.39 ms) : 0, 14390
Telemetry [candidate] (13.84 ms) : 0, 13840
section iast
BytebuddyAgent [baseline] (838.627 ms) : 0, 838627
BytebuddyAgent [candidate] (834.494 ms) : 0, 834494
GlobalTracer [baseline] (248.65 ms) : 0, 248650
GlobalTracer [candidate] (247.261 ms) : 0, 247261
AppSec [baseline] (58.093 ms) : 0, 58093
AppSec [candidate] (58.079 ms) : 0, 58079
IAST [baseline] (21.754 ms) : 0, 21754
IAST [candidate] (21.634 ms) : 0, 21634
Remote Config [baseline] (669.446 µs) : 0, 669
Remote Config [candidate] (689.967 µs) : 0, 690
Telemetry [baseline] (8.842 ms) : 0, 8842
Telemetry [candidate] (8.822 ms) : 0, 8822
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (832.026 ms) : 0, 832026
BytebuddyAgent [candidate] (831.417 ms) : 0, 831417
GlobalTracer [baseline] (248.748 ms) : 0, 248748
GlobalTracer [candidate] (247.359 ms) : 0, 247359
AppSec [baseline] (58.205 ms) : 0, 58205
AppSec [candidate] (58.22 ms) : 0, 58220
IAST [baseline] (21.643 ms) : 0, 21643
IAST [candidate] (21.67 ms) : 0, 21670
Remote Config [baseline] (670.628 µs) : 0, 671
Remote Config [candidate] (668.645 µs) : 0, 669
Telemetry [baseline] (8.904 ms) : 0, 8904
Telemetry [candidate] (8.908 ms) : 0, 8908
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (829.208 ms) : 0, 829208
BytebuddyAgent [candidate] (827.615 ms) : 0, 827615
GlobalTracer [baseline] (247.135 ms) : 0, 247135
GlobalTracer [candidate] (247.085 ms) : 0, 247085
AppSec [baseline] (58.162 ms) : 0, 58162
AppSec [candidate] (57.51 ms) : 0, 57510
IAST [baseline] (20.99 ms) : 0, 20990
IAST [candidate] (20.791 ms) : 0, 20791
Remote Config [baseline] (673.182 µs) : 0, 673
Remote Config [candidate] (649.042 µs) : 0, 649
Telemetry [baseline] (8.637 ms) : 0, 8637
Telemetry [candidate] (8.561 ms) : 0, 8561
Loading

Load

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
end_time 2025-01-15T20:03:10 2025-01-15T20:10:14
git_branch master mcculls/field-injection-smoke-test-fix
git_commit_date 1736952276 1736970646
git_commit_sha 0b1e6ff dabecd5
release_version 1.46.0-SNAPSHOT~0b1e6ff859 1.46.0-SNAPSHOT~dabecd5348
start_time 2025-01-15T20:02:56 2025-01-15T20:10:00
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1736972172 1736972172
ci_job_id 768018856 768018856
ci_pipeline_id 53120485 53120485
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
variant iast iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 13 metrics, 15 unstable metrics.

Request duration reports for insecure-bank 
gantt
    title insecure-bank - request duration [CI 0.99] : candidate=1.46.0-SNAPSHOT~dabecd5348, baseline=1.46.0-SNAPSHOT~0b1e6ff859
    dateFormat X
    axisFormat %s
section baseline
no_agent (382.347 µs) : 362, 403
.   : milestone, 382,
iast (510.572 µs) : 488, 533
.   : milestone, 511,
iast_FULL (741.973 µs) : 720, 764
.   : milestone, 742,
iast_GLOBAL (552.845 µs) : 531, 575
.   : milestone, 553,
iast_HARDCODED_SECRET_DISABLED (502.78 µs) : 481, 525
.   : milestone, 503,
iast_INACTIVE (456.861 µs) : 436, 478
.   : milestone, 457,
iast_TELEMETRY_OFF (495.671 µs) : 474, 517
.   : milestone, 496,
tracing (452.647 µs) : 432, 473
.   : milestone, 453,
section candidate
no_agent (381.811 µs) : 362, 401
.   : milestone, 382,
iast (506.097 µs) : 484, 528
.   : milestone, 506,
iast_FULL (738.62 µs) : 717, 760
.   : milestone, 739,
iast_GLOBAL (564.476 µs) : 541, 588
.   : milestone, 564,
iast_HARDCODED_SECRET_DISABLED (506.094 µs) : 484, 528
.   : milestone, 506,
iast_INACTIVE (455.79 µs) : 435, 477
.   : milestone, 456,
iast_TELEMETRY_OFF (497.166 µs) : 476, 519
.   : milestone, 497,
tracing (445.07 µs) : 425, 466
.   : milestone, 445,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 382.347 µs [361.818 µs, 402.877 µs] -
iast 510.572 µs [488.414 µs, 532.73 µs] 128.224 µs (33.5%)
iast_FULL 741.973 µs [720.017 µs, 763.929 µs] 359.625 µs (94.1%)
iast_GLOBAL 552.845 µs [531.025 µs, 574.666 µs] 170.498 µs (44.6%)
iast_HARDCODED_SECRET_DISABLED 502.78 µs [480.789 µs, 524.77 µs] 120.432 µs (31.5%)
iast_INACTIVE 456.861 µs [435.6 µs, 478.122 µs] 74.513 µs (19.5%)
iast_TELEMETRY_OFF 495.671 µs [473.894 µs, 517.448 µs] 113.323 µs (29.6%)
tracing 452.647 µs [431.932 µs, 473.361 µs] 70.299 µs (18.4%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 381.811 µs [362.139 µs, 401.483 µs] -
iast 506.097 µs [484.096 µs, 528.098 µs] 124.287 µs (32.6%)
iast_FULL 738.62 µs [716.878 µs, 760.362 µs] 356.809 µs (93.5%)
iast_GLOBAL 564.476 µs [541.163 µs, 587.79 µs] 182.666 µs (47.8%)
iast_HARDCODED_SECRET_DISABLED 506.094 µs [484.289 µs, 527.899 µs] 124.284 µs (32.6%)
iast_INACTIVE 455.79 µs [434.768 µs, 476.812 µs] 73.98 µs (19.4%)
iast_TELEMETRY_OFF 497.166 µs [475.592 µs, 518.74 µs] 115.355 µs (30.2%)
tracing 445.07 µs [424.528 µs, 465.612 µs] 63.259 µs (16.6%)
Request duration reports for petclinic 
gantt
    title petclinic - request duration [CI 0.99] : candidate=1.46.0-SNAPSHOT~dabecd5348, baseline=1.46.0-SNAPSHOT~0b1e6ff859
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.358 ms) : 1338, 1377
.   : milestone, 1358,
appsec (1.753 ms) : 1729, 1777
.   : milestone, 1753,
appsec_no_iast (1.771 ms) : 1747, 1794
.   : milestone, 1771,
iast (1.514 ms) : 1490, 1539
.   : milestone, 1514,
profiling (1.502 ms) : 1478, 1526
.   : milestone, 1502,
tracing (1.497 ms) : 1472, 1521
.   : milestone, 1497,
section candidate
no_agent (1.363 ms) : 1344, 1383
.   : milestone, 1363,
appsec (1.737 ms) : 1713, 1761
.   : milestone, 1737,
appsec_no_iast (1.75 ms) : 1724, 1775
.   : milestone, 1750,
iast (1.506 ms) : 1482, 1531
.   : milestone, 1506,
profiling (1.497 ms) : 1473, 1520
.   : milestone, 1497,
tracing (1.477 ms) : 1451, 1503
.   : milestone, 1477,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.358 ms [1.338 ms, 1.377 ms] -
appsec 1.753 ms [1.729 ms, 1.777 ms] 394.93 µs (29.1%)
appsec_no_iast 1.771 ms [1.747 ms, 1.794 ms] 412.667 µs (30.4%)
iast 1.514 ms [1.49 ms, 1.539 ms] 156.598 µs (11.5%)
profiling 1.502 ms [1.478 ms, 1.526 ms] 143.972 µs (10.6%)
tracing 1.497 ms [1.472 ms, 1.521 ms] 138.857 µs (10.2%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.363 ms [1.344 ms, 1.383 ms] -
appsec 1.737 ms [1.713 ms, 1.761 ms] 373.738 µs (27.4%)
appsec_no_iast 1.75 ms [1.724 ms, 1.775 ms] 386.211 µs (28.3%)
iast 1.506 ms [1.482 ms, 1.531 ms] 142.752 µs (10.5%)
profiling 1.497 ms [1.473 ms, 1.52 ms] 133.396 µs (9.8%)
tracing 1.477 ms [1.451 ms, 1.503 ms] 113.545 µs (8.3%)

Dacapo

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master mcculls/field-injection-smoke-test-fix
git_commit_date 1736952276 1736970646
git_commit_sha 0b1e6ff dabecd5
release_version 1.46.0-SNAPSHOT~0b1e6ff859 1.46.0-SNAPSHOT~dabecd5348
See matching parameters
Baseline Candidate
application biojava biojava
ci_job_date 1736972780 1736972780
ci_job_id 768018857 768018857
ci_pipeline_id 53120485 53120485
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
variant appsec appsec

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 1 unstable metrics.

Execution time for biojava 
gantt
    title biojava - execution time [CI 0.99] : candidate=1.46.0-SNAPSHOT~dabecd5348, baseline=1.46.0-SNAPSHOT~0b1e6ff859
    dateFormat X
    axisFormat %s
section baseline
no_agent (15.283 s) : 15283000, 15283000
.   : milestone, 15283000,
appsec (15.174 s) : 15174000, 15174000
.   : milestone, 15174000,
iast (18.867 s) : 18867000, 18867000
.   : milestone, 18867000,
iast_GLOBAL (18.09 s) : 18090000, 18090000
.   : milestone, 18090000,
profiling (15.229 s) : 15229000, 15229000
.   : milestone, 15229000,
tracing (15.146 s) : 15146000, 15146000
.   : milestone, 15146000,
section candidate
no_agent (14.75 s) : 14750000, 14750000
.   : milestone, 14750000,
appsec (15.016 s) : 15016000, 15016000
.   : milestone, 15016000,
iast (19.16 s) : 19160000, 19160000
.   : milestone, 19160000,
iast_GLOBAL (18.224 s) : 18224000, 18224000
.   : milestone, 18224000,
profiling (15.179 s) : 15179000, 15179000
.   : milestone, 15179000,
tracing (15.293 s) : 15293000, 15293000
.   : milestone, 15293000,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 15.283 s [15.283 s, 15.283 s] -
appsec 15.174 s [15.174 s, 15.174 s] -109.0 ms (-0.7%)
iast 18.867 s [18.867 s, 18.867 s] 3.584 s (23.5%)
iast_GLOBAL 18.09 s [18.09 s, 18.09 s] 2.807 s (18.4%)
profiling 15.229 s [15.229 s, 15.229 s] -54.0 ms (-0.4%)
tracing 15.146 s [15.146 s, 15.146 s] -137.0 ms (-0.9%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 14.75 s [14.75 s, 14.75 s] -
appsec 15.016 s [15.016 s, 15.016 s] 266.0 ms (1.8%)
iast 19.16 s [19.16 s, 19.16 s] 4.41 s (29.9%)
iast_GLOBAL 18.224 s [18.224 s, 18.224 s] 3.474 s (23.6%)
profiling 15.179 s [15.179 s, 15.179 s] 429.0 ms (2.9%)
tracing 15.293 s [15.293 s, 15.293 s] 543.0 ms (3.7%)
Execution time for tomcat 
gantt
    title tomcat - execution time [CI 0.99] : candidate=1.46.0-SNAPSHOT~dabecd5348, baseline=1.46.0-SNAPSHOT~0b1e6ff859
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.482 ms) : 1470, 1493
.   : milestone, 1482,
appsec (2.383 ms) : 2340, 2426
.   : milestone, 2383,
iast (2.123 ms) : 2069, 2177
.   : milestone, 2123,
iast_GLOBAL (2.156 ms) : 2102, 2211
.   : milestone, 2156,
profiling (2.467 ms) : 2277, 2658
.   : milestone, 2467,
tracing (1.952 ms) : 1910, 1993
.   : milestone, 1952,
section candidate
no_agent (1.471 ms) : 1459, 1482
.   : milestone, 1471,
appsec (2.369 ms) : 2326, 2412
.   : milestone, 2369,
iast (2.117 ms) : 2063, 2171
.   : milestone, 2117,
iast_GLOBAL (2.161 ms) : 2106, 2215
.   : milestone, 2161,
profiling (1.984 ms) : 1940, 2027
.   : milestone, 1984,
tracing (1.956 ms) : 1914, 1997
.   : milestone, 1956,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.482 ms [1.47 ms, 1.493 ms] -
appsec 2.383 ms [2.34 ms, 2.426 ms] 900.814 µs (60.8%)
iast 2.123 ms [2.069 ms, 2.177 ms] 641.416 µs (43.3%)
iast_GLOBAL 2.156 ms [2.102 ms, 2.211 ms] 674.319 µs (45.5%)
profiling 2.467 ms [2.277 ms, 2.658 ms] 985.359 µs (66.5%)
tracing 1.952 ms [1.91 ms, 1.993 ms] 469.93 µs (31.7%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.471 ms [1.459 ms, 1.482 ms] -
appsec 2.369 ms [2.326 ms, 2.412 ms] 898.172 µs (61.1%)
iast 2.117 ms [2.063 ms, 2.171 ms] 646.565 µs (44.0%)
iast_GLOBAL 2.161 ms [2.106 ms, 2.215 ms] 690.204 µs (46.9%)
profiling 1.984 ms [1.94 ms, 2.027 ms] 512.977 µs (34.9%)
tracing 1.956 ms [1.914 ms, 1.997 ms] 485.129 µs (33.0%)

@mcculls mcculls enabled auto-merge (squash) January 15, 2025 20:40
ygree
ygree approved these changes Jan 15, 2025
View reviewed changes
Copy link
Contributor

@ygree ygree left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mcculls mcculls merged commit 0da31f6 into master Jan 15, 2025
176 checks passed
@mcculls mcculls deleted the mcculls/field-injection-smoke-test-fix branch January 15, 2025 20:53
@github-actions github-actions bot added this to the 1.46.0 milestone Jan 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ygree ygree ygree approved these changes

@manuel-alvarez-alvarez manuel-alvarez-alvarez Awaiting requested review from manuel-alvarez-alvarez manuel-alvarez-alvarez is a code owner automatically assigned from DataDog/apm-java

Assignees
No one assigned
Labels
comp: testing Testing tag: no release notes Changes to exclude from release notes type: refactoring
Projects
None yet
Milestone
1.46.0
Development

Successfully merging this pull request may close these issues.
2 participants
@mcculls @ygree