Group `javax.jms` instrumentations under a single module #8154

mcculls · 2025-01-04T16:37:20Z

Motivation

Preparation for using the new feature that supports instrumentation of repackaged libraries

Contributor Checklist

Format the title according the contribution guidelines
Assign the type: and (comp: or inst:) labels in addition to any usefull labels
Don't use close, fix or any linking keywords when referencing an issue.
Use solves instead, and assign the PR milestone to the issue
Update the public documentation in case of new configuration flag or behavior

mcculls · 2025-01-04T16:41:30Z

...n/jms/src/main/java/datadog/trace/instrumentation/jms/MDBMessageConsumerInstrumentation.java

    implements Instrumenter.ForTypeHierarchy, Instrumenter.HasMethodAdvice {

-  public MDBMessageConsumerInstrumentation() {
-    super("jms", "javax-mdb");


To simplify things, and given we haven't had to turn this off independently, we're now grouping this under the JMS module with the rest of the JMS instrumentation.

pr-commenter · 2025-01-04T17:15:51Z

Benchmarks

Startup

Parameters

	Baseline	Candidate
baseline_or_candidate	baseline	candidate
git_branch	master	mcculls/javax-jms-module
git_commit_date	1736152625	1736153825
git_commit_sha	`6bfef97`	`35d6fa0`
release_version	1.45.0-SNAPSHOT~6bfef97d85	1.45.0-SNAPSHOT~35d6fa0d84

See matching parameters

	Baseline	Candidate
application	insecure-bank	insecure-bank
ci_job_date	1736156240	1736156240
ci_job_id	755026990	755026990
ci_pipeline_id	52203394	52203394
cpu_model	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
module	Agent	Agent
parent	None	None
variant	iast	iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 58 metrics, 5 unstable metrics.

Startup time reports for petclinic

gantt
    title petclinic - global startup overhead: candidate=1.45.0-SNAPSHOT~35d6fa0d84, baseline=1.45.0-SNAPSHOT~6bfef97d85

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.061 s) : 0, 1060704
Total [baseline] (10.421 s) : 0, 10420999
Agent [candidate] (1.055 s) : 0, 1055410
Total [candidate] (10.437 s) : 0, 10437054
section appsec
Agent [baseline] (1.188 s) : 0, 1188180
Total [baseline] (10.695 s) : 0, 10695190
Agent [candidate] (1.187 s) : 0, 1186947
Total [candidate] (10.716 s) : 0, 10715848
section iast
Agent [baseline] (1.188 s) : 0, 1187751
Total [baseline] (10.991 s) : 0, 10990822
Agent [candidate] (1.189 s) : 0, 1188840
Total [candidate] (10.928 s) : 0, 10927559
section profiling
Agent [baseline] (1.273 s) : 0, 1273341
Total [baseline] (10.774 s) : 0, 10774067
Agent [candidate] (1.276 s) : 0, 1276385
Total [candidate] (10.838 s) : 0, 10837510

baseline results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.061 s	-
Agent	appsec	1.188 s	127.476 ms (12.0%)
Agent	iast	1.188 s	127.047 ms (12.0%)
Agent	profiling	1.273 s	212.637 ms (20.0%)
Total	tracing	10.421 s	-
Total	appsec	10.695 s	274.191 ms (2.6%)
Total	iast	10.991 s	569.823 ms (5.5%)
Total	profiling	10.774 s	353.068 ms (3.4%)

candidate results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.055 s	-
Agent	appsec	1.187 s	131.537 ms (12.5%)
Agent	iast	1.189 s	133.43 ms (12.6%)
Agent	profiling	1.276 s	220.975 ms (20.9%)
Total	tracing	10.437 s	-
Total	appsec	10.716 s	278.794 ms (2.7%)
Total	iast	10.928 s	490.505 ms (4.7%)
Total	profiling	10.838 s	400.456 ms (3.8%)

gantt
    title petclinic - break down per module: candidate=1.45.0-SNAPSHOT~35d6fa0d84, baseline=1.45.0-SNAPSHOT~6bfef97d85

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (716.785 ms) : 0, 716785
BytebuddyAgent [candidate] (713.558 ms) : 0, 713558
GlobalTracer [baseline] (257.539 ms) : 0, 257539
GlobalTracer [candidate] (256.844 ms) : 0, 256844
AppSec [baseline] (56.182 ms) : 0, 56182
AppSec [candidate] (55.205 ms) : 0, 55205
Remote Config [baseline] (727.194 µs) : 0, 727
Remote Config [candidate] (728.268 µs) : 0, 728
Telemetry [baseline] (14.369 ms) : 0, 14369
Telemetry [candidate] (14.082 ms) : 0, 14082
section appsec
BytebuddyAgent [baseline] (731.201 ms) : 0, 731201
BytebuddyAgent [candidate] (729.896 ms) : 0, 729896
GlobalTracer [baseline] (253.001 ms) : 0, 253001
GlobalTracer [candidate] (252.879 ms) : 0, 252879
AppSec [baseline] (170.773 ms) : 0, 170773
AppSec [candidate] (170.241 ms) : 0, 170241
IAST [baseline] (19.345 ms) : 0, 19345
IAST [candidate] (20.67 ms) : 0, 20670
Remote Config [baseline] (658.182 µs) : 0, 658
Remote Config [candidate] (656.878 µs) : 0, 657
Telemetry [baseline] (7.904 ms) : 0, 7904
Telemetry [candidate] (7.927 ms) : 0, 7927
section iast
BytebuddyAgent [baseline] (836.623 ms) : 0, 836623
BytebuddyAgent [candidate] (837.481 ms) : 0, 837481
GlobalTracer [baseline] (247.968 ms) : 0, 247968
GlobalTracer [candidate] (247.058 ms) : 0, 247058
AppSec [baseline] (57.87 ms) : 0, 57870
AppSec [candidate] (58.431 ms) : 0, 58431
IAST [baseline] (21.049 ms) : 0, 21049
IAST [candidate] (21.435 ms) : 0, 21435
Remote Config [baseline] (660.799 µs) : 0, 661
Remote Config [candidate] (670.18 µs) : 0, 670
Telemetry [baseline] (8.457 ms) : 0, 8457
Telemetry [candidate] (8.589 ms) : 0, 8589
section profiling
BytebuddyAgent [baseline] (702.455 ms) : 0, 702455
BytebuddyAgent [candidate] (704.198 ms) : 0, 704198
GlobalTracer [baseline] (370.339 ms) : 0, 370339
GlobalTracer [candidate] (372.171 ms) : 0, 372171
AppSec [baseline] (54.722 ms) : 0, 54722
AppSec [candidate] (54.204 ms) : 0, 54204
Remote Config [baseline] (666.508 µs) : 0, 667
Remote Config [candidate] (652.684 µs) : 0, 653
Telemetry [baseline] (7.866 ms) : 0, 7866
Telemetry [candidate] (7.769 ms) : 0, 7769
ProfilingAgent [baseline] (95.532 ms) : 0, 95532
ProfilingAgent [candidate] (95.507 ms) : 0, 95507
Profiling [baseline] (95.556 ms) : 0, 95556
Profiling [candidate] (95.532 ms) : 0, 95532

Startup time reports for insecure-bank

gantt
    title insecure-bank - global startup overhead: candidate=1.45.0-SNAPSHOT~35d6fa0d84, baseline=1.45.0-SNAPSHOT~6bfef97d85

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.06 s) : 0, 1060357
Total [baseline] (8.612 s) : 0, 8612416
Agent [candidate] (1.06 s) : 0, 1060161
Total [candidate] (8.619 s) : 0, 8619162
section iast
Agent [baseline] (1.181 s) : 0, 1180721
Total [baseline] (9.19 s) : 0, 9189561
Agent [candidate] (1.187 s) : 0, 1187145
Total [candidate] (9.202 s) : 0, 9202429
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.189 s) : 0, 1189215
Total [baseline] (9.208 s) : 0, 9208255
Agent [candidate] (1.18 s) : 0, 1180468
Total [candidate] (9.152 s) : 0, 9152032
section iast_TELEMETRY_OFF
Agent [baseline] (1.176 s) : 0, 1176385
Total [baseline] (9.158 s) : 0, 9157879
Agent [candidate] (1.192 s) : 0, 1192223
Total [candidate] (9.199 s) : 0, 9199296

baseline results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.06 s	-
Agent	iast	1.181 s	120.363 ms (11.4%)
Agent	iast_HARDCODED_SECRET_DISABLED	1.189 s	128.858 ms (12.2%)
Agent	iast_TELEMETRY_OFF	1.176 s	116.027 ms (10.9%)
Total	tracing	8.612 s	-
Total	iast	9.19 s	577.145 ms (6.7%)
Total	iast_HARDCODED_SECRET_DISABLED	9.208 s	595.839 ms (6.9%)
Total	iast_TELEMETRY_OFF	9.158 s	545.463 ms (6.3%)

candidate results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.06 s	-
Agent	iast	1.187 s	126.984 ms (12.0%)
Agent	iast_HARDCODED_SECRET_DISABLED	1.18 s	120.307 ms (11.3%)
Agent	iast_TELEMETRY_OFF	1.192 s	132.062 ms (12.5%)
Total	tracing	8.619 s	-
Total	iast	9.202 s	583.267 ms (6.8%)
Total	iast_HARDCODED_SECRET_DISABLED	9.152 s	532.87 ms (6.2%)
Total	iast_TELEMETRY_OFF	9.199 s	580.134 ms (6.7%)

gantt
    title insecure-bank - break down per module: candidate=1.45.0-SNAPSHOT~35d6fa0d84, baseline=1.45.0-SNAPSHOT~6bfef97d85

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (717.362 ms) : 0, 717362
BytebuddyAgent [candidate] (716.152 ms) : 0, 716152
GlobalTracer [baseline] (257.038 ms) : 0, 257038
GlobalTracer [candidate] (258.046 ms) : 0, 258046
AppSec [baseline] (56.068 ms) : 0, 56068
AppSec [candidate] (55.731 ms) : 0, 55731
Remote Config [baseline] (721.637 µs) : 0, 722
Remote Config [candidate] (743.205 µs) : 0, 743
Telemetry [baseline] (14.045 ms) : 0, 14045
Telemetry [candidate] (14.362 ms) : 0, 14362
section iast
BytebuddyAgent [baseline] (831.394 ms) : 0, 831394
BytebuddyAgent [candidate] (836.252 ms) : 0, 836252
GlobalTracer [baseline] (246.356 ms) : 0, 246356
GlobalTracer [candidate] (246.995 ms) : 0, 246995
AppSec [baseline] (57.822 ms) : 0, 57822
AppSec [candidate] (58.303 ms) : 0, 58303
IAST [baseline] (21.196 ms) : 0, 21196
IAST [candidate] (21.274 ms) : 0, 21274
Remote Config [baseline] (644.484 µs) : 0, 644
Remote Config [candidate] (666.81 µs) : 0, 667
Telemetry [baseline] (8.406 ms) : 0, 8406
Telemetry [candidate] (8.566 ms) : 0, 8566
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (836.447 ms) : 0, 836447
BytebuddyAgent [candidate] (830.387 ms) : 0, 830387
GlobalTracer [baseline] (248.187 ms) : 0, 248187
GlobalTracer [candidate] (246.669 ms) : 0, 246669
AppSec [baseline] (58.731 ms) : 0, 58731
AppSec [candidate] (58.055 ms) : 0, 58055
IAST [baseline] (21.556 ms) : 0, 21556
IAST [candidate] (21.185 ms) : 0, 21185
Remote Config [baseline] (673.056 µs) : 0, 673
Remote Config [candidate] (643.628 µs) : 0, 644
Telemetry [baseline] (8.574 ms) : 0, 8574
Telemetry [candidate] (8.516 ms) : 0, 8516
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (827.785 ms) : 0, 827785
BytebuddyAgent [candidate] (839.174 ms) : 0, 839174
GlobalTracer [baseline] (246.048 ms) : 0, 246048
GlobalTracer [candidate] (249.382 ms) : 0, 249382
AppSec [baseline] (57.875 ms) : 0, 57875
AppSec [candidate] (58.259 ms) : 0, 58259
IAST [baseline] (20.772 ms) : 0, 20772
IAST [candidate] (21.079 ms) : 0, 21079
Remote Config [baseline] (637.853 µs) : 0, 638
Remote Config [candidate] (658.529 µs) : 0, 659
Telemetry [baseline] (8.342 ms) : 0, 8342
Telemetry [candidate] (8.487 ms) : 0, 8487

Load

Parameters

	Baseline	Candidate
baseline_or_candidate	baseline	candidate
end_time	2025-01-06T09:05:46	2025-01-06T09:12:48
git_branch	master	mcculls/javax-jms-module
git_commit_date	1736152625	1736153825
git_commit_sha	`6bfef97`	`35d6fa0`
release_version	1.45.0-SNAPSHOT~6bfef97d85	1.45.0-SNAPSHOT~35d6fa0d84
start_time	2025-01-06T09:05:32	2025-01-06T09:12:34

See matching parameters

	Baseline	Candidate
application	insecure-bank	insecure-bank
ci_job_date	1736155124	1736155124
ci_job_id	755026991	755026991
ci_pipeline_id	52203394	52203394
cpu_model	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
variant	iast	iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 16 unstable metrics.

Request duration reports for insecure-bank

gantt
    title insecure-bank - request duration [CI 0.99] : candidate=1.45.0-SNAPSHOT~35d6fa0d84, baseline=1.45.0-SNAPSHOT~6bfef97d85
    dateFormat X
    axisFormat %s
section baseline
no_agent (388.853 µs) : 367, 411
.   : milestone, 389,
iast (501.652 µs) : 480, 523
.   : milestone, 502,
iast_FULL (662.517 µs) : 641, 684
.   : milestone, 663,
iast_GLOBAL (533.105 µs) : 511, 556
.   : milestone, 533,
iast_HARDCODED_SECRET_DISABLED (498.308 µs) : 477, 520
.   : milestone, 498,
iast_INACTIVE (463.801 µs) : 442, 486
.   : milestone, 464,
iast_TELEMETRY_OFF (487.329 µs) : 466, 509
.   : milestone, 487,
tracing (455.381 µs) : 433, 477
.   : milestone, 455,
section candidate
no_agent (383.893 µs) : 364, 403
.   : milestone, 384,
iast (500.275 µs) : 478, 522
.   : milestone, 500,
iast_FULL (665.969 µs) : 644, 688
.   : milestone, 666,
iast_GLOBAL (529.37 µs) : 507, 551
.   : milestone, 529,
iast_HARDCODED_SECRET_DISABLED (501.53 µs) : 480, 523
.   : milestone, 502,
iast_INACTIVE (459.419 µs) : 439, 480
.   : milestone, 459,
iast_TELEMETRY_OFF (496.821 µs) : 475, 519
.   : milestone, 497,
tracing (459.089 µs) : 437, 482
.   : milestone, 459,

baseline results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	388.853 µs [366.798 µs, 410.907 µs]	-
iast	501.652 µs [480.279 µs, 523.025 µs]	112.8 µs (29.0%)
iast_FULL	662.517 µs [640.681 µs, 684.353 µs]	273.664 µs (70.4%)
iast_GLOBAL	533.105 µs [510.508 µs, 555.702 µs]	144.252 µs (37.1%)
iast_HARDCODED_SECRET_DISABLED	498.308 µs [476.678 µs, 519.938 µs]	109.455 µs (28.1%)
iast_INACTIVE	463.801 µs [442.096 µs, 485.506 µs]	74.948 µs (19.3%)
iast_TELEMETRY_OFF	487.329 µs [465.608 µs, 509.05 µs]	98.476 µs (25.3%)
tracing	455.381 µs [433.426 µs, 477.336 µs]	66.529 µs (17.1%)

candidate results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	383.893 µs [364.4 µs, 403.385 µs]	-
iast	500.275 µs [478.445 µs, 522.104 µs]	116.382 µs (30.3%)
iast_FULL	665.969 µs [644.395 µs, 687.543 µs]	282.076 µs (73.5%)
iast_GLOBAL	529.37 µs [507.304 µs, 551.436 µs]	145.477 µs (37.9%)
iast_HARDCODED_SECRET_DISABLED	501.53 µs [480.045 µs, 523.015 µs]	117.637 µs (30.6%)
iast_INACTIVE	459.419 µs [438.63 µs, 480.208 µs]	75.526 µs (19.7%)
iast_TELEMETRY_OFF	496.821 µs [475.02 µs, 518.623 µs]	112.929 µs (29.4%)
tracing	459.089 µs [436.652 µs, 481.526 µs]	75.196 µs (19.6%)

Request duration reports for petclinic

gantt
    title petclinic - request duration [CI 0.99] : candidate=1.45.0-SNAPSHOT~35d6fa0d84, baseline=1.45.0-SNAPSHOT~6bfef97d85
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.349 ms) : 1329, 1368
.   : milestone, 1349,
appsec (1.759 ms) : 1736, 1782
.   : milestone, 1759,
appsec_no_iast (1.779 ms) : 1756, 1802
.   : milestone, 1779,
iast (1.497 ms) : 1473, 1520
.   : milestone, 1497,
profiling (1.566 ms) : 1541, 1592
.   : milestone, 1566,
tracing (1.513 ms) : 1489, 1537
.   : milestone, 1513,
section candidate
no_agent (1.375 ms) : 1355, 1396
.   : milestone, 1375,
appsec (1.769 ms) : 1746, 1792
.   : milestone, 1769,
appsec_no_iast (1.769 ms) : 1746, 1792
.   : milestone, 1769,
iast (1.535 ms) : 1512, 1557
.   : milestone, 1535,
profiling (1.534 ms) : 1511, 1558
.   : milestone, 1534,
tracing (1.489 ms) : 1464, 1514
.   : milestone, 1489,

baseline results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	1.349 ms [1.329 ms, 1.368 ms]	-
appsec	1.759 ms [1.736 ms, 1.782 ms]	410.108 µs (30.4%)
appsec_no_iast	1.779 ms [1.756 ms, 1.802 ms]	430.461 µs (31.9%)
iast	1.497 ms [1.473 ms, 1.52 ms]	148.019 µs (11.0%)
profiling	1.566 ms [1.541 ms, 1.592 ms]	217.71 µs (16.1%)
tracing	1.513 ms [1.489 ms, 1.537 ms]	163.935 µs (12.2%)

candidate results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	1.375 ms [1.355 ms, 1.396 ms]	-
appsec	1.769 ms [1.746 ms, 1.792 ms]	393.564 µs (28.6%)
appsec_no_iast	1.769 ms [1.746 ms, 1.792 ms]	393.796 µs (28.6%)
iast	1.535 ms [1.512 ms, 1.557 ms]	159.454 µs (11.6%)
profiling	1.534 ms [1.511 ms, 1.558 ms]	159.127 µs (11.6%)
tracing	1.489 ms [1.464 ms, 1.514 ms]	113.998 µs (8.3%)

Dacapo

Parameters

	Baseline	Candidate
baseline_or_candidate	baseline	candidate
git_branch	master	mcculls/javax-jms-module
git_commit_date	1736152625	1736153825
git_commit_sha	`6bfef97`	`35d6fa0`
release_version	1.45.0-SNAPSHOT~6bfef97d85	1.45.0-SNAPSHOT~35d6fa0d84

See matching parameters

	Baseline	Candidate
application	biojava	biojava
ci_job_date	1736155710	1736155710
ci_job_id	755026992	755026992
ci_pipeline_id	52203394	52203394
cpu_model	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
variant	appsec	appsec

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics.

Execution time for tomcat

gantt
    title tomcat - execution time [CI 0.99] : candidate=1.45.0-SNAPSHOT~35d6fa0d84, baseline=1.45.0-SNAPSHOT~6bfef97d85
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.477 ms) : 1466, 1489
.   : milestone, 1477,
appsec (2.354 ms) : 2311, 2396
.   : milestone, 2354,
iast (2.095 ms) : 2042, 2148
.   : milestone, 2095,
iast_GLOBAL (2.145 ms) : 2092, 2198
.   : milestone, 2145,
profiling (1.964 ms) : 1920, 2007
.   : milestone, 1964,
tracing (1.944 ms) : 1902, 1985
.   : milestone, 1944,
section candidate
no_agent (1.47 ms) : 1459, 1482
.   : milestone, 1470,
appsec (2.364 ms) : 2322, 2406
.   : milestone, 2364,
iast (2.102 ms) : 2048, 2155
.   : milestone, 2102,
iast_GLOBAL (2.149 ms) : 2095, 2202
.   : milestone, 2149,
profiling (1.952 ms) : 1910, 1995
.   : milestone, 1952,
tracing (1.947 ms) : 1905, 1988
.   : milestone, 1947,

baseline results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	1.477 ms [1.466 ms, 1.489 ms]	-
appsec	2.354 ms [2.311 ms, 2.396 ms]	876.296 µs (59.3%)
iast	2.095 ms [2.042 ms, 2.148 ms]	617.662 µs (41.8%)
iast_GLOBAL	2.145 ms [2.092 ms, 2.198 ms]	667.809 µs (45.2%)
profiling	1.964 ms [1.92 ms, 2.007 ms]	486.475 µs (32.9%)
tracing	1.944 ms [1.902 ms, 1.985 ms]	466.424 µs (31.6%)

candidate results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	1.47 ms [1.459 ms, 1.482 ms]	-
appsec	2.364 ms [2.322 ms, 2.406 ms]	894.002 µs (60.8%)
iast	2.102 ms [2.048 ms, 2.155 ms]	631.296 µs (42.9%)
iast_GLOBAL	2.149 ms [2.095 ms, 2.202 ms]	678.669 µs (46.2%)
profiling	1.952 ms [1.91 ms, 1.995 ms]	482.19 µs (32.8%)
tracing	1.947 ms [1.905 ms, 1.988 ms]	476.27 µs (32.4%)

Execution time for biojava

gantt
    title biojava - execution time [CI 0.99] : candidate=1.45.0-SNAPSHOT~35d6fa0d84, baseline=1.45.0-SNAPSHOT~6bfef97d85
    dateFormat X
    axisFormat %s
section baseline
no_agent (14.747 s) : 14747000, 14747000
.   : milestone, 14747000,
appsec (15.058 s) : 15058000, 15058000
.   : milestone, 15058000,
iast (18.822 s) : 18822000, 18822000
.   : milestone, 18822000,
iast_GLOBAL (18.157 s) : 18157000, 18157000
.   : milestone, 18157000,
profiling (15.049 s) : 15049000, 15049000
.   : milestone, 15049000,
tracing (14.957 s) : 14957000, 14957000
.   : milestone, 14957000,
section candidate
no_agent (14.904 s) : 14904000, 14904000
.   : milestone, 14904000,
appsec (15.112 s) : 15112000, 15112000
.   : milestone, 15112000,
iast (18.787 s) : 18787000, 18787000
.   : milestone, 18787000,
iast_GLOBAL (17.91 s) : 17910000, 17910000
.   : milestone, 17910000,
profiling (15.772 s) : 15772000, 15772000
.   : milestone, 15772000,
tracing (14.868 s) : 14868000, 14868000
.   : milestone, 14868000,

baseline results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	14.747 s [14.747 s, 14.747 s]	-
appsec	15.058 s [15.058 s, 15.058 s]	311.0 ms (2.1%)
iast	18.822 s [18.822 s, 18.822 s]	4.075 s (27.6%)
iast_GLOBAL	18.157 s [18.157 s, 18.157 s]	3.41 s (23.1%)
profiling	15.049 s [15.049 s, 15.049 s]	302.0 ms (2.0%)
tracing	14.957 s [14.957 s, 14.957 s]	210.0 ms (1.4%)

candidate results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	14.904 s [14.904 s, 14.904 s]	-
appsec	15.112 s [15.112 s, 15.112 s]	208.0 ms (1.4%)
iast	18.787 s [18.787 s, 18.787 s]	3.883 s (26.1%)
iast_GLOBAL	17.91 s [17.91 s, 17.91 s]	3.006 s (20.2%)
profiling	15.772 s [15.772 s, 15.772 s]	868.0 ms (5.8%)
tracing	14.868 s [14.868 s, 14.868 s]	-36.0 ms (-0.2%)

amarziali

lgtm

| Package | Type | Package file | Manager | Update | Change | |---|---|---|---|---|---| | [com.google.api.grpc:proto-google-common-protos](https://github.com/googleapis/sdk-platform-java) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `2.50.0` -> `2.50.1` | | [com.google.cloud:google-cloud-core-http](https://github.com/googleapis/sdk-platform-java) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `2.49.0` -> `2.49.1` | | [com.google.cloud:google-cloud-core](https://github.com/googleapis/sdk-platform-java) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `2.49.0` -> `2.49.1` | | [com.google.api:gax](https://github.com/googleapis/sdk-platform-java) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `2.59.0` -> `2.59.1` | | [com.datadoghq:dd-trace-api](https://github.com/datadog/dd-trace-java) | dependencies | misk/gradle/libs.versions.toml | gradle | minor | `1.44.1` -> `1.45.0` | | [com.datadoghq:dd-trace-ot](https://github.com/datadog/dd-trace-java) | dependencies | misk/gradle/libs.versions.toml | gradle | minor | `1.44.1` -> `1.45.0` | | [software.amazon.awssdk:sdk-core](https://aws.amazon.com/sdkforjava) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `2.29.47` -> `2.29.48` | | [software.amazon.awssdk:dynamodb-enhanced](https://aws.amazon.com/sdkforjava) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `2.29.47` -> `2.29.48` | | [software.amazon.awssdk:dynamodb](https://aws.amazon.com/sdkforjava) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `2.29.47` -> `2.29.48` | | [software.amazon.awssdk:aws-core](https://aws.amazon.com/sdkforjava) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `2.29.47` -> `2.29.48` | | [software.amazon.awssdk:bom](https://aws.amazon.com/sdkforjava) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `2.29.47` -> `2.29.48` | | [software.amazon.awssdk:auth](https://aws.amazon.com/sdkforjava) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `2.29.47` -> `2.29.48` | --- ### Release Notes <details> <summary>datadog/dd-trace-java (com.datadoghq:dd-trace-api)</summary> ### [`v1.45.0`](https://github.com/DataDog/dd-trace-java/releases/tag/v1.45.0): 1.45.0 ##### Breaking changes > \[!WARNING]\ > Support for custom scope manager using OpenTelemetry tracer artifact (`dd-trace-ot`) is dropped. > Tracing with OpenTracing API and custom scope manager will continue to work on 1.44.x releases. ##### Components ##### Application Security Management (IAST) - ✨ Add propagation to URI#toURL method ([#8146](DataDog/dd-trace-java#8146) - [@manuel-alvarez-alvarez](https://github.com/manuel-alvarez-alvarez)) - ✨ Increase IAST propagation to StringBuilder setLength ([#8119](DataDog/dd-trace-java#8119) - [@Mariovido](https://github.com/Mariovido)) - ✨ Increase IAST propagation to StringBuffer append ([#8082](DataDog/dd-trace-java#8082) - [@Mariovido](https://github.com/Mariovido)) - ✨ Handle IAST security controls custom validation and sanitization methods ([#7997](DataDog/dd-trace-java#7997) - [@jandro996](https://github.com/jandro996)) ##### Application Security Management (WAF) - ✨ Update user lifecycle tracking to V3 ([#8108](DataDog/dd-trace-java#8108) - [@manuel-alvarez-alvarez](https://github.com/manuel-alvarez-alvarez)) - ✨ Exploit prevention for Shell Injection / Command Injection ([#7615](DataDog/dd-trace-java#7615) - [@jandro996](https://github.com/jandro996)) ##### Build & Tooling - 💡 Support instrumentation of repackaged libraries ([#8153](DataDog/dd-trace-java#8153) - [@mcculls](https://github.com/mcculls)) - ✨ Configure native image build setting for JDK-22 based GraalVM ([#8092](DataDog/dd-trace-java#8092) - [@MattAlp](https://github.com/MattAlp)) ##### Database Monitoring - ✨ Add full APM/DBM mode for Oracle ([#8090](DataDog/dd-trace-java#8090) - [@nenadnoveljic](https://github.com/nenadnoveljic)) ##### Dynamic Instrumentation - 🐛 make local var hoisting disabled by default ([#8158](DataDog/dd-trace-java#8158) - [@jpbempel](https://github.com/jpbempel)) - 🐛 Fix var hoisting issue when no previous store ([#8122](DataDog/dd-trace-java#8122) - [@jpbempel](https://github.com/jpbempel)) - ✨ Only decorate spans without code origin information ([#8105](DataDog/dd-trace-java#8105) - [@evanchooly](https://github.com/evanchooly)) - 🐛 Fix suspend Kotlin methods instrumentation ([#8080](DataDog/dd-trace-java#8080) - [@jpbempel](https://github.com/jpbempel)) - 🐛 Fix class file version detection ([#8057](DataDog/dd-trace-java#8057) - [@jpbempel](https://github.com/jpbempel)) ##### GraalVM native-image - ✨ Configure native image build setting for JDK-22 based GraalVM ([#8092](DataDog/dd-trace-java#8092) - [@MattAlp](https://github.com/MattAlp)) ##### ML Observability (LLMObs) - ✨🧪 Add LLMObs configuration ([#8076](DataDog/dd-trace-java#8076) - [@gary-huang](https://github.com/gary-huang)) ##### Metrics - Bump integrations-core submodule to 7.60.0 ([#8098](DataDog/dd-trace-java#8098) - [@mcculls](https://github.com/mcculls)) - Upgrade to java-dogstatsd-client v4.4.3 ([#8096](DataDog/dd-trace-java#8096) - [@mcculls](https://github.com/mcculls)) ##### OpenTracing - ⚠️🧹 Remove custom scope manager support ([#8164](DataDog/dd-trace-java#8164) - [@PerfectSlayer](https://github.com/PerfectSlayer)) ##### Telemetry - ✨ Retry telemetry requests if CI Visibility is enabled ([#8147](DataDog/dd-trace-java#8147) - [@nikita-tkachenko-datadog](https://github.com/nikita-tkachenko-datadog)) - ✨ Add configurable Dependency service resolution period ([#8079](DataDog/dd-trace-java#8079) - [@jandro996](https://github.com/jandro996)) ##### Testing - 🐛 Remove restriction to not run vertx4 latest tests on java 17 ([#8133](DataDog/dd-trace-java#8133) - [@vandonr](https://github.com/vandonr)) ##### Tracer core - ✨ Defer remote components to avoid OkHttp class-loading side-effects ([#8131](DataDog/dd-trace-java#8131) - [@mcculls](https://github.com/mcculls)) - ✨ Improve Context API null handling and Javadoc ([#8129](DataDog/dd-trace-java#8129) - [@PerfectSlayer](https://github.com/PerfectSlayer)) - 🐛⚡ Avoid performing blocking I/O operation on application thread ([#8120](DataDog/dd-trace-java#8120) - [@mcculls](https://github.com/mcculls)) - 💡 Introduce a shared context component, independent of tracing ([#8117](DataDog/dd-trace-java#8117) - [@mcculls](https://github.com/mcculls)) - ✨ Improves ServiceNameCollector ([#8109](DataDog/dd-trace-java#8109) - [@amarziali](https://github.com/amarziali)) - Upgrade to ASM 9.7.1 (adds new constant for Java 24) ([#8097](DataDog/dd-trace-java#8097) - [@mcculls](https://github.com/mcculls)) - 🐛 Dynamically evaluate service name for message consumers ([#8088](DataDog/dd-trace-java#8088) - [@amarziali](https://github.com/amarziali)) ##### Serverless - 🐛 Add avoid double instrumenting lambda non-streaming handlers. ([#8073](DataDog/dd-trace-java#8073) - [@purple4reina](https://github.com/purple4reina)) ##### Instrumentations ##### AWS SDK instrumentation - 💡 Instrument EMR's relocated AWS SDK ([#8157](DataDog/dd-trace-java#8157) - [@mcculls](https://github.com/mcculls)) ##### Eclipse Vert.x instrumentation - 🐛 Remove restriction to not run vertx4 latest tests on java 17 ([#8133](DataDog/dd-trace-java#8133) - [@vandonr](https://github.com/vandonr)) ##### JDBC instrumentation - ✨ Add full APM/DBM mode for Oracle ([#8090](DataDog/dd-trace-java#8090) - [@nenadnoveljic](https://github.com/nenadnoveljic)) ##### Jetty instrumentation - 🐛 Ensure jetty 12 has servlet.path starting with / ([#8093](DataDog/dd-trace-java#8093) - [@github-actions](https://github.com/github-actions)\[bot]) ##### JMS instrumentation - 🧹 Re-use `javax` JMS module for `jakarta` namespace ([#8155](DataDog/dd-trace-java#8155) - [@mcculls](https://github.com/mcculls)) - 🧹 Group `javax.jms` instrumentations under a single module ([#8154](DataDog/dd-trace-java#8154) - [@mcculls](https://github.com/mcculls)) ##### Reactor instrumentation - 🐛 Reactor: early propagate span in context when subscribing ([#8166](DataDog/dd-trace-java#8166) - [@amarziali](https://github.com/amarziali)) </details> --- ### Configuration 📅 **Schedule**: Branch creation - "after 6pm every weekday,before 2am every weekday" in timezone Australia/Melbourne, Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 👻 **Immortal**: This PR will be recreated if closed unmerged. Get [config help](https://github.com/renovatebot/renovate/discussions) if that's undesired. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). GitOrigin-RevId: ba2355aa4e2e39ab1fee27319cc4176238efd90b

mcculls added type: refactoring inst: jms JMS instrumentation labels Jan 4, 2025

mcculls commented Jan 4, 2025

View reviewed changes

mcculls marked this pull request as ready for review January 4, 2025 21:56

mcculls requested a review from a team as a code owner January 4, 2025 21:56

mcculls mentioned this pull request Jan 4, 2025

Re-use javax JMS module for jakarta namespace #8155

Merged

mcculls force-pushed the mcculls/support-instrumenting-repackaged-libraries branch from 7391ebd to 11f0727 Compare January 5, 2025 15:18

mcculls requested a review from a team as a code owner January 5, 2025 15:18

mcculls requested a review from PerfectSlayer January 5, 2025 15:18

mcculls force-pushed the mcculls/javax-jms-module branch from c93097f to a38fa07 Compare January 5, 2025 15:21

mcculls force-pushed the mcculls/support-instrumenting-repackaged-libraries branch from 11f0727 to c39b811 Compare January 5, 2025 15:56

mcculls force-pushed the mcculls/javax-jms-module branch from a38fa07 to 7b079e1 Compare January 5, 2025 15:57

mcculls requested a review from amarziali January 5, 2025 18:36

mcculls force-pushed the mcculls/support-instrumenting-repackaged-libraries branch from c39b811 to e4d0c6f Compare January 5, 2025 21:57

mcculls force-pushed the mcculls/javax-jms-module branch from 7b079e1 to 066251a Compare January 5, 2025 21:59

amarziali approved these changes Jan 6, 2025

View reviewed changes

Base automatically changed from mcculls/support-instrumenting-repackaged-libraries to master January 6, 2025 08:37

Group javax.jms instrumentations under a single module

35d6fa0

mcculls force-pushed the mcculls/javax-jms-module branch from 066251a to 35d6fa0 Compare January 6, 2025 08:57

mcculls enabled auto-merge (squash) January 6, 2025 08:58

mcculls added tag: no release notes Changes to exclude from release notes and removed tag: no release notes Changes to exclude from release notes labels Jan 6, 2025

mcculls merged commit 350b2cd into master Jan 6, 2025
150 checks passed

mcculls deleted the mcculls/javax-jms-module branch January 6, 2025 10:03

github-actions bot added this to the 1.45.0 milestone Jan 6, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Group `javax.jms` instrumentations under a single module #8154

Group `javax.jms` instrumentations under a single module #8154

mcculls commented Jan 4, 2025 •

edited by jira bot

Loading

mcculls Jan 4, 2025

pr-commenter bot commented Jan 4, 2025 •

edited

Loading

amarziali left a comment

Group javax.jms instrumentations under a single module #8154

Group javax.jms instrumentations under a single module #8154

Conversation

mcculls commented Jan 4, 2025 • edited by jira bot Loading

Motivation

Contributor Checklist

mcculls Jan 4, 2025

Choose a reason for hiding this comment

pr-commenter bot commented Jan 4, 2025 • edited Loading

Benchmarks

Startup

Parameters

Summary

Load

Parameters

Summary

Dacapo

Parameters

Summary

amarziali left a comment

Choose a reason for hiding this comment

Group `javax.jms` instrumentations under a single module #8154

Group `javax.jms` instrumentations under a single module #8154

mcculls commented Jan 4, 2025 •

edited by jira bot

Loading

pr-commenter bot commented Jan 4, 2025 •

edited

Loading