-
Notifications
You must be signed in to change notification settings - Fork 292
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add the possibility to output the logs of the Java tracer in JSON #8083
base: master
Are you sure you want to change the base?
Conversation
Hi! 👋 Looks like you updated a Git Submodule.
|
Hi! 👋 Looks like you updated a Git Submodule.
|
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 59 metrics, 4 unstable metrics. Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.45.0-SNAPSHOT~1179ee5c35, baseline=1.45.0-SNAPSHOT~0dc9c087f0
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.052 s) : 0, 1052481
Total [baseline] (8.595 s) : 0, 8595113
Agent [candidate] (1.051 s) : 0, 1050720
Total [candidate] (8.597 s) : 0, 8597442
section iast
Agent [baseline] (1.179 s) : 0, 1178537
Total [baseline] (9.214 s) : 0, 9214105
Agent [candidate] (1.178 s) : 0, 1177747
Total [candidate] (9.209 s) : 0, 9209206
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.189 s) : 0, 1188703
Total [baseline] (9.21 s) : 0, 9209581
Agent [candidate] (1.179 s) : 0, 1178699
Total [candidate] (9.192 s) : 0, 9191729
section iast_TELEMETRY_OFF
Agent [baseline] (1.174 s) : 0, 1173716
Total [baseline] (9.204 s) : 0, 9203862
Agent [candidate] (1.176 s) : 0, 1176403
Total [candidate] (9.195 s) : 0, 9195399
gantt
title insecure-bank - break down per module: candidate=1.45.0-SNAPSHOT~1179ee5c35, baseline=1.45.0-SNAPSHOT~0dc9c087f0
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (711.3 ms) : 0, 711300
BytebuddyAgent [candidate] (710.3 ms) : 0, 710300
GlobalTracer [baseline] (256.343 ms) : 0, 256343
GlobalTracer [candidate] (255.756 ms) : 0, 255756
AppSec [baseline] (54.933 ms) : 0, 54933
AppSec [candidate] (57.221 ms) : 0, 57221
Remote Config [baseline] (711.989 µs) : 0, 712
Remote Config [candidate] (688.106 µs) : 0, 688
Telemetry [baseline] (14.233 ms) : 0, 14233
Telemetry [candidate] (11.912 ms) : 0, 11912
section iast
BytebuddyAgent [baseline] (828.464 ms) : 0, 828464
BytebuddyAgent [candidate] (828.246 ms) : 0, 828246
GlobalTracer [baseline] (246.614 ms) : 0, 246614
GlobalTracer [candidate] (246.927 ms) : 0, 246927
AppSec [baseline] (58.032 ms) : 0, 58032
AppSec [candidate] (57.731 ms) : 0, 57731
IAST [baseline] (21.243 ms) : 0, 21243
IAST [candidate] (20.943 ms) : 0, 20943
Remote Config [baseline] (647.541 µs) : 0, 648
Remote Config [candidate] (655.301 µs) : 0, 655
Telemetry [baseline] (8.61 ms) : 0, 8610
Telemetry [candidate] (8.427 ms) : 0, 8427
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (835.565 ms) : 0, 835565
BytebuddyAgent [candidate] (828.41 ms) : 0, 828410
GlobalTracer [baseline] (248.402 ms) : 0, 248402
GlobalTracer [candidate] (247.234 ms) : 0, 247234
AppSec [baseline] (58.564 ms) : 0, 58564
AppSec [candidate] (57.938 ms) : 0, 57938
IAST [baseline] (21.701 ms) : 0, 21701
IAST [candidate] (21.133 ms) : 0, 21133
Remote Config [baseline] (682.219 µs) : 0, 682
Remote Config [candidate] (664.607 µs) : 0, 665
Telemetry [baseline] (8.722 ms) : 0, 8722
Telemetry [candidate] (8.529 ms) : 0, 8529
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (824.449 ms) : 0, 824449
BytebuddyAgent [candidate] (827.595 ms) : 0, 827595
GlobalTracer [baseline] (246.521 ms) : 0, 246521
GlobalTracer [candidate] (246.868 ms) : 0, 246868
AppSec [baseline] (57.663 ms) : 0, 57663
AppSec [candidate] (57.218 ms) : 0, 57218
IAST [baseline] (21.09 ms) : 0, 21090
IAST [candidate] (20.736 ms) : 0, 20736
Remote Config [baseline] (651.341 µs) : 0, 651
Remote Config [candidate] (655.512 µs) : 0, 656
Telemetry [baseline] (8.447 ms) : 0, 8447
Telemetry [candidate] (8.344 ms) : 0, 8344
Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.45.0-SNAPSHOT~1179ee5c35, baseline=1.45.0-SNAPSHOT~0dc9c087f0
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.051 s) : 0, 1050985
Total [baseline] (10.405 s) : 0, 10405206
Agent [candidate] (1.054 s) : 0, 1053637
Total [candidate] (10.421 s) : 0, 10420804
section appsec
Agent [baseline] (1.191 s) : 0, 1190889
Total [baseline] (10.717 s) : 0, 10717061
Agent [candidate] (1.189 s) : 0, 1188987
Total [candidate] (10.812 s) : 0, 10811804
section iast
Agent [baseline] (1.178 s) : 0, 1178406
Total [baseline] (11.02 s) : 0, 11019841
Agent [candidate] (1.183 s) : 0, 1183452
Total [candidate] (11.037 s) : 0, 11037170
section profiling
Agent [baseline] (1.272 s) : 0, 1272140
Total [baseline] (10.804 s) : 0, 10803623
Agent [candidate] (1.281 s) : 0, 1281487
Total [candidate] (10.837 s) : 0, 10837321
gantt
title petclinic - break down per module: candidate=1.45.0-SNAPSHOT~1179ee5c35, baseline=1.45.0-SNAPSHOT~0dc9c087f0
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (711.548 ms) : 0, 711548
BytebuddyAgent [candidate] (712.338 ms) : 0, 712338
GlobalTracer [baseline] (256.737 ms) : 0, 256737
GlobalTracer [candidate] (255.898 ms) : 0, 255898
AppSec [baseline] (55.207 ms) : 0, 55207
AppSec [candidate] (57.225 ms) : 0, 57225
Remote Config [baseline] (711.328 µs) : 0, 711
Remote Config [candidate] (707.92 µs) : 0, 708
Telemetry [baseline] (11.867 ms) : 0, 11867
Telemetry [candidate] (12.569 ms) : 0, 12569
section appsec
BytebuddyAgent [baseline] (732.078 ms) : 0, 732078
BytebuddyAgent [candidate] (729.607 ms) : 0, 729607
GlobalTracer [baseline] (254.283 ms) : 0, 254283
GlobalTracer [candidate] (254.32 ms) : 0, 254320
AppSec [baseline] (171.1 ms) : 0, 171100
AppSec [candidate] (171.686 ms) : 0, 171686
IAST [baseline] (19.397 ms) : 0, 19397
IAST [candidate] (19.561 ms) : 0, 19561
Remote Config [baseline] (659.758 µs) : 0, 660
Remote Config [candidate] (666.117 µs) : 0, 666
Telemetry [baseline] (8.066 ms) : 0, 8066
Telemetry [candidate] (7.997 ms) : 0, 7997
section iast
BytebuddyAgent [baseline] (827.967 ms) : 0, 827967
BytebuddyAgent [candidate] (833.299 ms) : 0, 833299
GlobalTracer [baseline] (246.66 ms) : 0, 246660
GlobalTracer [candidate] (246.785 ms) : 0, 246785
AppSec [baseline] (58.16 ms) : 0, 58160
AppSec [candidate] (57.888 ms) : 0, 57888
IAST [baseline] (21.529 ms) : 0, 21529
IAST [candidate] (21.254 ms) : 0, 21254
Remote Config [baseline] (662.75 µs) : 0, 663
Remote Config [candidate] (669.513 µs) : 0, 670
Telemetry [baseline] (8.561 ms) : 0, 8561
Telemetry [candidate] (8.544 ms) : 0, 8544
section profiling
BytebuddyAgent [baseline] (700.863 ms) : 0, 700863
BytebuddyAgent [candidate] (706.668 ms) : 0, 706668
GlobalTracer [baseline] (371.248 ms) : 0, 371248
GlobalTracer [candidate] (373.52 ms) : 0, 373520
AppSec [baseline] (54.283 ms) : 0, 54283
AppSec [candidate] (54.528 ms) : 0, 54528
Remote Config [baseline] (672.606 µs) : 0, 673
Remote Config [candidate] (649.785 µs) : 0, 650
Telemetry [baseline] (7.744 ms) : 0, 7744
Telemetry [candidate] (7.845 ms) : 0, 7845
ProfilingAgent [baseline] (95.687 ms) : 0, 95687
ProfilingAgent [candidate] (96.351 ms) : 0, 96351
Profiling [baseline] (95.711 ms) : 0, 95711
Profiling [candidate] (96.375 ms) : 0, 96375
LoadParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 16 unstable metrics. Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.45.0-SNAPSHOT~1179ee5c35, baseline=1.45.0-SNAPSHOT~0dc9c087f0
dateFormat X
axisFormat %s
section baseline
no_agent (1.347 ms) : 1327, 1368
. : milestone, 1347,
appsec (1.753 ms) : 1729, 1777
. : milestone, 1753,
appsec_no_iast (1.764 ms) : 1740, 1788
. : milestone, 1764,
iast (1.517 ms) : 1495, 1540
. : milestone, 1517,
profiling (1.539 ms) : 1513, 1564
. : milestone, 1539,
tracing (1.5 ms) : 1476, 1524
. : milestone, 1500,
section candidate
no_agent (1.356 ms) : 1336, 1376
. : milestone, 1356,
appsec (1.744 ms) : 1721, 1767
. : milestone, 1744,
appsec_no_iast (1.746 ms) : 1720, 1771
. : milestone, 1746,
iast (1.495 ms) : 1472, 1518
. : milestone, 1495,
profiling (1.494 ms) : 1471, 1517
. : milestone, 1494,
tracing (1.476 ms) : 1451, 1501
. : milestone, 1476,
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.45.0-SNAPSHOT~1179ee5c35, baseline=1.45.0-SNAPSHOT~0dc9c087f0
dateFormat X
axisFormat %s
section baseline
no_agent (370.318 µs) : 351, 390
. : milestone, 370,
iast (488.25 µs) : 467, 510
. : milestone, 488,
iast_FULL (649.833 µs) : 628, 672
. : milestone, 650,
iast_GLOBAL (516.635 µs) : 495, 538
. : milestone, 517,
iast_HARDCODED_SECRET_DISABLED (489.49 µs) : 468, 511
. : milestone, 489,
iast_INACTIVE (461.21 µs) : 440, 482
. : milestone, 461,
iast_TELEMETRY_OFF (480.03 µs) : 458, 502
. : milestone, 480,
tracing (449.298 µs) : 428, 470
. : milestone, 449,
section candidate
no_agent (380.24 µs) : 359, 402
. : milestone, 380,
iast (492.466 µs) : 471, 514
. : milestone, 492,
iast_FULL (647.936 µs) : 626, 670
. : milestone, 648,
iast_GLOBAL (513.849 µs) : 493, 535
. : milestone, 514,
iast_HARDCODED_SECRET_DISABLED (483.535 µs) : 462, 505
. : milestone, 484,
iast_INACTIVE (460.578 µs) : 439, 482
. : milestone, 461,
iast_TELEMETRY_OFF (475.737 µs) : 454, 497
. : milestone, 476,
tracing (449.218 µs) : 428, 470
. : milestone, 449,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics. Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.45.0-SNAPSHOT~1179ee5c35, baseline=1.45.0-SNAPSHOT~0dc9c087f0
dateFormat X
axisFormat %s
section baseline
no_agent (1.464 ms) : 1453, 1475
. : milestone, 1464,
appsec (2.332 ms) : 2290, 2373
. : milestone, 2332,
iast (2.083 ms) : 2030, 2136
. : milestone, 2083,
iast_GLOBAL (2.128 ms) : 2075, 2182
. : milestone, 2128,
profiling (1.946 ms) : 1904, 1989
. : milestone, 1946,
tracing (1.929 ms) : 1888, 1969
. : milestone, 1929,
section candidate
no_agent (1.464 ms) : 1452, 1475
. : milestone, 1464,
appsec (2.338 ms) : 2296, 2379
. : milestone, 2338,
iast (2.08 ms) : 2027, 2132
. : milestone, 2080,
iast_GLOBAL (2.115 ms) : 2062, 2168
. : milestone, 2115,
profiling (1.953 ms) : 1910, 1995
. : milestone, 1953,
tracing (1.926 ms) : 1885, 1966
. : milestone, 1926,
Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.45.0-SNAPSHOT~1179ee5c35, baseline=1.45.0-SNAPSHOT~0dc9c087f0
dateFormat X
axisFormat %s
section baseline
no_agent (14.887 s) : 14887000, 14887000
. : milestone, 14887000,
appsec (15.145 s) : 15145000, 15145000
. : milestone, 15145000,
iast (18.584 s) : 18584000, 18584000
. : milestone, 18584000,
iast_GLOBAL (17.921 s) : 17921000, 17921000
. : milestone, 17921000,
profiling (15.111 s) : 15111000, 15111000
. : milestone, 15111000,
tracing (14.966 s) : 14966000, 14966000
. : milestone, 14966000,
section candidate
no_agent (14.918 s) : 14918000, 14918000
. : milestone, 14918000,
appsec (15.079 s) : 15079000, 15079000
. : milestone, 15079000,
iast (18.573 s) : 18573000, 18573000
. : milestone, 18573000,
iast_GLOBAL (17.714 s) : 17714000, 17714000
. : milestone, 17714000,
profiling (15.19 s) : 15190000, 15190000
. : milestone, 15190000,
tracing (15.043 s) : 15043000, 15043000
. : milestone, 15043000,
|
What Does This Do
Add the possibility to output the logs of the Java tracer in JSON.
The JSON keys have been chosen to be compatible out of the box with the Logs UI of Datadog.
You will be able to identify all the logs coming from the tracer by filtering them using @origin:dd.trace
Note:
If you don’t configure a specific
datadog.slf4j.simpleLogger.dateTimeFormat
,yyyy-MM-dd'T'HH:mm:ss.SSSZ
to be compatible with the logs UI .[dd.trace 'yyyy-MM-dd HH:mm:ss:SSS Z']
Usage
System property:
datadog.slf4j.simpleLogger.jsonEnabled
Default: false
Description: This configuration key set to true will output the logs of the Java tracer in JSON.
Motivation
#1109
Additional Notes
Contributor Checklist
type:
and (comp:
orinst:
) labels in addition to any usefull labelsclose
,fix
or any linking keywords when referencing an issue.Use
solves
instead, and assign the PR milestone to the issueJira ticket: [PROJ-IDENT]