-
Notifications
You must be signed in to change notification settings - Fork 292
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update PR checks automation #8056
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Fix missing ready_for_review event * Add issue liking keyword detection * Replace the checklist by a simple list as the workflow does most of the checks automatically * Remove the squash your commits entry from the checklist as it is now enforced in GitHub repository settings
PerfectSlayer
added
type: enhancement
tag: no release notes
Changes to exclude from release notes
comp: tooling
Build & Tooling
labels
Dec 4, 2024
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 53 metrics, 10 unstable metrics. Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.44.0-SNAPSHOT~3791e98418, baseline=1.44.0-SNAPSHOT~5b587720dd
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.094 s) : 0, 1093586
Total [baseline] (10.501 s) : 0, 10501449
Agent [candidate] (1.091 s) : 0, 1091491
Total [candidate] (10.433 s) : 0, 10432519
section appsec
Agent [baseline] (1.224 s) : 0, 1224209
Total [baseline] (10.769 s) : 0, 10768832
Agent [candidate] (1.229 s) : 0, 1228841
Total [candidate] (10.756 s) : 0, 10755650
section iast
Agent [baseline] (1.229 s) : 0, 1228607
Total [baseline] (10.954 s) : 0, 10953567
Agent [candidate] (1.227 s) : 0, 1226920
Total [candidate] (10.991 s) : 0, 10991456
section profiling
Agent [baseline] (1.311 s) : 0, 1311469
Total [baseline] (10.864 s) : 0, 10864376
Agent [candidate] (1.324 s) : 0, 1323948
Total [candidate] (10.883 s) : 0, 10883400
gantt
title petclinic - break down per module: candidate=1.44.0-SNAPSHOT~3791e98418, baseline=1.44.0-SNAPSHOT~5b587720dd
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (694.76 ms) : 0, 694760
BytebuddyAgent [candidate] (695.285 ms) : 0, 695285
GlobalTracer [baseline] (318.415 ms) : 0, 318415
GlobalTracer [candidate] (317.569 ms) : 0, 317569
AppSec [baseline] (54.756 ms) : 0, 54756
AppSec [candidate] (54.995 ms) : 0, 54995
Remote Config [baseline] (680.535 µs) : 0, 681
Remote Config [candidate] (678.433 µs) : 0, 678
Telemetry [baseline] (11.268 ms) : 0, 11268
Telemetry [candidate] (9.238 ms) : 0, 9238
section appsec
BytebuddyAgent [baseline] (711.132 ms) : 0, 711132
BytebuddyAgent [candidate] (713.945 ms) : 0, 713945
GlobalTracer [baseline] (314.408 ms) : 0, 314408
GlobalTracer [candidate] (315.722 ms) : 0, 315722
AppSec [baseline] (167.084 ms) : 0, 167084
AppSec [candidate] (166.88 ms) : 0, 166880
Remote Config [baseline] (645.487 µs) : 0, 645
Remote Config [candidate] (653.57 µs) : 0, 654
Telemetry [baseline] (7.422 ms) : 0, 7422
Telemetry [candidate] (8.098 ms) : 0, 8098
IAST [baseline] (19.584 ms) : 0, 19584
IAST [candidate] (19.512 ms) : 0, 19512
section iast
BytebuddyAgent [baseline] (818.565 ms) : 0, 818565
BytebuddyAgent [candidate] (817.772 ms) : 0, 817772
GlobalTracer [baseline] (308.157 ms) : 0, 308157
GlobalTracer [candidate] (307.917 ms) : 0, 307917
AppSec [baseline] (57.894 ms) : 0, 57894
AppSec [candidate] (57.424 ms) : 0, 57424
Remote Config [baseline] (643.75 µs) : 0, 644
Remote Config [candidate] (625.431 µs) : 0, 625
Telemetry [baseline] (7.581 ms) : 0, 7581
Telemetry [candidate] (7.544 ms) : 0, 7544
IAST [baseline] (21.935 ms) : 0, 21935
IAST [candidate] (21.768 ms) : 0, 21768
section profiling
BytebuddyAgent [baseline] (686.912 ms) : 0, 686912
BytebuddyAgent [candidate] (691.968 ms) : 0, 691968
GlobalTracer [baseline] (431.497 ms) : 0, 431497
GlobalTracer [candidate] (435.513 ms) : 0, 435513
AppSec [baseline] (53.095 ms) : 0, 53095
AppSec [candidate] (53.774 ms) : 0, 53774
Remote Config [baseline] (650.445 µs) : 0, 650
Remote Config [candidate] (661.868 µs) : 0, 662
Telemetry [baseline] (7.675 ms) : 0, 7675
Telemetry [candidate] (7.783 ms) : 0, 7783
ProfilingAgent [baseline] (92.707 ms) : 0, 92707
ProfilingAgent [candidate] (94.887 ms) : 0, 94887
Profiling [baseline] (92.73 ms) : 0, 92730
Profiling [candidate] (94.912 ms) : 0, 94912
Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.44.0-SNAPSHOT~3791e98418, baseline=1.44.0-SNAPSHOT~5b587720dd
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.094 s) : 0, 1093956
Total [baseline] (8.72 s) : 0, 8720266
Agent [candidate] (1.092 s) : 0, 1092351
Total [candidate] (8.693 s) : 0, 8692809
section iast
Agent [baseline] (1.219 s) : 0, 1219340
Total [baseline] (9.225 s) : 0, 9225174
Agent [candidate] (1.219 s) : 0, 1219453
Total [candidate] (9.224 s) : 0, 9224138
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.22 s) : 0, 1220478
Total [baseline] (9.195 s) : 0, 9194688
Agent [candidate] (1.22 s) : 0, 1219847
Total [candidate] (9.175 s) : 0, 9175257
section iast_TELEMETRY_OFF
Agent [baseline] (1.218 s) : 0, 1217584
Total [baseline] (9.19 s) : 0, 9189800
Agent [candidate] (1.225 s) : 0, 1225327
Total [candidate] (9.182 s) : 0, 9181878
gantt
title insecure-bank - break down per module: candidate=1.44.0-SNAPSHOT~3791e98418, baseline=1.44.0-SNAPSHOT~5b587720dd
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (694.779 ms) : 0, 694779
BytebuddyAgent [candidate] (694.885 ms) : 0, 694885
GlobalTracer [baseline] (317.976 ms) : 0, 317976
GlobalTracer [candidate] (317.794 ms) : 0, 317794
AppSec [baseline] (55.371 ms) : 0, 55371
AppSec [candidate] (54.633 ms) : 0, 54633
Remote Config [baseline] (690.82 µs) : 0, 691
Remote Config [candidate] (675.636 µs) : 0, 676
Telemetry [baseline] (11.436 ms) : 0, 11436
Telemetry [candidate] (10.612 ms) : 0, 10612
section iast
BytebuddyAgent [baseline] (812.595 ms) : 0, 812595
BytebuddyAgent [candidate] (812.482 ms) : 0, 812482
GlobalTracer [baseline] (306.28 ms) : 0, 306280
GlobalTracer [candidate] (306.269 ms) : 0, 306269
AppSec [baseline] (57.776 ms) : 0, 57776
AppSec [candidate] (56.931 ms) : 0, 56931
IAST [baseline] (20.773 ms) : 0, 20773
IAST [candidate] (21.554 ms) : 0, 21554
Remote Config [baseline] (637.277 µs) : 0, 637
Remote Config [candidate] (650.351 µs) : 0, 650
Telemetry [baseline] (7.565 ms) : 0, 7565
Telemetry [candidate] (7.776 ms) : 0, 7776
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (813.473 ms) : 0, 813473
BytebuddyAgent [candidate] (812.484 ms) : 0, 812484
GlobalTracer [baseline] (306.571 ms) : 0, 306571
GlobalTracer [candidate] (306.488 ms) : 0, 306488
AppSec [baseline] (57.588 ms) : 0, 57588
AppSec [candidate] (57.073 ms) : 0, 57073
IAST [baseline] (20.973 ms) : 0, 20973
IAST [candidate] (21.823 ms) : 0, 21823
Remote Config [baseline] (626.465 µs) : 0, 626
Remote Config [candidate] (642.867 µs) : 0, 643
Telemetry [baseline] (7.496 ms) : 0, 7496
Telemetry [candidate] (7.575 ms) : 0, 7575
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (810.913 ms) : 0, 810913
BytebuddyAgent [candidate] (816.911 ms) : 0, 816911
GlobalTracer [baseline] (306.356 ms) : 0, 306356
GlobalTracer [candidate] (307.593 ms) : 0, 307593
AppSec [baseline] (56.196 ms) : 0, 56196
AppSec [candidate] (58.235 ms) : 0, 58235
IAST [baseline] (22.238 ms) : 0, 22238
IAST [candidate] (20.501 ms) : 0, 20501
Remote Config [baseline] (627.159 µs) : 0, 627
Remote Config [candidate] (628.421 µs) : 0, 628
Telemetry [baseline] (7.485 ms) : 0, 7485
Telemetry [candidate] (7.541 ms) : 0, 7541
LoadParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 16 unstable metrics. Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.44.0-SNAPSHOT~3791e98418, baseline=1.44.0-SNAPSHOT~5b587720dd
dateFormat X
axisFormat %s
section baseline
no_agent (1.372 ms) : 1352, 1391
. : milestone, 1372,
appsec (1.745 ms) : 1720, 1770
. : milestone, 1745,
appsec_no_iast (1.763 ms) : 1738, 1788
. : milestone, 1763,
iast (1.505 ms) : 1483, 1527
. : milestone, 1505,
profiling (1.53 ms) : 1507, 1552
. : milestone, 1530,
tracing (1.495 ms) : 1471, 1519
. : milestone, 1495,
section candidate
no_agent (1.366 ms) : 1346, 1386
. : milestone, 1366,
appsec (1.746 ms) : 1721, 1771
. : milestone, 1746,
appsec_no_iast (1.756 ms) : 1730, 1782
. : milestone, 1756,
iast (1.483 ms) : 1461, 1506
. : milestone, 1483,
profiling (1.528 ms) : 1503, 1553
. : milestone, 1528,
tracing (1.48 ms) : 1455, 1505
. : milestone, 1480,
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.44.0-SNAPSHOT~3791e98418, baseline=1.44.0-SNAPSHOT~5b587720dd
dateFormat X
axisFormat %s
section baseline
no_agent (377.425 µs) : 357, 398
. : milestone, 377,
iast (490.67 µs) : 469, 512
. : milestone, 491,
iast_FULL (654.443 µs) : 633, 676
. : milestone, 654,
iast_GLOBAL (518.235 µs) : 496, 540
. : milestone, 518,
iast_HARDCODED_SECRET_DISABLED (490.487 µs) : 469, 512
. : milestone, 490,
iast_INACTIVE (457.612 µs) : 436, 479
. : milestone, 458,
iast_TELEMETRY_OFF (481.853 µs) : 460, 504
. : milestone, 482,
tracing (451.977 µs) : 431, 473
. : milestone, 452,
section candidate
no_agent (375.845 µs) : 356, 396
. : milestone, 376,
iast (488.795 µs) : 468, 510
. : milestone, 489,
iast_FULL (651.24 µs) : 630, 673
. : milestone, 651,
iast_GLOBAL (510.463 µs) : 489, 532
. : milestone, 510,
iast_HARDCODED_SECRET_DISABLED (489.279 µs) : 468, 511
. : milestone, 489,
iast_INACTIVE (451.58 µs) : 431, 473
. : milestone, 452,
iast_TELEMETRY_OFF (483.785 µs) : 462, 506
. : milestone, 484,
tracing (450.963 µs) : 430, 472
. : milestone, 451,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics. Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.44.0-SNAPSHOT~3791e98418, baseline=1.44.0-SNAPSHOT~5b587720dd
dateFormat X
axisFormat %s
section baseline
no_agent (14.901 s) : 14901000, 14901000
. : milestone, 14901000,
appsec (15.045 s) : 15045000, 15045000
. : milestone, 15045000,
iast (18.595 s) : 18595000, 18595000
. : milestone, 18595000,
iast_GLOBAL (17.752 s) : 17752000, 17752000
. : milestone, 17752000,
profiling (15.48 s) : 15480000, 15480000
. : milestone, 15480000,
tracing (14.792 s) : 14792000, 14792000
. : milestone, 14792000,
section candidate
no_agent (15.245 s) : 15245000, 15245000
. : milestone, 15245000,
appsec (14.949 s) : 14949000, 14949000
. : milestone, 14949000,
iast (18.992 s) : 18992000, 18992000
. : milestone, 18992000,
iast_GLOBAL (18.137 s) : 18137000, 18137000
. : milestone, 18137000,
profiling (14.871 s) : 14871000, 14871000
. : milestone, 14871000,
tracing (14.881 s) : 14881000, 14881000
. : milestone, 14881000,
Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.44.0-SNAPSHOT~3791e98418, baseline=1.44.0-SNAPSHOT~5b587720dd
dateFormat X
axisFormat %s
section baseline
no_agent (1.471 ms) : 1460, 1483
. : milestone, 1471,
appsec (2.348 ms) : 2307, 2389
. : milestone, 2348,
iast (2.094 ms) : 2042, 2147
. : milestone, 2094,
iast_GLOBAL (2.142 ms) : 2089, 2195
. : milestone, 2142,
profiling (1.98 ms) : 1937, 2023
. : milestone, 1980,
tracing (1.934 ms) : 1894, 1974
. : milestone, 1934,
section candidate
no_agent (1.472 ms) : 1461, 1484
. : milestone, 1472,
appsec (2.354 ms) : 2312, 2395
. : milestone, 2354,
iast (2.089 ms) : 2037, 2142
. : milestone, 2089,
iast_GLOBAL (2.129 ms) : 2076, 2182
. : milestone, 2129,
profiling (1.969 ms) : 1926, 2012
. : milestone, 1969,
tracing (1.929 ms) : 1889, 1970
. : milestone, 1929,
|
smola
approved these changes
Dec 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
comp: tooling
Build & Tooling
tag: no release notes
Changes to exclude from release notes
type: enhancement
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What Does This Do
This PR improves the PR checks automation and template:
Motivation
Automate more checks
Additional Notes
Contributor Checklist
type:
and (comp:
orinst:
) labels in addition to any usefull labelsclose
,fix
or any linking keywords when referencing an issue.Use
solves
instead, and assign the PR milestone to the issueJira ticket: [PROJ-IDENT]