-
Notifications
You must be signed in to change notification settings - Fork 292
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix JUnit test case name uniqueness when uploading results #8024
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smola
approved these changes
Nov 27, 2024
PerfectSlayer
force-pushed
the
bbujon/ci-junit-result
branch
from
November 27, 2024 10:18
ffa4986
to
81b5001
Compare
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 56 metrics, 7 unstable metrics. Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.44.0-SNAPSHOT~81b5001337, baseline=1.44.0-SNAPSHOT~9eaf5a01bb
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.092 s) : 0, 1091611
Total [baseline] (8.672 s) : 0, 8672083
Agent [candidate] (1.098 s) : 0, 1097616
Total [candidate] (8.672 s) : 0, 8672316
section iast
Agent [baseline] (1.232 s) : 0, 1232207
Total [baseline] (9.237 s) : 0, 9237266
Agent [candidate] (1.218 s) : 0, 1218412
Total [candidate] (9.199 s) : 0, 9199269
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.22 s) : 0, 1219853
Total [baseline] (9.175 s) : 0, 9174852
Agent [candidate] (1.222 s) : 0, 1221837
Total [candidate] (9.16 s) : 0, 9160475
section iast_TELEMETRY_OFF
Agent [baseline] (1.222 s) : 0, 1221671
Total [baseline] (9.195 s) : 0, 9194709
Agent [candidate] (1.224 s) : 0, 1224305
Total [candidate] (9.22 s) : 0, 9219876
gantt
title insecure-bank - break down per module: candidate=1.44.0-SNAPSHOT~81b5001337, baseline=1.44.0-SNAPSHOT~9eaf5a01bb
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (695.259 ms) : 0, 695259
BytebuddyAgent [candidate] (698.88 ms) : 0, 698880
GlobalTracer [baseline] (318.742 ms) : 0, 318742
GlobalTracer [candidate] (320.047 ms) : 0, 320047
AppSec [baseline] (54.763 ms) : 0, 54763
AppSec [candidate] (54.94 ms) : 0, 54940
Remote Config [baseline] (675.143 µs) : 0, 675
Remote Config [candidate] (685.449 µs) : 0, 685
Telemetry [baseline] (8.42 ms) : 0, 8420
Telemetry [candidate] (9.224 ms) : 0, 9224
section iast
BytebuddyAgent [baseline] (821.192 ms) : 0, 821192
BytebuddyAgent [candidate] (811.105 ms) : 0, 811105
GlobalTracer [baseline] (308.727 ms) : 0, 308727
GlobalTracer [candidate] (306.493 ms) : 0, 306493
AppSec [baseline] (57.038 ms) : 0, 57038
AppSec [candidate] (56.388 ms) : 0, 56388
Remote Config [baseline] (622.423 µs) : 0, 622
Remote Config [candidate] (634.545 µs) : 0, 635
Telemetry [baseline] (7.647 ms) : 0, 7647
Telemetry [candidate] (7.555 ms) : 0, 7555
IAST [baseline] (23.038 ms) : 0, 23038
IAST [candidate] (22.479 ms) : 0, 22479
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (811.975 ms) : 0, 811975
BytebuddyAgent [candidate] (813.392 ms) : 0, 813392
GlobalTracer [baseline] (306.949 ms) : 0, 306949
GlobalTracer [candidate] (307.649 ms) : 0, 307649
AppSec [baseline] (58.189 ms) : 0, 58189
AppSec [candidate] (58.108 ms) : 0, 58108
Remote Config [baseline] (626.055 µs) : 0, 626
Remote Config [candidate] (621.026 µs) : 0, 621
Telemetry [baseline] (7.554 ms) : 0, 7554
Telemetry [candidate] (7.512 ms) : 0, 7512
IAST [baseline] (20.811 ms) : 0, 20811
IAST [candidate] (20.781 ms) : 0, 20781
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (812.829 ms) : 0, 812829
BytebuddyAgent [candidate] (814.228 ms) : 0, 814228
GlobalTracer [baseline] (307.868 ms) : 0, 307868
GlobalTracer [candidate] (308.699 ms) : 0, 308699
AppSec [baseline] (56.06 ms) : 0, 56060
AppSec [candidate] (57.842 ms) : 0, 57842
Remote Config [baseline] (617.096 µs) : 0, 617
Remote Config [candidate] (640.457 µs) : 0, 640
Telemetry [baseline] (7.374 ms) : 0, 7374
Telemetry [candidate] (7.484 ms) : 0, 7484
IAST [baseline] (23.126 ms) : 0, 23126
IAST [candidate] (21.549 ms) : 0, 21549
Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.44.0-SNAPSHOT~81b5001337, baseline=1.44.0-SNAPSHOT~9eaf5a01bb
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.098 s) : 0, 1097818
Total [baseline] (10.473 s) : 0, 10472784
Agent [candidate] (1.105 s) : 0, 1104918
Total [candidate] (10.454 s) : 0, 10454281
section appsec
Agent [baseline] (1.232 s) : 0, 1231752
Total [baseline] (10.825 s) : 0, 10825218
Agent [candidate] (1.228 s) : 0, 1227677
Total [candidate] (10.75 s) : 0, 10750168
section iast
Agent [baseline] (1.229 s) : 0, 1228632
Total [baseline] (11.027 s) : 0, 11027490
Agent [candidate] (1.219 s) : 0, 1219373
Total [candidate] (10.968 s) : 0, 10967821
section profiling
Agent [baseline] (1.313 s) : 0, 1313327
Total [baseline] (10.845 s) : 0, 10844985
Agent [candidate] (1.314 s) : 0, 1314332
Total [candidate] (10.744 s) : 0, 10744009
gantt
title petclinic - break down per module: candidate=1.44.0-SNAPSHOT~81b5001337, baseline=1.44.0-SNAPSHOT~9eaf5a01bb
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (698.659 ms) : 0, 698659
BytebuddyAgent [candidate] (703.429 ms) : 0, 703429
GlobalTracer [baseline] (320.349 ms) : 0, 320349
GlobalTracer [candidate] (322.79 ms) : 0, 322790
AppSec [baseline] (55.056 ms) : 0, 55056
AppSec [candidate] (54.851 ms) : 0, 54851
Remote Config [baseline] (686.667 µs) : 0, 687
Remote Config [candidate] (689.824 µs) : 0, 690
Telemetry [baseline] (9.215 ms) : 0, 9215
Telemetry [candidate] (9.209 ms) : 0, 9209
section appsec
BytebuddyAgent [baseline] (715.174 ms) : 0, 715174
BytebuddyAgent [candidate] (712.932 ms) : 0, 712932
GlobalTracer [baseline] (316.082 ms) : 0, 316082
GlobalTracer [candidate] (315.453 ms) : 0, 315453
AppSec [baseline] (168.11 ms) : 0, 168110
AppSec [candidate] (166.113 ms) : 0, 166113
Remote Config [baseline] (638.972 µs) : 0, 639
Remote Config [candidate] (650.409 µs) : 0, 650
Telemetry [baseline] (8.513 ms) : 0, 8513
Telemetry [candidate] (9.281 ms) : 0, 9281
IAST [baseline] (18.903 ms) : 0, 18903
IAST [candidate] (19.035 ms) : 0, 19035
section iast
BytebuddyAgent [baseline] (818.848 ms) : 0, 818848
BytebuddyAgent [candidate] (811.978 ms) : 0, 811978
GlobalTracer [baseline] (309.184 ms) : 0, 309184
GlobalTracer [candidate] (306.56 ms) : 0, 306560
AppSec [baseline] (56.163 ms) : 0, 56163
AppSec [candidate] (55.511 ms) : 0, 55511
Remote Config [baseline] (632.729 µs) : 0, 633
Remote Config [candidate] (618.243 µs) : 0, 618
Telemetry [baseline] (7.488 ms) : 0, 7488
Telemetry [candidate] (7.558 ms) : 0, 7558
IAST [baseline] (22.347 ms) : 0, 22347
IAST [candidate] (23.412 ms) : 0, 23412
section profiling
BytebuddyAgent [baseline] (686.949 ms) : 0, 686949
BytebuddyAgent [candidate] (686.462 ms) : 0, 686462
GlobalTracer [baseline] (432.551 ms) : 0, 432551
GlobalTracer [candidate] (433.617 ms) : 0, 433617
AppSec [baseline] (53.543 ms) : 0, 53543
AppSec [candidate] (53.722 ms) : 0, 53722
Remote Config [baseline] (644.618 µs) : 0, 645
Remote Config [candidate] (653.49 µs) : 0, 653
Telemetry [baseline] (7.661 ms) : 0, 7661
Telemetry [candidate] (7.694 ms) : 0, 7694
ProfilingAgent [baseline] (92.959 ms) : 0, 92959
ProfilingAgent [candidate] (93.194 ms) : 0, 93194
Profiling [baseline] (92.984 ms) : 0, 92984
Profiling [candidate] (93.218 ms) : 0, 93218
LoadParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 13 metrics, 15 unstable metrics. Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.44.0-SNAPSHOT~81b5001337, baseline=1.44.0-SNAPSHOT~9eaf5a01bb
dateFormat X
axisFormat %s
section baseline
no_agent (380.219 µs) : 360, 400
. : milestone, 380,
iast (499.368 µs) : 478, 521
. : milestone, 499,
iast_FULL (658.76 µs) : 637, 680
. : milestone, 659,
iast_GLOBAL (525.445 µs) : 504, 547
. : milestone, 525,
iast_HARDCODED_SECRET_DISABLED (501.191 µs) : 480, 523
. : milestone, 501,
iast_INACTIVE (450.258 µs) : 430, 471
. : milestone, 450,
iast_TELEMETRY_OFF (491.614 µs) : 470, 513
. : milestone, 492,
tracing (462.334 µs) : 442, 483
. : milestone, 462,
section candidate
no_agent (376.74 µs) : 356, 397
. : milestone, 377,
iast (493.752 µs) : 473, 515
. : milestone, 494,
iast_FULL (659.446 µs) : 638, 681
. : milestone, 659,
iast_GLOBAL (526.29 µs) : 505, 548
. : milestone, 526,
iast_HARDCODED_SECRET_DISABLED (496.058 µs) : 475, 518
. : milestone, 496,
iast_INACTIVE (459.704 µs) : 439, 481
. : milestone, 460,
iast_TELEMETRY_OFF (484.893 µs) : 463, 506
. : milestone, 485,
tracing (457.545 µs) : 437, 479
. : milestone, 458,
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.44.0-SNAPSHOT~81b5001337, baseline=1.44.0-SNAPSHOT~9eaf5a01bb
dateFormat X
axisFormat %s
section baseline
no_agent (1.374 ms) : 1354, 1393
. : milestone, 1374,
appsec (1.766 ms) : 1741, 1791
. : milestone, 1766,
appsec_no_iast (1.754 ms) : 1729, 1780
. : milestone, 1754,
iast (1.502 ms) : 1479, 1525
. : milestone, 1502,
profiling (1.564 ms) : 1539, 1589
. : milestone, 1564,
tracing (1.484 ms) : 1459, 1509
. : milestone, 1484,
section candidate
no_agent (1.371 ms) : 1352, 1390
. : milestone, 1371,
appsec (1.756 ms) : 1731, 1781
. : milestone, 1756,
appsec_no_iast (1.748 ms) : 1723, 1773
. : milestone, 1748,
iast (1.511 ms) : 1488, 1533
. : milestone, 1511,
profiling (1.507 ms) : 1484, 1531
. : milestone, 1507,
tracing (1.513 ms) : 1488, 1539
. : milestone, 1513,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics. Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.44.0-SNAPSHOT~81b5001337, baseline=1.44.0-SNAPSHOT~9eaf5a01bb
dateFormat X
axisFormat %s
section baseline
no_agent (1.462 ms) : 1451, 1474
. : milestone, 1462,
appsec (2.336 ms) : 2295, 2377
. : milestone, 2336,
iast (2.071 ms) : 2018, 2124
. : milestone, 2071,
iast_GLOBAL (2.116 ms) : 2064, 2169
. : milestone, 2116,
profiling (1.951 ms) : 1908, 1994
. : milestone, 1951,
tracing (1.916 ms) : 1876, 1957
. : milestone, 1916,
section candidate
no_agent (1.461 ms) : 1450, 1473
. : milestone, 1461,
appsec (2.331 ms) : 2290, 2373
. : milestone, 2331,
iast (2.08 ms) : 2028, 2132
. : milestone, 2080,
iast_GLOBAL (2.121 ms) : 2068, 2174
. : milestone, 2121,
profiling (1.942 ms) : 1900, 1985
. : milestone, 1942,
tracing (1.922 ms) : 1882, 1962
. : milestone, 1922,
Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.44.0-SNAPSHOT~81b5001337, baseline=1.44.0-SNAPSHOT~9eaf5a01bb
dateFormat X
axisFormat %s
section baseline
no_agent (15.403 s) : 15403000, 15403000
. : milestone, 15403000,
appsec (14.806 s) : 14806000, 14806000
. : milestone, 14806000,
iast (19.013 s) : 19013000, 19013000
. : milestone, 19013000,
iast_GLOBAL (17.865 s) : 17865000, 17865000
. : milestone, 17865000,
profiling (15.352 s) : 15352000, 15352000
. : milestone, 15352000,
tracing (14.865 s) : 14865000, 14865000
. : milestone, 14865000,
section candidate
no_agent (14.919 s) : 14919000, 14919000
. : milestone, 14919000,
appsec (14.764 s) : 14764000, 14764000
. : milestone, 14764000,
iast (18.684 s) : 18684000, 18684000
. : milestone, 18684000,
iast_GLOBAL (17.872 s) : 17872000, 17872000
. : milestone, 17872000,
profiling (15.718 s) : 15718000, 15718000
. : milestone, 15718000,
tracing (15.167 s) : 15167000, 15167000
. : milestone, 15167000,
|
PerfectSlayer
added
the
tag: no release notes
Changes to exclude from release notes
label
Nov 27, 2024
PerfectSlayer
added a commit
that referenced
this pull request
Nov 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What Does This Do
This PR will alter JUnit test reports that are uploaded to CI Visibility to remove Java object hashCode from the test case name, replacing them by
HASHCODE
.Motivation
This will help with CI monitoring to keep track of test execution.
Additional Notes
In addition, the script will now dump the collected result files, their mapping, and warn about hashCode presence.
Output example:
Contributor Checklist
type:
and (comp:
orinst:
) labels in addition to any usefull labelsclose
,fix
or any linking keywords when referencing an issue.Use
solves
instead, and assign the PR milestone to the issueJira ticket: [PROJ-IDENT]