Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Instrument Gradle Launcher to avoid overwriting org.gradle.jvmargs property #8001

Merged
merged 2 commits into from
Nov 25, 2024
Merged

Instrument Gradle Launcher to avoid overwriting org.gradle.jvmargs property #8001

merged 2 commits into from
Nov 25, 2024

Conversation

nikita-tkachenko-datadog
Copy link
Contributor

@nikita-tkachenko-datadog nikita-tkachenko-datadog commented Nov 22, 2024 •
edited by jira bot
Loading

What Does This Do

Fixes a problem with Gradle Daemon auto-instrumentation.

Our auto-instrumentation works by modifying the GRADLE_OPTS environment property.
This property controls JVM options used for starting Gradle Launcher.
Gradle Launcher is a wrapper that is started when gradle or gradlew command is run.
The launcher itself does not execute Gradle builds, however.
The builds are executed by the Gradle Daemon, which is a long-running process that runs in the background and that is started by the launcher.

The properties of the JVM that runs Gradle Daemon can be controlled with org.gradle.jvmargs system property of the launcher.
Which is why existing auto-instrumentation logic sets GRADLE_OPTS=-Dorg.gradle.jvmargs=-javaagent:<TRACER_PATH>.
This works, but the problem with this approach is that org.gradle.jvmargs that is set like this in the command line overwrites org.gradle.jvmargs that may be set elsewhere.
Usually org.gradle.jvmargs is set inside gradle.properties file that lives in the root folder of a Gradle project.
It is often used to set max heap size and other important properties for the Gradle daemon, so auto-instrumentation over-writing it can cause build failure.

The updated tracer instruments the Gradle Launcher, and automatically injects itself into the daemon when the launcher forks it.
This allows setting GRADLE_OPTS=-javaagent:... instead of GRADLE_OPTS=-Dorg.gradle.jvmargs=-javaagent:..., preserving org.gradle.jvmargs value.

Motivation

To avoid overriding the users' Gradle Daemon JVM settings when auto-instrumentation is used.

Contributor Checklist

Jira ticket: SCV-208

@nikita-tkachenko-datadog nikita-tkachenko-datadog added the comp: ci visibility Continuous Integration Visibility label Nov 22, 2024
@nikita-tkachenko-datadog nikita-tkachenko-datadog changed the title Instrument Gradle Launcher to avoid overwriting org.gradle.jvmargs pr… Instrument Gradle Launcher to avoid overwriting org.gradle.jvmargs property Nov 22, 2024
@pr-commenter
Copy link

pr-commenter bot commented Nov 22, 2024 •
edited
Loading

Benchmarks

Startup

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master nikita-tkachenko/gradle-launcher-instrumentation
git_commit_date 1732290365 1732306188
git_commit_sha 79ca6e4 73d15fc
release_version 1.43.0-SNAPSHOT~79ca6e471f 1.43.0-SNAPSHOT~73d15fc31b
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1732308718 1732308718
ci_job_id 717709179 717709179
ci_pipeline_id 49768438 49768438
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
module Agent Agent
parent None None
variant iast iast

Summary

Found 1 performance improvements and 0 performance regressions! Performance is the same for 52 metrics, 10 unstable metrics.

scenario Δ mean execution_time candidate mean execution_time baseline mean execution_time
scenario:startup:petclinic:profiling:GlobalTracer better
[-37.250ms; -32.089ms] or [-8.545%; -7.361%]		 401.266ms 435.936ms
Startup time reports for insecure-bank 
gantt
    title insecure-bank - global startup overhead: candidate=1.43.0-SNAPSHOT~73d15fc31b, baseline=1.43.0-SNAPSHOT~79ca6e471f

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.109 s) : 0, 1109489
Total [baseline] (8.768 s) : 0, 8767976
Agent [candidate] (1.089 s) : 0, 1089364
Total [candidate] (8.666 s) : 0, 8665627
section iast
Agent [baseline] (1.217 s) : 0, 1216961
Total [baseline] (9.205 s) : 0, 9204708
Agent [candidate] (1.218 s) : 0, 1217802
Total [candidate] (9.2 s) : 0, 9200370
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.234 s) : 0, 1234207
Total [baseline] (9.259 s) : 0, 9258858
Agent [candidate] (1.216 s) : 0, 1215974
Total [candidate] (9.164 s) : 0, 9164140
section iast_TELEMETRY_OFF
Agent [baseline] (1.221 s) : 0, 1220776
Total [baseline] (9.265 s) : 0, 9264562
Agent [candidate] (1.213 s) : 0, 1212726
Total [candidate] (9.235 s) : 0, 9235014
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.109 s -
Agent iast 1.217 s 107.472 ms (9.7%)
Agent iast_HARDCODED_SECRET_DISABLED 1.234 s 124.718 ms (11.2%)
Agent iast_TELEMETRY_OFF 1.221 s 111.286 ms (10.0%)
Total tracing 8.768 s -
Total iast 9.205 s 436.732 ms (5.0%)
Total iast_HARDCODED_SECRET_DISABLED 9.259 s 490.882 ms (5.6%)
Total iast_TELEMETRY_OFF 9.265 s 496.586 ms (5.7%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.089 s -
Agent iast 1.218 s 128.438 ms (11.8%)
Agent iast_HARDCODED_SECRET_DISABLED 1.216 s 126.611 ms (11.6%)
Agent iast_TELEMETRY_OFF 1.213 s 123.363 ms (11.3%)
Total tracing 8.666 s -
Total iast 9.2 s 534.743 ms (6.2%)
Total iast_HARDCODED_SECRET_DISABLED 9.164 s 498.513 ms (5.8%)
Total iast_TELEMETRY_OFF 9.235 s 569.387 ms (6.6%) 
gantt
    title insecure-bank - break down per module: candidate=1.43.0-SNAPSHOT~73d15fc31b, baseline=1.43.0-SNAPSHOT~79ca6e471f

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (705.549 ms) : 0, 705549
BytebuddyAgent [candidate] (692.013 ms) : 0, 692013
GlobalTracer [baseline] (321.985 ms) : 0, 321985
GlobalTracer [candidate] (317.039 ms) : 0, 317039
AppSec [baseline] (55.557 ms) : 0, 55557
AppSec [candidate] (54.7 ms) : 0, 54700
Remote Config [baseline] (691.865 µs) : 0, 692
Remote Config [candidate] (686.122 µs) : 0, 686
Telemetry [baseline] (11.618 ms) : 0, 11618
Telemetry [candidate] (11.228 ms) : 0, 11228
section iast
BytebuddyAgent [baseline] (809.107 ms) : 0, 809107
BytebuddyAgent [candidate] (812.431 ms) : 0, 812431
GlobalTracer [baseline] (307.221 ms) : 0, 307221
GlobalTracer [candidate] (305.685 ms) : 0, 305685
AppSec [baseline] (57.245 ms) : 0, 57245
AppSec [candidate] (56.585 ms) : 0, 56585
IAST [baseline] (21.581 ms) : 0, 21581
IAST [candidate] (21.326 ms) : 0, 21326
Remote Config [baseline] (610.449 µs) : 0, 610
Remote Config [candidate] (599.568 µs) : 0, 600
Telemetry [baseline] (7.458 ms) : 0, 7458
Telemetry [candidate] (7.346 ms) : 0, 7346
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (820.265 ms) : 0, 820265
BytebuddyAgent [candidate] (809.215 ms) : 0, 809215
GlobalTracer [baseline] (312.124 ms) : 0, 312124
GlobalTracer [candidate] (306.527 ms) : 0, 306527
AppSec [baseline] (58.284 ms) : 0, 58284
AppSec [candidate] (57.66 ms) : 0, 57660
IAST [baseline] (21.354 ms) : 0, 21354
IAST [candidate] (20.714 ms) : 0, 20714
Remote Config [baseline] (636.03 µs) : 0, 636
Remote Config [candidate] (617.839 µs) : 0, 618
Telemetry [baseline] (7.677 ms) : 0, 7677
Telemetry [candidate] (7.518 ms) : 0, 7518
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (811.149 ms) : 0, 811149
BytebuddyAgent [candidate] (805.689 ms) : 0, 805689
GlobalTracer [baseline] (308.545 ms) : 0, 308545
GlobalTracer [candidate] (306.541 ms) : 0, 306541
AppSec [baseline] (58.384 ms) : 0, 58384
AppSec [candidate] (57.432 ms) : 0, 57432
IAST [baseline] (20.79 ms) : 0, 20790
IAST [candidate] (21.288 ms) : 0, 21288
Remote Config [baseline] (637.114 µs) : 0, 637
Remote Config [candidate] (618.757 µs) : 0, 619
Telemetry [baseline] (7.557 ms) : 0, 7557
Telemetry [candidate] (7.456 ms) : 0, 7456
Loading
Startup time reports for petclinic 
gantt
    title petclinic - global startup overhead: candidate=1.43.0-SNAPSHOT~73d15fc31b, baseline=1.43.0-SNAPSHOT~79ca6e471f

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.092 s) : 0, 1092051
Total [baseline] (10.445 s) : 0, 10444551
Agent [candidate] (1.091 s) : 0, 1090642
Total [candidate] (10.45 s) : 0, 10450300
section appsec
Agent [baseline] (1.222 s) : 0, 1222401
Total [baseline] (10.739 s) : 0, 10738802
Agent [candidate] (1.223 s) : 0, 1222621
Total [candidate] (10.743 s) : 0, 10742788
section iast
Agent [baseline] (1.215 s) : 0, 1214529
Total [baseline] (10.886 s) : 0, 10886395
Agent [candidate] (1.225 s) : 0, 1224630
Total [candidate] (10.956 s) : 0, 10956340
section profiling
Agent [baseline] (1.316 s) : 0, 1315887
Total [baseline] (10.797 s) : 0, 10796597
Agent [candidate] (1.287 s) : 0, 1287478
Total [candidate] (10.854 s) : 0, 10853937
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.092 s -
Agent appsec 1.222 s 130.35 ms (11.9%)
Agent iast 1.215 s 122.478 ms (11.2%)
Agent profiling 1.316 s 223.836 ms (20.5%)
Total tracing 10.445 s -
Total appsec 10.739 s 294.252 ms (2.8%)
Total iast 10.886 s 441.844 ms (4.2%)
Total profiling 10.797 s 352.046 ms (3.4%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.091 s -
Agent appsec 1.223 s 131.98 ms (12.1%)
Agent iast 1.225 s 133.988 ms (12.3%)
Agent profiling 1.287 s 196.836 ms (18.0%)
Total tracing 10.45 s -
Total appsec 10.743 s 292.488 ms (2.8%)
Total iast 10.956 s 506.039 ms (4.8%)
Total profiling 10.854 s 403.637 ms (3.9%) 
gantt
    title petclinic - break down per module: candidate=1.43.0-SNAPSHOT~73d15fc31b, baseline=1.43.0-SNAPSHOT~79ca6e471f

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (691.842 ms) : 0, 691842
BytebuddyAgent [candidate] (693.001 ms) : 0, 693001
GlobalTracer [baseline] (319.039 ms) : 0, 319039
GlobalTracer [candidate] (318.029 ms) : 0, 318029
AppSec [baseline] (54.81 ms) : 0, 54810
AppSec [candidate] (54.613 ms) : 0, 54613
Remote Config [baseline] (696.144 µs) : 0, 696
Remote Config [candidate] (682.455 µs) : 0, 682
Telemetry [baseline] (11.973 ms) : 0, 11973
Telemetry [candidate] (10.57 ms) : 0, 10570
section appsec
BytebuddyAgent [baseline] (708.946 ms) : 0, 708946
BytebuddyAgent [candidate] (709.143 ms) : 0, 709143
GlobalTracer [baseline] (314.517 ms) : 0, 314517
GlobalTracer [candidate] (314.401 ms) : 0, 314401
AppSec [baseline] (166.666 ms) : 0, 166666
AppSec [candidate] (166.63 ms) : 0, 166630
IAST [baseline] (19.496 ms) : 0, 19496
IAST [candidate] (21.23 ms) : 0, 21230
Remote Config [baseline] (638.312 µs) : 0, 638
Remote Config [candidate] (637.914 µs) : 0, 638
Telemetry [baseline] (8.206 ms) : 0, 8206
Telemetry [candidate] (7.504 ms) : 0, 7504
section iast
BytebuddyAgent [baseline] (807.305 ms) : 0, 807305
BytebuddyAgent [candidate] (814.995 ms) : 0, 814995
GlobalTracer [baseline] (306.714 ms) : 0, 306714
GlobalTracer [candidate] (307.91 ms) : 0, 307910
AppSec [baseline] (57.203 ms) : 0, 57203
AppSec [candidate] (56.939 ms) : 0, 56939
IAST [baseline] (21.529 ms) : 0, 21529
IAST [candidate] (22.78 ms) : 0, 22780
Remote Config [baseline] (613.092 µs) : 0, 613
Remote Config [candidate] (622.476 µs) : 0, 622
Telemetry [baseline] (7.46 ms) : 0, 7460
Telemetry [candidate] (7.594 ms) : 0, 7594
section profiling
BytebuddyAgent [baseline] (685.883 ms) : 0, 685883
BytebuddyAgent [candidate] (686.284 ms) : 0, 686284
GlobalTracer [baseline] (435.936 ms) : 0, 435936
GlobalTracer [candidate] (401.266 ms) : 0, 401266
AppSec [baseline] (53.799 ms) : 0, 53799
AppSec [candidate] (55.162 ms) : 0, 55162
Remote Config [baseline] (649.781 µs) : 0, 650
Remote Config [candidate] (1.338 ms) : 0, 1338
Telemetry [baseline] (7.713 ms) : 0, 7713
Telemetry [candidate] (12.038 ms) : 0, 12038
ProfilingAgent [baseline] (92.993 ms) : 0, 92993
ProfilingAgent [candidate] (92.332 ms) : 0, 92332
Profiling [baseline] (93.016 ms) : 0, 93016
Profiling [candidate] (92.356 ms) : 0, 92356
Loading

Load

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
end_time 2024-11-22T20:22:07 2024-11-22T20:29:03
git_branch master nikita-tkachenko/gradle-launcher-instrumentation
git_commit_date 1732290365 1732306188
git_commit_sha 79ca6e4 73d15fc
release_version 1.43.0-SNAPSHOT~79ca6e471f 1.43.0-SNAPSHOT~73d15fc31b
start_time 2024-11-22T20:21:54 2024-11-22T20:28:50
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1732307695 1732307695
ci_job_id 717709180 717709180
ci_pipeline_id 49768438 49768438
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
variant iast iast

Summary

Found 0 performance improvements and 1 performance regressions! Performance is the same for 11 metrics, 16 unstable metrics.

scenario Δ mean http_req_duration Δ mean throughput candidate mean http_req_duration candidate mean throughput baseline mean http_req_duration baseline mean throughput
scenario:load:petclinic:profiling worse
[+45.334µs; +96.844µs] or [+3.020%; +6.452%]		 unstable
[-682.939op/s; +455.019op/s] or [-22.196%; +14.788%]		 1.572ms 2962.963op/s 1.501ms 3076.923op/s
Request duration reports for insecure-bank 
gantt
    title insecure-bank - request duration [CI 0.99] : candidate=1.43.0-SNAPSHOT~73d15fc31b, baseline=1.43.0-SNAPSHOT~79ca6e471f
    dateFormat X
    axisFormat %s
section baseline
no_agent (366.815 µs) : 347, 386
.   : milestone, 367,
iast (481.405 µs) : 460, 503
.   : milestone, 481,
iast_FULL (644.999 µs) : 624, 666
.   : milestone, 645,
iast_GLOBAL (516.815 µs) : 495, 539
.   : milestone, 517,
iast_HARDCODED_SECRET_DISABLED (486.572 µs) : 465, 508
.   : milestone, 487,
iast_INACTIVE (444.994 µs) : 424, 466
.   : milestone, 445,
iast_TELEMETRY_OFF (483.657 µs) : 462, 506
.   : milestone, 484,
tracing (444.75 µs) : 424, 466
.   : milestone, 445,
section candidate
no_agent (374.149 µs) : 355, 394
.   : milestone, 374,
iast (488.852 µs) : 466, 511
.   : milestone, 489,
iast_FULL (640.37 µs) : 619, 662
.   : milestone, 640,
iast_GLOBAL (516.178 µs) : 494, 538
.   : milestone, 516,
iast_HARDCODED_SECRET_DISABLED (489.004 µs) : 467, 511
.   : milestone, 489,
iast_INACTIVE (452.156 µs) : 431, 474
.   : milestone, 452,
iast_TELEMETRY_OFF (473.04 µs) : 452, 494
.   : milestone, 473,
tracing (442.689 µs) : 422, 463
.   : milestone, 443,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 366.815 µs [347.136 µs, 386.494 µs] -
iast 481.405 µs [460.242 µs, 502.568 µs] 114.59 µs (31.2%)
iast_FULL 644.999 µs [623.573 µs, 666.425 µs] 278.184 µs (75.8%)
iast_GLOBAL 516.815 µs [494.949 µs, 538.681 µs] 150.0 µs (40.9%)
iast_HARDCODED_SECRET_DISABLED 486.572 µs [465.442 µs, 507.701 µs] 119.757 µs (32.6%)
iast_INACTIVE 444.994 µs [423.861 µs, 466.128 µs] 78.179 µs (21.3%)
iast_TELEMETRY_OFF 483.657 µs [461.758 µs, 505.555 µs] 116.842 µs (31.9%)
tracing 444.75 µs [423.93 µs, 465.571 µs] 77.936 µs (21.2%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 374.149 µs [354.568 µs, 393.729 µs] -
iast 488.852 µs [466.392 µs, 511.311 µs] 114.703 µs (30.7%)
iast_FULL 640.37 µs [618.833 µs, 661.908 µs] 266.222 µs (71.2%)
iast_GLOBAL 516.178 µs [494.157 µs, 538.2 µs] 142.03 µs (38.0%)
iast_HARDCODED_SECRET_DISABLED 489.004 µs [467.359 µs, 510.65 µs] 114.856 µs (30.7%)
iast_INACTIVE 452.156 µs [430.645 µs, 473.667 µs] 78.007 µs (20.8%)
iast_TELEMETRY_OFF 473.04 µs [451.917 µs, 494.164 µs] 98.892 µs (26.4%)
tracing 442.689 µs [422.243 µs, 463.136 µs] 68.541 µs (18.3%)
Request duration reports for petclinic 
gantt
    title petclinic - request duration [CI 0.99] : candidate=1.43.0-SNAPSHOT~73d15fc31b, baseline=1.43.0-SNAPSHOT~79ca6e471f
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.339 ms) : 1320, 1359
.   : milestone, 1339,
appsec (1.764 ms) : 1740, 1787
.   : milestone, 1764,
appsec_no_iast (1.764 ms) : 1740, 1788
.   : milestone, 1764,
iast (1.48 ms) : 1458, 1503
.   : milestone, 1480,
profiling (1.501 ms) : 1478, 1524
.   : milestone, 1501,
tracing (1.477 ms) : 1452, 1502
.   : milestone, 1477,
section candidate
no_agent (1.349 ms) : 1330, 1369
.   : milestone, 1349,
appsec (1.748 ms) : 1725, 1772
.   : milestone, 1748,
appsec_no_iast (1.737 ms) : 1712, 1762
.   : milestone, 1737,
iast (1.494 ms) : 1472, 1516
.   : milestone, 1494,
profiling (1.572 ms) : 1547, 1597
.   : milestone, 1572,
tracing (1.501 ms) : 1477, 1526
.   : milestone, 1501,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.339 ms [1.32 ms, 1.359 ms] -
appsec 1.764 ms [1.74 ms, 1.787 ms] 424.033 µs (31.7%)
appsec_no_iast 1.764 ms [1.74 ms, 1.788 ms] 424.319 µs (31.7%)
iast 1.48 ms [1.458 ms, 1.503 ms] 140.75 µs (10.5%)
profiling 1.501 ms [1.478 ms, 1.524 ms] 161.551 µs (12.1%)
tracing 1.477 ms [1.452 ms, 1.502 ms] 137.923 µs (10.3%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.349 ms [1.33 ms, 1.369 ms] -
appsec 1.748 ms [1.725 ms, 1.772 ms] 399.154 µs (29.6%)
appsec_no_iast 1.737 ms [1.712 ms, 1.762 ms] 387.624 µs (28.7%)
iast 1.494 ms [1.472 ms, 1.516 ms] 144.984 µs (10.7%)
profiling 1.572 ms [1.547 ms, 1.597 ms] 222.874 µs (16.5%)
tracing 1.501 ms [1.477 ms, 1.526 ms] 152.215 µs (11.3%)

Dacapo

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master nikita-tkachenko/gradle-launcher-instrumentation
git_commit_date 1732290365 1732306188
git_commit_sha 79ca6e4 73d15fc
release_version 1.43.0-SNAPSHOT~79ca6e471f 1.43.0-SNAPSHOT~73d15fc31b
See matching parameters
Baseline Candidate
application biojava biojava
ci_job_date 1732308290 1732308290
ci_job_id 717709181 717709181
ci_pipeline_id 49768438 49768438
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
variant appsec appsec

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics.

Execution time for tomcat 
gantt
    title tomcat - execution time [CI 0.99] : candidate=1.43.0-SNAPSHOT~73d15fc31b, baseline=1.43.0-SNAPSHOT~79ca6e471f
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.466 ms) : 1455, 1477
.   : milestone, 1466,
appsec (2.327 ms) : 2286, 2368
.   : milestone, 2327,
iast (2.079 ms) : 2027, 2131
.   : milestone, 2079,
iast_GLOBAL (2.116 ms) : 2064, 2168
.   : milestone, 2116,
profiling (1.948 ms) : 1907, 1990
.   : milestone, 1948,
tracing (1.925 ms) : 1885, 1965
.   : milestone, 1925,
section candidate
no_agent (1.465 ms) : 1454, 1477
.   : milestone, 1465,
appsec (2.329 ms) : 2288, 2370
.   : milestone, 2329,
iast (2.073 ms) : 2021, 2125
.   : milestone, 2073,
iast_GLOBAL (2.114 ms) : 2061, 2166
.   : milestone, 2114,
profiling (1.931 ms) : 1890, 1972
.   : milestone, 1931,
tracing (1.915 ms) : 1875, 1955
.   : milestone, 1915,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.466 ms [1.455 ms, 1.477 ms] -
appsec 2.327 ms [2.286 ms, 2.368 ms] 861.396 µs (58.8%)
iast 2.079 ms [2.027 ms, 2.131 ms] 612.617 µs (41.8%)
iast_GLOBAL 2.116 ms [2.064 ms, 2.168 ms] 649.983 µs (44.3%)
profiling 1.948 ms [1.907 ms, 1.99 ms] 482.158 µs (32.9%)
tracing 1.925 ms [1.885 ms, 1.965 ms] 458.924 µs (31.3%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.465 ms [1.454 ms, 1.477 ms] -
appsec 2.329 ms [2.288 ms, 2.37 ms] 863.772 µs (59.0%)
iast 2.073 ms [2.021 ms, 2.125 ms] 607.462 µs (41.5%)
iast_GLOBAL 2.114 ms [2.061 ms, 2.166 ms] 648.378 µs (44.3%)
profiling 1.931 ms [1.89 ms, 1.972 ms] 465.887 µs (31.8%)
tracing 1.915 ms [1.875 ms, 1.955 ms] 449.58 µs (30.7%)
Execution time for biojava 
gantt
    title biojava - execution time [CI 0.99] : candidate=1.43.0-SNAPSHOT~73d15fc31b, baseline=1.43.0-SNAPSHOT~79ca6e471f
    dateFormat X
    axisFormat %s
section baseline
no_agent (14.92 s) : 14920000, 14920000
.   : milestone, 14920000,
appsec (14.998 s) : 14998000, 14998000
.   : milestone, 14998000,
iast (18.755 s) : 18755000, 18755000
.   : milestone, 18755000,
iast_GLOBAL (17.963 s) : 17963000, 17963000
.   : milestone, 17963000,
profiling (14.818 s) : 14818000, 14818000
.   : milestone, 14818000,
tracing (14.896 s) : 14896000, 14896000
.   : milestone, 14896000,
section candidate
no_agent (14.891 s) : 14891000, 14891000
.   : milestone, 14891000,
appsec (14.863 s) : 14863000, 14863000
.   : milestone, 14863000,
iast (18.708 s) : 18708000, 18708000
.   : milestone, 18708000,
iast_GLOBAL (17.912 s) : 17912000, 17912000
.   : milestone, 17912000,
profiling (14.934 s) : 14934000, 14934000
.   : milestone, 14934000,
tracing (14.943 s) : 14943000, 14943000
.   : milestone, 14943000,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 14.92 s [14.92 s, 14.92 s] -
appsec 14.998 s [14.998 s, 14.998 s] 78.0 ms (0.5%)
iast 18.755 s [18.755 s, 18.755 s] 3.835 s (25.7%)
iast_GLOBAL 17.963 s [17.963 s, 17.963 s] 3.043 s (20.4%)
profiling 14.818 s [14.818 s, 14.818 s] -102.0 ms (-0.7%)
tracing 14.896 s [14.896 s, 14.896 s] -24.0 ms (-0.2%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 14.891 s [14.891 s, 14.891 s] -
appsec 14.863 s [14.863 s, 14.863 s] -28.0 ms (-0.2%)
iast 18.708 s [18.708 s, 18.708 s] 3.817 s (25.6%)
iast_GLOBAL 17.912 s [17.912 s, 17.912 s] 3.021 s (20.3%)
profiling 14.934 s [14.934 s, 14.934 s] 43.0 ms (0.3%)
tracing 14.943 s [14.943 s, 14.943 s] 52.0 ms (0.3%)

@nikita-tkachenko-datadog nikita-tkachenko-datadog marked this pull request as ready for review November 25, 2024 09:40
@nikita-tkachenko-datadog nikita-tkachenko-datadog requested a review from a team as a code owner November 25, 2024 09:40
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 25, 2024 •
edited
Loading

Hi! 👋 Thanks for your pull request! 🎉

To help us review it, please make sure to:

  • Add at least one type, and one component or instrumentation label to the pull request

If you need help, please check our contributing guidelines.

@nikita-tkachenko-datadog nikita-tkachenko-datadog merged commit b055376 into master Nov 25, 2024
104 of 106 checks passed
@nikita-tkachenko-datadog nikita-tkachenko-datadog deleted the nikita-tkachenko/gradle-launcher-instrumentation branch November 25, 2024 10:11
@github-actions github-actions bot added this to the 1.43.0 milestone Nov 25, 2024
This was referenced Nov 25, 2024
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juan-fernandez juan-fernandez juan-fernandez approved these changes

@anmarchenko anmarchenko Awaiting requested review from anmarchenko anmarchenko is a code owner automatically assigned from DataDog/ci-app-libraries-java

Assignees
No one assigned
Labels
comp: ci visibility Continuous Integration Visibility type: bug
Projects
None yet
Milestone
1.43.0
Development

Successfully merging this pull request may close these issues.
2 participants
@nikita-tkachenko-datadog @juan-fernandez