Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade to libddwaf 1.21.0 (libddwaf-java 11.2.0) #7993

Merged
merged 1 commit into from
Nov 21, 2024
Merged

Upgrade to libddwaf 1.21.0 (libddwaf-java 11.2.0) #7993

merged 1 commit into from
Nov 21, 2024

Conversation

ValentinZakharov
Copy link
Contributor

@ValentinZakharov ValentinZakharov commented Nov 21, 2024 •
edited by jira bot
Loading

What Does This Do

Upgrade to libddwaf 1.21.0 (libddwaf-java 11.2.0)

Motivation

Additional Notes

Contributor Checklist

Jira ticket: APPSEC-55867

@ValentinZakharov ValentinZakharov self-assigned this Nov 21, 2024
@pr-commenter
Copy link

pr-commenter bot commented Nov 21, 2024

Benchmarks

Startup

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master vzakharov/update-libddwaf-1.21.0
git_commit_date 1732196287 1732200101
git_commit_sha cd1b746 4e32fec
release_version 1.43.0-SNAPSHOT~cd1b746d93 1.43.0-SNAPSHOT~4e32fecffc
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1732202434 1732202434
ci_job_id 715457701 715457701
ci_pipeline_id 49610801 49610801
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
module Agent Agent
parent None None
variant iast iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 50 metrics, 13 unstable metrics.

Startup time reports for petclinic 
gantt
    title petclinic - global startup overhead: candidate=1.43.0-SNAPSHOT~4e32fecffc, baseline=1.43.0-SNAPSHOT~cd1b746d93

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.107 s) : 0, 1106962
Total [baseline] (10.571 s) : 0, 10571142
Agent [candidate] (1.092 s) : 0, 1091644
Total [candidate] (10.484 s) : 0, 10483924
section appsec
Agent [baseline] (1.227 s) : 0, 1227052
Total [baseline] (10.716 s) : 0, 10716499
Agent [candidate] (1.223 s) : 0, 1223058
Total [candidate] (10.722 s) : 0, 10722069
section iast
Agent [baseline] (1.216 s) : 0, 1216219
Total [baseline] (10.872 s) : 0, 10871986
Agent [candidate] (1.214 s) : 0, 1214260
Total [candidate] (10.959 s) : 0, 10958917
section profiling
Agent [baseline] (1.289 s) : 0, 1288729
Total [baseline] (10.77 s) : 0, 10770154
Agent [candidate] (1.288 s) : 0, 1288210
Total [candidate] (10.808 s) : 0, 10808198
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.107 s -
Agent appsec 1.227 s 120.09 ms (10.8%)
Agent iast 1.216 s 109.257 ms (9.9%)
Agent profiling 1.289 s 181.767 ms (16.4%)
Total tracing 10.571 s -
Total appsec 10.716 s 145.358 ms (1.4%)
Total iast 10.872 s 300.844 ms (2.8%)
Total profiling 10.77 s 199.012 ms (1.9%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.092 s -
Agent appsec 1.223 s 131.415 ms (12.0%)
Agent iast 1.214 s 122.616 ms (11.2%)
Agent profiling 1.288 s 196.567 ms (18.0%)
Total tracing 10.484 s -
Total appsec 10.722 s 238.145 ms (2.3%)
Total iast 10.959 s 474.993 ms (4.5%)
Total profiling 10.808 s 324.273 ms (3.1%) 
gantt
    title petclinic - break down per module: candidate=1.43.0-SNAPSHOT~4e32fecffc, baseline=1.43.0-SNAPSHOT~cd1b746d93

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (702.882 ms) : 0, 702882
BytebuddyAgent [candidate] (695.397 ms) : 0, 695397
GlobalTracer [baseline] (321.93 ms) : 0, 321930
GlobalTracer [candidate] (317.844 ms) : 0, 317844
AppSec [baseline] (55.249 ms) : 0, 55249
AppSec [candidate] (54.614 ms) : 0, 54614
Remote Config [baseline] (694.854 µs) : 0, 695
Remote Config [candidate] (687.852 µs) : 0, 688
Telemetry [baseline] (12.274 ms) : 0, 12274
Telemetry [candidate] (9.282 ms) : 0, 9282
section appsec
BytebuddyAgent [baseline] (711.299 ms) : 0, 711299
BytebuddyAgent [candidate] (708.782 ms) : 0, 708782
GlobalTracer [baseline] (315.553 ms) : 0, 315553
GlobalTracer [candidate] (315.207 ms) : 0, 315207
AppSec [baseline] (166.299 ms) : 0, 166299
AppSec [candidate] (166.284 ms) : 0, 166284
Remote Config [baseline] (645.194 µs) : 0, 645
Remote Config [candidate] (648.814 µs) : 0, 649
Telemetry [baseline] (9.685 ms) : 0, 9685
Telemetry [candidate] (8.193 ms) : 0, 8193
IAST [baseline] (19.666 ms) : 0, 19666
IAST [candidate] (20.465 ms) : 0, 20465
section iast
BytebuddyAgent [baseline] (808.334 ms) : 0, 808334
BytebuddyAgent [candidate] (807.714 ms) : 0, 807714
GlobalTracer [baseline] (306.85 ms) : 0, 306850
GlobalTracer [candidate] (306.331 ms) : 0, 306331
AppSec [baseline] (56.847 ms) : 0, 56847
AppSec [candidate] (57.83 ms) : 0, 57830
Remote Config [baseline] (691.313 µs) : 0, 691
Remote Config [candidate] (610.755 µs) : 0, 611
Telemetry [baseline] (7.472 ms) : 0, 7472
Telemetry [candidate] (7.42 ms) : 0, 7420
IAST [baseline] (22.343 ms) : 0, 22343
IAST [candidate] (20.652 ms) : 0, 20652
section profiling
ProfilingAgent [baseline] (91.741 ms) : 0, 91741
ProfilingAgent [candidate] (92.81 ms) : 0, 92810
BytebuddyAgent [baseline] (686.789 ms) : 0, 686789
BytebuddyAgent [candidate] (687.113 ms) : 0, 687113
GlobalTracer [baseline] (401.7 ms) : 0, 401700
GlobalTracer [candidate] (401.109 ms) : 0, 401109
AppSec [baseline] (55.287 ms) : 0, 55287
AppSec [candidate] (55.196 ms) : 0, 55196
Remote Config [baseline] (674.593 µs) : 0, 675
Remote Config [candidate] (668.198 µs) : 0, 668
Telemetry [baseline] (13.489 ms) : 0, 13489
Telemetry [candidate] (12.167 ms) : 0, 12167
Profiling [baseline] (91.764 ms) : 0, 91764
Profiling [candidate] (92.834 ms) : 0, 92834
Loading
Startup time reports for insecure-bank 
gantt
    title insecure-bank - global startup overhead: candidate=1.43.0-SNAPSHOT~4e32fecffc, baseline=1.43.0-SNAPSHOT~cd1b746d93

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.095 s) : 0, 1095320
Total [baseline] (8.635 s) : 0, 8634707
Agent [candidate] (1.09 s) : 0, 1090135
Total [candidate] (8.641 s) : 0, 8640707
section iast
Agent [baseline] (1.214 s) : 0, 1214455
Total [baseline] (9.16 s) : 0, 9160232
Agent [candidate] (1.219 s) : 0, 1219242
Total [candidate] (9.206 s) : 0, 9206260
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.219 s) : 0, 1219387
Total [baseline] (9.162 s) : 0, 9162419
Agent [candidate] (1.22 s) : 0, 1219564
Total [candidate] (9.159 s) : 0, 9159263
section iast_TELEMETRY_OFF
Agent [baseline] (1.211 s) : 0, 1211194
Total [baseline] (9.176 s) : 0, 9176435
Agent [candidate] (1.213 s) : 0, 1212702
Total [candidate] (9.21 s) : 0, 9209873
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.095 s -
Agent iast 1.214 s 119.135 ms (10.9%)
Agent iast_HARDCODED_SECRET_DISABLED 1.219 s 124.067 ms (11.3%)
Agent iast_TELEMETRY_OFF 1.211 s 115.874 ms (10.6%)
Total tracing 8.635 s -
Total iast 9.16 s 525.525 ms (6.1%)
Total iast_HARDCODED_SECRET_DISABLED 9.162 s 527.712 ms (6.1%)
Total iast_TELEMETRY_OFF 9.176 s 541.728 ms (6.3%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.09 s -
Agent iast 1.219 s 129.107 ms (11.8%)
Agent iast_HARDCODED_SECRET_DISABLED 1.22 s 129.43 ms (11.9%)
Agent iast_TELEMETRY_OFF 1.213 s 122.567 ms (11.2%)
Total tracing 8.641 s -
Total iast 9.206 s 565.552 ms (6.5%)
Total iast_HARDCODED_SECRET_DISABLED 9.159 s 518.555 ms (6.0%)
Total iast_TELEMETRY_OFF 9.21 s 569.166 ms (6.6%) 
gantt
    title insecure-bank - break down per module: candidate=1.43.0-SNAPSHOT~4e32fecffc, baseline=1.43.0-SNAPSHOT~cd1b746d93

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (696.5 ms) : 0, 696500
BytebuddyAgent [candidate] (691.655 ms) : 0, 691655
GlobalTracer [baseline] (318.167 ms) : 0, 318167
GlobalTracer [candidate] (317.54 ms) : 0, 317540
AppSec [baseline] (54.708 ms) : 0, 54708
AppSec [candidate] (54.924 ms) : 0, 54924
Remote Config [baseline] (688.178 µs) : 0, 688
Remote Config [candidate] (697.532 µs) : 0, 698
Telemetry [baseline] (11.407 ms) : 0, 11407
Telemetry [candidate] (11.505 ms) : 0, 11505
section iast
BytebuddyAgent [baseline] (808.001 ms) : 0, 808001
BytebuddyAgent [candidate] (810.719 ms) : 0, 810719
GlobalTracer [baseline] (306.059 ms) : 0, 306059
GlobalTracer [candidate] (307.628 ms) : 0, 307628
AppSec [baseline] (57.834 ms) : 0, 57834
AppSec [candidate] (56.58 ms) : 0, 56580
IAST [baseline] (20.745 ms) : 0, 20745
IAST [candidate] (22.473 ms) : 0, 22473
Remote Config [baseline] (628.524 µs) : 0, 629
Remote Config [candidate] (622.122 µs) : 0, 622
Telemetry [baseline] (7.466 ms) : 0, 7466
Telemetry [candidate] (7.458 ms) : 0, 7458
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (811.258 ms) : 0, 811258
BytebuddyAgent [candidate] (811.532 ms) : 0, 811532
GlobalTracer [baseline] (307.338 ms) : 0, 307338
GlobalTracer [candidate] (307.315 ms) : 0, 307315
AppSec [baseline] (57.92 ms) : 0, 57920
AppSec [candidate] (57.233 ms) : 0, 57233
IAST [baseline] (20.882 ms) : 0, 20882
IAST [candidate] (21.561 ms) : 0, 21561
Remote Config [baseline] (637.218 µs) : 0, 637
Remote Config [candidate] (623.58 µs) : 0, 624
Telemetry [baseline] (7.547 ms) : 0, 7547
Telemetry [candidate] (7.452 ms) : 0, 7452
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (804.173 ms) : 0, 804173
BytebuddyAgent [candidate] (805.849 ms) : 0, 805849
GlobalTracer [baseline] (306.388 ms) : 0, 306388
GlobalTracer [candidate] (306.447 ms) : 0, 306447
AppSec [baseline] (58.564 ms) : 0, 58564
AppSec [candidate] (57.207 ms) : 0, 57207
IAST [baseline] (20.313 ms) : 0, 20313
IAST [candidate] (20.52 ms) : 0, 20520
Remote Config [baseline] (592.362 µs) : 0, 592
Remote Config [candidate] (633.075 µs) : 0, 633
Telemetry [baseline] (7.427 ms) : 0, 7427
Telemetry [candidate] (8.308 ms) : 0, 8308
Loading

Load

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
end_time 2024-11-21T14:50:47 2024-11-21T14:57:44
git_branch master vzakharov/update-libddwaf-1.21.0
git_commit_date 1732196287 1732200101
git_commit_sha cd1b746 4e32fec
release_version 1.43.0-SNAPSHOT~cd1b746d93 1.43.0-SNAPSHOT~4e32fecffc
start_time 2024-11-21T14:50:34 2024-11-21T14:57:31
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1732201415 1732201415
ci_job_id 715457702 715457702
ci_pipeline_id 49610801 49610801
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
variant iast iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 13 metrics, 15 unstable metrics.

Request duration reports for petclinic 
gantt
    title petclinic - request duration [CI 0.99] : candidate=1.43.0-SNAPSHOT~4e32fecffc, baseline=1.43.0-SNAPSHOT~cd1b746d93
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.35 ms) : 1331, 1368
.   : milestone, 1350,
appsec (1.744 ms) : 1720, 1768
.   : milestone, 1744,
appsec_no_iast (1.735 ms) : 1710, 1760
.   : milestone, 1735,
iast (1.491 ms) : 1468, 1514
.   : milestone, 1491,
profiling (1.496 ms) : 1472, 1519
.   : milestone, 1496,
tracing (1.5 ms) : 1476, 1524
.   : milestone, 1500,
section candidate
no_agent (1.362 ms) : 1343, 1382
.   : milestone, 1362,
appsec (1.742 ms) : 1718, 1767
.   : milestone, 1742,
appsec_no_iast (1.739 ms) : 1713, 1764
.   : milestone, 1739,
iast (1.495 ms) : 1472, 1518
.   : milestone, 1495,
profiling (1.5 ms) : 1478, 1523
.   : milestone, 1500,
tracing (1.481 ms) : 1456, 1507
.   : milestone, 1481,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.35 ms [1.331 ms, 1.368 ms] -
appsec 1.744 ms [1.72 ms, 1.768 ms] 394.614 µs (29.2%)
appsec_no_iast 1.735 ms [1.71 ms, 1.76 ms] 385.624 µs (28.6%)
iast 1.491 ms [1.468 ms, 1.514 ms] 141.173 µs (10.5%)
profiling 1.496 ms [1.472 ms, 1.519 ms] 146.187 µs (10.8%)
tracing 1.5 ms [1.476 ms, 1.524 ms] 149.974 µs (11.1%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.362 ms [1.343 ms, 1.382 ms] -
appsec 1.742 ms [1.718 ms, 1.767 ms] 380.042 µs (27.9%)
appsec_no_iast 1.739 ms [1.713 ms, 1.764 ms] 376.108 µs (27.6%)
iast 1.495 ms [1.472 ms, 1.518 ms] 132.283 µs (9.7%)
profiling 1.5 ms [1.478 ms, 1.523 ms] 138.023 µs (10.1%)
tracing 1.481 ms [1.456 ms, 1.507 ms] 118.752 µs (8.7%)
Request duration reports for insecure-bank 
gantt
    title insecure-bank - request duration [CI 0.99] : candidate=1.43.0-SNAPSHOT~4e32fecffc, baseline=1.43.0-SNAPSHOT~cd1b746d93
    dateFormat X
    axisFormat %s
section baseline
no_agent (377.921 µs) : 357, 398
.   : milestone, 378,
iast (493.193 µs) : 472, 515
.   : milestone, 493,
iast_FULL (649.889 µs) : 628, 671
.   : milestone, 650,
iast_GLOBAL (515.232 µs) : 494, 537
.   : milestone, 515,
iast_HARDCODED_SECRET_DISABLED (491.368 µs) : 470, 513
.   : milestone, 491,
iast_INACTIVE (455.294 µs) : 434, 476
.   : milestone, 455,
iast_TELEMETRY_OFF (474.261 µs) : 453, 496
.   : milestone, 474,
tracing (446.59 µs) : 426, 467
.   : milestone, 447,
section candidate
no_agent (376.862 µs) : 356, 397
.   : milestone, 377,
iast (488.218 µs) : 466, 510
.   : milestone, 488,
iast_FULL (657.622 µs) : 634, 681
.   : milestone, 658,
iast_GLOBAL (511.013 µs) : 490, 532
.   : milestone, 511,
iast_HARDCODED_SECRET_DISABLED (493.958 µs) : 472, 516
.   : milestone, 494,
iast_INACTIVE (448.074 µs) : 427, 469
.   : milestone, 448,
iast_TELEMETRY_OFF (480.31 µs) : 459, 502
.   : milestone, 480,
tracing (446.889 µs) : 426, 468
.   : milestone, 447,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 377.921 µs [357.442 µs, 398.401 µs] -
iast 493.193 µs [471.827 µs, 514.56 µs] 115.272 µs (30.5%)
iast_FULL 649.889 µs [628.447 µs, 671.331 µs] 271.968 µs (72.0%)
iast_GLOBAL 515.232 µs [493.882 µs, 536.581 µs] 137.31 µs (36.3%)
iast_HARDCODED_SECRET_DISABLED 491.368 µs [469.752 µs, 512.984 µs] 113.447 µs (30.0%)
iast_INACTIVE 455.294 µs [434.179 µs, 476.409 µs] 77.373 µs (20.5%)
iast_TELEMETRY_OFF 474.261 µs [452.993 µs, 495.529 µs] 96.34 µs (25.5%)
tracing 446.59 µs [426.034 µs, 467.146 µs] 68.669 µs (18.2%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 376.862 µs [356.364 µs, 397.36 µs] -
iast 488.218 µs [466.491 µs, 509.945 µs] 111.356 µs (29.5%)
iast_FULL 657.622 µs [634.463 µs, 680.781 µs] 280.76 µs (74.5%)
iast_GLOBAL 511.013 µs [489.754 µs, 532.272 µs] 134.151 µs (35.6%)
iast_HARDCODED_SECRET_DISABLED 493.958 µs [472.375 µs, 515.541 µs] 117.096 µs (31.1%)
iast_INACTIVE 448.074 µs [427.436 µs, 468.713 µs] 71.212 µs (18.9%)
iast_TELEMETRY_OFF 480.31 µs [458.963 µs, 501.658 µs] 103.449 µs (27.5%)
tracing 446.889 µs [426.191 µs, 467.588 µs] 70.027 µs (18.6%)

Dacapo

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master vzakharov/update-libddwaf-1.21.0
git_commit_date 1732196287 1732200101
git_commit_sha cd1b746 4e32fec
release_version 1.43.0-SNAPSHOT~cd1b746d93 1.43.0-SNAPSHOT~4e32fecffc
See matching parameters
Baseline Candidate
application biojava biojava
ci_job_date 1732202119 1732202119
ci_job_id 715457703 715457703
ci_pipeline_id 49610801 49610801
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
variant appsec appsec

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics.

Execution time for tomcat 
gantt
    title tomcat - execution time [CI 0.99] : candidate=1.43.0-SNAPSHOT~4e32fecffc, baseline=1.43.0-SNAPSHOT~cd1b746d93
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.467 ms) : 1456, 1479
.   : milestone, 1467,
appsec (2.339 ms) : 2298, 2380
.   : milestone, 2339,
iast (2.068 ms) : 2016, 2120
.   : milestone, 2068,
iast_GLOBAL (2.122 ms) : 2069, 2175
.   : milestone, 2122,
profiling (1.952 ms) : 1910, 1995
.   : milestone, 1952,
tracing (1.922 ms) : 1882, 1962
.   : milestone, 1922,
section candidate
no_agent (1.465 ms) : 1454, 1477
.   : milestone, 1465,
appsec (2.315 ms) : 2274, 2355
.   : milestone, 2315,
iast (2.075 ms) : 2022, 2127
.   : milestone, 2075,
iast_GLOBAL (2.12 ms) : 2067, 2173
.   : milestone, 2120,
profiling (1.939 ms) : 1898, 1980
.   : milestone, 1939,
tracing (1.913 ms) : 1873, 1953
.   : milestone, 1913,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.467 ms [1.456 ms, 1.479 ms] -
appsec 2.339 ms [2.298 ms, 2.38 ms] 871.682 µs (59.4%)
iast 2.068 ms [2.016 ms, 2.12 ms] 600.855 µs (40.9%)
iast_GLOBAL 2.122 ms [2.069 ms, 2.175 ms] 654.525 µs (44.6%)
profiling 1.952 ms [1.91 ms, 1.995 ms] 484.733 µs (33.0%)
tracing 1.922 ms [1.882 ms, 1.962 ms] 454.543 µs (31.0%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.465 ms [1.454 ms, 1.477 ms] -
appsec 2.315 ms [2.274 ms, 2.355 ms] 849.708 µs (58.0%)
iast 2.075 ms [2.022 ms, 2.127 ms] 609.443 µs (41.6%)
iast_GLOBAL 2.12 ms [2.067 ms, 2.173 ms] 654.895 µs (44.7%)
profiling 1.939 ms [1.898 ms, 1.98 ms] 473.953 µs (32.3%)
tracing 1.913 ms [1.873 ms, 1.953 ms] 447.885 µs (30.6%)
Execution time for biojava 
gantt
    title biojava - execution time [CI 0.99] : candidate=1.43.0-SNAPSHOT~4e32fecffc, baseline=1.43.0-SNAPSHOT~cd1b746d93
    dateFormat X
    axisFormat %s
section baseline
no_agent (15.436 s) : 15436000, 15436000
.   : milestone, 15436000,
appsec (15.115 s) : 15115000, 15115000
.   : milestone, 15115000,
iast (18.863 s) : 18863000, 18863000
.   : milestone, 18863000,
iast_GLOBAL (18.218 s) : 18218000, 18218000
.   : milestone, 18218000,
profiling (14.701 s) : 14701000, 14701000
.   : milestone, 14701000,
tracing (15.081 s) : 15081000, 15081000
.   : milestone, 15081000,
section candidate
no_agent (15.639 s) : 15639000, 15639000
.   : milestone, 15639000,
appsec (15.147 s) : 15147000, 15147000
.   : milestone, 15147000,
iast (18.716 s) : 18716000, 18716000
.   : milestone, 18716000,
iast_GLOBAL (17.642 s) : 17642000, 17642000
.   : milestone, 17642000,
profiling (15.333 s) : 15333000, 15333000
.   : milestone, 15333000,
tracing (15.003 s) : 15003000, 15003000
.   : milestone, 15003000,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 15.436 s [15.436 s, 15.436 s] -
appsec 15.115 s [15.115 s, 15.115 s] -321.0 ms (-2.1%)
iast 18.863 s [18.863 s, 18.863 s] 3.427 s (22.2%)
iast_GLOBAL 18.218 s [18.218 s, 18.218 s] 2.782 s (18.0%)
profiling 14.701 s [14.701 s, 14.701 s] -735.0 ms (-4.8%)
tracing 15.081 s [15.081 s, 15.081 s] -355.0 ms (-2.3%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 15.639 s [15.639 s, 15.639 s] -
appsec 15.147 s [15.147 s, 15.147 s] -492.0 ms (-3.1%)
iast 18.716 s [18.716 s, 18.716 s] 3.077 s (19.7%)
iast_GLOBAL 17.642 s [17.642 s, 17.642 s] 2.003 s (12.8%)
profiling 15.333 s [15.333 s, 15.333 s] -306.0 ms (-2.0%)
tracing 15.003 s [15.003 s, 15.003 s] -636.0 ms (-4.1%)

@ValentinZakharov ValentinZakharov marked this pull request as ready for review November 21, 2024 15:32
@ValentinZakharov ValentinZakharov requested a review from a team as a code owner November 21, 2024 15:32
@ValentinZakharov ValentinZakharov merged commit 603ef41 into master Nov 21, 2024
105 checks passed
@ValentinZakharov ValentinZakharov deleted the vzakharov/update-libddwaf-1.21.0 branch November 21, 2024 15:33
@ValentinZakharov ValentinZakharov added the comp: asm waf Application Security Management (WAF) label Nov 21, 2024
@github-actions github-actions bot added this to the 1.43.0 milestone Nov 21, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 21, 2024 •
edited
Loading

Hi! 👋 Thanks for your pull request! 🎉

To help us review it, please make sure to:

  • Add at least one type, and one component or instrumentation label to the pull request

If you need help, please check our contributing guidelines.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@manuel-alvarez-alvarez manuel-alvarez-alvarez manuel-alvarez-alvarez approved these changes

@Mariovido Mariovido Awaiting requested review from Mariovido Mariovido is a code owner automatically assigned from DataDog/asm-java

Assignees

@ValentinZakharov ValentinZakharov

Labels
comp: asm waf Application Security Management (WAF)
Projects
None yet
Milestone
1.43.0
Development

Successfully merging this pull request may close these issues.
2 participants
@ValentinZakharov @manuel-alvarez-alvarez