-
Notifications
You must be signed in to change notification settings - Fork 292
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add propagation to StringBuffer substring methods #7992
Add propagation to StringBuffer substring methods #7992
Conversation
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 53 metrics, 10 unstable metrics. Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.43.0-SNAPSHOT~e1bcfc9ea7, baseline=1.43.0-SNAPSHOT~58de7ff6c6
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.089 s) : 0, 1089188
Total [baseline] (10.408 s) : 0, 10407619
Agent [candidate] (1.097 s) : 0, 1096643
Total [candidate] (10.497 s) : 0, 10496796
section appsec
Agent [baseline] (1.226 s) : 0, 1226127
Total [baseline] (10.77 s) : 0, 10769666
Agent [candidate] (1.226 s) : 0, 1225532
Total [candidate] (10.757 s) : 0, 10757256
section iast
Agent [baseline] (1.216 s) : 0, 1216442
Total [baseline] (10.937 s) : 0, 10937072
Agent [candidate] (1.227 s) : 0, 1227385
Total [candidate] (10.918 s) : 0, 10917635
section profiling
Agent [baseline] (1.288 s) : 0, 1287868
Total [baseline] (10.826 s) : 0, 10825633
Agent [candidate] (1.295 s) : 0, 1295130
Total [candidate] (10.828 s) : 0, 10828067
gantt
title petclinic - break down per module: candidate=1.43.0-SNAPSHOT~e1bcfc9ea7, baseline=1.43.0-SNAPSHOT~58de7ff6c6
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (691.644 ms) : 0, 691644
BytebuddyAgent [candidate] (695.7 ms) : 0, 695700
GlobalTracer [baseline] (317.095 ms) : 0, 317095
GlobalTracer [candidate] (319.288 ms) : 0, 319288
AppSec [baseline] (54.673 ms) : 0, 54673
AppSec [candidate] (54.842 ms) : 0, 54842
Remote Config [baseline] (685.019 µs) : 0, 685
Remote Config [candidate] (705.305 µs) : 0, 705
Telemetry [baseline] (11.395 ms) : 0, 11395
Telemetry [candidate] (12.282 ms) : 0, 12282
section appsec
BytebuddyAgent [baseline] (711.224 ms) : 0, 711224
BytebuddyAgent [candidate] (709.368 ms) : 0, 709368
GlobalTracer [baseline] (315.825 ms) : 0, 315825
GlobalTracer [candidate] (315.489 ms) : 0, 315489
AppSec [baseline] (166.831 ms) : 0, 166831
AppSec [candidate] (168.491 ms) : 0, 168491
Remote Config [baseline] (646.476 µs) : 0, 646
Remote Config [candidate] (650.967 µs) : 0, 651
Telemetry [baseline] (7.909 ms) : 0, 7909
Telemetry [candidate] (7.902 ms) : 0, 7902
IAST [baseline] (19.84 ms) : 0, 19840
IAST [candidate] (19.791 ms) : 0, 19791
section iast
BytebuddyAgent [baseline] (809.116 ms) : 0, 809116
BytebuddyAgent [candidate] (816.505 ms) : 0, 816505
GlobalTracer [baseline] (306.986 ms) : 0, 306986
GlobalTracer [candidate] (308.988 ms) : 0, 308988
AppSec [baseline] (57.078 ms) : 0, 57078
AppSec [candidate] (57.375 ms) : 0, 57375
Remote Config [baseline] (617.848 µs) : 0, 618
Remote Config [candidate] (598.493 µs) : 0, 598
Telemetry [baseline] (7.434 ms) : 0, 7434
Telemetry [candidate] (7.463 ms) : 0, 7463
IAST [baseline] (21.5 ms) : 0, 21500
IAST [candidate] (22.598 ms) : 0, 22598
section profiling
ProfilingAgent [baseline] (93.609 ms) : 0, 93609
ProfilingAgent [candidate] (94.67 ms) : 0, 94670
BytebuddyAgent [baseline] (686.303 ms) : 0, 686303
BytebuddyAgent [candidate] (690.331 ms) : 0, 690331
GlobalTracer [baseline] (401.625 ms) : 0, 401625
GlobalTracer [candidate] (403.163 ms) : 0, 403163
AppSec [baseline] (55.28 ms) : 0, 55280
AppSec [candidate] (55.454 ms) : 0, 55454
Remote Config [baseline] (681.613 µs) : 0, 682
Remote Config [candidate] (677.359 µs) : 0, 677
Telemetry [baseline] (11.312 ms) : 0, 11312
Telemetry [candidate] (11.449 ms) : 0, 11449
Profiling [baseline] (93.634 ms) : 0, 93634
Profiling [candidate] (94.694 ms) : 0, 94694
Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.43.0-SNAPSHOT~e1bcfc9ea7, baseline=1.43.0-SNAPSHOT~58de7ff6c6
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.085 s) : 0, 1085431
Total [baseline] (8.646 s) : 0, 8645627
Agent [candidate] (1.099 s) : 0, 1098925
Total [candidate] (8.701 s) : 0, 8700783
section iast
Agent [baseline] (1.225 s) : 0, 1225318
Total [baseline] (9.202 s) : 0, 9202117
Agent [candidate] (1.217 s) : 0, 1217007
Total [candidate] (9.181 s) : 0, 9181372
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.219 s) : 0, 1219464
Total [baseline] (9.206 s) : 0, 9206220
Agent [candidate] (1.221 s) : 0, 1220845
Total [candidate] (9.192 s) : 0, 9192044
section iast_TELEMETRY_OFF
Agent [baseline] (1.216 s) : 0, 1215824
Total [baseline] (9.186 s) : 0, 9185778
Agent [candidate] (1.221 s) : 0, 1220827
Total [candidate] (9.19 s) : 0, 9189950
gantt
title insecure-bank - break down per module: candidate=1.43.0-SNAPSHOT~e1bcfc9ea7, baseline=1.43.0-SNAPSHOT~58de7ff6c6
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (690.941 ms) : 0, 690941
BytebuddyAgent [candidate] (697.972 ms) : 0, 697972
GlobalTracer [baseline] (317.046 ms) : 0, 317046
GlobalTracer [candidate] (319.94 ms) : 0, 319940
AppSec [baseline] (54.509 ms) : 0, 54509
AppSec [candidate] (55.018 ms) : 0, 55018
Remote Config [baseline] (683.26 µs) : 0, 683
Remote Config [candidate] (704.247 µs) : 0, 704
Telemetry [baseline] (8.554 ms) : 0, 8554
Telemetry [candidate] (11.424 ms) : 0, 11424
section iast
BytebuddyAgent [baseline] (814.932 ms) : 0, 814932
BytebuddyAgent [candidate] (809.491 ms) : 0, 809491
GlobalTracer [baseline] (309.126 ms) : 0, 309126
GlobalTracer [candidate] (307.005 ms) : 0, 307005
AppSec [baseline] (57.509 ms) : 0, 57509
AppSec [candidate] (58.231 ms) : 0, 58231
IAST [baseline] (21.763 ms) : 0, 21763
IAST [candidate] (20.503 ms) : 0, 20503
Remote Config [baseline] (642.686 µs) : 0, 643
Remote Config [candidate] (609.49 µs) : 0, 609
Telemetry [baseline] (7.487 ms) : 0, 7487
Telemetry [candidate] (7.445 ms) : 0, 7445
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (809.335 ms) : 0, 809335
BytebuddyAgent [candidate] (810.349 ms) : 0, 810349
GlobalTracer [baseline] (308.926 ms) : 0, 308926
GlobalTracer [candidate] (309.175 ms) : 0, 309175
AppSec [baseline] (56.656 ms) : 0, 56656
AppSec [candidate] (57.384 ms) : 0, 57384
IAST [baseline] (22.62 ms) : 0, 22620
IAST [candidate] (21.914 ms) : 0, 21914
Remote Config [baseline] (635.714 µs) : 0, 636
Remote Config [candidate] (637.878 µs) : 0, 638
Telemetry [baseline] (7.533 ms) : 0, 7533
Telemetry [candidate] (7.628 ms) : 0, 7628
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (807.609 ms) : 0, 807609
BytebuddyAgent [candidate] (810.955 ms) : 0, 810955
GlobalTracer [baseline] (307.51 ms) : 0, 307510
GlobalTracer [candidate] (308.54 ms) : 0, 308540
AppSec [baseline] (58.313 ms) : 0, 58313
AppSec [candidate] (58.822 ms) : 0, 58822
IAST [baseline] (20.675 ms) : 0, 20675
IAST [candidate] (20.602 ms) : 0, 20602
Remote Config [baseline] (622.616 µs) : 0, 623
Remote Config [candidate] (643.403 µs) : 0, 643
Telemetry [baseline] (7.416 ms) : 0, 7416
Telemetry [candidate] (7.48 ms) : 0, 7480
LoadParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 17 unstable metrics. Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.43.0-SNAPSHOT~e1bcfc9ea7, baseline=1.43.0-SNAPSHOT~58de7ff6c6
dateFormat X
axisFormat %s
section baseline
no_agent (378.793 µs) : 359, 399
. : milestone, 379,
iast (482.994 µs) : 462, 504
. : milestone, 483,
iast_FULL (642.512 µs) : 621, 664
. : milestone, 643,
iast_GLOBAL (520.617 µs) : 498, 543
. : milestone, 521,
iast_HARDCODED_SECRET_DISABLED (483.443 µs) : 462, 505
. : milestone, 483,
iast_INACTIVE (446.032 µs) : 425, 467
. : milestone, 446,
iast_TELEMETRY_OFF (474.893 µs) : 454, 496
. : milestone, 475,
tracing (441.315 µs) : 421, 462
. : milestone, 441,
section candidate
no_agent (368.418 µs) : 348, 388
. : milestone, 368,
iast (484.354 µs) : 463, 506
. : milestone, 484,
iast_FULL (646.671 µs) : 625, 668
. : milestone, 647,
iast_GLOBAL (509.555 µs) : 488, 531
. : milestone, 510,
iast_HARDCODED_SECRET_DISABLED (485.234 µs) : 464, 507
. : milestone, 485,
iast_INACTIVE (445.815 µs) : 425, 467
. : milestone, 446,
iast_TELEMETRY_OFF (480.263 µs) : 458, 502
. : milestone, 480,
tracing (442.842 µs) : 422, 463
. : milestone, 443,
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.43.0-SNAPSHOT~e1bcfc9ea7, baseline=1.43.0-SNAPSHOT~58de7ff6c6
dateFormat X
axisFormat %s
section baseline
no_agent (1.331 ms) : 1312, 1350
. : milestone, 1331,
appsec (1.748 ms) : 1724, 1772
. : milestone, 1748,
appsec_no_iast (1.744 ms) : 1720, 1768
. : milestone, 1744,
iast (1.482 ms) : 1460, 1504
. : milestone, 1482,
profiling (1.521 ms) : 1497, 1545
. : milestone, 1521,
tracing (1.48 ms) : 1454, 1505
. : milestone, 1480,
section candidate
no_agent (1.356 ms) : 1337, 1375
. : milestone, 1356,
appsec (1.731 ms) : 1705, 1756
. : milestone, 1731,
appsec_no_iast (1.731 ms) : 1705, 1756
. : milestone, 1731,
iast (1.488 ms) : 1465, 1511
. : milestone, 1488,
profiling (1.484 ms) : 1460, 1507
. : milestone, 1484,
tracing (1.498 ms) : 1474, 1522
. : milestone, 1498,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics. Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.43.0-SNAPSHOT~e1bcfc9ea7, baseline=1.43.0-SNAPSHOT~58de7ff6c6
dateFormat X
axisFormat %s
section baseline
no_agent (1.472 ms) : 1461, 1484
. : milestone, 1472,
appsec (2.352 ms) : 2311, 2393
. : milestone, 2352,
iast (2.093 ms) : 2041, 2145
. : milestone, 2093,
iast_GLOBAL (2.136 ms) : 2084, 2189
. : milestone, 2136,
profiling (1.968 ms) : 1925, 2011
. : milestone, 1968,
tracing (1.931 ms) : 1890, 1971
. : milestone, 1931,
section candidate
no_agent (1.472 ms) : 1461, 1484
. : milestone, 1472,
appsec (2.347 ms) : 2306, 2388
. : milestone, 2347,
iast (2.094 ms) : 2042, 2146
. : milestone, 2094,
iast_GLOBAL (2.138 ms) : 2085, 2191
. : milestone, 2138,
profiling (1.978 ms) : 1935, 2020
. : milestone, 1978,
tracing (1.925 ms) : 1885, 1965
. : milestone, 1925,
Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.43.0-SNAPSHOT~e1bcfc9ea7, baseline=1.43.0-SNAPSHOT~58de7ff6c6
dateFormat X
axisFormat %s
section baseline
no_agent (15.188 s) : 15188000, 15188000
. : milestone, 15188000,
appsec (14.97 s) : 14970000, 14970000
. : milestone, 14970000,
iast (18.533 s) : 18533000, 18533000
. : milestone, 18533000,
iast_GLOBAL (18.221 s) : 18221000, 18221000
. : milestone, 18221000,
profiling (14.748 s) : 14748000, 14748000
. : milestone, 14748000,
tracing (14.669 s) : 14669000, 14669000
. : milestone, 14669000,
section candidate
no_agent (14.926 s) : 14926000, 14926000
. : milestone, 14926000,
appsec (15.033 s) : 15033000, 15033000
. : milestone, 15033000,
iast (18.93 s) : 18930000, 18930000
. : milestone, 18930000,
iast_GLOBAL (17.83 s) : 17830000, 17830000
. : milestone, 17830000,
profiling (15.124 s) : 15124000, 15124000
. : milestone, 15124000,
tracing (14.904 s) : 14904000, 14904000
. : milestone, 14904000,
|
dd-java-agent/agent-iast/src/test/groovy/com/datadog/iast/propagation/StringModuleTest.groovy
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See above
What Does This Do
This adds the instrumentation to propagate the taint values through the following methods of
StringBuffer
:substring(int)
substring(int, int)
Motivation
Increase propagation of
StringBuffer
methods.Additional Notes
Contributor Checklist
type:
and (comp:
orinst:
) labels in addition to any usefull labelsclose
,fix
or any linking keywords when referencing an issue.Use
solves
instead, and assign the PR milestone to the issueJira ticket: APPSEC-55369