Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix baggages mapping configuration when only keys are provided #7972

Merged
merged 4 commits into from
Nov 20, 2024
Merged

Fix baggages mapping configuration when only keys are provided #7972

merged 4 commits into from
Nov 20, 2024

Conversation

cecile75
Copy link
Collaborator

@cecile75 cecile75 commented Nov 18, 2024 •
edited
Loading

What Does This Do

Fix baggages mapping when only keys are provided.
Before that, setting a baggage mapping with key only was not taken into tracer configuration: for example, setting
dd.trace.header.baggage=thisisabaggage leads to baggageMapping={}.

Workaround without this fix: use dd.trace.header.baggage=thisisabaggage:thisisabaggage instead of dd.trace.header.baggage=thisisabaggage

Motivation

Run into this while working on APMS-13920.
Fix how this is supposed to work according to our specification/documentation.

Additional Notes

Contributor Checklist

@pr-commenter
Copy link

pr-commenter bot commented Nov 18, 2024 •
edited
Loading

Benchmarks

Startup

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master cecile/baggages
git_commit_date 1731943603 1732009780
git_commit_sha 6181783 ad038d2
release_version 1.43.0-SNAPSHOT~6181783bd1 1.43.0-SNAPSHOT~ad038d2876
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1732012097 1732012097
ci_job_id 711770408 711770408
ci_pipeline_id 49348563 49348563
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
module Agent Agent
parent None None
variant iast iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 52 metrics, 11 unstable metrics.

Startup time reports for insecure-bank 
gantt
    title insecure-bank - global startup overhead: candidate=1.43.0-SNAPSHOT~ad038d2876, baseline=1.43.0-SNAPSHOT~6181783bd1

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.091 s) : 0, 1091021
Total [baseline] (8.596 s) : 0, 8596238
Agent [candidate] (1.084 s) : 0, 1084306
Total [candidate] (8.58 s) : 0, 8580106
section iast
Agent [baseline] (1.214 s) : 0, 1214345
Total [baseline] (9.143 s) : 0, 9143178
Agent [candidate] (1.209 s) : 0, 1208941
Total [candidate] (9.181 s) : 0, 9181191
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.207 s) : 0, 1206690
Total [baseline] (9.116 s) : 0, 9116310
Agent [candidate] (1.21 s) : 0, 1209617
Total [candidate] (9.098 s) : 0, 9098350
section iast_TELEMETRY_OFF
Agent [baseline] (1.212 s) : 0, 1212164
Total [baseline] (9.135 s) : 0, 9135462
Agent [candidate] (1.215 s) : 0, 1214723
Total [candidate] (9.147 s) : 0, 9146665
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.091 s -
Agent iast 1.214 s 123.324 ms (11.3%)
Agent iast_HARDCODED_SECRET_DISABLED 1.207 s 115.669 ms (10.6%)
Agent iast_TELEMETRY_OFF 1.212 s 121.143 ms (11.1%)
Total tracing 8.596 s -
Total iast 9.143 s 546.94 ms (6.4%)
Total iast_HARDCODED_SECRET_DISABLED 9.116 s 520.072 ms (6.0%)
Total iast_TELEMETRY_OFF 9.135 s 539.224 ms (6.3%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.084 s -
Agent iast 1.209 s 124.634 ms (11.5%)
Agent iast_HARDCODED_SECRET_DISABLED 1.21 s 125.31 ms (11.6%)
Agent iast_TELEMETRY_OFF 1.215 s 130.416 ms (12.0%)
Total tracing 8.58 s -
Total iast 9.181 s 601.084 ms (7.0%)
Total iast_HARDCODED_SECRET_DISABLED 9.098 s 518.243 ms (6.0%)
Total iast_TELEMETRY_OFF 9.147 s 566.558 ms (6.6%) 
gantt
    title insecure-bank - break down per module: candidate=1.43.0-SNAPSHOT~ad038d2876, baseline=1.43.0-SNAPSHOT~6181783bd1

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (693.278 ms) : 0, 693278
BytebuddyAgent [candidate] (690.763 ms) : 0, 690763
GlobalTracer [baseline] (317.499 ms) : 0, 317499
GlobalTracer [candidate] (314.752 ms) : 0, 314752
AppSec [baseline] (54.854 ms) : 0, 54854
AppSec [candidate] (54.326 ms) : 0, 54326
Remote Config [baseline] (713.983 µs) : 0, 714
Remote Config [candidate] (678.452 µs) : 0, 678
Telemetry [baseline] (10.773 ms) : 0, 10773
Telemetry [candidate] (9.957 ms) : 0, 9957
section iast
BytebuddyAgent [baseline] (809.225 ms) : 0, 809225
BytebuddyAgent [candidate] (803.502 ms) : 0, 803502
GlobalTracer [baseline] (304.886 ms) : 0, 304886
GlobalTracer [candidate] (304.687 ms) : 0, 304687
AppSec [baseline] (56.851 ms) : 0, 56851
AppSec [candidate] (57.312 ms) : 0, 57312
IAST [baseline] (21.476 ms) : 0, 21476
IAST [candidate] (21.483 ms) : 0, 21483
Remote Config [baseline] (618.015 µs) : 0, 618
Remote Config [candidate] (601.314 µs) : 0, 601
Telemetry [baseline] (7.436 ms) : 0, 7436
Telemetry [candidate] (7.521 ms) : 0, 7521
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (802.208 ms) : 0, 802208
BytebuddyAgent [candidate] (804.779 ms) : 0, 804779
GlobalTracer [baseline] (304.22 ms) : 0, 304220
GlobalTracer [candidate] (304.548 ms) : 0, 304548
AppSec [baseline] (56.101 ms) : 0, 56101
AppSec [candidate] (57.04 ms) : 0, 57040
IAST [baseline] (22.361 ms) : 0, 22361
IAST [candidate] (21.382 ms) : 0, 21382
Remote Config [baseline] (622.31 µs) : 0, 622
Remote Config [candidate] (622.44 µs) : 0, 622
Telemetry [baseline] (7.443 ms) : 0, 7443
Telemetry [candidate] (7.441 ms) : 0, 7441
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (805.853 ms) : 0, 805853
BytebuddyAgent [candidate] (807.197 ms) : 0, 807197
GlobalTracer [baseline] (305.88 ms) : 0, 305880
GlobalTracer [candidate] (306.737 ms) : 0, 306737
AppSec [baseline] (58.129 ms) : 0, 58129
AppSec [candidate] (57.364 ms) : 0, 57364
IAST [baseline] (20.388 ms) : 0, 20388
IAST [candidate] (21.475 ms) : 0, 21475
Remote Config [baseline] (628.774 µs) : 0, 629
Remote Config [candidate] (627.095 µs) : 0, 627
Telemetry [baseline] (7.425 ms) : 0, 7425
Telemetry [candidate] (7.439 ms) : 0, 7439
Loading
Startup time reports for petclinic 
gantt
    title petclinic - global startup overhead: candidate=1.43.0-SNAPSHOT~ad038d2876, baseline=1.43.0-SNAPSHOT~6181783bd1

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.086 s) : 0, 1086494
Total [baseline] (10.411 s) : 0, 10411186
Agent [candidate] (1.084 s) : 0, 1084399
Total [candidate] (10.426 s) : 0, 10425873
section appsec
Agent [baseline] (1.216 s) : 0, 1216196
Total [baseline] (10.679 s) : 0, 10679098
Agent [candidate] (1.216 s) : 0, 1215704
Total [candidate] (10.659 s) : 0, 10658674
section iast
Agent [baseline] (1.209 s) : 0, 1209382
Total [baseline] (10.854 s) : 0, 10853630
Agent [candidate] (1.211 s) : 0, 1210634
Total [candidate] (10.851 s) : 0, 10850990
section profiling
Agent [baseline] (1.283 s) : 0, 1282935
Total [baseline] (10.858 s) : 0, 10857648
Agent [candidate] (1.285 s) : 0, 1285100
Total [candidate] (10.832 s) : 0, 10831772
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.086 s -
Agent appsec 1.216 s 129.702 ms (11.9%)
Agent iast 1.209 s 122.888 ms (11.3%)
Agent profiling 1.283 s 196.441 ms (18.1%)
Total tracing 10.411 s -
Total appsec 10.679 s 267.912 ms (2.6%)
Total iast 10.854 s 442.444 ms (4.2%)
Total profiling 10.858 s 446.462 ms (4.3%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.084 s -
Agent appsec 1.216 s 131.304 ms (12.1%)
Agent iast 1.211 s 126.235 ms (11.6%)
Agent profiling 1.285 s 200.7 ms (18.5%)
Total tracing 10.426 s -
Total appsec 10.659 s 232.801 ms (2.2%)
Total iast 10.851 s 425.118 ms (4.1%)
Total profiling 10.832 s 405.899 ms (3.9%) 
gantt
    title petclinic - break down per module: candidate=1.43.0-SNAPSHOT~ad038d2876, baseline=1.43.0-SNAPSHOT~6181783bd1

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (691.712 ms) : 0, 691712
BytebuddyAgent [candidate] (687.63 ms) : 0, 687630
GlobalTracer [baseline] (316.826 ms) : 0, 316826
GlobalTracer [candidate] (315.715 ms) : 0, 315715
AppSec [baseline] (54.765 ms) : 0, 54765
AppSec [candidate] (54.454 ms) : 0, 54454
Remote Config [baseline] (699.931 µs) : 0, 700
Remote Config [candidate] (714.932 µs) : 0, 715
Telemetry [baseline] (8.631 ms) : 0, 8631
Telemetry [candidate] (12.077 ms) : 0, 12077
section appsec
BytebuddyAgent [baseline] (704.617 ms) : 0, 704617
BytebuddyAgent [candidate] (704.213 ms) : 0, 704213
GlobalTracer [baseline] (312.843 ms) : 0, 312843
GlobalTracer [candidate] (312.945 ms) : 0, 312945
AppSec [baseline] (165.309 ms) : 0, 165309
AppSec [candidate] (166.212 ms) : 0, 166212
IAST [baseline] (21.667 ms) : 0, 21667
IAST [candidate] (20.315 ms) : 0, 20315
Remote Config [baseline] (643.732 µs) : 0, 644
Remote Config [candidate] (640.864 µs) : 0, 641
Telemetry [baseline] (8.182 ms) : 0, 8182
Telemetry [candidate] (7.801 ms) : 0, 7801
section iast
BytebuddyAgent [baseline] (804.099 ms) : 0, 804099
BytebuddyAgent [candidate] (805.167 ms) : 0, 805167
GlobalTracer [baseline] (305.069 ms) : 0, 305069
GlobalTracer [candidate] (305.158 ms) : 0, 305158
AppSec [baseline] (57.669 ms) : 0, 57669
AppSec [candidate] (56.759 ms) : 0, 56759
IAST [baseline] (20.658 ms) : 0, 20658
IAST [candidate] (21.607 ms) : 0, 21607
Remote Config [baseline] (616.483 µs) : 0, 616
Remote Config [candidate] (628.089 µs) : 0, 628
Telemetry [baseline] (7.481 ms) : 0, 7481
Telemetry [candidate] (7.518 ms) : 0, 7518
section profiling
BytebuddyAgent [baseline] (682.926 ms) : 0, 682926
BytebuddyAgent [candidate] (682.939 ms) : 0, 682939
GlobalTracer [baseline] (399.383 ms) : 0, 399383
GlobalTracer [candidate] (401.639 ms) : 0, 401639
AppSec [baseline] (54.967 ms) : 0, 54967
AppSec [candidate] (55.144 ms) : 0, 55144
Remote Config [baseline] (674.922 µs) : 0, 675
Remote Config [candidate] (678.664 µs) : 0, 679
Telemetry [baseline] (12.97 ms) : 0, 12970
Telemetry [candidate] (10.754 ms) : 0, 10754
ProfilingAgent [baseline] (92.866 ms) : 0, 92866
ProfilingAgent [candidate] (94.889 ms) : 0, 94889
Profiling [baseline] (92.89 ms) : 0, 92890
Profiling [candidate] (94.912 ms) : 0, 94912
Loading

Load

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
end_time 2024-11-19T09:58:35 2024-11-19T10:05:33
git_branch master cecile/baggages
git_commit_date 1731943603 1732009780
git_commit_sha 6181783 ad038d2
release_version 1.43.0-SNAPSHOT~6181783bd1 1.43.0-SNAPSHOT~ad038d2876
start_time 2024-11-19T09:58:22 2024-11-19T10:05:19
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1732011085 1732011085
ci_job_id 711770412 711770412
ci_pipeline_id 49348563 49348563
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
variant iast iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 17 unstable metrics.

Request duration reports for insecure-bank 
gantt
    title insecure-bank - request duration [CI 0.99] : candidate=1.43.0-SNAPSHOT~ad038d2876, baseline=1.43.0-SNAPSHOT~6181783bd1
    dateFormat X
    axisFormat %s
section baseline
no_agent (380.73 µs) : 361, 401
.   : milestone, 381,
iast (486.991 µs) : 466, 508
.   : milestone, 487,
iast_FULL (649.378 µs) : 628, 671
.   : milestone, 649,
iast_GLOBAL (523.855 µs) : 502, 545
.   : milestone, 524,
iast_HARDCODED_SECRET_DISABLED (495.039 µs) : 473, 517
.   : milestone, 495,
iast_INACTIVE (449.889 µs) : 429, 471
.   : milestone, 450,
iast_TELEMETRY_OFF (492.234 µs) : 470, 514
.   : milestone, 492,
tracing (451.228 µs) : 429, 473
.   : milestone, 451,
section candidate
no_agent (378.15 µs) : 358, 398
.   : milestone, 378,
iast (494.647 µs) : 473, 516
.   : milestone, 495,
iast_FULL (646.947 µs) : 626, 668
.   : milestone, 647,
iast_GLOBAL (513.512 µs) : 492, 536
.   : milestone, 514,
iast_HARDCODED_SECRET_DISABLED (487.585 µs) : 467, 509
.   : milestone, 488,
iast_INACTIVE (449.782 µs) : 429, 471
.   : milestone, 450,
iast_TELEMETRY_OFF (480.411 µs) : 459, 502
.   : milestone, 480,
tracing (452.247 µs) : 431, 473
.   : milestone, 452,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 380.73 µs [360.63 µs, 400.83 µs] -
iast 486.991 µs [465.549 µs, 508.434 µs] 106.262 µs (27.9%)
iast_FULL 649.378 µs [628.124 µs, 670.632 µs] 268.648 µs (70.6%)
iast_GLOBAL 523.855 µs [502.269 µs, 545.442 µs] 143.126 µs (37.6%)
iast_HARDCODED_SECRET_DISABLED 495.039 µs [473.146 µs, 516.931 µs] 114.309 µs (30.0%)
iast_INACTIVE 449.889 µs [429.134 µs, 470.643 µs] 69.159 µs (18.2%)
iast_TELEMETRY_OFF 492.234 µs [470.268 µs, 514.201 µs] 111.505 µs (29.3%)
tracing 451.228 µs [429.347 µs, 473.11 µs] 70.498 µs (18.5%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 378.15 µs [358.287 µs, 398.013 µs] -
iast 494.647 µs [473.261 µs, 516.033 µs] 116.497 µs (30.8%)
iast_FULL 646.947 µs [625.608 µs, 668.286 µs] 268.797 µs (71.1%)
iast_GLOBAL 513.512 µs [491.519 µs, 535.505 µs] 135.362 µs (35.8%)
iast_HARDCODED_SECRET_DISABLED 487.585 µs [466.618 µs, 508.551 µs] 109.435 µs (28.9%)
iast_INACTIVE 449.782 µs [428.631 µs, 470.933 µs] 71.632 µs (18.9%)
iast_TELEMETRY_OFF 480.411 µs [458.85 µs, 501.972 µs] 102.261 µs (27.0%)
tracing 452.247 µs [431.178 µs, 473.316 µs] 74.097 µs (19.6%)
Request duration reports for petclinic 
gantt
    title petclinic - request duration [CI 0.99] : candidate=1.43.0-SNAPSHOT~ad038d2876, baseline=1.43.0-SNAPSHOT~6181783bd1
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.368 ms) : 1347, 1388
.   : milestone, 1368,
appsec (1.736 ms) : 1711, 1760
.   : milestone, 1736,
appsec_no_iast (1.731 ms) : 1706, 1756
.   : milestone, 1731,
iast (1.499 ms) : 1476, 1521
.   : milestone, 1499,
profiling (1.507 ms) : 1483, 1531
.   : milestone, 1507,
tracing (1.478 ms) : 1454, 1503
.   : milestone, 1478,
section candidate
no_agent (1.367 ms) : 1347, 1386
.   : milestone, 1367,
appsec (1.747 ms) : 1722, 1772
.   : milestone, 1747,
appsec_no_iast (1.747 ms) : 1723, 1772
.   : milestone, 1747,
iast (1.493 ms) : 1471, 1515
.   : milestone, 1493,
profiling (1.524 ms) : 1500, 1548
.   : milestone, 1524,
tracing (1.479 ms) : 1454, 1505
.   : milestone, 1479,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.368 ms [1.347 ms, 1.388 ms] -
appsec 1.736 ms [1.711 ms, 1.76 ms] 368.199 µs (26.9%)
appsec_no_iast 1.731 ms [1.706 ms, 1.756 ms] 363.164 µs (26.6%)
iast 1.499 ms [1.476 ms, 1.521 ms] 130.891 µs (9.6%)
profiling 1.507 ms [1.483 ms, 1.531 ms] 139.338 µs (10.2%)
tracing 1.478 ms [1.454 ms, 1.503 ms] 110.513 µs (8.1%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.367 ms [1.347 ms, 1.386 ms] -
appsec 1.747 ms [1.722 ms, 1.772 ms] 380.297 µs (27.8%)
appsec_no_iast 1.747 ms [1.723 ms, 1.772 ms] 380.884 µs (27.9%)
iast 1.493 ms [1.471 ms, 1.515 ms] 126.062 µs (9.2%)
profiling 1.524 ms [1.5 ms, 1.548 ms] 157.758 µs (11.5%)
tracing 1.479 ms [1.454 ms, 1.505 ms] 112.712 µs (8.2%)

Dacapo

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master cecile/baggages
git_commit_date 1731943603 1732009780
git_commit_sha 6181783 ad038d2
release_version 1.43.0-SNAPSHOT~6181783bd1 1.43.0-SNAPSHOT~ad038d2876
See matching parameters
Baseline Candidate
application biojava biojava
ci_job_date 1732011608 1732011608
ci_job_id 711770415 711770415
ci_pipeline_id 49348563 49348563
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
variant appsec appsec

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics.

Execution time for biojava 
gantt
    title biojava - execution time [CI 0.99] : candidate=1.43.0-SNAPSHOT~ad038d2876, baseline=1.43.0-SNAPSHOT~6181783bd1
    dateFormat X
    axisFormat %s
section baseline
no_agent (15.104 s) : 15104000, 15104000
.   : milestone, 15104000,
appsec (15.452 s) : 15452000, 15452000
.   : milestone, 15452000,
iast (18.425 s) : 18425000, 18425000
.   : milestone, 18425000,
iast_GLOBAL (18.492 s) : 18492000, 18492000
.   : milestone, 18492000,
profiling (14.872 s) : 14872000, 14872000
.   : milestone, 14872000,
tracing (15.205 s) : 15205000, 15205000
.   : milestone, 15205000,
section candidate
no_agent (15.529 s) : 15529000, 15529000
.   : milestone, 15529000,
appsec (15.061 s) : 15061000, 15061000
.   : milestone, 15061000,
iast (19.066 s) : 19066000, 19066000
.   : milestone, 19066000,
iast_GLOBAL (18.283 s) : 18283000, 18283000
.   : milestone, 18283000,
profiling (15.622 s) : 15622000, 15622000
.   : milestone, 15622000,
tracing (14.939 s) : 14939000, 14939000
.   : milestone, 14939000,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 15.104 s [15.104 s, 15.104 s] -
appsec 15.452 s [15.452 s, 15.452 s] 348.0 ms (2.3%)
iast 18.425 s [18.425 s, 18.425 s] 3.321 s (22.0%)
iast_GLOBAL 18.492 s [18.492 s, 18.492 s] 3.388 s (22.4%)
profiling 14.872 s [14.872 s, 14.872 s] -232.0 ms (-1.5%)
tracing 15.205 s [15.205 s, 15.205 s] 101.0 ms (0.7%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 15.529 s [15.529 s, 15.529 s] -
appsec 15.061 s [15.061 s, 15.061 s] -468.0 ms (-3.0%)
iast 19.066 s [19.066 s, 19.066 s] 3.537 s (22.8%)
iast_GLOBAL 18.283 s [18.283 s, 18.283 s] 2.754 s (17.7%)
profiling 15.622 s [15.622 s, 15.622 s] 93.0 ms (0.6%)
tracing 14.939 s [14.939 s, 14.939 s] -590.0 ms (-3.8%)
Execution time for tomcat 
gantt
    title tomcat - execution time [CI 0.99] : candidate=1.43.0-SNAPSHOT~ad038d2876, baseline=1.43.0-SNAPSHOT~6181783bd1
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.458 ms) : 1447, 1470
.   : milestone, 1458,
appsec (2.33 ms) : 2288, 2371
.   : milestone, 2330,
iast (2.068 ms) : 2015, 2120
.   : milestone, 2068,
iast_GLOBAL (2.114 ms) : 2061, 2167
.   : milestone, 2114,
profiling (1.924 ms) : 1883, 1965
.   : milestone, 1924,
tracing (1.914 ms) : 1873, 1954
.   : milestone, 1914,
section candidate
no_agent (1.466 ms) : 1455, 1478
.   : milestone, 1466,
appsec (2.317 ms) : 2276, 2358
.   : milestone, 2317,
iast (2.073 ms) : 2021, 2125
.   : milestone, 2073,
iast_GLOBAL (2.11 ms) : 2057, 2162
.   : milestone, 2110,
profiling (1.931 ms) : 1889, 1974
.   : milestone, 1931,
tracing (1.919 ms) : 1879, 1960
.   : milestone, 1919,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.458 ms [1.447 ms, 1.47 ms] -
appsec 2.33 ms [2.288 ms, 2.371 ms] 871.369 µs (59.7%)
iast 2.068 ms [2.015 ms, 2.12 ms] 609.027 µs (41.8%)
iast_GLOBAL 2.114 ms [2.061 ms, 2.167 ms] 655.211 µs (44.9%)
profiling 1.924 ms [1.883 ms, 1.965 ms] 465.345 µs (31.9%)
tracing 1.914 ms [1.873 ms, 1.954 ms] 455.216 µs (31.2%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.466 ms [1.455 ms, 1.478 ms] -
appsec 2.317 ms [2.276 ms, 2.358 ms] 850.47 µs (58.0%)
iast 2.073 ms [2.021 ms, 2.125 ms] 606.817 µs (41.4%)
iast_GLOBAL 2.11 ms [2.057 ms, 2.162 ms] 643.674 µs (43.9%)
profiling 1.931 ms [1.889 ms, 1.974 ms] 465.051 µs (31.7%)
tracing 1.919 ms [1.879 ms, 1.96 ms] 452.978 µs (30.9%)

@cecile75 cecile75 changed the title WIP - Fix baggages mapping when keys only Fix baggages mapping when only keys are provided Nov 19, 2024
@cecile75 cecile75 marked this pull request as ready for review November 19, 2024 10:45
@cecile75 cecile75 requested a review from a team as a code owner November 19, 2024 10:45
@cecile75 cecile75 requested a review from dougqh November 19, 2024 10:45
@cecile75 cecile75 changed the title Fix baggages mapping when only keys are provided Fix baggages mapping configuration when only keys are provided Nov 19, 2024
@PerfectSlayer PerfectSlayer added comp: context propagation Trace context propagation and removed comp: core Tracer core labels Nov 20, 2024
PerfectSlayer
PerfectSlayer approved these changes Nov 20, 2024
View reviewed changes
Copy link
Contributor

@PerfectSlayer PerfectSlayer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@cecile75 cecile75 merged commit e5aa8fa into master Nov 20, 2024
108 checks passed
@cecile75 cecile75 deleted the cecile/baggages branch November 20, 2024 10:10
@github-actions github-actions bot added this to the 1.43.0 milestone Nov 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PerfectSlayer PerfectSlayer PerfectSlayer approved these changes

@dougqh dougqh Awaiting requested review from dougqh dougqh is a code owner automatically assigned from DataDog/apm-java

Assignees
No one assigned
Labels
comp: context propagation Trace context propagation type: bug
Projects
None yet
Milestone
1.43.0
Development

Successfully merging this pull request may close these issues.
2 participants
@cecile75 @PerfectSlayer