Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add source line tags to test suites #7964

Merged
merged 12 commits into from
Nov 18, 2024
Merged

Add source line tags to test suites #7964

merged 12 commits into from
Nov 18, 2024

Conversation

daniel-mohedano
Copy link
Contributor

@daniel-mohedano daniel-mohedano commented Nov 15, 2024 •
edited
Loading

What Does This Do

  • Adds test.source.start and test.source.end tags to test suites
  • Bumps default java compiler plugin version to 0.2.2

Motivation

To show test suite source code in the Datadog platform the tracer needs to provide the source line tags.

Additional Notes

Contributor Checklist

Jira ticket: SDTEST-276

@daniel-mohedano daniel-mohedano added the comp: ci visibility Continuous Integration Visibility label Nov 15, 2024
@pr-commenter
Copy link

pr-commenter bot commented Nov 15, 2024 •
edited
Loading

Benchmarks

Startup

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master daniel.mohedano/SDTEST-276-class-source-file-info
git_commit_date 1731663875 1731685896
git_commit_sha 92eab56 286c855
release_version 1.43.0-SNAPSHOT~92eab56ab4 1.43.0-SNAPSHOT~286c855587
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1731688358 1731688358
ci_job_id 708855547 708855547
ci_pipeline_id 49145983 49145983
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
module Agent Agent
parent None None
variant iast iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 52 metrics, 11 unstable metrics.

Startup time reports for petclinic 
gantt
    title petclinic - global startup overhead: candidate=1.43.0-SNAPSHOT~286c855587, baseline=1.43.0-SNAPSHOT~92eab56ab4

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.083 s) : 0, 1082549
Total [baseline] (10.427 s) : 0, 10426943
Agent [candidate] (1.083 s) : 0, 1082504
Total [candidate] (10.376 s) : 0, 10375503
section appsec
Agent [baseline] (1.225 s) : 0, 1225086
Total [baseline] (10.682 s) : 0, 10682358
Agent [candidate] (1.217 s) : 0, 1217381
Total [candidate] (10.699 s) : 0, 10698902
section iast
Agent [baseline] (1.217 s) : 0, 1216653
Total [baseline] (11.005 s) : 0, 11004652
Agent [candidate] (1.211 s) : 0, 1210816
Total [candidate] (10.94 s) : 0, 10939849
section profiling
Agent [baseline] (1.28 s) : 0, 1279753
Total [baseline] (10.798 s) : 0, 10797825
Agent [candidate] (1.296 s) : 0, 1296075
Total [candidate] (10.753 s) : 0, 10752600
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.083 s -
Agent appsec 1.225 s 142.537 ms (13.2%)
Agent iast 1.217 s 134.104 ms (12.4%)
Agent profiling 1.28 s 197.204 ms (18.2%)
Total tracing 10.427 s -
Total appsec 10.682 s 255.415 ms (2.4%)
Total iast 11.005 s 577.709 ms (5.5%)
Total profiling 10.798 s 370.882 ms (3.6%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.083 s -
Agent appsec 1.217 s 134.877 ms (12.5%)
Agent iast 1.211 s 128.312 ms (11.9%)
Agent profiling 1.296 s 213.571 ms (19.7%)
Total tracing 10.376 s -
Total appsec 10.699 s 323.399 ms (3.1%)
Total iast 10.94 s 564.345 ms (5.4%)
Total profiling 10.753 s 377.097 ms (3.6%) 
gantt
    title petclinic - break down per module: candidate=1.43.0-SNAPSHOT~286c855587, baseline=1.43.0-SNAPSHOT~92eab56ab4

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (687.935 ms) : 0, 687935
BytebuddyAgent [candidate] (687.461 ms) : 0, 687461
GlobalTracer [baseline] (315.694 ms) : 0, 315694
GlobalTracer [candidate] (315.592 ms) : 0, 315592
AppSec [baseline] (54.526 ms) : 0, 54526
AppSec [candidate] (54.435 ms) : 0, 54435
Remote Config [baseline] (681.636 µs) : 0, 682
Remote Config [candidate] (684.107 µs) : 0, 684
Telemetry [baseline] (9.982 ms) : 0, 9982
Telemetry [candidate] (10.588 ms) : 0, 10588
section appsec
BytebuddyAgent [baseline] (710.924 ms) : 0, 710924
BytebuddyAgent [candidate] (704.819 ms) : 0, 704819
GlobalTracer [baseline] (315.278 ms) : 0, 315278
GlobalTracer [candidate] (313.443 ms) : 0, 313443
AppSec [baseline] (166.537 ms) : 0, 166537
AppSec [candidate] (166.774 ms) : 0, 166774
Remote Config [baseline] (632.621 µs) : 0, 633
Remote Config [candidate] (643.738 µs) : 0, 644
Telemetry [baseline] (8.146 ms) : 0, 8146
Telemetry [candidate] (8.181 ms) : 0, 8181
IAST [baseline] (19.513 ms) : 0, 19513
IAST [candidate] (19.582 ms) : 0, 19582
section iast
BytebuddyAgent [baseline] (808.782 ms) : 0, 808782
BytebuddyAgent [candidate] (805.49 ms) : 0, 805490
GlobalTracer [baseline] (306.806 ms) : 0, 306806
GlobalTracer [candidate] (304.912 ms) : 0, 304912
AppSec [baseline] (57.308 ms) : 0, 57308
AppSec [candidate] (57.759 ms) : 0, 57759
Remote Config [baseline] (618.038 µs) : 0, 618
Remote Config [candidate] (620.451 µs) : 0, 620
Telemetry [baseline] (7.586 ms) : 0, 7586
Telemetry [candidate] (7.528 ms) : 0, 7528
IAST [baseline] (21.746 ms) : 0, 21746
IAST [candidate] (20.725 ms) : 0, 20725
section profiling
BytebuddyAgent [baseline] (681.835 ms) : 0, 681835
BytebuddyAgent [candidate] (690.807 ms) : 0, 690807
GlobalTracer [baseline] (398.663 ms) : 0, 398663
GlobalTracer [candidate] (403.885 ms) : 0, 403885
AppSec [baseline] (54.771 ms) : 0, 54771
AppSec [candidate] (55.315 ms) : 0, 55315
Remote Config [baseline] (668.129 µs) : 0, 668
Remote Config [candidate] (691.63 µs) : 0, 692
Telemetry [baseline] (12.105 ms) : 0, 12105
Telemetry [candidate] (12.081 ms) : 0, 12081
ProfilingAgent [baseline] (92.753 ms) : 0, 92753
ProfilingAgent [candidate] (93.671 ms) : 0, 93671
Profiling [baseline] (92.776 ms) : 0, 92776
Profiling [candidate] (93.695 ms) : 0, 93695
Loading
Startup time reports for insecure-bank 
gantt
    title insecure-bank - global startup overhead: candidate=1.43.0-SNAPSHOT~286c855587, baseline=1.43.0-SNAPSHOT~92eab56ab4

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.084 s) : 0, 1084163
Total [baseline] (8.581 s) : 0, 8580806
Agent [candidate] (1.099 s) : 0, 1098526
Total [candidate] (8.613 s) : 0, 8613300
section iast
Agent [baseline] (1.21 s) : 0, 1210412
Total [baseline] (9.157 s) : 0, 9157084
Agent [candidate] (1.208 s) : 0, 1207613
Total [candidate] (9.179 s) : 0, 9178960
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.207 s) : 0, 1206810
Total [baseline] (9.124 s) : 0, 9123669
Agent [candidate] (1.209 s) : 0, 1208527
Total [candidate] (9.1 s) : 0, 9100001
section iast_TELEMETRY_OFF
Agent [baseline] (1.205 s) : 0, 1205081
Total [baseline] (9.119 s) : 0, 9119499
Agent [candidate] (1.212 s) : 0, 1212019
Total [candidate] (9.145 s) : 0, 9145091
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.084 s -
Agent iast 1.21 s 126.249 ms (11.6%)
Agent iast_HARDCODED_SECRET_DISABLED 1.207 s 122.647 ms (11.3%)
Agent iast_TELEMETRY_OFF 1.205 s 120.918 ms (11.2%)
Total tracing 8.581 s -
Total iast 9.157 s 576.278 ms (6.7%)
Total iast_HARDCODED_SECRET_DISABLED 9.124 s 542.863 ms (6.3%)
Total iast_TELEMETRY_OFF 9.119 s 538.693 ms (6.3%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.099 s -
Agent iast 1.208 s 109.087 ms (9.9%)
Agent iast_HARDCODED_SECRET_DISABLED 1.209 s 110.0 ms (10.0%)
Agent iast_TELEMETRY_OFF 1.212 s 113.492 ms (10.3%)
Total tracing 8.613 s -
Total iast 9.179 s 565.66 ms (6.6%)
Total iast_HARDCODED_SECRET_DISABLED 9.1 s 486.702 ms (5.7%)
Total iast_TELEMETRY_OFF 9.145 s 531.792 ms (6.2%) 
gantt
    title insecure-bank - break down per module: candidate=1.43.0-SNAPSHOT~286c855587, baseline=1.43.0-SNAPSHOT~92eab56ab4

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (688.083 ms) : 0, 688083
BytebuddyAgent [candidate] (698.09 ms) : 0, 698090
GlobalTracer [baseline] (315.976 ms) : 0, 315976
GlobalTracer [candidate] (319.605 ms) : 0, 319605
AppSec [baseline] (54.259 ms) : 0, 54259
AppSec [candidate] (54.841 ms) : 0, 54841
Remote Config [baseline] (689.802 µs) : 0, 690
Remote Config [candidate] (699.83 µs) : 0, 700
Telemetry [baseline] (11.384 ms) : 0, 11384
Telemetry [candidate] (11.337 ms) : 0, 11337
section iast
BytebuddyAgent [baseline] (805.463 ms) : 0, 805463
BytebuddyAgent [candidate] (803.092 ms) : 0, 803092
GlobalTracer [baseline] (304.989 ms) : 0, 304989
GlobalTracer [candidate] (304.511 ms) : 0, 304511
AppSec [baseline] (56.572 ms) : 0, 56572
AppSec [candidate] (56.904 ms) : 0, 56904
IAST [baseline] (21.579 ms) : 0, 21579
IAST [candidate] (21.2 ms) : 0, 21200
Remote Config [baseline] (609.583 µs) : 0, 610
Remote Config [candidate] (620.984 µs) : 0, 621
Telemetry [baseline] (7.437 ms) : 0, 7437
Telemetry [candidate] (7.518 ms) : 0, 7518
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (802.474 ms) : 0, 802474
BytebuddyAgent [candidate] (802.68 ms) : 0, 802680
GlobalTracer [baseline] (304.668 ms) : 0, 304668
GlobalTracer [candidate] (305.066 ms) : 0, 305066
AppSec [baseline] (56.625 ms) : 0, 56625
AppSec [candidate] (58.085 ms) : 0, 58085
IAST [baseline] (21.182 ms) : 0, 21182
IAST [candidate] (20.728 ms) : 0, 20728
Remote Config [baseline] (614.793 µs) : 0, 615
Remote Config [candidate] (605.511 µs) : 0, 606
Telemetry [baseline] (7.513 ms) : 0, 7513
Telemetry [candidate] (7.617 ms) : 0, 7617
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (800.098 ms) : 0, 800098
BytebuddyAgent [candidate] (806.498 ms) : 0, 806498
GlobalTracer [baseline] (304.316 ms) : 0, 304316
GlobalTracer [candidate] (304.68 ms) : 0, 304680
AppSec [baseline] (58.644 ms) : 0, 58644
AppSec [candidate] (56.764 ms) : 0, 56764
IAST [baseline] (20.33 ms) : 0, 20330
IAST [candidate] (21.288 ms) : 0, 21288
Remote Config [baseline] (621.555 µs) : 0, 622
Remote Config [candidate] (610.673 µs) : 0, 611
Telemetry [baseline] (7.369 ms) : 0, 7369
Telemetry [candidate] (8.273 ms) : 0, 8273
Loading

Load

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
end_time 2024-11-15T16:02:56 2024-11-15T16:09:51
git_branch master daniel.mohedano/SDTEST-276-class-source-file-info
git_commit_date 1731663875 1731685896
git_commit_sha 92eab56 286c855
release_version 1.43.0-SNAPSHOT~92eab56ab4 1.43.0-SNAPSHOT~286c855587
start_time 2024-11-15T16:02:42 2024-11-15T16:09:37
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1731687343 1731687343
ci_job_id 708855548 708855548
ci_pipeline_id 49145983 49145983
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
variant iast iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 17 unstable metrics.

Request duration reports for petclinic 
gantt
    title petclinic - request duration [CI 0.99] : candidate=1.43.0-SNAPSHOT~286c855587, baseline=1.43.0-SNAPSHOT~92eab56ab4
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.359 ms) : 1340, 1379
.   : milestone, 1359,
appsec (1.747 ms) : 1722, 1772
.   : milestone, 1747,
appsec_no_iast (1.745 ms) : 1720, 1770
.   : milestone, 1745,
iast (1.477 ms) : 1454, 1500
.   : milestone, 1477,
profiling (1.493 ms) : 1470, 1516
.   : milestone, 1493,
tracing (1.471 ms) : 1447, 1495
.   : milestone, 1471,
section candidate
no_agent (1.354 ms) : 1335, 1373
.   : milestone, 1354,
appsec (1.736 ms) : 1714, 1759
.   : milestone, 1736,
appsec_no_iast (1.74 ms) : 1717, 1764
.   : milestone, 1740,
iast (1.485 ms) : 1461, 1508
.   : milestone, 1485,
profiling (1.525 ms) : 1501, 1549
.   : milestone, 1525,
tracing (1.494 ms) : 1469, 1519
.   : milestone, 1494,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.359 ms [1.34 ms, 1.379 ms] -
appsec 1.747 ms [1.722 ms, 1.772 ms] 388.075 µs (28.5%)
appsec_no_iast 1.745 ms [1.72 ms, 1.77 ms] 385.937 µs (28.4%)
iast 1.477 ms [1.454 ms, 1.5 ms] 118.027 µs (8.7%)
profiling 1.493 ms [1.47 ms, 1.516 ms] 133.696 µs (9.8%)
tracing 1.471 ms [1.447 ms, 1.495 ms] 111.661 µs (8.2%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.354 ms [1.335 ms, 1.373 ms] -
appsec 1.736 ms [1.714 ms, 1.759 ms] 382.474 µs (28.2%)
appsec_no_iast 1.74 ms [1.717 ms, 1.764 ms] 386.541 µs (28.5%)
iast 1.485 ms [1.461 ms, 1.508 ms] 130.625 µs (9.6%)
profiling 1.525 ms [1.501 ms, 1.549 ms] 171.148 µs (12.6%)
tracing 1.494 ms [1.469 ms, 1.519 ms] 139.73 µs (10.3%)
Request duration reports for insecure-bank 
gantt
    title insecure-bank - request duration [CI 0.99] : candidate=1.43.0-SNAPSHOT~286c855587, baseline=1.43.0-SNAPSHOT~92eab56ab4
    dateFormat X
    axisFormat %s
section baseline
no_agent (374.803 µs) : 355, 394
.   : milestone, 375,
iast (490.114 µs) : 469, 511
.   : milestone, 490,
iast_FULL (646.699 µs) : 625, 668
.   : milestone, 647,
iast_GLOBAL (517.251 µs) : 496, 539
.   : milestone, 517,
iast_HARDCODED_SECRET_DISABLED (484.014 µs) : 463, 505
.   : milestone, 484,
iast_INACTIVE (447.243 µs) : 427, 468
.   : milestone, 447,
iast_TELEMETRY_OFF (477.735 µs) : 456, 499
.   : milestone, 478,
tracing (442.493 µs) : 422, 463
.   : milestone, 442,
section candidate
no_agent (370.877 µs) : 351, 391
.   : milestone, 371,
iast (487.677 µs) : 466, 509
.   : milestone, 488,
iast_FULL (643.798 µs) : 622, 665
.   : milestone, 644,
iast_GLOBAL (519.799 µs) : 497, 543
.   : milestone, 520,
iast_HARDCODED_SECRET_DISABLED (491.028 µs) : 470, 512
.   : milestone, 491,
iast_INACTIVE (457.396 µs) : 436, 479
.   : milestone, 457,
iast_TELEMETRY_OFF (474.061 µs) : 453, 495
.   : milestone, 474,
tracing (446.765 µs) : 426, 468
.   : milestone, 447,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 374.803 µs [355.344 µs, 394.262 µs] -
iast 490.114 µs [468.739 µs, 511.489 µs] 115.311 µs (30.8%)
iast_FULL 646.699 µs [625.267 µs, 668.131 µs] 271.896 µs (72.5%)
iast_GLOBAL 517.251 µs [495.711 µs, 538.791 µs] 142.448 µs (38.0%)
iast_HARDCODED_SECRET_DISABLED 484.014 µs [462.72 µs, 505.307 µs] 109.211 µs (29.1%)
iast_INACTIVE 447.243 µs [426.59 µs, 467.896 µs] 72.44 µs (19.3%)
iast_TELEMETRY_OFF 477.735 µs [456.332 µs, 499.138 µs] 102.932 µs (27.5%)
tracing 442.493 µs [421.895 µs, 463.09 µs] 67.69 µs (18.1%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 370.877 µs [350.606 µs, 391.147 µs] -
iast 487.677 µs [465.973 µs, 509.38 µs] 116.8 µs (31.5%)
iast_FULL 643.798 µs [622.356 µs, 665.24 µs] 272.921 µs (73.6%)
iast_GLOBAL 519.799 µs [497.042 µs, 542.555 µs] 148.922 µs (40.2%)
iast_HARDCODED_SECRET_DISABLED 491.028 µs [469.897 µs, 512.159 µs] 120.151 µs (32.4%)
iast_INACTIVE 457.396 µs [435.842 µs, 478.95 µs] 86.519 µs (23.3%)
iast_TELEMETRY_OFF 474.061 µs [453.004 µs, 495.119 µs] 103.184 µs (27.8%)
tracing 446.765 µs [425.688 µs, 467.841 µs] 75.888 µs (20.5%)

Dacapo

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master daniel.mohedano/SDTEST-276-class-source-file-info
git_commit_date 1731663875 1731685896
git_commit_sha 92eab56 286c855
release_version 1.43.0-SNAPSHOT~92eab56ab4 1.43.0-SNAPSHOT~286c855587
See matching parameters
Baseline Candidate
application biojava biojava
ci_job_date 1731687754 1731687754
ci_job_id 708855549 708855549
ci_pipeline_id 49145983 49145983
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
variant appsec appsec

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics.

Execution time for biojava 
gantt
    title biojava - execution time [CI 0.99] : candidate=1.43.0-SNAPSHOT~286c855587, baseline=1.43.0-SNAPSHOT~92eab56ab4
    dateFormat X
    axisFormat %s
section baseline
no_agent (15.705 s) : 15705000, 15705000
.   : milestone, 15705000,
appsec (15.289 s) : 15289000, 15289000
.   : milestone, 15289000,
iast (18.632 s) : 18632000, 18632000
.   : milestone, 18632000,
iast_GLOBAL (18.055 s) : 18055000, 18055000
.   : milestone, 18055000,
profiling (15.24 s) : 15240000, 15240000
.   : milestone, 15240000,
tracing (15.178 s) : 15178000, 15178000
.   : milestone, 15178000,
section candidate
no_agent (15.789 s) : 15789000, 15789000
.   : milestone, 15789000,
appsec (15.603 s) : 15603000, 15603000
.   : milestone, 15603000,
iast (18.48 s) : 18480000, 18480000
.   : milestone, 18480000,
iast_GLOBAL (18.178 s) : 18178000, 18178000
.   : milestone, 18178000,
profiling (15.063 s) : 15063000, 15063000
.   : milestone, 15063000,
tracing (15.303 s) : 15303000, 15303000
.   : milestone, 15303000,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 15.705 s [15.705 s, 15.705 s] -
appsec 15.289 s [15.289 s, 15.289 s] -416.0 ms (-2.6%)
iast 18.632 s [18.632 s, 18.632 s] 2.927 s (18.6%)
iast_GLOBAL 18.055 s [18.055 s, 18.055 s] 2.35 s (15.0%)
profiling 15.24 s [15.24 s, 15.24 s] -465.0 ms (-3.0%)
tracing 15.178 s [15.178 s, 15.178 s] -527.0 ms (-3.4%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 15.789 s [15.789 s, 15.789 s] -
appsec 15.603 s [15.603 s, 15.603 s] -186.0 ms (-1.2%)
iast 18.48 s [18.48 s, 18.48 s] 2.691 s (17.0%)
iast_GLOBAL 18.178 s [18.178 s, 18.178 s] 2.389 s (15.1%)
profiling 15.063 s [15.063 s, 15.063 s] -726.0 ms (-4.6%)
tracing 15.303 s [15.303 s, 15.303 s] -486.0 ms (-3.1%)
Execution time for tomcat 
gantt
    title tomcat - execution time [CI 0.99] : candidate=1.43.0-SNAPSHOT~286c855587, baseline=1.43.0-SNAPSHOT~92eab56ab4
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.48 ms) : 1468, 1491
.   : milestone, 1480,
appsec (2.346 ms) : 2304, 2389
.   : milestone, 2346,
iast (2.081 ms) : 2029, 2134
.   : milestone, 2081,
iast_GLOBAL (2.13 ms) : 2077, 2184
.   : milestone, 2130,
profiling (1.942 ms) : 1899, 1984
.   : milestone, 1942,
tracing (1.933 ms) : 1892, 1973
.   : milestone, 1933,
section candidate
no_agent (1.474 ms) : 1462, 1486
.   : milestone, 1474,
appsec (2.337 ms) : 2296, 2378
.   : milestone, 2337,
iast (2.087 ms) : 2035, 2140
.   : milestone, 2087,
iast_GLOBAL (2.135 ms) : 2082, 2188
.   : milestone, 2135,
profiling (1.951 ms) : 1909, 1993
.   : milestone, 1951,
tracing (1.929 ms) : 1889, 1970
.   : milestone, 1929,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.48 ms [1.468 ms, 1.491 ms] -
appsec 2.346 ms [2.304 ms, 2.389 ms] 866.892 µs (58.6%)
iast 2.081 ms [2.029 ms, 2.134 ms] 601.714 µs (40.7%)
iast_GLOBAL 2.13 ms [2.077 ms, 2.184 ms] 650.907 µs (44.0%)
profiling 1.942 ms [1.899 ms, 1.984 ms] 462.146 µs (31.2%)
tracing 1.933 ms [1.892 ms, 1.973 ms] 453.385 µs (30.6%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.474 ms [1.462 ms, 1.486 ms] -
appsec 2.337 ms [2.296 ms, 2.378 ms] 862.924 µs (58.5%)
iast 2.087 ms [2.035 ms, 2.14 ms] 613.322 µs (41.6%)
iast_GLOBAL 2.135 ms [2.082 ms, 2.188 ms] 660.927 µs (44.8%)
profiling 1.951 ms [1.909 ms, 1.993 ms] 476.954 µs (32.4%)
tracing 1.929 ms [1.889 ms, 1.97 ms] 455.429 µs (30.9%)

nikita-tkachenko-datadog
nikita-tkachenko-datadog reviewed Nov 15, 2024
View reviewed changes
...nt/agent-ci-visibility/src/test/groovy/datadog/trace/civisibility/domain/TestImplTest.groovy Outdated
def methodLinesResolver = { it -> MethodLinesResolver.MethodLines.EMPTY }

def linesResolver = Stub(LinesResolver)
linesResolver.getMethodLines(null) >> LinesResolver.Lines.EMPTY
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you should use .getMethodLines(_) to stub invocation for any argument.

...ty/src/testFixtures/groovy/datadog/trace/civisibility/CiVisibilityInstrumentationTest.groovy Outdated
def methodLinesResolver = Stub(MethodLinesResolver)
methodLinesResolver.getLines(_ as Method) >> new MethodLinesResolver.MethodLines(DUMMY_TEST_METHOD_START, DUMMY_TEST_METHOD_END)
def methodLinesResolver = Stub(LinesResolver)
methodLinesResolver.getMethodLines(_ as Method) >> new LinesResolver.Lines(DUMMY_TEST_METHOD_START, DUMMY_TEST_METHOD_END)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suspect we might have to stub the getClassLines method as well: the tested code expects that the return value is always non-null, so we'll probably get a bunch of NPEs in tests.

@daniel-mohedano daniel-mohedano marked this pull request as ready for review November 18, 2024 13:53
@daniel-mohedano daniel-mohedano requested review from a team as code owners November 18, 2024 13:53
@daniel-mohedano daniel-mohedano merged commit c4bc3cc into master Nov 18, 2024
102 checks passed
@daniel-mohedano daniel-mohedano deleted the daniel.mohedano/SDTEST-276-class-source-file-info branch November 18, 2024 14:00
@github-actions github-actions bot added this to the 1.43.0 milestone Nov 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nikita-tkachenko-datadog nikita-tkachenko-datadog nikita-tkachenko-datadog approved these changes

@smola smola Awaiting requested review from smola smola is a code owner automatically assigned from DataDog/apm-java

Assignees
No one assigned
Labels
comp: ci visibility Continuous Integration Visibility
Projects
None yet
Milestone
1.43.0
Development

Successfully merging this pull request may close these issues.
2 participants
@daniel-mohedano @nikita-tkachenko-datadog