Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not reset IAST concurrent request counter #7963

Merged
merged 1 commit into from
Nov 19, 2024
Merged

Do not reset IAST concurrent request counter #7963

merged 1 commit into from
Nov 19, 2024

Conversation

smola
Copy link
Member

@smola smola commented Nov 15, 2024 •
edited by jira bot
Loading

What Does This Do

Until now, every 30s we did reset some values for IAST overhead control, including the counter for maximum concurrent requests. This change does:

  • Avoid resetting the counter of available requests. This may lead to IAST starving if coupled with a bug in end of request event handling, but the alternative is worse: producing an uncontrolled increase in memory overhead.
  • If we're starved of available requests for 1 hour, we'll emit a telemetry log. This will help us finding any case where we might have a bug here.

Motivation

We observed an akka-http service with an abnormal number of IAST contexts in the heap:

  • These exceeded, by large, the default number of concurrent IAST contexts (at the moment, 2).
  • It seems IAST request contexts leaked to Akka objects beyond the request scope. This should not be a big deal (although we'll continue investigating it), if we were always re-using them and not creating this amount of contexts.
  • The combination of both issues, with this traffic pattern, seem to lead to both excessive memory overhead, and potentially a memory leak (unconfirmed, but plausible).

Additional Notes

Contributor Checklist

Jira ticket: APPSEC-55869

@smola smola added type: bug comp: asm iast Application Security Management (IAST) labels Nov 15, 2024
@pr-commenter
Copy link

pr-commenter bot commented Nov 15, 2024 •
edited
Loading

Benchmarks

Startup

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master smola/avoid-iast-context-reset
git_commit_date 1731943603 1732007343
git_commit_sha 6181783 87c5c78
release_version 1.43.0-SNAPSHOT~6181783bd1 1.43.0-SNAPSHOT~87c5c789f5
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1732009793 1732009793
ci_job_id 711696252 711696252
ci_pipeline_id 49344503 49344503
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
module Agent Agent
parent None None
variant iast iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 56 metrics, 7 unstable metrics.

Startup time reports for insecure-bank 
gantt
    title insecure-bank - global startup overhead: candidate=1.43.0-SNAPSHOT~87c5c789f5, baseline=1.43.0-SNAPSHOT~6181783bd1

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.082 s) : 0, 1081896
Total [baseline] (8.577 s) : 0, 8576927
Agent [candidate] (1.08 s) : 0, 1080000
Total [candidate] (8.545 s) : 0, 8545158
section iast
Agent [baseline] (1.214 s) : 0, 1213894
Total [baseline] (9.138 s) : 0, 9138318
Agent [candidate] (1.206 s) : 0, 1205815
Total [candidate] (9.105 s) : 0, 9105033
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.215 s) : 0, 1215112
Total [baseline] (9.116 s) : 0, 9116366
Agent [candidate] (1.209 s) : 0, 1209455
Total [candidate] (9.103 s) : 0, 9103220
section iast_TELEMETRY_OFF
Agent [baseline] (1.213 s) : 0, 1213110
Total [baseline] (9.152 s) : 0, 9151884
Agent [candidate] (1.203 s) : 0, 1202543
Total [candidate] (9.104 s) : 0, 9104128
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.082 s -
Agent iast 1.214 s 131.998 ms (12.2%)
Agent iast_HARDCODED_SECRET_DISABLED 1.215 s 133.216 ms (12.3%)
Agent iast_TELEMETRY_OFF 1.213 s 131.214 ms (12.1%)
Total tracing 8.577 s -
Total iast 9.138 s 561.392 ms (6.5%)
Total iast_HARDCODED_SECRET_DISABLED 9.116 s 539.439 ms (6.3%)
Total iast_TELEMETRY_OFF 9.152 s 574.957 ms (6.7%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.08 s -
Agent iast 1.206 s 125.816 ms (11.6%)
Agent iast_HARDCODED_SECRET_DISABLED 1.209 s 129.456 ms (12.0%)
Agent iast_TELEMETRY_OFF 1.203 s 122.543 ms (11.3%)
Total tracing 8.545 s -
Total iast 9.105 s 559.875 ms (6.6%)
Total iast_HARDCODED_SECRET_DISABLED 9.103 s 558.062 ms (6.5%)
Total iast_TELEMETRY_OFF 9.104 s 558.97 ms (6.5%) 
gantt
    title insecure-bank - break down per module: candidate=1.43.0-SNAPSHOT~87c5c789f5, baseline=1.43.0-SNAPSHOT~6181783bd1

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (687.091 ms) : 0, 687091
BytebuddyAgent [candidate] (685.79 ms) : 0, 685790
GlobalTracer [baseline] (316.224 ms) : 0, 316224
GlobalTracer [candidate] (315.225 ms) : 0, 315225
AppSec [baseline] (54.314 ms) : 0, 54314
AppSec [candidate] (54.086 ms) : 0, 54086
Remote Config [baseline] (682.264 µs) : 0, 682
Remote Config [candidate] (682.07 µs) : 0, 682
Telemetry [baseline] (9.897 ms) : 0, 9897
Telemetry [candidate] (10.534 ms) : 0, 10534
section iast
BytebuddyAgent [baseline] (807.588 ms) : 0, 807588
BytebuddyAgent [candidate] (802.065 ms) : 0, 802065
GlobalTracer [baseline] (306.826 ms) : 0, 306826
GlobalTracer [candidate] (304.601 ms) : 0, 304601
AppSec [baseline] (57.361 ms) : 0, 57361
AppSec [candidate] (57.106 ms) : 0, 57106
IAST [baseline] (20.378 ms) : 0, 20378
IAST [candidate] (20.408 ms) : 0, 20408
Remote Config [baseline] (600.267 µs) : 0, 600
Remote Config [candidate] (600.312 µs) : 0, 600
Telemetry [baseline] (7.396 ms) : 0, 7396
Telemetry [candidate] (7.352 ms) : 0, 7352
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (807.759 ms) : 0, 807759
BytebuddyAgent [candidate] (802.954 ms) : 0, 802954
GlobalTracer [baseline] (306.77 ms) : 0, 306770
GlobalTracer [candidate] (307.045 ms) : 0, 307045
AppSec [baseline] (57.73 ms) : 0, 57730
AppSec [candidate] (57.308 ms) : 0, 57308
IAST [baseline] (20.814 ms) : 0, 20814
IAST [candidate] (20.454 ms) : 0, 20454
Remote Config [baseline] (620.385 µs) : 0, 620
Remote Config [candidate] (595.75 µs) : 0, 596
Telemetry [baseline] (7.639 ms) : 0, 7639
Telemetry [candidate] (7.383 ms) : 0, 7383
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (806.325 ms) : 0, 806325
BytebuddyAgent [candidate] (799.148 ms) : 0, 799148
GlobalTracer [baseline] (306.327 ms) : 0, 306327
GlobalTracer [candidate] (304.373 ms) : 0, 304373
AppSec [baseline] (58.07 ms) : 0, 58070
AppSec [candidate] (57.351 ms) : 0, 57351
IAST [baseline] (20.522 ms) : 0, 20522
IAST [candidate] (20.173 ms) : 0, 20173
Remote Config [baseline] (629.015 µs) : 0, 629
Remote Config [candidate] (601.476 µs) : 0, 601
Telemetry [baseline] (7.458 ms) : 0, 7458
Telemetry [candidate] (7.228 ms) : 0, 7228
Loading
Startup time reports for petclinic 
gantt
    title petclinic - global startup overhead: candidate=1.43.0-SNAPSHOT~87c5c789f5, baseline=1.43.0-SNAPSHOT~6181783bd1

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.08 s) : 0, 1079971
Total [baseline] (10.409 s) : 0, 10409158
Agent [candidate] (1.082 s) : 0, 1081953
Total [candidate] (10.405 s) : 0, 10404920
section appsec
Agent [baseline] (1.218 s) : 0, 1217953
Total [baseline] (10.682 s) : 0, 10682289
Agent [candidate] (1.22 s) : 0, 1219676
Total [candidate] (10.684 s) : 0, 10683989
section iast
Agent [baseline] (1.206 s) : 0, 1205511
Total [baseline] (10.932 s) : 0, 10931518
Agent [candidate] (1.207 s) : 0, 1207192
Total [candidate] (10.849 s) : 0, 10848923
section profiling
Agent [baseline] (1.288 s) : 0, 1287789
Total [baseline] (10.785 s) : 0, 10784640
Agent [candidate] (1.287 s) : 0, 1286593
Total [candidate] (10.729 s) : 0, 10729054
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.08 s -
Agent appsec 1.218 s 137.982 ms (12.8%)
Agent iast 1.206 s 125.54 ms (11.6%)
Agent profiling 1.288 s 207.817 ms (19.2%)
Total tracing 10.409 s -
Total appsec 10.682 s 273.132 ms (2.6%)
Total iast 10.932 s 522.36 ms (5.0%)
Total profiling 10.785 s 375.482 ms (3.6%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.082 s -
Agent appsec 1.22 s 137.723 ms (12.7%)
Agent iast 1.207 s 125.238 ms (11.6%)
Agent profiling 1.287 s 204.64 ms (18.9%)
Total tracing 10.405 s -
Total appsec 10.684 s 279.068 ms (2.7%)
Total iast 10.849 s 444.003 ms (4.3%)
Total profiling 10.729 s 324.134 ms (3.1%) 
gantt
    title petclinic - break down per module: candidate=1.43.0-SNAPSHOT~87c5c789f5, baseline=1.43.0-SNAPSHOT~6181783bd1

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (685.601 ms) : 0, 685601
BytebuddyAgent [candidate] (688.05 ms) : 0, 688050
GlobalTracer [baseline] (315.423 ms) : 0, 315423
GlobalTracer [candidate] (315.887 ms) : 0, 315887
AppSec [baseline] (54.09 ms) : 0, 54090
AppSec [candidate] (54.366 ms) : 0, 54366
Remote Config [baseline] (682.35 µs) : 0, 682
Remote Config [candidate] (677.902 µs) : 0, 678
Telemetry [baseline] (10.562 ms) : 0, 10562
Telemetry [candidate] (9.241 ms) : 0, 9241
section appsec
BytebuddyAgent [baseline] (705.552 ms) : 0, 705552
BytebuddyAgent [candidate] (707.139 ms) : 0, 707139
GlobalTracer [baseline] (313.617 ms) : 0, 313617
GlobalTracer [candidate] (314.531 ms) : 0, 314531
AppSec [baseline] (167.31 ms) : 0, 167310
AppSec [candidate] (164.889 ms) : 0, 164889
Remote Config [baseline] (638.612 µs) : 0, 639
Remote Config [candidate] (638.583 µs) : 0, 639
Telemetry [baseline] (7.463 ms) : 0, 7463
Telemetry [candidate] (8.916 ms) : 0, 8916
IAST [baseline] (19.417 ms) : 0, 19417
IAST [candidate] (19.711 ms) : 0, 19711
section iast
BytebuddyAgent [baseline] (800.955 ms) : 0, 800955
BytebuddyAgent [candidate] (802.888 ms) : 0, 802888
GlobalTracer [baseline] (304.746 ms) : 0, 304746
GlobalTracer [candidate] (305.09 ms) : 0, 305090
AppSec [baseline] (56.698 ms) : 0, 56698
AppSec [candidate] (57.076 ms) : 0, 57076
Remote Config [baseline] (607.485 µs) : 0, 607
Remote Config [candidate] (603.903 µs) : 0, 604
Telemetry [baseline] (7.417 ms) : 0, 7417
Telemetry [candidate] (7.314 ms) : 0, 7314
IAST [baseline] (21.424 ms) : 0, 21424
IAST [candidate] (20.538 ms) : 0, 20538
section profiling
BytebuddyAgent [baseline] (686.851 ms) : 0, 686851
BytebuddyAgent [candidate] (685.632 ms) : 0, 685632
GlobalTracer [baseline] (401.261 ms) : 0, 401261
GlobalTracer [candidate] (400.727 ms) : 0, 400727
AppSec [baseline] (54.949 ms) : 0, 54949
AppSec [candidate] (54.93 ms) : 0, 54930
Remote Config [baseline] (670.413 µs) : 0, 670
Remote Config [candidate] (665.835 µs) : 0, 666
Telemetry [baseline] (13.484 ms) : 0, 13484
Telemetry [candidate] (10.65 ms) : 0, 10650
ProfilingAgent [baseline] (91.381 ms) : 0, 91381
ProfilingAgent [candidate] (94.756 ms) : 0, 94756
Profiling [baseline] (91.405 ms) : 0, 91405
Profiling [candidate] (94.78 ms) : 0, 94780
Loading

Load

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
end_time 2024-11-19T09:20:13 2024-11-19T09:27:05
git_branch master smola/avoid-iast-context-reset
git_commit_date 1731943603 1732007343
git_commit_sha 6181783 87c5c78
release_version 1.43.0-SNAPSHOT~6181783bd1 1.43.0-SNAPSHOT~87c5c789f5
start_time 2024-11-19T09:19:59 2024-11-19T09:26:52
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1732008773 1732008773
ci_job_id 711696254 711696254
ci_pipeline_id 49344503 49344503
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
variant iast iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 16 unstable metrics.

Request duration reports for insecure-bank 
gantt
    title insecure-bank - request duration [CI 0.99] : candidate=1.43.0-SNAPSHOT~87c5c789f5, baseline=1.43.0-SNAPSHOT~6181783bd1
    dateFormat X
    axisFormat %s
section baseline
no_agent (371.566 µs) : 351, 392
.   : milestone, 372,
iast (475.878 µs) : 455, 497
.   : milestone, 476,
iast_FULL (636.187 µs) : 615, 657
.   : milestone, 636,
iast_GLOBAL (510.44 µs) : 489, 532
.   : milestone, 510,
iast_HARDCODED_SECRET_DISABLED (479.182 µs) : 458, 501
.   : milestone, 479,
iast_INACTIVE (446.205 µs) : 425, 467
.   : milestone, 446,
iast_TELEMETRY_OFF (471.528 µs) : 450, 493
.   : milestone, 472,
tracing (443.56 µs) : 423, 464
.   : milestone, 444,
section candidate
no_agent (367.869 µs) : 349, 387
.   : milestone, 368,
iast (485.042 µs) : 464, 507
.   : milestone, 485,
iast_FULL (637.065 µs) : 616, 658
.   : milestone, 637,
iast_GLOBAL (504.355 µs) : 483, 526
.   : milestone, 504,
iast_HARDCODED_SECRET_DISABLED (483.062 µs) : 462, 504
.   : milestone, 483,
iast_INACTIVE (444.228 µs) : 423, 465
.   : milestone, 444,
iast_TELEMETRY_OFF (475.806 µs) : 454, 498
.   : milestone, 476,
tracing (442.243 µs) : 422, 463
.   : milestone, 442,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 371.566 µs [351.475 µs, 391.658 µs] -
iast 475.878 µs [454.843 µs, 496.913 µs] 104.312 µs (28.1%)
iast_FULL 636.187 µs [614.9 µs, 657.473 µs] 264.62 µs (71.2%)
iast_GLOBAL 510.44 µs [488.724 µs, 532.156 µs] 138.874 µs (37.4%)
iast_HARDCODED_SECRET_DISABLED 479.182 µs [457.775 µs, 500.589 µs] 107.615 µs (29.0%)
iast_INACTIVE 446.205 µs [425.161 µs, 467.248 µs] 74.638 µs (20.1%)
iast_TELEMETRY_OFF 471.528 µs [450.071 µs, 492.985 µs] 99.962 µs (26.9%)
tracing 443.56 µs [423.288 µs, 463.832 µs] 71.994 µs (19.4%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 367.869 µs [348.507 µs, 387.231 µs] -
iast 485.042 µs [463.515 µs, 506.569 µs] 117.173 µs (31.9%)
iast_FULL 637.065 µs [615.671 µs, 658.459 µs] 269.196 µs (73.2%)
iast_GLOBAL 504.355 µs [482.755 µs, 525.955 µs] 136.486 µs (37.1%)
iast_HARDCODED_SECRET_DISABLED 483.062 µs [461.833 µs, 504.29 µs] 115.193 µs (31.3%)
iast_INACTIVE 444.228 µs [423.225 µs, 465.23 µs] 76.359 µs (20.8%)
iast_TELEMETRY_OFF 475.806 µs [453.855 µs, 497.757 µs] 107.937 µs (29.3%)
tracing 442.243 µs [421.609 µs, 462.877 µs] 74.374 µs (20.2%)
Request duration reports for petclinic 
gantt
    title petclinic - request duration [CI 0.99] : candidate=1.43.0-SNAPSHOT~87c5c789f5, baseline=1.43.0-SNAPSHOT~6181783bd1
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.33 ms) : 1311, 1350
.   : milestone, 1330,
appsec (1.729 ms) : 1704, 1754
.   : milestone, 1729,
appsec_no_iast (1.713 ms) : 1688, 1738
.   : milestone, 1713,
iast (1.455 ms) : 1432, 1478
.   : milestone, 1455,
profiling (1.476 ms) : 1454, 1499
.   : milestone, 1476,
tracing (1.475 ms) : 1451, 1499
.   : milestone, 1475,
section candidate
no_agent (1.327 ms) : 1308, 1346
.   : milestone, 1327,
appsec (1.722 ms) : 1699, 1746
.   : milestone, 1722,
appsec_no_iast (1.731 ms) : 1707, 1754
.   : milestone, 1731,
iast (1.489 ms) : 1466, 1513
.   : milestone, 1489,
profiling (1.486 ms) : 1463, 1509
.   : milestone, 1486,
tracing (1.473 ms) : 1448, 1498
.   : milestone, 1473,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.33 ms [1.311 ms, 1.35 ms] -
appsec 1.729 ms [1.704 ms, 1.754 ms] 398.77 µs (30.0%)
appsec_no_iast 1.713 ms [1.688 ms, 1.738 ms] 382.964 µs (28.8%)
iast 1.455 ms [1.432 ms, 1.478 ms] 125.036 µs (9.4%)
profiling 1.476 ms [1.454 ms, 1.499 ms] 146.123 µs (11.0%)
tracing 1.475 ms [1.451 ms, 1.499 ms] 145.33 µs (10.9%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.327 ms [1.308 ms, 1.346 ms] -
appsec 1.722 ms [1.699 ms, 1.746 ms] 395.459 µs (29.8%)
appsec_no_iast 1.731 ms [1.707 ms, 1.754 ms] 403.919 µs (30.4%)
iast 1.489 ms [1.466 ms, 1.513 ms] 162.388 µs (12.2%)
profiling 1.486 ms [1.463 ms, 1.509 ms] 158.796 µs (12.0%)
tracing 1.473 ms [1.448 ms, 1.498 ms] 146.013 µs (11.0%)

Dacapo

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master smola/avoid-iast-context-reset
git_commit_date 1731943603 1732007343
git_commit_sha 6181783 87c5c78
release_version 1.43.0-SNAPSHOT~6181783bd1 1.43.0-SNAPSHOT~87c5c789f5
See matching parameters
Baseline Candidate
application biojava biojava
ci_job_date 1732009484 1732009484
ci_job_id 711696256 711696256
ci_pipeline_id 49344503 49344503
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
variant appsec appsec

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics.

Execution time for biojava 
gantt
    title biojava - execution time [CI 0.99] : candidate=1.43.0-SNAPSHOT~87c5c789f5, baseline=1.43.0-SNAPSHOT~6181783bd1
    dateFormat X
    axisFormat %s
section baseline
no_agent (15.148 s) : 15148000, 15148000
.   : milestone, 15148000,
appsec (15.232 s) : 15232000, 15232000
.   : milestone, 15232000,
iast (19.039 s) : 19039000, 19039000
.   : milestone, 19039000,
iast_GLOBAL (18.289 s) : 18289000, 18289000
.   : milestone, 18289000,
profiling (14.946 s) : 14946000, 14946000
.   : milestone, 14946000,
tracing (15.312 s) : 15312000, 15312000
.   : milestone, 15312000,
section candidate
no_agent (15.248 s) : 15248000, 15248000
.   : milestone, 15248000,
appsec (15.04 s) : 15040000, 15040000
.   : milestone, 15040000,
iast (18.943 s) : 18943000, 18943000
.   : milestone, 18943000,
iast_GLOBAL (17.95 s) : 17950000, 17950000
.   : milestone, 17950000,
profiling (14.875 s) : 14875000, 14875000
.   : milestone, 14875000,
tracing (14.891 s) : 14891000, 14891000
.   : milestone, 14891000,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 15.148 s [15.148 s, 15.148 s] -
appsec 15.232 s [15.232 s, 15.232 s] 84.0 ms (0.6%)
iast 19.039 s [19.039 s, 19.039 s] 3.891 s (25.7%)
iast_GLOBAL 18.289 s [18.289 s, 18.289 s] 3.141 s (20.7%)
profiling 14.946 s [14.946 s, 14.946 s] -202.0 ms (-1.3%)
tracing 15.312 s [15.312 s, 15.312 s] 164.0 ms (1.1%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 15.248 s [15.248 s, 15.248 s] -
appsec 15.04 s [15.04 s, 15.04 s] -208.0 ms (-1.4%)
iast 18.943 s [18.943 s, 18.943 s] 3.695 s (24.2%)
iast_GLOBAL 17.95 s [17.95 s, 17.95 s] 2.702 s (17.7%)
profiling 14.875 s [14.875 s, 14.875 s] -373.0 ms (-2.4%)
tracing 14.891 s [14.891 s, 14.891 s] -357.0 ms (-2.3%)
Execution time for tomcat 
gantt
    title tomcat - execution time [CI 0.99] : candidate=1.43.0-SNAPSHOT~87c5c789f5, baseline=1.43.0-SNAPSHOT~6181783bd1
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.466 ms) : 1455, 1478
.   : milestone, 1466,
appsec (2.331 ms) : 2290, 2373
.   : milestone, 2331,
iast (2.065 ms) : 2013, 2117
.   : milestone, 2065,
iast_GLOBAL (2.117 ms) : 2064, 2170
.   : milestone, 2117,
profiling (1.959 ms) : 1915, 2003
.   : milestone, 1959,
tracing (1.918 ms) : 1878, 1958
.   : milestone, 1918,
section candidate
no_agent (1.464 ms) : 1453, 1475
.   : milestone, 1464,
appsec (2.341 ms) : 2300, 2382
.   : milestone, 2341,
iast (2.058 ms) : 2007, 2109
.   : milestone, 2058,
iast_GLOBAL (2.109 ms) : 2057, 2162
.   : milestone, 2109,
profiling (1.942 ms) : 1899, 1985
.   : milestone, 1942,
tracing (1.914 ms) : 1874, 1953
.   : milestone, 1914,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.466 ms [1.455 ms, 1.478 ms] -
appsec 2.331 ms [2.29 ms, 2.373 ms] 865.01 µs (59.0%)
iast 2.065 ms [2.013 ms, 2.117 ms] 599.241 µs (40.9%)
iast_GLOBAL 2.117 ms [2.064 ms, 2.17 ms] 650.96 µs (44.4%)
profiling 1.959 ms [1.915 ms, 2.003 ms] 492.983 µs (33.6%)
tracing 1.918 ms [1.878 ms, 1.958 ms] 452.284 µs (30.9%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.464 ms [1.453 ms, 1.475 ms] -
appsec 2.341 ms [2.3 ms, 2.382 ms] 876.948 µs (59.9%)
iast 2.058 ms [2.007 ms, 2.109 ms] 593.874 µs (40.6%)
iast_GLOBAL 2.109 ms [2.057 ms, 2.162 ms] 645.055 µs (44.1%)
profiling 1.942 ms [1.899 ms, 1.985 ms] 477.644 µs (32.6%)
tracing 1.914 ms [1.874 ms, 1.953 ms] 449.676 µs (30.7%)

@smola smola marked this pull request as ready for review November 15, 2024 13:29
@smola smola requested a review from a team as a code owner November 15, 2024 13:29
@manuel-alvarez-alvarez manuel-alvarez-alvarez force-pushed the smola/avoid-iast-context-reset branch from 3765b7d to 87c5c78 Compare November 19, 2024 09:09
@manuel-alvarez-alvarez manuel-alvarez-alvarez merged commit 4dfa404 into master Nov 19, 2024
102 checks passed
@manuel-alvarez-alvarez manuel-alvarez-alvarez deleted the smola/avoid-iast-context-reset branch November 19, 2024 10:15
@github-actions github-actions bot added this to the 1.43.0 milestone Nov 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@manuel-alvarez-alvarez manuel-alvarez-alvarez manuel-alvarez-alvarez approved these changes

@Mariovido Mariovido Awaiting requested review from Mariovido Mariovido is a code owner automatically assigned from DataDog/asm-java

Assignees
No one assigned
Labels
comp: asm iast Application Security Management (IAST) type: bug
Projects
None yet
Milestone
1.43.0
Development

Successfully merging this pull request may close these issues.
2 participants
@smola @manuel-alvarez-alvarez