Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Standardize some of the profiler sampling frequencies #7961

Merged
merged 3 commits into from
Nov 20, 2024
Merged

Standardize some of the profiler sampling frequencies #7961

merged 3 commits into from
Nov 20, 2024
+11 −2

Conversation

MattAlp
Copy link
Contributor

@MattAlp MattAlp commented Nov 14, 2024 •
edited by jira bot
Loading

What Does This Do

Modifies profiler launch config to CPU sample every 50ms (due to triggering safepoints). Updates default wallclock sampling frequency to be true to ddprof (50ms).

Motivation

Following benchmarking and code review, we've identified that J9 CPU sampling overhead is adequately low at ≥50ms. Additionally, the wallclock default frequency should have been 50ms to maintain parity with ddprof.

Additional Notes

Contributor Checklist

Jira ticket: PROF-10875

@MattAlp MattAlp requested review from a team as code owners November 14, 2024 18:59
@MattAlp MattAlp requested a review from smola November 14, 2024 18:59
@pr-commenter
Copy link

pr-commenter bot commented Nov 14, 2024 •
edited
Loading

Benchmarks

Startup

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master mattalp/standardize-sampling-frequencies
git_commit_date 1732022072 1732049825
git_commit_sha 137948f c055807
release_version 1.43.0-SNAPSHOT~137948ff59 1.43.0-SNAPSHOT~c055807dbd
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1732052286 1732052286
ci_job_id 713008352 713008352
ci_pipeline_id 49434951 49434951
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
module Agent Agent
parent None None
variant iast iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 53 metrics, 10 unstable metrics.

Startup time reports for petclinic 
gantt
    title petclinic - global startup overhead: candidate=1.43.0-SNAPSHOT~c055807dbd, baseline=1.43.0-SNAPSHOT~137948ff59

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.086 s) : 0, 1086074
Total [baseline] (10.465 s) : 0, 10464619
Agent [candidate] (1.085 s) : 0, 1085002
Total [candidate] (10.438 s) : 0, 10437799
section appsec
Agent [baseline] (1.217 s) : 0, 1217102
Total [baseline] (10.622 s) : 0, 10622295
Agent [candidate] (1.22 s) : 0, 1219742
Total [candidate] (10.631 s) : 0, 10631077
section iast
Agent [baseline] (1.207 s) : 0, 1206591
Total [baseline] (10.868 s) : 0, 10867994
Agent [candidate] (1.208 s) : 0, 1207941
Total [candidate] (10.876 s) : 0, 10876347
section profiling
Agent [baseline] (1.277 s) : 0, 1277288
Total [baseline] (10.718 s) : 0, 10717658
Agent [candidate] (1.284 s) : 0, 1283634
Total [candidate] (10.718 s) : 0, 10718142
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.086 s -
Agent appsec 1.217 s 131.028 ms (12.1%)
Agent iast 1.207 s 120.518 ms (11.1%)
Agent profiling 1.277 s 191.215 ms (17.6%)
Total tracing 10.465 s -
Total appsec 10.622 s 157.675 ms (1.5%)
Total iast 10.868 s 403.374 ms (3.9%)
Total profiling 10.718 s 253.039 ms (2.4%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.085 s -
Agent appsec 1.22 s 134.74 ms (12.4%)
Agent iast 1.208 s 122.939 ms (11.3%)
Agent profiling 1.284 s 198.632 ms (18.3%)
Total tracing 10.438 s -
Total appsec 10.631 s 193.278 ms (1.9%)
Total iast 10.876 s 438.548 ms (4.2%)
Total profiling 10.718 s 280.343 ms (2.7%) 
gantt
    title petclinic - break down per module: candidate=1.43.0-SNAPSHOT~c055807dbd, baseline=1.43.0-SNAPSHOT~137948ff59

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (691.447 ms) : 0, 691447
BytebuddyAgent [candidate] (690.776 ms) : 0, 690776
GlobalTracer [baseline] (317.302 ms) : 0, 317302
GlobalTracer [candidate] (315.817 ms) : 0, 315817
AppSec [baseline] (54.393 ms) : 0, 54393
AppSec [candidate] (54.108 ms) : 0, 54108
Remote Config [baseline] (677.852 µs) : 0, 678
Remote Config [candidate] (669.858 µs) : 0, 670
Telemetry [baseline] (8.502 ms) : 0, 8502
Telemetry [candidate] (9.83 ms) : 0, 9830
section appsec
BytebuddyAgent [baseline] (705.256 ms) : 0, 705256
BytebuddyAgent [candidate] (707.533 ms) : 0, 707533
GlobalTracer [baseline] (313.423 ms) : 0, 313423
GlobalTracer [candidate] (314.076 ms) : 0, 314076
AppSec [baseline] (165.806 ms) : 0, 165806
AppSec [candidate] (166.218 ms) : 0, 166218
IAST [baseline] (20.43 ms) : 0, 20430
IAST [candidate] (20.318 ms) : 0, 20318
Remote Config [baseline] (627.974 µs) : 0, 628
Remote Config [candidate] (630.615 µs) : 0, 631
Telemetry [baseline] (8.105 ms) : 0, 8105
Telemetry [candidate] (7.405 ms) : 0, 7405
section iast
BytebuddyAgent [baseline] (802.405 ms) : 0, 802405
BytebuddyAgent [candidate] (802.889 ms) : 0, 802889
GlobalTracer [baseline] (304.906 ms) : 0, 304906
GlobalTracer [candidate] (305.103 ms) : 0, 305103
AppSec [baseline] (56.265 ms) : 0, 56265
AppSec [candidate] (56.538 ms) : 0, 56538
IAST [baseline] (21.406 ms) : 0, 21406
IAST [candidate] (21.65 ms) : 0, 21650
Remote Config [baseline] (589.082 µs) : 0, 589
Remote Config [candidate] (618.737 µs) : 0, 619
Telemetry [baseline] (7.326 ms) : 0, 7326
Telemetry [candidate] (7.433 ms) : 0, 7433
section profiling
BytebuddyAgent [baseline] (680.325 ms) : 0, 680325
BytebuddyAgent [candidate] (683.281 ms) : 0, 683281
GlobalTracer [baseline] (398.777 ms) : 0, 398777
GlobalTracer [candidate] (400.973 ms) : 0, 400973
AppSec [baseline] (54.585 ms) : 0, 54585
AppSec [candidate] (54.539 ms) : 0, 54539
Remote Config [baseline] (658.229 µs) : 0, 658
Remote Config [candidate] (688.209 µs) : 0, 688
Telemetry [baseline] (11.953 ms) : 0, 11953
Telemetry [candidate] (12.685 ms) : 0, 12685
ProfilingAgent [baseline] (92.171 ms) : 0, 92171
ProfilingAgent [candidate] (92.431 ms) : 0, 92431
Profiling [baseline] (92.195 ms) : 0, 92195
Profiling [candidate] (92.455 ms) : 0, 92455
Loading
Startup time reports for insecure-bank 
gantt
    title insecure-bank - global startup overhead: candidate=1.43.0-SNAPSHOT~c055807dbd, baseline=1.43.0-SNAPSHOT~137948ff59

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.08 s) : 0, 1080200
Total [baseline] (8.574 s) : 0, 8574269
Agent [candidate] (1.079 s) : 0, 1079164
Total [candidate] (8.568 s) : 0, 8567988
section iast
Agent [baseline] (1.214 s) : 0, 1213702
Total [baseline] (9.156 s) : 0, 9155516
Agent [candidate] (1.207 s) : 0, 1207079
Total [candidate] (9.131 s) : 0, 9130778
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.214 s) : 0, 1214321
Total [baseline] (9.106 s) : 0, 9105542
Agent [candidate] (1.208 s) : 0, 1207567
Total [candidate] (9.108 s) : 0, 9108181
section iast_TELEMETRY_OFF
Agent [baseline] (1.221 s) : 0, 1220777
Total [baseline] (9.148 s) : 0, 9148209
Agent [candidate] (1.208 s) : 0, 1207684
Total [candidate] (9.124 s) : 0, 9123831
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.08 s -
Agent iast 1.214 s 133.502 ms (12.4%)
Agent iast_HARDCODED_SECRET_DISABLED 1.214 s 134.12 ms (12.4%)
Agent iast_TELEMETRY_OFF 1.221 s 140.577 ms (13.0%)
Total tracing 8.574 s -
Total iast 9.156 s 581.247 ms (6.8%)
Total iast_HARDCODED_SECRET_DISABLED 9.106 s 531.273 ms (6.2%)
Total iast_TELEMETRY_OFF 9.148 s 573.94 ms (6.7%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.079 s -
Agent iast 1.207 s 127.915 ms (11.9%)
Agent iast_HARDCODED_SECRET_DISABLED 1.208 s 128.404 ms (11.9%)
Agent iast_TELEMETRY_OFF 1.208 s 128.52 ms (11.9%)
Total tracing 8.568 s -
Total iast 9.131 s 562.79 ms (6.6%)
Total iast_HARDCODED_SECRET_DISABLED 9.108 s 540.194 ms (6.3%)
Total iast_TELEMETRY_OFF 9.124 s 555.843 ms (6.5%) 
gantt
    title insecure-bank - break down per module: candidate=1.43.0-SNAPSHOT~c055807dbd, baseline=1.43.0-SNAPSHOT~137948ff59

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (685.623 ms) : 0, 685623
BytebuddyAgent [candidate] (685.687 ms) : 0, 685687
GlobalTracer [baseline] (315.389 ms) : 0, 315389
GlobalTracer [candidate] (314.654 ms) : 0, 314654
AppSec [baseline] (54.223 ms) : 0, 54223
AppSec [candidate] (53.897 ms) : 0, 53897
Remote Config [baseline] (667.475 µs) : 0, 667
Remote Config [candidate] (670.056 µs) : 0, 670
Telemetry [baseline] (10.654 ms) : 0, 10654
Telemetry [candidate] (10.638 ms) : 0, 10638
section iast
BytebuddyAgent [baseline] (807.277 ms) : 0, 807277
BytebuddyAgent [candidate] (803.116 ms) : 0, 803116
GlobalTracer [baseline] (306.543 ms) : 0, 306543
GlobalTracer [candidate] (304.555 ms) : 0, 304555
AppSec [baseline] (56.625 ms) : 0, 56625
AppSec [candidate] (55.892 ms) : 0, 55892
IAST [baseline] (21.505 ms) : 0, 21505
IAST [candidate] (21.863 ms) : 0, 21863
Remote Config [baseline] (603.712 µs) : 0, 604
Remote Config [candidate] (599.534 µs) : 0, 600
Telemetry [baseline] (7.409 ms) : 0, 7409
Telemetry [candidate] (7.34 ms) : 0, 7340
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (807.861 ms) : 0, 807861
BytebuddyAgent [candidate] (802.74 ms) : 0, 802740
GlobalTracer [baseline] (306.777 ms) : 0, 306777
GlobalTracer [candidate] (305.089 ms) : 0, 305089
AppSec [baseline] (56.469 ms) : 0, 56469
AppSec [candidate] (57.375 ms) : 0, 57375
IAST [baseline] (21.405 ms) : 0, 21405
IAST [candidate] (20.532 ms) : 0, 20532
Remote Config [baseline] (604.98 µs) : 0, 605
Remote Config [candidate] (605.052 µs) : 0, 605
Telemetry [baseline] (7.472 ms) : 0, 7472
Telemetry [candidate] (7.504 ms) : 0, 7504
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (811.696 ms) : 0, 811696
BytebuddyAgent [candidate] (803.502 ms) : 0, 803502
GlobalTracer [baseline] (309.355 ms) : 0, 309355
GlobalTracer [candidate] (304.479 ms) : 0, 304479
AppSec [baseline] (57.397 ms) : 0, 57397
AppSec [candidate] (56.94 ms) : 0, 56940
IAST [baseline] (20.48 ms) : 0, 20480
IAST [candidate] (21.057 ms) : 0, 21057
Remote Config [baseline] (615.149 µs) : 0, 615
Remote Config [candidate] (594.824 µs) : 0, 595
Telemetry [baseline] (7.394 ms) : 0, 7394
Telemetry [candidate] (7.358 ms) : 0, 7358
Loading

Load

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
end_time 2024-11-19T21:08:34 2024-11-19T21:15:29
git_branch master mattalp/standardize-sampling-frequencies
git_commit_date 1732022072 1732049825
git_commit_sha 137948f c055807
release_version 1.43.0-SNAPSHOT~137948ff59 1.43.0-SNAPSHOT~c055807dbd
start_time 2024-11-19T21:08:20 2024-11-19T21:15:15
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1732051281 1732051281
ci_job_id 713008354 713008354
ci_pipeline_id 49434951 49434951
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
variant iast iast

Summary

Found 0 performance improvements and 1 performance regressions! Performance is the same for 11 metrics, 16 unstable metrics.

scenario Δ mean http_req_duration Δ mean throughput candidate mean http_req_duration candidate mean throughput baseline mean http_req_duration baseline mean throughput
scenario:load:petclinic:profiling worse
[+39.505µs; +91.373µs] or [+2.667%; +6.170%]		 unstable
[-654.168op/s; +408.014op/s] or [-20.443%; +12.750%]		 1.546ms 3076.923op/s 1.481ms 3200.000op/s
Request duration reports for insecure-bank 
gantt
    title insecure-bank - request duration [CI 0.99] : candidate=1.43.0-SNAPSHOT~c055807dbd, baseline=1.43.0-SNAPSHOT~137948ff59
    dateFormat X
    axisFormat %s
section baseline
no_agent (382.146 µs) : 355, 409
.   : milestone, 382,
iast (490.133 µs) : 469, 511
.   : milestone, 490,
iast_FULL (642.212 µs) : 621, 664
.   : milestone, 642,
iast_GLOBAL (509.104 µs) : 488, 530
.   : milestone, 509,
iast_HARDCODED_SECRET_DISABLED (485.142 µs) : 464, 506
.   : milestone, 485,
iast_INACTIVE (450.183 µs) : 429, 471
.   : milestone, 450,
iast_TELEMETRY_OFF (483.105 µs) : 462, 505
.   : milestone, 483,
tracing (441.427 µs) : 421, 462
.   : milestone, 441,
section candidate
no_agent (372.847 µs) : 353, 392
.   : milestone, 373,
iast (493.599 µs) : 472, 515
.   : milestone, 494,
iast_FULL (643.213 µs) : 622, 665
.   : milestone, 643,
iast_GLOBAL (507.025 µs) : 486, 528
.   : milestone, 507,
iast_HARDCODED_SECRET_DISABLED (484.382 µs) : 463, 506
.   : milestone, 484,
iast_INACTIVE (443.663 µs) : 423, 464
.   : milestone, 444,
iast_TELEMETRY_OFF (476.567 µs) : 455, 498
.   : milestone, 477,
tracing (443.316 µs) : 422, 465
.   : milestone, 443,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 382.146 µs [355.48 µs, 408.812 µs] -
iast 490.133 µs [468.833 µs, 511.433 µs] 107.987 µs (28.3%)
iast_FULL 642.212 µs [620.843 µs, 663.582 µs] 260.067 µs (68.1%)
iast_GLOBAL 509.104 µs [488.042 µs, 530.167 µs] 126.959 µs (33.2%)
iast_HARDCODED_SECRET_DISABLED 485.142 µs [463.989 µs, 506.294 µs] 102.996 µs (27.0%)
iast_INACTIVE 450.183 µs [429.309 µs, 471.057 µs] 68.037 µs (17.8%)
iast_TELEMETRY_OFF 483.105 µs [461.532 µs, 504.679 µs] 100.96 µs (26.4%)
tracing 441.427 µs [420.898 µs, 461.956 µs] 59.281 µs (15.5%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 372.847 µs [353.27 µs, 392.424 µs] -
iast 493.599 µs [472.123 µs, 515.076 µs] 120.752 µs (32.4%)
iast_FULL 643.213 µs [621.671 µs, 664.756 µs] 270.366 µs (72.5%)
iast_GLOBAL 507.025 µs [485.807 µs, 528.243 µs] 134.178 µs (36.0%)
iast_HARDCODED_SECRET_DISABLED 484.382 µs [462.963 µs, 505.8 µs] 111.534 µs (29.9%)
iast_INACTIVE 443.663 µs [423.227 µs, 464.1 µs] 70.816 µs (19.0%)
iast_TELEMETRY_OFF 476.567 µs [455.416 µs, 497.719 µs] 103.72 µs (27.8%)
tracing 443.316 µs [422.092 µs, 464.539 µs] 70.468 µs (18.9%)
Request duration reports for petclinic 
gantt
    title petclinic - request duration [CI 0.99] : candidate=1.43.0-SNAPSHOT~c055807dbd, baseline=1.43.0-SNAPSHOT~137948ff59
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.346 ms) : 1327, 1365
.   : milestone, 1346,
appsec (1.738 ms) : 1713, 1763
.   : milestone, 1738,
appsec_no_iast (1.752 ms) : 1727, 1777
.   : milestone, 1752,
iast (1.481 ms) : 1459, 1504
.   : milestone, 1481,
profiling (1.481 ms) : 1458, 1504
.   : milestone, 1481,
tracing (1.459 ms) : 1434, 1484
.   : milestone, 1459,
section candidate
no_agent (1.334 ms) : 1314, 1354
.   : milestone, 1334,
appsec (1.748 ms) : 1724, 1771
.   : milestone, 1748,
appsec_no_iast (1.717 ms) : 1692, 1742
.   : milestone, 1717,
iast (1.491 ms) : 1468, 1514
.   : milestone, 1491,
profiling (1.546 ms) : 1522, 1571
.   : milestone, 1546,
tracing (1.466 ms) : 1442, 1491
.   : milestone, 1466,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.346 ms [1.327 ms, 1.365 ms] -
appsec 1.738 ms [1.713 ms, 1.763 ms] 392.096 µs (29.1%)
appsec_no_iast 1.752 ms [1.727 ms, 1.777 ms] 406.03 µs (30.2%)
iast 1.481 ms [1.459 ms, 1.504 ms] 135.652 µs (10.1%)
profiling 1.481 ms [1.458 ms, 1.504 ms] 135.344 µs (10.1%)
tracing 1.459 ms [1.434 ms, 1.484 ms] 112.971 µs (8.4%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.334 ms [1.314 ms, 1.354 ms] -
appsec 1.748 ms [1.724 ms, 1.771 ms] 413.362 µs (31.0%)
appsec_no_iast 1.717 ms [1.692 ms, 1.742 ms] 382.577 µs (28.7%)
iast 1.491 ms [1.468 ms, 1.514 ms] 156.267 µs (11.7%)
profiling 1.546 ms [1.522 ms, 1.571 ms] 212.171 µs (15.9%)
tracing 1.466 ms [1.442 ms, 1.491 ms] 132.003 µs (9.9%)

Dacapo

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master mattalp/standardize-sampling-frequencies
git_commit_date 1732022072 1732049825
git_commit_sha 137948f c055807
release_version 1.43.0-SNAPSHOT~137948ff59 1.43.0-SNAPSHOT~c055807dbd
See matching parameters
Baseline Candidate
application biojava biojava
ci_job_date 1732051803 1732051803
ci_job_id 713008356 713008356
ci_pipeline_id 49434951 49434951
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
variant appsec appsec

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 1 unstable metrics.

Execution time for biojava 
gantt
    title biojava - execution time [CI 0.99] : candidate=1.43.0-SNAPSHOT~c055807dbd, baseline=1.43.0-SNAPSHOT~137948ff59
    dateFormat X
    axisFormat %s
section baseline
no_agent (15.805 s) : 15805000, 15805000
.   : milestone, 15805000,
appsec (15.228 s) : 15228000, 15228000
.   : milestone, 15228000,
iast (18.848 s) : 18848000, 18848000
.   : milestone, 18848000,
iast_GLOBAL (17.887 s) : 17887000, 17887000
.   : milestone, 17887000,
profiling (15.211 s) : 15211000, 15211000
.   : milestone, 15211000,
tracing (15.178 s) : 15178000, 15178000
.   : milestone, 15178000,
section candidate
no_agent (14.902 s) : 14902000, 14902000
.   : milestone, 14902000,
appsec (15.294 s) : 15294000, 15294000
.   : milestone, 15294000,
iast (18.683 s) : 18683000, 18683000
.   : milestone, 18683000,
iast_GLOBAL (18.414 s) : 18414000, 18414000
.   : milestone, 18414000,
profiling (14.976 s) : 14976000, 14976000
.   : milestone, 14976000,
tracing (14.864 s) : 14864000, 14864000
.   : milestone, 14864000,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 15.805 s [15.805 s, 15.805 s] -
appsec 15.228 s [15.228 s, 15.228 s] -577.0 ms (-3.7%)
iast 18.848 s [18.848 s, 18.848 s] 3.043 s (19.3%)
iast_GLOBAL 17.887 s [17.887 s, 17.887 s] 2.082 s (13.2%)
profiling 15.211 s [15.211 s, 15.211 s] -594.0 ms (-3.8%)
tracing 15.178 s [15.178 s, 15.178 s] -627.0 ms (-4.0%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 14.902 s [14.902 s, 14.902 s] -
appsec 15.294 s [15.294 s, 15.294 s] 392.0 ms (2.6%)
iast 18.683 s [18.683 s, 18.683 s] 3.781 s (25.4%)
iast_GLOBAL 18.414 s [18.414 s, 18.414 s] 3.512 s (23.6%)
profiling 14.976 s [14.976 s, 14.976 s] 74.0 ms (0.5%)
tracing 14.864 s [14.864 s, 14.864 s] -38.0 ms (-0.3%)
Execution time for tomcat 
gantt
    title tomcat - execution time [CI 0.99] : candidate=1.43.0-SNAPSHOT~c055807dbd, baseline=1.43.0-SNAPSHOT~137948ff59
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.462 ms) : 1450, 1473
.   : milestone, 1462,
appsec (2.336 ms) : 2294, 2377
.   : milestone, 2336,
iast (2.066 ms) : 2014, 2117
.   : milestone, 2066,
iast_GLOBAL (2.108 ms) : 2056, 2160
.   : milestone, 2108,
profiling (1.942 ms) : 1899, 1986
.   : milestone, 1942,
tracing (1.906 ms) : 1867, 1946
.   : milestone, 1906,
section candidate
no_agent (1.466 ms) : 1455, 1478
.   : milestone, 1466,
appsec (2.336 ms) : 2295, 2377
.   : milestone, 2336,
iast (2.087 ms) : 2034, 2139
.   : milestone, 2087,
iast_GLOBAL (2.117 ms) : 2064, 2169
.   : milestone, 2117,
profiling (2.426 ms) : 2234, 2617
.   : milestone, 2426,
tracing (1.914 ms) : 1874, 1954
.   : milestone, 1914,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.462 ms [1.45 ms, 1.473 ms] -
appsec 2.336 ms [2.294 ms, 2.377 ms] 874.175 µs (59.8%)
iast 2.066 ms [2.014 ms, 2.117 ms] 603.991 µs (41.3%)
iast_GLOBAL 2.108 ms [2.056 ms, 2.16 ms] 646.628 µs (44.2%)
profiling 1.942 ms [1.899 ms, 1.986 ms] 480.843 µs (32.9%)
tracing 1.906 ms [1.867 ms, 1.946 ms] 444.786 µs (30.4%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.466 ms [1.455 ms, 1.478 ms] -
appsec 2.336 ms [2.295 ms, 2.377 ms] 869.712 µs (59.3%)
iast 2.087 ms [2.034 ms, 2.139 ms] 620.328 µs (42.3%)
iast_GLOBAL 2.117 ms [2.064 ms, 2.169 ms] 650.152 µs (44.3%)
profiling 2.426 ms [2.234 ms, 2.617 ms] 959.136 µs (65.4%)
tracing 1.914 ms [1.874 ms, 1.954 ms] 447.572 µs (30.5%)

jbachorik
jbachorik requested changes Nov 15, 2024
View reviewed changes
...t-profiling/profiling-ddprof/src/main/java/com/datadog/profiling/ddprof/DatadogProfiler.java Outdated Show resolved Hide resolved
...t-profiling/profiling-ddprof/src/main/java/com/datadog/profiling/ddprof/DatadogProfiler.java Outdated
@@ -258,6 +258,8 @@ String cmdStartProfiling(Path file) throws IllegalStateException {
}
if (profilingModes.contains(CPU)) {
// cpu profiling is enabled.
final int DEFAULT_J9_CPU_SAMPLING_FREQUENCY = 50;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you pull this up to ProfilingConfig constant?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, though we use this area for the configurable settings (i.e. wall interval name + wall interval default), hence the original inline constant def

@jbachorik
Copy link
Contributor

Gentle ping?

@MattAlp MattAlp merged commit 270a82d into master Nov 20, 2024
102 checks passed
@MattAlp MattAlp deleted the mattalp/standardize-sampling-frequencies branch November 20, 2024 14:12
@github-actions github-actions bot added this to the 1.43.0 milestone Nov 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@datadog-datadog-prod-us1 datadog-datadog-prod-us1[bot] datadog-datadog-prod-us1[bot] left review comments

@jbachorik jbachorik jbachorik approved these changes

@smola smola Awaiting requested review from smola smola is a code owner automatically assigned from DataDog/apm-java

Assignees
No one assigned
Labels
comp: profiling Profiling type: bug type: enhancement
Projects
None yet
Milestone
1.43.0
Development

Successfully merging this pull request may close these issues.
2 participants
@MattAlp @jbachorik