Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve crashtracking support for older Bash versions #7956

Merged
merged 1 commit into from
Nov 21, 2024
Merged

Improve crashtracking support for older Bash versions #7956

merged 1 commit into from
Nov 21, 2024

Conversation

PerfectSlayer
Copy link
Contributor

@PerfectSlayer PerfectSlayer commented Nov 14, 2024 •
edited
Loading

What Does This Do

This PR fixes case when Bash associative array are not supported as associative arrays require Bash 4.
I replaced them with dynamic variable names.

Motivation

It was reported by @dougqh encountering issues with its dev environment.

Additional Notes

Contributor Checklist

Jira ticket: [PROJ-IDENT]

@PerfectSlayer
fix(crashtracking): Fix case when Bash associative array are not supp…
9a707fd 
…orted

Associative arrays require Bash 4.
I replaced them with dynamic variable names.
@PerfectSlayer PerfectSlayer requested a review from a team as a code owner November 14, 2024 15:04
@PerfectSlayer PerfectSlayer requested a review from dougqh November 14, 2024 15:04
@PerfectSlayer PerfectSlayer changed the title Improve crashtracking support for older Bash version Improve crashtracking support for older Bash versions Nov 14, 2024
@pr-commenter
Copy link

pr-commenter bot commented Nov 14, 2024

Benchmarks

Startup

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master bbujon/crashtracking
git_commit_date 1731594304 1731596364
git_commit_sha ea008a2 9a707fd
release_version 1.43.0-SNAPSHOT~ea008a2aad 1.43.0-SNAPSHOT~9a707fd11e
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1731598916 1731598916
ci_job_id 707102991 707102991
ci_pipeline_id 49020947 49020947
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
module Agent Agent
parent None None
variant iast iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 53 metrics, 10 unstable metrics.

Startup time reports for petclinic 
gantt
    title petclinic - global startup overhead: candidate=1.43.0-SNAPSHOT~9a707fd11e, baseline=1.43.0-SNAPSHOT~ea008a2aad

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.083 s) : 0, 1082905
Total [baseline] (10.412 s) : 0, 10411561
Agent [candidate] (1.081 s) : 0, 1080830
Total [candidate] (10.407 s) : 0, 10407279
section appsec
Agent [baseline] (1.215 s) : 0, 1214781
Total [baseline] (10.695 s) : 0, 10694781
Agent [candidate] (1.218 s) : 0, 1218006
Total [candidate] (10.68 s) : 0, 10679706
section iast
Agent [baseline] (1.207 s) : 0, 1207474
Total [baseline] (10.958 s) : 0, 10958035
Agent [candidate] (1.208 s) : 0, 1208308
Total [candidate] (10.88 s) : 0, 10880494
section profiling
Agent [baseline] (1.278 s) : 0, 1277732
Total [baseline] (10.685 s) : 0, 10685019
Agent [candidate] (1.296 s) : 0, 1295991
Total [candidate] (10.835 s) : 0, 10835475
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.083 s -
Agent appsec 1.215 s 131.877 ms (12.2%)
Agent iast 1.207 s 124.57 ms (11.5%)
Agent profiling 1.278 s 194.827 ms (18.0%)
Total tracing 10.412 s -
Total appsec 10.695 s 283.22 ms (2.7%)
Total iast 10.958 s 546.474 ms (5.2%)
Total profiling 10.685 s 273.458 ms (2.6%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.081 s -
Agent appsec 1.218 s 137.176 ms (12.7%)
Agent iast 1.208 s 127.478 ms (11.8%)
Agent profiling 1.296 s 215.161 ms (19.9%)
Total tracing 10.407 s -
Total appsec 10.68 s 272.427 ms (2.6%)
Total iast 10.88 s 473.215 ms (4.5%)
Total profiling 10.835 s 428.196 ms (4.1%) 
gantt
    title petclinic - break down per module: candidate=1.43.0-SNAPSHOT~9a707fd11e, baseline=1.43.0-SNAPSHOT~ea008a2aad

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (688.892 ms) : 0, 688892
BytebuddyAgent [candidate] (686.741 ms) : 0, 686741
GlobalTracer [baseline] (316.01 ms) : 0, 316010
GlobalTracer [candidate] (315.356 ms) : 0, 315356
AppSec [baseline] (54.331 ms) : 0, 54331
AppSec [candidate] (54.252 ms) : 0, 54252
Remote Config [baseline] (675.945 µs) : 0, 676
Remote Config [candidate] (682.451 µs) : 0, 682
Telemetry [baseline] (9.191 ms) : 0, 9191
Telemetry [candidate] (10.06 ms) : 0, 10060
section appsec
BytebuddyAgent [baseline] (703.694 ms) : 0, 703694
BytebuddyAgent [candidate] (706.259 ms) : 0, 706259
GlobalTracer [baseline] (312.503 ms) : 0, 312503
GlobalTracer [candidate] (313.941 ms) : 0, 313941
AppSec [baseline] (166.329 ms) : 0, 166329
AppSec [candidate] (165.156 ms) : 0, 165156
Remote Config [baseline] (632.639 µs) : 0, 633
Remote Config [candidate] (630.886 µs) : 0, 631
Telemetry [baseline] (7.806 ms) : 0, 7806
Telemetry [candidate] (7.767 ms) : 0, 7767
IAST [baseline] (20.264 ms) : 0, 20264
IAST [candidate] (21.008 ms) : 0, 21008
section iast
BytebuddyAgent [baseline] (802.525 ms) : 0, 802525
BytebuddyAgent [candidate] (803.716 ms) : 0, 803716
GlobalTracer [baseline] (305.048 ms) : 0, 305048
GlobalTracer [candidate] (304.696 ms) : 0, 304696
AppSec [baseline] (56.708 ms) : 0, 56708
AppSec [candidate] (57.383 ms) : 0, 57383
Remote Config [baseline] (612.609 µs) : 0, 613
Remote Config [candidate] (611.966 µs) : 0, 612
Telemetry [baseline] (7.485 ms) : 0, 7485
Telemetry [candidate] (7.462 ms) : 0, 7462
IAST [baseline] (21.375 ms) : 0, 21375
IAST [candidate] (20.673 ms) : 0, 20673
section profiling
ProfilingAgent [baseline] (92.831 ms) : 0, 92831
ProfilingAgent [candidate] (93.402 ms) : 0, 93402
BytebuddyAgent [baseline] (680.166 ms) : 0, 680166
BytebuddyAgent [candidate] (689.281 ms) : 0, 689281
GlobalTracer [baseline] (398.641 ms) : 0, 398641
GlobalTracer [candidate] (404.447 ms) : 0, 404447
AppSec [baseline] (54.567 ms) : 0, 54567
AppSec [candidate] (55.763 ms) : 0, 55763
Remote Config [baseline] (669.584 µs) : 0, 670
Remote Config [candidate] (683.889 µs) : 0, 684
Telemetry [baseline] (11.894 ms) : 0, 11894
Telemetry [candidate] (12.965 ms) : 0, 12965
Profiling [baseline] (92.854 ms) : 0, 92854
Profiling [candidate] (93.428 ms) : 0, 93428
Loading
Startup time reports for insecure-bank 
gantt
    title insecure-bank - global startup overhead: candidate=1.43.0-SNAPSHOT~9a707fd11e, baseline=1.43.0-SNAPSHOT~ea008a2aad

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.084 s) : 0, 1083749
Total [baseline] (8.589 s) : 0, 8588692
Agent [candidate] (1.084 s) : 0, 1083741
Total [candidate] (8.596 s) : 0, 8595581
section iast
Agent [baseline] (1.207 s) : 0, 1206994
Total [baseline] (9.181 s) : 0, 9181446
Agent [candidate] (1.217 s) : 0, 1217298
Total [candidate] (9.162 s) : 0, 9162184
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.208 s) : 0, 1207558
Total [baseline] (9.122 s) : 0, 9121657
Agent [candidate] (1.208 s) : 0, 1208402
Total [candidate] (9.102 s) : 0, 9101795
section iast_TELEMETRY_OFF
Agent [baseline] (1.206 s) : 0, 1206103
Total [baseline] (9.116 s) : 0, 9115913
Agent [candidate] (1.213 s) : 0, 1213012
Total [candidate] (9.137 s) : 0, 9136845
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.084 s -
Agent iast 1.207 s 123.245 ms (11.4%)
Agent iast_HARDCODED_SECRET_DISABLED 1.208 s 123.809 ms (11.4%)
Agent iast_TELEMETRY_OFF 1.206 s 122.354 ms (11.3%)
Total tracing 8.589 s -
Total iast 9.181 s 592.754 ms (6.9%)
Total iast_HARDCODED_SECRET_DISABLED 9.122 s 532.965 ms (6.2%)
Total iast_TELEMETRY_OFF 9.116 s 527.221 ms (6.1%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.084 s -
Agent iast 1.217 s 133.557 ms (12.3%)
Agent iast_HARDCODED_SECRET_DISABLED 1.208 s 124.662 ms (11.5%)
Agent iast_TELEMETRY_OFF 1.213 s 129.272 ms (11.9%)
Total tracing 8.596 s -
Total iast 9.162 s 566.603 ms (6.6%)
Total iast_HARDCODED_SECRET_DISABLED 9.102 s 506.214 ms (5.9%)
Total iast_TELEMETRY_OFF 9.137 s 541.264 ms (6.3%) 
gantt
    title insecure-bank - break down per module: candidate=1.43.0-SNAPSHOT~9a707fd11e, baseline=1.43.0-SNAPSHOT~ea008a2aad

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (687.955 ms) : 0, 687955
BytebuddyAgent [candidate] (686.48 ms) : 0, 686480
GlobalTracer [baseline] (315.525 ms) : 0, 315525
GlobalTracer [candidate] (317.042 ms) : 0, 317042
AppSec [baseline] (54.336 ms) : 0, 54336
AppSec [candidate] (54.58 ms) : 0, 54580
Remote Config [baseline] (684.879 µs) : 0, 685
Remote Config [candidate] (678.692 µs) : 0, 679
Telemetry [baseline] (11.519 ms) : 0, 11519
Telemetry [candidate] (11.18 ms) : 0, 11180
section iast
BytebuddyAgent [baseline] (802.354 ms) : 0, 802354
BytebuddyAgent [candidate] (810.224 ms) : 0, 810224
GlobalTracer [baseline] (304.068 ms) : 0, 304068
GlobalTracer [candidate] (306.667 ms) : 0, 306667
AppSec [baseline] (58.142 ms) : 0, 58142
AppSec [candidate] (56.769 ms) : 0, 56769
IAST [baseline] (20.534 ms) : 0, 20534
IAST [candidate] (21.64 ms) : 0, 21640
Remote Config [baseline] (615.591 µs) : 0, 616
Remote Config [candidate] (619.278 µs) : 0, 619
Telemetry [baseline] (7.551 ms) : 0, 7551
Telemetry [candidate] (7.469 ms) : 0, 7469
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (803.149 ms) : 0, 803149
BytebuddyAgent [candidate] (802.863 ms) : 0, 802863
GlobalTracer [baseline] (304.437 ms) : 0, 304437
GlobalTracer [candidate] (305.008 ms) : 0, 305008
AppSec [baseline] (57.377 ms) : 0, 57377
AppSec [candidate] (57.817 ms) : 0, 57817
IAST [baseline] (20.69 ms) : 0, 20690
IAST [candidate] (20.765 ms) : 0, 20765
Remote Config [baseline] (618.696 µs) : 0, 619
Remote Config [candidate] (612.811 µs) : 0, 613
Telemetry [baseline] (7.523 ms) : 0, 7523
Telemetry [candidate] (7.533 ms) : 0, 7533
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (801.068 ms) : 0, 801068
BytebuddyAgent [candidate] (806.118 ms) : 0, 806118
GlobalTracer [baseline] (304.855 ms) : 0, 304855
GlobalTracer [candidate] (306.178 ms) : 0, 306178
AppSec [baseline] (57.525 ms) : 0, 57525
AppSec [candidate] (58.299 ms) : 0, 58299
IAST [baseline] (20.944 ms) : 0, 20944
IAST [candidate] (20.454 ms) : 0, 20454
Remote Config [baseline] (593.101 µs) : 0, 593
Remote Config [candidate] (619.775 µs) : 0, 620
Telemetry [baseline] (7.353 ms) : 0, 7353
Telemetry [candidate] (7.465 ms) : 0, 7465
Loading

Load

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
end_time 2024-11-14T15:12:11 2024-11-14T15:19:05
git_branch master bbujon/crashtracking
git_commit_date 1731594304 1731596364
git_commit_sha ea008a2 9a707fd
release_version 1.43.0-SNAPSHOT~ea008a2aad 1.43.0-SNAPSHOT~9a707fd11e
start_time 2024-11-14T15:11:58 2024-11-14T15:18:52
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1731597895 1731597895
ci_job_id 707102992 707102992
ci_pipeline_id 49020947 49020947
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
variant iast iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 16 unstable metrics.

Request duration reports for insecure-bank 
gantt
    title insecure-bank - request duration [CI 0.99] : candidate=1.43.0-SNAPSHOT~9a707fd11e, baseline=1.43.0-SNAPSHOT~ea008a2aad
    dateFormat X
    axisFormat %s
section baseline
no_agent (370.995 µs) : 351, 391
.   : milestone, 371,
iast (484.836 µs) : 463, 506
.   : milestone, 485,
iast_FULL (639.891 µs) : 618, 661
.   : milestone, 640,
iast_GLOBAL (508.261 µs) : 487, 529
.   : milestone, 508,
iast_HARDCODED_SECRET_DISABLED (481.765 µs) : 461, 503
.   : milestone, 482,
iast_INACTIVE (440.774 µs) : 420, 461
.   : milestone, 441,
iast_TELEMETRY_OFF (478.878 µs) : 457, 501
.   : milestone, 479,
tracing (441.783 µs) : 421, 462
.   : milestone, 442,
section candidate
no_agent (368.04 µs) : 348, 388
.   : milestone, 368,
iast (487.114 µs) : 465, 509
.   : milestone, 487,
iast_FULL (650.305 µs) : 629, 672
.   : milestone, 650,
iast_GLOBAL (513.33 µs) : 491, 536
.   : milestone, 513,
iast_HARDCODED_SECRET_DISABLED (493.296 µs) : 472, 515
.   : milestone, 493,
iast_INACTIVE (441.855 µs) : 421, 462
.   : milestone, 442,
iast_TELEMETRY_OFF (475.163 µs) : 454, 497
.   : milestone, 475,
tracing (440.364 µs) : 420, 461
.   : milestone, 440,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 370.995 µs [350.66 µs, 391.33 µs] -
iast 484.836 µs [463.349 µs, 506.323 µs] 113.841 µs (30.7%)
iast_FULL 639.891 µs [618.364 µs, 661.419 µs] 268.897 µs (72.5%)
iast_GLOBAL 508.261 µs [487.21 µs, 529.312 µs] 137.267 µs (37.0%)
iast_HARDCODED_SECRET_DISABLED 481.765 µs [460.809 µs, 502.721 µs] 110.77 µs (29.9%)
iast_INACTIVE 440.774 µs [420.054 µs, 461.494 µs] 69.78 µs (18.8%)
iast_TELEMETRY_OFF 478.878 µs [456.902 µs, 500.855 µs] 107.884 µs (29.1%)
tracing 441.783 µs [421.21 µs, 462.355 µs] 70.788 µs (19.1%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 368.04 µs [348.011 µs, 388.068 µs] -
iast 487.114 µs [465.476 µs, 508.752 µs] 119.075 µs (32.4%)
iast_FULL 650.305 µs [628.93 µs, 671.68 µs] 282.266 µs (76.7%)
iast_GLOBAL 513.33 µs [491.151 µs, 535.509 µs] 145.291 µs (39.5%)
iast_HARDCODED_SECRET_DISABLED 493.296 µs [472.063 µs, 514.53 µs] 125.257 µs (34.0%)
iast_INACTIVE 441.855 µs [421.368 µs, 462.342 µs] 73.816 µs (20.1%)
iast_TELEMETRY_OFF 475.163 µs [453.665 µs, 496.661 µs] 107.124 µs (29.1%)
tracing 440.364 µs [420.144 µs, 460.583 µs] 72.324 µs (19.7%)
Request duration reports for petclinic 
gantt
    title petclinic - request duration [CI 0.99] : candidate=1.43.0-SNAPSHOT~9a707fd11e, baseline=1.43.0-SNAPSHOT~ea008a2aad
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.331 ms) : 1311, 1351
.   : milestone, 1331,
appsec (1.726 ms) : 1704, 1749
.   : milestone, 1726,
appsec_no_iast (1.738 ms) : 1714, 1761
.   : milestone, 1738,
iast (1.472 ms) : 1449, 1495
.   : milestone, 1472,
profiling (1.495 ms) : 1472, 1518
.   : milestone, 1495,
tracing (1.493 ms) : 1469, 1517
.   : milestone, 1493,
section candidate
no_agent (1.355 ms) : 1336, 1374
.   : milestone, 1355,
appsec (1.714 ms) : 1689, 1739
.   : milestone, 1714,
appsec_no_iast (1.722 ms) : 1697, 1747
.   : milestone, 1722,
iast (1.5 ms) : 1478, 1522
.   : milestone, 1500,
profiling (1.508 ms) : 1483, 1533
.   : milestone, 1508,
tracing (1.449 ms) : 1424, 1474
.   : milestone, 1449,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.331 ms [1.311 ms, 1.351 ms] -
appsec 1.726 ms [1.704 ms, 1.749 ms] 395.11 µs (29.7%)
appsec_no_iast 1.738 ms [1.714 ms, 1.761 ms] 406.359 µs (30.5%)
iast 1.472 ms [1.449 ms, 1.495 ms] 140.618 µs (10.6%)
profiling 1.495 ms [1.472 ms, 1.518 ms] 163.552 µs (12.3%)
tracing 1.493 ms [1.469 ms, 1.517 ms] 161.971 µs (12.2%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.355 ms [1.336 ms, 1.374 ms] -
appsec 1.714 ms [1.689 ms, 1.739 ms] 358.998 µs (26.5%)
appsec_no_iast 1.722 ms [1.697 ms, 1.747 ms] 366.616 µs (27.1%)
iast 1.5 ms [1.478 ms, 1.522 ms] 144.943 µs (10.7%)
profiling 1.508 ms [1.483 ms, 1.533 ms] 152.85 µs (11.3%)
tracing 1.449 ms [1.424 ms, 1.474 ms] 93.795 µs (6.9%)

Dacapo

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master bbujon/crashtracking
git_commit_date 1731594304 1731596364
git_commit_sha ea008a2 9a707fd
release_version 1.43.0-SNAPSHOT~ea008a2aad 1.43.0-SNAPSHOT~9a707fd11e
See matching parameters
Baseline Candidate
application biojava biojava
ci_job_date 1731598433 1731598433
ci_job_id 707102993 707102993
ci_pipeline_id 49020947 49020947
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
variant appsec appsec

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics.

Execution time for tomcat 
gantt
    title tomcat - execution time [CI 0.99] : candidate=1.43.0-SNAPSHOT~9a707fd11e, baseline=1.43.0-SNAPSHOT~ea008a2aad
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.464 ms) : 1452, 1475
.   : milestone, 1464,
appsec (2.333 ms) : 2292, 2375
.   : milestone, 2333,
iast (2.074 ms) : 2022, 2126
.   : milestone, 2074,
iast_GLOBAL (2.124 ms) : 2072, 2176
.   : milestone, 2124,
profiling (1.944 ms) : 1902, 1986
.   : milestone, 1944,
tracing (1.92 ms) : 1880, 1960
.   : milestone, 1920,
section candidate
no_agent (1.464 ms) : 1453, 1476
.   : milestone, 1464,
appsec (2.321 ms) : 2280, 2361
.   : milestone, 2321,
iast (2.073 ms) : 2021, 2125
.   : milestone, 2073,
iast_GLOBAL (2.106 ms) : 2054, 2158
.   : milestone, 2106,
profiling (1.925 ms) : 1884, 1966
.   : milestone, 1925,
tracing (1.922 ms) : 1882, 1962
.   : milestone, 1922,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.464 ms [1.452 ms, 1.475 ms] -
appsec 2.333 ms [2.292 ms, 2.375 ms] 869.506 µs (59.4%)
iast 2.074 ms [2.022 ms, 2.126 ms] 610.227 µs (41.7%)
iast_GLOBAL 2.124 ms [2.072 ms, 2.176 ms] 660.32 µs (45.1%)
profiling 1.944 ms [1.902 ms, 1.986 ms] 479.884 µs (32.8%)
tracing 1.92 ms [1.88 ms, 1.96 ms] 455.895 µs (31.1%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.464 ms [1.453 ms, 1.476 ms] -
appsec 2.321 ms [2.28 ms, 2.361 ms] 856.39 µs (58.5%)
iast 2.073 ms [2.021 ms, 2.125 ms] 609.113 µs (41.6%)
iast_GLOBAL 2.106 ms [2.054 ms, 2.158 ms] 641.876 µs (43.8%)
profiling 1.925 ms [1.884 ms, 1.966 ms] 460.917 µs (31.5%)
tracing 1.922 ms [1.882 ms, 1.962 ms] 457.627 µs (31.3%)
Execution time for biojava 
gantt
    title biojava - execution time [CI 0.99] : candidate=1.43.0-SNAPSHOT~9a707fd11e, baseline=1.43.0-SNAPSHOT~ea008a2aad
    dateFormat X
    axisFormat %s
section baseline
no_agent (15.721 s) : 15721000, 15721000
.   : milestone, 15721000,
appsec (15.373 s) : 15373000, 15373000
.   : milestone, 15373000,
iast (19.173 s) : 19173000, 19173000
.   : milestone, 19173000,
iast_GLOBAL (18.262 s) : 18262000, 18262000
.   : milestone, 18262000,
profiling (15.032 s) : 15032000, 15032000
.   : milestone, 15032000,
tracing (15.251 s) : 15251000, 15251000
.   : milestone, 15251000,
section candidate
no_agent (14.98 s) : 14980000, 14980000
.   : milestone, 14980000,
appsec (15.166 s) : 15166000, 15166000
.   : milestone, 15166000,
iast (18.924 s) : 18924000, 18924000
.   : milestone, 18924000,
iast_GLOBAL (18.085 s) : 18085000, 18085000
.   : milestone, 18085000,
profiling (15.832 s) : 15832000, 15832000
.   : milestone, 15832000,
tracing (15.239 s) : 15239000, 15239000
.   : milestone, 15239000,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 15.721 s [15.721 s, 15.721 s] -
appsec 15.373 s [15.373 s, 15.373 s] -348.0 ms (-2.2%)
iast 19.173 s [19.173 s, 19.173 s] 3.452 s (22.0%)
iast_GLOBAL 18.262 s [18.262 s, 18.262 s] 2.541 s (16.2%)
profiling 15.032 s [15.032 s, 15.032 s] -689.0 ms (-4.4%)
tracing 15.251 s [15.251 s, 15.251 s] -470.0 ms (-3.0%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 14.98 s [14.98 s, 14.98 s] -
appsec 15.166 s [15.166 s, 15.166 s] 186.0 ms (1.2%)
iast 18.924 s [18.924 s, 18.924 s] 3.944 s (26.3%)
iast_GLOBAL 18.085 s [18.085 s, 18.085 s] 3.105 s (20.7%)
profiling 15.832 s [15.832 s, 15.832 s] 852.0 ms (5.7%)
tracing 15.239 s [15.239 s, 15.239 s] 259.0 ms (1.7%)

@PerfectSlayer PerfectSlayer mentioned this pull request Nov 21, 2024
Merged
@PerfectSlayer PerfectSlayer merged commit 3618cef into master Nov 21, 2024
111 checks passed
@PerfectSlayer PerfectSlayer deleted the bbujon/crashtracking branch November 21, 2024 15:30
@github-actions github-actions bot added this to the 1.43.0 milestone Nov 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jbachorik jbachorik jbachorik approved these changes

@dougqh dougqh Awaiting requested review from dougqh

Assignees
No one assigned
Labels
comp: crash tracking Crash tracking type: bug
Projects
None yet
Milestone
1.43.0
Development

Successfully merging this pull request may close these issues.
2 participants
@PerfectSlayer @jbachorik