-
Notifications
You must be signed in to change notification settings - Fork 292
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Collect git metadata for telemetry #7951
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collect git metadata (git repository url and git commit sha) to be sent with app-started event by telemetry
smola
approved these changes
Nov 14, 2024
manuel-alvarez-alvarez
approved these changes
Nov 14, 2024
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 52 metrics, 11 unstable metrics. Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.43.0-SNAPSHOT~926d655f74, baseline=1.43.0-SNAPSHOT~ed1371858a
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.084 s) : 0, 1083704
Total [baseline] (10.42 s) : 0, 10419890
Agent [candidate] (1.083 s) : 0, 1082689
Total [candidate] (10.385 s) : 0, 10384526
section appsec
Agent [baseline] (1.218 s) : 0, 1218266
Total [baseline] (10.726 s) : 0, 10725975
Agent [candidate] (1.237 s) : 0, 1236532
Total [candidate] (10.747 s) : 0, 10746552
section iast
Agent [baseline] (1.213 s) : 0, 1213300
Total [baseline] (10.93 s) : 0, 10929611
Agent [candidate] (1.212 s) : 0, 1211701
Total [candidate] (10.907 s) : 0, 10907265
section profiling
Agent [baseline] (1.281 s) : 0, 1281464
Total [baseline] (10.733 s) : 0, 10733019
Agent [candidate] (1.291 s) : 0, 1290957
Total [candidate] (10.771 s) : 0, 10771097
gantt
title petclinic - break down per module: candidate=1.43.0-SNAPSHOT~926d655f74, baseline=1.43.0-SNAPSHOT~ed1371858a
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (688.788 ms) : 0, 688788
BytebuddyAgent [candidate] (687.699 ms) : 0, 687699
GlobalTracer [baseline] (316.558 ms) : 0, 316558
GlobalTracer [candidate] (316.15 ms) : 0, 316150
AppSec [baseline] (54.5 ms) : 0, 54500
AppSec [candidate] (54.387 ms) : 0, 54387
Remote Config [baseline] (677.332 µs) : 0, 677
Remote Config [candidate] (675.527 µs) : 0, 676
Telemetry [baseline] (9.386 ms) : 0, 9386
Telemetry [candidate] (10.021 ms) : 0, 10021
section appsec
BytebuddyAgent [baseline] (705.066 ms) : 0, 705066
BytebuddyAgent [candidate] (716.936 ms) : 0, 716936
GlobalTracer [baseline] (314.108 ms) : 0, 314108
GlobalTracer [candidate] (318.805 ms) : 0, 318805
AppSec [baseline] (167.84 ms) : 0, 167840
AppSec [candidate] (168.416 ms) : 0, 168416
Remote Config [baseline] (647.887 µs) : 0, 648
Remote Config [candidate] (644.968 µs) : 0, 645
Telemetry [baseline] (7.506 ms) : 0, 7506
Telemetry [candidate] (7.883 ms) : 0, 7883
IAST [baseline] (18.696 ms) : 0, 18696
IAST [candidate] (19.698 ms) : 0, 19698
section iast
BytebuddyAgent [baseline] (806.128 ms) : 0, 806128
BytebuddyAgent [candidate] (804.646 ms) : 0, 804646
GlobalTracer [baseline] (306.304 ms) : 0, 306304
GlobalTracer [candidate] (306.137 ms) : 0, 306137
AppSec [baseline] (56.547 ms) : 0, 56547
AppSec [candidate] (55.564 ms) : 0, 55564
Remote Config [baseline] (628.494 µs) : 0, 628
Remote Config [candidate] (628.455 µs) : 0, 628
Telemetry [baseline] (7.592 ms) : 0, 7592
Telemetry [candidate] (7.51 ms) : 0, 7510
IAST [baseline] (22.294 ms) : 0, 22294
IAST [candidate] (23.425 ms) : 0, 23425
section profiling
ProfilingAgent [baseline] (92.373 ms) : 0, 92373
ProfilingAgent [candidate] (92.133 ms) : 0, 92133
BytebuddyAgent [baseline] (681.571 ms) : 0, 681571
BytebuddyAgent [candidate] (687.081 ms) : 0, 687081
GlobalTracer [baseline] (400.867 ms) : 0, 400867
GlobalTracer [candidate] (402.821 ms) : 0, 402821
AppSec [baseline] (54.736 ms) : 0, 54736
AppSec [candidate] (55.274 ms) : 0, 55274
Remote Config [baseline] (665.22 µs) : 0, 665
Remote Config [candidate] (674.291 µs) : 0, 674
Telemetry [baseline] (12.145 ms) : 0, 12145
Telemetry [candidate] (13.571 ms) : 0, 13571
Profiling [baseline] (92.396 ms) : 0, 92396
Profiling [candidate] (92.157 ms) : 0, 92157
Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.43.0-SNAPSHOT~926d655f74, baseline=1.43.0-SNAPSHOT~ed1371858a
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.082 s) : 0, 1081918
Total [baseline] (8.575 s) : 0, 8575326
Agent [candidate] (1.097 s) : 0, 1097190
Total [candidate] (8.632 s) : 0, 8632432
section iast
Agent [baseline] (1.211 s) : 0, 1211254
Total [baseline] (9.139 s) : 0, 9138798
Agent [candidate] (1.217 s) : 0, 1217146
Total [candidate] (9.191 s) : 0, 9191269
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.215 s) : 0, 1215359
Total [baseline] (9.111 s) : 0, 9110820
Agent [candidate] (1.219 s) : 0, 1219128
Total [candidate] (9.175 s) : 0, 9175051
section iast_TELEMETRY_OFF
Agent [baseline] (1.205 s) : 0, 1205312
Total [baseline] (9.156 s) : 0, 9156208
Agent [candidate] (1.228 s) : 0, 1228121
Total [candidate] (9.15 s) : 0, 9150048
gantt
title insecure-bank - break down per module: candidate=1.43.0-SNAPSHOT~926d655f74, baseline=1.43.0-SNAPSHOT~ed1371858a
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (687.221 ms) : 0, 687221
BytebuddyAgent [candidate] (697.682 ms) : 0, 697682
GlobalTracer [baseline] (315.895 ms) : 0, 315895
GlobalTracer [candidate] (319.721 ms) : 0, 319721
AppSec [baseline] (54.26 ms) : 0, 54260
AppSec [candidate] (55.074 ms) : 0, 55074
Remote Config [baseline] (675.858 µs) : 0, 676
Remote Config [candidate] (690.396 µs) : 0, 690
Telemetry [baseline] (10.095 ms) : 0, 10095
Telemetry [candidate] (10.023 ms) : 0, 10023
section iast
BytebuddyAgent [baseline] (804.793 ms) : 0, 804793
BytebuddyAgent [candidate] (809.771 ms) : 0, 809771
GlobalTracer [baseline] (305.644 ms) : 0, 305644
GlobalTracer [candidate] (306.789 ms) : 0, 306789
AppSec [baseline] (56.493 ms) : 0, 56493
AppSec [candidate] (57.661 ms) : 0, 57661
Remote Config [baseline] (647.396 µs) : 0, 647
Remote Config [candidate] (623.301 µs) : 0, 623
Telemetry [baseline] (7.54 ms) : 0, 7540
Telemetry [candidate] (7.529 ms) : 0, 7529
IAST [baseline] (22.28 ms) : 0, 22280
IAST [candidate] (20.895 ms) : 0, 20895
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (807.588 ms) : 0, 807588
BytebuddyAgent [candidate] (809.812 ms) : 0, 809812
GlobalTracer [baseline] (307.0 ms) : 0, 307000
GlobalTracer [candidate] (308.036 ms) : 0, 308036
AppSec [baseline] (55.618 ms) : 0, 55618
AppSec [candidate] (58.377 ms) : 0, 58377
Remote Config [baseline] (1.407 ms) : 0, 1407
Remote Config [candidate] (608.178 µs) : 0, 608
Telemetry [baseline] (7.574 ms) : 0, 7574
Telemetry [candidate] (7.582 ms) : 0, 7582
IAST [baseline] (22.37 ms) : 0, 22370
IAST [candidate] (20.779 ms) : 0, 20779
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (800.153 ms) : 0, 800153
BytebuddyAgent [candidate] (816.232 ms) : 0, 816232
GlobalTracer [baseline] (305.056 ms) : 0, 305056
GlobalTracer [candidate] (310.397 ms) : 0, 310397
AppSec [baseline] (57.076 ms) : 0, 57076
AppSec [candidate] (57.12 ms) : 0, 57120
Remote Config [baseline] (607.907 µs) : 0, 608
Remote Config [candidate] (604.913 µs) : 0, 605
Telemetry [baseline] (7.365 ms) : 0, 7365
Telemetry [candidate] (7.439 ms) : 0, 7439
IAST [baseline] (21.269 ms) : 0, 21269
IAST [candidate] (22.227 ms) : 0, 22227
LoadParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 16 unstable metrics. Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.43.0-SNAPSHOT~926d655f74, baseline=1.43.0-SNAPSHOT~ed1371858a
dateFormat X
axisFormat %s
section baseline
no_agent (373.782 µs) : 354, 394
. : milestone, 374,
iast (487.903 µs) : 467, 509
. : milestone, 488,
iast_FULL (643.819 µs) : 623, 665
. : milestone, 644,
iast_GLOBAL (523.514 µs) : 500, 547
. : milestone, 524,
iast_HARDCODED_SECRET_DISABLED (491.384 µs) : 470, 513
. : milestone, 491,
iast_INACTIVE (449.088 µs) : 428, 470
. : milestone, 449,
iast_TELEMETRY_OFF (472.336 µs) : 451, 494
. : milestone, 472,
tracing (442.645 µs) : 422, 463
. : milestone, 443,
section candidate
no_agent (372.92 µs) : 354, 392
. : milestone, 373,
iast (488.816 µs) : 467, 510
. : milestone, 489,
iast_FULL (643.726 µs) : 623, 665
. : milestone, 644,
iast_GLOBAL (514.986 µs) : 493, 537
. : milestone, 515,
iast_HARDCODED_SECRET_DISABLED (489.909 µs) : 468, 511
. : milestone, 490,
iast_INACTIVE (446.927 µs) : 426, 468
. : milestone, 447,
iast_TELEMETRY_OFF (482.388 µs) : 461, 504
. : milestone, 482,
tracing (446.85 µs) : 426, 468
. : milestone, 447,
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.43.0-SNAPSHOT~926d655f74, baseline=1.43.0-SNAPSHOT~ed1371858a
dateFormat X
axisFormat %s
section baseline
no_agent (1.328 ms) : 1309, 1348
. : milestone, 1328,
appsec (1.739 ms) : 1715, 1763
. : milestone, 1739,
appsec_no_iast (1.717 ms) : 1692, 1741
. : milestone, 1717,
iast (1.485 ms) : 1462, 1508
. : milestone, 1485,
profiling (1.497 ms) : 1474, 1519
. : milestone, 1497,
tracing (1.487 ms) : 1463, 1511
. : milestone, 1487,
section candidate
no_agent (1.335 ms) : 1316, 1354
. : milestone, 1335,
appsec (1.742 ms) : 1720, 1765
. : milestone, 1742,
appsec_no_iast (1.736 ms) : 1712, 1760
. : milestone, 1736,
iast (1.46 ms) : 1438, 1483
. : milestone, 1460,
profiling (1.489 ms) : 1465, 1513
. : milestone, 1489,
tracing (1.463 ms) : 1438, 1488
. : milestone, 1463,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics. Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.43.0-SNAPSHOT~926d655f74, baseline=1.43.0-SNAPSHOT~ed1371858a
dateFormat X
axisFormat %s
section baseline
no_agent (1.47 ms) : 1458, 1481
. : milestone, 1470,
appsec (2.345 ms) : 2304, 2387
. : milestone, 2345,
iast (2.081 ms) : 2029, 2134
. : milestone, 2081,
iast_GLOBAL (2.117 ms) : 2064, 2169
. : milestone, 2117,
profiling (1.948 ms) : 1905, 1991
. : milestone, 1948,
tracing (1.912 ms) : 1873, 1952
. : milestone, 1912,
section candidate
no_agent (1.473 ms) : 1461, 1484
. : milestone, 1473,
appsec (2.318 ms) : 2277, 2359
. : milestone, 2318,
iast (2.069 ms) : 2017, 2120
. : milestone, 2069,
iast_GLOBAL (2.126 ms) : 2073, 2179
. : milestone, 2126,
profiling (1.935 ms) : 1893, 1977
. : milestone, 1935,
tracing (1.927 ms) : 1887, 1968
. : milestone, 1927,
Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.43.0-SNAPSHOT~926d655f74, baseline=1.43.0-SNAPSHOT~ed1371858a
dateFormat X
axisFormat %s
section baseline
no_agent (15.697 s) : 15697000, 15697000
. : milestone, 15697000,
appsec (14.961 s) : 14961000, 14961000
. : milestone, 14961000,
iast (18.729 s) : 18729000, 18729000
. : milestone, 18729000,
iast_GLOBAL (17.958 s) : 17958000, 17958000
. : milestone, 17958000,
profiling (15.552 s) : 15552000, 15552000
. : milestone, 15552000,
tracing (15.199 s) : 15199000, 15199000
. : milestone, 15199000,
section candidate
no_agent (15.43 s) : 15430000, 15430000
. : milestone, 15430000,
appsec (15.291 s) : 15291000, 15291000
. : milestone, 15291000,
iast (18.857 s) : 18857000, 18857000
. : milestone, 18857000,
iast_GLOBAL (18.262 s) : 18262000, 18262000
. : milestone, 18262000,
profiling (14.82 s) : 14820000, 14820000
. : milestone, 14820000,
tracing (14.942 s) : 14942000, 14942000
. : milestone, 14942000,
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What Does This Do
Collect git metadata (git repository url and git commit sha) to be sent with app-started event by telemetry
Motivation
Having git metadata at startup even without traces, and help onboard for SCI
Additional Notes
Contributor Checklist
type:
and (comp:
orinst:
) labels in addition to any usefull labelsclose
,fix
or any linking keywords when referencing an issue.Use
solves
instead, and assign the PR milestone to the issueJira ticket: DEBUG-2978