[🍒7900] Finish netty span when request is cancelled #7945

vandonr · 2024-11-13T12:19:10Z

Finish netty span when request is cancelled
Propagate channelInactive to next handler

What Does This Do

cherry pick of #7900 for this patch release

JIRA: APMS-13662

* Finish netty span when request is cancelled * Propagate channelInactive to next handler

pr-commenter · 2024-11-13T12:42:38Z

Debugger benchmarks

Parameters

	Baseline	Candidate
baseline_or_candidate	baseline	candidate
ci_job_date	1731515928	1731516304
end_time	2024-11-13T16:40:04	2024-11-13T16:46:19
git_branch	master	raphael.vandon/backport-pr-7900
git_commit_sha	`8d7866c`	`815ccfc`
start_time	2024-11-13T16:38:49	2024-11-13T16:45:05

See matching parameters

	Baseline	Candidate
ci_job_id	705677015	705677015
ci_pipeline_id	48922056	48922056
cpu_model	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
git_commit_date	1731514872	1731514872

Summary

Found 0 performance improvements and 5 performance regressions! Performance is the same for 4 metrics, 6 unstable metrics.

scenario	Δ mean agg_http_req_duration_min	Δ mean agg_http_req_duration_p50	Δ mean agg_http_req_duration_p75	Δ mean agg_http_req_duration_p99	Δ mean throughput
scenario:loop	worse [+325.540µs; +760.114µs] or [+3.197%; +7.465%]	worse [+370.224µs; +831.689µs] or [+3.579%; +8.039%]	worse [+338.799µs; +806.823µs] or [+3.243%; +7.724%]	worse [+174.855µs; +921.309µs] or [+1.602%; +8.443%]	worse [-5.041op/s; -2.015op/s] or [-5.268%; -2.105%]

See unchanged results

scenario	Δ mean agg_http_req_duration_min	Δ mean agg_http_req_duration_p50	Δ mean agg_http_req_duration_p75	Δ mean agg_http_req_duration_p99	Δ mean throughput
scenario:noprobe	unstable [-22344.559ns; +23328.618ns] or [-8.454%; +8.827%]	unstable [-33756.937ns; +34704.191ns] or [-11.145%; +11.458%]	unstable [-45732.662ns; +45423.321ns] or [-14.403%; +14.305%]	unstable [-101.143µs; +89.839µs] or [-16.692%; +14.827%]	same
scenario:basic	unsure [-13.847µs; -1.655µs] or [-4.974%; -0.595%]	same	same	unstable [-65.342µs; +22.336µs] or [-12.090%; +4.133%]	unstable [-149.103op/s; +149.103op/s] or [-5.815%; +5.815%]

Request duration reports for reports

gantt
    title reports - request duration [CI 0.99] : candidate=None, baseline=None
    dateFormat X
    axisFormat %s
section baseline
noprobe (302.876 µs) : 276, 330
.   : milestone, 303,
basic (309.299 µs) : 297, 322
.   : milestone, 309,
loop (10.345 ms) : 10319, 10372
.   : milestone, 10345,
section candidate
noprobe (303.35 µs) : 266, 341
.   : milestone, 303,
basic (300.679 µs) : 293, 309
.   : milestone, 301,
loop (10.946 ms) : 10644, 11248
.   : milestone, 10946,

baseline results

Scenario	Request median duration [CI 0.99]
noprobe	302.876 µs [275.753 µs, 329.999 µs]
basic	309.299 µs [297.095 µs, 321.503 µs]
loop	10.345 ms [10.319 ms, 10.372 ms]

candidate results

Scenario	Request median duration [CI 0.99]
noprobe	303.35 µs [265.986 µs, 340.713 µs]
basic	300.679 µs [292.723 µs, 308.636 µs]
loop	10.946 ms [10.644 ms, 11.248 ms]

pr-commenter · 2024-11-13T12:56:16Z

Kafka / producer-benchmark

Parameters

	Baseline	Candidate
baseline_or_candidate	baseline	candidate
git_branch	release/v1.42.x	raphael.vandon/backport-pr-7900
git_commit_date	1731428107	1731514872
git_commit_sha	`0dde9bd`	`815ccfc`

See matching parameters

	Baseline	Candidate
ci_job_date	1731516394	1731516394
ci_job_id	705677013	705677013
ci_pipeline_id	48922056	48922056
cpu_model	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
jdkVersion	11.0.21	11.0.21
jmhVersion	1.36	1.36
jvm	/usr/lib/jvm/java-11-openjdk-amd64/bin/java	/usr/lib/jvm/java-11-openjdk-amd64/bin/java
jvmArgs	-Dfile.encoding=UTF-8 -Djava.io.tmpdir=/go/src/github.com/DataDog/apm-reliability/dd-trace-java/platform/src/producer-benchmark/build/tmp/jmh -Duser.country=US -Duser.language=en -Duser.variant	-Dfile.encoding=UTF-8 -Djava.io.tmpdir=/go/src/github.com/DataDog/apm-reliability/dd-trace-java/platform/src/producer-benchmark/build/tmp/jmh -Duser.country=US -Duser.language=en -Duser.variant
vmName	OpenJDK 64-Bit Server VM	OpenJDK 64-Bit Server VM
vmVersion	11.0.21+9-post-Ubuntu-0ubuntu122.04	11.0.21+9-post-Ubuntu-0ubuntu122.04

Summary

Found 1 performance improvements and 0 performance regressions! Performance is the same for 2 metrics, 0 unstable metrics.

scenario	Δ mean throughput
scenario:only-tracing-dsm-disabled-benchmarks/KafkaProduceBenchmark.benchProduce	better [+2312.097op/s; +7534.615op/s] or [+1.337%; +4.357%]

See unchanged results

scenario	Δ mean throughput
scenario:not-instrumented/KafkaProduceBenchmark.benchProduce	same
scenario:only-tracing-dsm-enabled-benchmarks/KafkaProduceBenchmark.benchProduce	same

pr-commenter · 2024-11-13T13:03:56Z

Benchmarks

Startup

Parameters

	Baseline	Candidate
baseline_or_candidate	baseline	candidate
git_branch	master	raphael.vandon/backport-pr-7900
git_commit_date	1731513047	1731514872
git_commit_sha	`8d7866c`	`815ccfc`
release_version	1.43.0-SNAPSHOT~8d7866c147	1.43.0-SNAPSHOT~815ccfc964

See matching parameters

	Baseline	Candidate
application	insecure-bank	insecure-bank
ci_job_date	1731517657	1731517657
ci_job_id	705677009	705677009
ci_pipeline_id	48922056	48922056
cpu_model	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
module	Agent	Agent
parent	None	None
variant	iast	iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 52 metrics, 11 unstable metrics.

Startup time reports for insecure-bank

gantt
    title insecure-bank - global startup overhead: candidate=1.43.0-SNAPSHOT~815ccfc964, baseline=1.43.0-SNAPSHOT~8d7866c147

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.089 s) : 0, 1089042
Total [baseline] (8.627 s) : 0, 8627389
Agent [candidate] (1.08 s) : 0, 1080071
Total [candidate] (8.653 s) : 0, 8652924
section iast
Agent [baseline] (1.209 s) : 0, 1208817
Total [baseline] (9.16 s) : 0, 9160132
Agent [candidate] (1.226 s) : 0, 1226444
Total [candidate] (9.215 s) : 0, 9214548
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.22 s) : 0, 1220172
Total [baseline] (9.16 s) : 0, 9159525
Agent [candidate] (1.209 s) : 0, 1208742
Total [candidate] (9.146 s) : 0, 9146251
section iast_TELEMETRY_OFF
Agent [baseline] (1.214 s) : 0, 1214112
Total [baseline] (9.121 s) : 0, 9121389
Agent [candidate] (1.207 s) : 0, 1206973
Total [candidate] (9.169 s) : 0, 9169128

baseline results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.089 s	-
Agent	iast	1.209 s	119.775 ms (11.0%)
Agent	iast_HARDCODED_SECRET_DISABLED	1.22 s	131.13 ms (12.0%)
Agent	iast_TELEMETRY_OFF	1.214 s	125.07 ms (11.5%)
Total	tracing	8.627 s	-
Total	iast	9.16 s	532.743 ms (6.2%)
Total	iast_HARDCODED_SECRET_DISABLED	9.16 s	532.136 ms (6.2%)
Total	iast_TELEMETRY_OFF	9.121 s	494.0 ms (5.7%)

candidate results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.08 s	-
Agent	iast	1.226 s	146.373 ms (13.6%)
Agent	iast_HARDCODED_SECRET_DISABLED	1.209 s	128.671 ms (11.9%)
Agent	iast_TELEMETRY_OFF	1.207 s	126.902 ms (11.7%)
Total	tracing	8.653 s	-
Total	iast	9.215 s	561.624 ms (6.5%)
Total	iast_HARDCODED_SECRET_DISABLED	9.146 s	493.327 ms (5.7%)
Total	iast_TELEMETRY_OFF	9.169 s	516.203 ms (6.0%)

gantt
    title insecure-bank - break down per module: candidate=1.43.0-SNAPSHOT~815ccfc964, baseline=1.43.0-SNAPSHOT~8d7866c147

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (692.001 ms) : 0, 692001
BytebuddyAgent [candidate] (687.013 ms) : 0, 687013
GlobalTracer [baseline] (317.442 ms) : 0, 317442
GlobalTracer [candidate] (315.691 ms) : 0, 315691
AppSec [baseline] (54.419 ms) : 0, 54419
AppSec [candidate] (54.388 ms) : 0, 54388
Remote Config [baseline] (677.86 µs) : 0, 678
Remote Config [candidate] (679.972 µs) : 0, 680
Telemetry [baseline] (10.637 ms) : 0, 10637
Telemetry [candidate] (8.541 ms) : 0, 8541
section iast
BytebuddyAgent [baseline] (803.557 ms) : 0, 803557
BytebuddyAgent [candidate] (815.627 ms) : 0, 815627
GlobalTracer [baseline] (305.057 ms) : 0, 305057
GlobalTracer [candidate] (308.812 ms) : 0, 308812
AppSec [baseline] (57.585 ms) : 0, 57585
AppSec [candidate] (58.604 ms) : 0, 58604
IAST [baseline] (20.672 ms) : 0, 20672
IAST [candidate] (21.086 ms) : 0, 21086
Remote Config [baseline] (628.761 µs) : 0, 629
Remote Config [candidate] (635.107 µs) : 0, 635
Telemetry [baseline] (7.549 ms) : 0, 7549
Telemetry [candidate] (7.696 ms) : 0, 7696
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (812.035 ms) : 0, 812035
BytebuddyAgent [candidate] (802.867 ms) : 0, 802867
GlobalTracer [baseline] (307.119 ms) : 0, 307119
GlobalTracer [candidate] (304.933 ms) : 0, 304933
AppSec [baseline] (57.196 ms) : 0, 57196
AppSec [candidate] (58.068 ms) : 0, 58068
IAST [baseline] (21.72 ms) : 0, 21720
IAST [candidate] (20.792 ms) : 0, 20792
Remote Config [baseline] (617.46 µs) : 0, 617
Remote Config [candidate] (641.163 µs) : 0, 641
Telemetry [baseline] (7.544 ms) : 0, 7544
Telemetry [candidate] (7.616 ms) : 0, 7616
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (807.682 ms) : 0, 807682
BytebuddyAgent [candidate] (800.944 ms) : 0, 800944
GlobalTracer [baseline] (305.666 ms) : 0, 305666
GlobalTracer [candidate] (305.269 ms) : 0, 305269
AppSec [baseline] (57.51 ms) : 0, 57510
AppSec [candidate] (58.639 ms) : 0, 58639
IAST [baseline] (21.298 ms) : 0, 21298
IAST [candidate] (20.259 ms) : 0, 20259
Remote Config [baseline] (621.872 µs) : 0, 622
Remote Config [candidate] (611.952 µs) : 0, 612
Telemetry [baseline] (7.477 ms) : 0, 7477
Telemetry [candidate] (7.452 ms) : 0, 7452

Startup time reports for petclinic

gantt
    title petclinic - global startup overhead: candidate=1.43.0-SNAPSHOT~815ccfc964, baseline=1.43.0-SNAPSHOT~8d7866c147

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.082 s) : 0, 1081734
Total [baseline] (10.416 s) : 0, 10415863
Agent [candidate] (1.094 s) : 0, 1093622
Total [candidate] (10.454 s) : 0, 10454487
section appsec
Agent [baseline] (1.227 s) : 0, 1227469
Total [baseline] (10.729 s) : 0, 10729047
Agent [candidate] (1.225 s) : 0, 1224792
Total [candidate] (10.697 s) : 0, 10696723
section iast
Agent [baseline] (1.21 s) : 0, 1210408
Total [baseline] (10.959 s) : 0, 10958969
Agent [candidate] (1.22 s) : 0, 1220277
Total [candidate] (10.958 s) : 0, 10958476
section profiling
Agent [baseline] (1.281 s) : 0, 1281472
Total [baseline] (10.738 s) : 0, 10738405
Agent [candidate] (1.281 s) : 0, 1281419
Total [candidate] (10.729 s) : 0, 10729165

baseline results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.082 s	-
Agent	appsec	1.227 s	145.734 ms (13.5%)
Agent	iast	1.21 s	128.673 ms (11.9%)
Agent	profiling	1.281 s	199.738 ms (18.5%)
Total	tracing	10.416 s	-
Total	appsec	10.729 s	313.184 ms (3.0%)
Total	iast	10.959 s	543.105 ms (5.2%)
Total	profiling	10.738 s	322.541 ms (3.1%)

candidate results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.094 s	-
Agent	appsec	1.225 s	131.171 ms (12.0%)
Agent	iast	1.22 s	126.656 ms (11.6%)
Agent	profiling	1.281 s	187.797 ms (17.2%)
Total	tracing	10.454 s	-
Total	appsec	10.697 s	242.236 ms (2.3%)
Total	iast	10.958 s	503.989 ms (4.8%)
Total	profiling	10.729 s	274.678 ms (2.6%)

gantt
    title petclinic - break down per module: candidate=1.43.0-SNAPSHOT~815ccfc964, baseline=1.43.0-SNAPSHOT~8d7866c147

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (688.297 ms) : 0, 688297
BytebuddyAgent [candidate] (693.715 ms) : 0, 693715
GlobalTracer [baseline] (315.452 ms) : 0, 315452
GlobalTracer [candidate] (318.961 ms) : 0, 318961
AppSec [baseline] (54.266 ms) : 0, 54266
AppSec [candidate] (54.798 ms) : 0, 54798
Remote Config [baseline] (706.359 µs) : 0, 706
Remote Config [candidate] (690.58 µs) : 0, 691
Telemetry [baseline] (9.298 ms) : 0, 9298
Telemetry [candidate] (11.595 ms) : 0, 11595
section appsec
BytebuddyAgent [baseline] (711.942 ms) : 0, 711942
BytebuddyAgent [candidate] (709.613 ms) : 0, 709613
GlobalTracer [baseline] (316.149 ms) : 0, 316149
GlobalTracer [candidate] (315.326 ms) : 0, 315326
AppSec [baseline] (166.44 ms) : 0, 166440
AppSec [candidate] (167.366 ms) : 0, 167366
Remote Config [baseline] (653.956 µs) : 0, 654
Remote Config [candidate] (650.008 µs) : 0, 650
Telemetry [baseline] (8.25 ms) : 0, 8250
Telemetry [candidate] (8.202 ms) : 0, 8202
IAST [baseline] (20.389 ms) : 0, 20389
IAST [candidate] (19.63 ms) : 0, 19630
section iast
BytebuddyAgent [baseline] (804.219 ms) : 0, 804219
BytebuddyAgent [candidate] (811.26 ms) : 0, 811260
GlobalTracer [baseline] (304.81 ms) : 0, 304810
GlobalTracer [candidate] (307.595 ms) : 0, 307595
AppSec [baseline] (56.758 ms) : 0, 56758
AppSec [candidate] (57.647 ms) : 0, 57647
Remote Config [baseline] (642.401 µs) : 0, 642
Remote Config [candidate] (636.85 µs) : 0, 637
Telemetry [baseline] (7.585 ms) : 0, 7585
Telemetry [candidate] (7.592 ms) : 0, 7592
IAST [baseline] (22.694 ms) : 0, 22694
IAST [candidate] (21.656 ms) : 0, 21656
section profiling
BytebuddyAgent [baseline] (682.229 ms) : 0, 682229
BytebuddyAgent [candidate] (682.536 ms) : 0, 682536
GlobalTracer [baseline] (399.859 ms) : 0, 399859
GlobalTracer [candidate] (400.127 ms) : 0, 400127
AppSec [baseline] (54.906 ms) : 0, 54906
AppSec [candidate] (54.867 ms) : 0, 54867
Remote Config [baseline] (669.712 µs) : 0, 670
Remote Config [candidate] (676.393 µs) : 0, 676
Telemetry [baseline] (12.718 ms) : 0, 12718
Telemetry [candidate] (11.384 ms) : 0, 11384
ProfilingAgent [baseline] (92.004 ms) : 0, 92004
ProfilingAgent [candidate] (92.867 ms) : 0, 92867
Profiling [baseline] (92.028 ms) : 0, 92028
Profiling [candidate] (92.891 ms) : 0, 92891

Load

Parameters

	Baseline	Candidate
baseline_or_candidate	baseline	candidate
end_time	2024-11-13T16:39:53	2024-11-13T16:46:50
git_branch	master	raphael.vandon/backport-pr-7900
git_commit_date	1731513047	1731514872
git_commit_sha	`8d7866c`	`815ccfc`
release_version	1.43.0-SNAPSHOT~8d7866c147	1.43.0-SNAPSHOT~815ccfc964
start_time	2024-11-13T16:39:40	2024-11-13T16:46:36

See matching parameters

	Baseline	Candidate
application	insecure-bank	insecure-bank
ci_job_date	1731516759	1731516759
ci_job_id	705677010	705677010
ci_pipeline_id	48922056	48922056
cpu_model	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
variant	iast	iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 17 unstable metrics.

Request duration reports for insecure-bank

gantt
    title insecure-bank - request duration [CI 0.99] : candidate=1.43.0-SNAPSHOT~815ccfc964, baseline=1.43.0-SNAPSHOT~8d7866c147
    dateFormat X
    axisFormat %s
section baseline
no_agent (372.983 µs) : 352, 394
.   : milestone, 373,
iast (485.342 µs) : 464, 506
.   : milestone, 485,
iast_FULL (643.457 µs) : 622, 665
.   : milestone, 643,
iast_GLOBAL (522.512 µs) : 500, 545
.   : milestone, 523,
iast_HARDCODED_SECRET_DISABLED (484.584 µs) : 463, 506
.   : milestone, 485,
iast_INACTIVE (442.454 µs) : 422, 463
.   : milestone, 442,
iast_TELEMETRY_OFF (484.099 µs) : 462, 506
.   : milestone, 484,
tracing (445.26 µs) : 424, 466
.   : milestone, 445,
section candidate
no_agent (368.108 µs) : 349, 388
.   : milestone, 368,
iast (482.593 µs) : 461, 504
.   : milestone, 483,
iast_FULL (639.207 µs) : 618, 661
.   : milestone, 639,
iast_GLOBAL (524.489 µs) : 501, 548
.   : milestone, 524,
iast_HARDCODED_SECRET_DISABLED (489.291 µs) : 468, 511
.   : milestone, 489,
iast_INACTIVE (442.769 µs) : 422, 464
.   : milestone, 443,
iast_TELEMETRY_OFF (475.045 µs) : 454, 496
.   : milestone, 475,
tracing (448.029 µs) : 427, 469
.   : milestone, 448,

baseline results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	372.983 µs [352.432 µs, 393.534 µs]	-
iast	485.342 µs [464.21 µs, 506.473 µs]	112.359 µs (30.1%)
iast_FULL	643.457 µs [622.105 µs, 664.809 µs]	270.474 µs (72.5%)
iast_GLOBAL	522.512 µs [500.151 µs, 544.872 µs]	149.528 µs (40.1%)
iast_HARDCODED_SECRET_DISABLED	484.584 µs [463.037 µs, 506.13 µs]	111.601 µs (29.9%)
iast_INACTIVE	442.454 µs [422.009 µs, 462.898 µs]	69.471 µs (18.6%)
iast_TELEMETRY_OFF	484.099 µs [462.365 µs, 505.832 µs]	111.116 µs (29.8%)
tracing	445.26 µs [424.385 µs, 466.134 µs]	72.276 µs (19.4%)

candidate results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	368.108 µs [348.601 µs, 387.616 µs]	-
iast	482.593 µs [461.33 µs, 503.855 µs]	114.484 µs (31.1%)
iast_FULL	639.207 µs [617.738 µs, 660.677 µs]	271.099 µs (73.6%)
iast_GLOBAL	524.489 µs [501.22 µs, 547.757 µs]	156.38 µs (42.5%)
iast_HARDCODED_SECRET_DISABLED	489.291 µs [467.972 µs, 510.611 µs]	121.183 µs (32.9%)
iast_INACTIVE	442.769 µs [421.539 µs, 463.998 µs]	74.66 µs (20.3%)
iast_TELEMETRY_OFF	475.045 µs [454.278 µs, 495.812 µs]	106.937 µs (29.1%)
tracing	448.029 µs [426.993 µs, 469.064 µs]	79.92 µs (21.7%)

Request duration reports for petclinic

gantt
    title petclinic - request duration [CI 0.99] : candidate=1.43.0-SNAPSHOT~815ccfc964, baseline=1.43.0-SNAPSHOT~8d7866c147
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.357 ms) : 1338, 1377
.   : milestone, 1357,
appsec (1.719 ms) : 1696, 1743
.   : milestone, 1719,
appsec_no_iast (1.716 ms) : 1692, 1741
.   : milestone, 1716,
iast (1.47 ms) : 1448, 1492
.   : milestone, 1470,
profiling (1.544 ms) : 1520, 1569
.   : milestone, 1544,
tracing (1.483 ms) : 1456, 1510
.   : milestone, 1483,
section candidate
no_agent (1.343 ms) : 1323, 1363
.   : milestone, 1343,
appsec (1.714 ms) : 1690, 1738
.   : milestone, 1714,
appsec_no_iast (1.716 ms) : 1692, 1741
.   : milestone, 1716,
iast (1.485 ms) : 1462, 1507
.   : milestone, 1485,
profiling (1.488 ms) : 1465, 1511
.   : milestone, 1488,
tracing (1.475 ms) : 1450, 1499
.   : milestone, 1475,

baseline results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	1.357 ms [1.338 ms, 1.377 ms]	-
appsec	1.719 ms [1.696 ms, 1.743 ms]	362.053 µs (26.7%)
appsec_no_iast	1.716 ms [1.692 ms, 1.741 ms]	358.781 µs (26.4%)
iast	1.47 ms [1.448 ms, 1.492 ms]	112.507 µs (8.3%)
profiling	1.544 ms [1.52 ms, 1.569 ms]	186.781 µs (13.8%)
tracing	1.483 ms [1.456 ms, 1.51 ms]	125.719 µs (9.3%)

candidate results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	1.343 ms [1.323 ms, 1.363 ms]	-
appsec	1.714 ms [1.69 ms, 1.738 ms]	370.991 µs (27.6%)
appsec_no_iast	1.716 ms [1.692 ms, 1.741 ms]	373.411 µs (27.8%)
iast	1.485 ms [1.462 ms, 1.507 ms]	141.88 µs (10.6%)
profiling	1.488 ms [1.465 ms, 1.511 ms]	145.041 µs (10.8%)
tracing	1.475 ms [1.45 ms, 1.499 ms]	131.473 µs (9.8%)

Dacapo

Parameters

	Baseline	Candidate
baseline_or_candidate	baseline	candidate
git_branch	master	raphael.vandon/backport-pr-7900
git_commit_date	1731513047	1731514872
git_commit_sha	`8d7866c`	`815ccfc`
release_version	1.43.0-SNAPSHOT~8d7866c147	1.43.0-SNAPSHOT~815ccfc964

See matching parameters

	Baseline	Candidate
application	biojava	biojava
ci_job_date	1731517155	1731517155
ci_job_id	705677011	705677011
ci_pipeline_id	48922056	48922056
cpu_model	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
variant	appsec	appsec

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics.

Execution time for biojava

gantt
    title biojava - execution time [CI 0.99] : candidate=1.43.0-SNAPSHOT~815ccfc964, baseline=1.43.0-SNAPSHOT~8d7866c147
    dateFormat X
    axisFormat %s
section baseline
no_agent (15.094 s) : 15094000, 15094000
.   : milestone, 15094000,
appsec (15.343 s) : 15343000, 15343000
.   : milestone, 15343000,
iast (18.216 s) : 18216000, 18216000
.   : milestone, 18216000,
iast_GLOBAL (18.27 s) : 18270000, 18270000
.   : milestone, 18270000,
profiling (15.234 s) : 15234000, 15234000
.   : milestone, 15234000,
tracing (14.922 s) : 14922000, 14922000
.   : milestone, 14922000,
section candidate
no_agent (15.058 s) : 15058000, 15058000
.   : milestone, 15058000,
appsec (15.142 s) : 15142000, 15142000
.   : milestone, 15142000,
iast (18.492 s) : 18492000, 18492000
.   : milestone, 18492000,
iast_GLOBAL (18.058 s) : 18058000, 18058000
.   : milestone, 18058000,
profiling (15.027 s) : 15027000, 15027000
.   : milestone, 15027000,
tracing (15.211 s) : 15211000, 15211000
.   : milestone, 15211000,

baseline results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	15.094 s [15.094 s, 15.094 s]	-
appsec	15.343 s [15.343 s, 15.343 s]	249.0 ms (1.6%)
iast	18.216 s [18.216 s, 18.216 s]	3.122 s (20.7%)
iast_GLOBAL	18.27 s [18.27 s, 18.27 s]	3.176 s (21.0%)
profiling	15.234 s [15.234 s, 15.234 s]	140.0 ms (0.9%)
tracing	14.922 s [14.922 s, 14.922 s]	-172.0 ms (-1.1%)

candidate results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	15.058 s [15.058 s, 15.058 s]	-
appsec	15.142 s [15.142 s, 15.142 s]	84.0 ms (0.6%)
iast	18.492 s [18.492 s, 18.492 s]	3.434 s (22.8%)
iast_GLOBAL	18.058 s [18.058 s, 18.058 s]	3.0 s (19.9%)
profiling	15.027 s [15.027 s, 15.027 s]	-31.0 ms (-0.2%)
tracing	15.211 s [15.211 s, 15.211 s]	153.0 ms (1.0%)

Execution time for tomcat

gantt
    title tomcat - execution time [CI 0.99] : candidate=1.43.0-SNAPSHOT~815ccfc964, baseline=1.43.0-SNAPSHOT~8d7866c147
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.462 ms) : 1451, 1474
.   : milestone, 1462,
appsec (2.327 ms) : 2285, 2368
.   : milestone, 2327,
iast (2.057 ms) : 2005, 2108
.   : milestone, 2057,
iast_GLOBAL (2.111 ms) : 2058, 2163
.   : milestone, 2111,
profiling (1.949 ms) : 1906, 1992
.   : milestone, 1949,
tracing (1.909 ms) : 1870, 1949
.   : milestone, 1909,
section candidate
no_agent (1.461 ms) : 1450, 1473
.   : milestone, 1461,
appsec (2.344 ms) : 2302, 2385
.   : milestone, 2344,
iast (2.065 ms) : 2013, 2117
.   : milestone, 2065,
iast_GLOBAL (2.117 ms) : 2064, 2169
.   : milestone, 2117,
profiling (1.93 ms) : 1889, 1971
.   : milestone, 1930,
tracing (1.909 ms) : 1870, 1949
.   : milestone, 1909,

baseline results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	1.462 ms [1.451 ms, 1.474 ms]	-
appsec	2.327 ms [2.285 ms, 2.368 ms]	864.298 µs (59.1%)
iast	2.057 ms [2.005 ms, 2.108 ms]	594.356 µs (40.6%)
iast_GLOBAL	2.111 ms [2.058 ms, 2.163 ms]	648.154 µs (44.3%)
profiling	1.949 ms [1.906 ms, 1.992 ms]	486.213 µs (33.2%)
tracing	1.909 ms [1.87 ms, 1.949 ms]	447.05 µs (30.6%)

candidate results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	1.461 ms [1.45 ms, 1.473 ms]	-
appsec	2.344 ms [2.302 ms, 2.385 ms]	882.182 µs (60.4%)
iast	2.065 ms [2.013 ms, 2.117 ms]	603.62 µs (41.3%)
iast_GLOBAL	2.117 ms [2.064 ms, 2.169 ms]	655.248 µs (44.8%)
profiling	1.93 ms [1.889 ms, 1.971 ms]	468.371 µs (32.0%)
tracing	1.909 ms [1.87 ms, 1.949 ms]	447.955 µs (30.7%)

pr-commenter · 2024-11-13T13:08:42Z

Kafka / consumer-benchmark

Parameters

	Baseline	Candidate
baseline_or_candidate	baseline	candidate
git_branch	release/v1.42.x	raphael.vandon/backport-pr-7900
git_commit_date	1731428107	1731514872
git_commit_sha	`0dde9bd`	`815ccfc`

See matching parameters

	Baseline	Candidate
ci_job_date	1731516439	1731516439
ci_job_id	705677014	705677014
ci_pipeline_id	48922056	48922056
cpu_model	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
jdkVersion	11.0.21	11.0.21
jmhVersion	1.36	1.36
jvm	/usr/lib/jvm/java-11-openjdk-amd64/bin/java	/usr/lib/jvm/java-11-openjdk-amd64/bin/java
jvmArgs	-Dfile.encoding=UTF-8 -Djava.io.tmpdir=/go/src/github.com/DataDog/apm-reliability/dd-trace-java/platform/src/consumer-benchmark/build/tmp/jmh -Duser.country=US -Duser.language=en -Duser.variant	-Dfile.encoding=UTF-8 -Djava.io.tmpdir=/go/src/github.com/DataDog/apm-reliability/dd-trace-java/platform/src/consumer-benchmark/build/tmp/jmh -Duser.country=US -Duser.language=en -Duser.variant
vmName	OpenJDK 64-Bit Server VM	OpenJDK 64-Bit Server VM
vmVersion	11.0.21+9-post-Ubuntu-0ubuntu122.04	11.0.21+9-post-Ubuntu-0ubuntu122.04

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 3 metrics, 0 unstable metrics.

See unchanged results

scenario	Δ mean throughput
scenario:not-instrumented/KafkaConsumerBenchmark.benchConsume	same
scenario:only-tracing-dsm-disabled-benchmarks/KafkaConsumerBenchmark.benchConsume	same
scenario:only-tracing-dsm-enabled-benchmarks/KafkaConsumerBenchmark.benchConsume	same

Finish netty span when request is cancelled (#7900)

c508521

* Finish netty span when request is cancelled * Propagate channelInactive to next handler

vandonr requested a review from a team as a code owner November 13, 2024 12:19

vandonr changed the title ~~[🍒pick] Finish netty span when request is cancelled (#7900)~~ [🍒7900] Finish netty span when request is cancelled Nov 13, 2024

vandonr added type: bug inst: jetty Jetty instrumentation labels Nov 13, 2024

vandonr added this to the 1.42.2 milestone Nov 13, 2024

amarziali approved these changes Nov 13, 2024

View reviewed changes

vandonr enabled auto-merge (squash) November 13, 2024 13:11

vandonr disabled auto-merge November 13, 2024 14:18

Support testing of latest quartz versions (#7948)

815ccfc

vandonr merged commit ed086cb into release/v1.42.x Nov 13, 2024
99 checks passed

vandonr deleted the raphael.vandon/backport-pr-7900 branch November 13, 2024 17:42

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[🍒7900] Finish netty span when request is cancelled #7945

[🍒7900] Finish netty span when request is cancelled #7945

vandonr commented Nov 13, 2024 •

edited by jira bot

Loading

pr-commenter bot commented Nov 13, 2024 •

edited

Loading

pr-commenter bot commented Nov 13, 2024 •

edited

Loading

pr-commenter bot commented Nov 13, 2024 •

edited

Loading

pr-commenter bot commented Nov 13, 2024 •

edited

Loading

[🍒7900] Finish netty span when request is cancelled #7945

[🍒7900] Finish netty span when request is cancelled #7945

Conversation

vandonr commented Nov 13, 2024 • edited by jira bot Loading

What Does This Do

pr-commenter bot commented Nov 13, 2024 • edited Loading

Debugger benchmarks

Parameters

Summary

pr-commenter bot commented Nov 13, 2024 • edited Loading

Kafka / producer-benchmark

Parameters

Summary

pr-commenter bot commented Nov 13, 2024 • edited Loading

Benchmarks

Startup

Parameters

Summary

Load

Parameters

Summary

Dacapo

Parameters

Summary

pr-commenter bot commented Nov 13, 2024 • edited Loading

Kafka / consumer-benchmark

Parameters

Summary

vandonr commented Nov 13, 2024 •

edited by jira bot

Loading

pr-commenter bot commented Nov 13, 2024 •

edited

Loading

pr-commenter bot commented Nov 13, 2024 •

edited

Loading

pr-commenter bot commented Nov 13, 2024 •

edited

Loading

pr-commenter bot commented Nov 13, 2024 •

edited

Loading