Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix NullPointerException Extracting Class symbols #7934

Merged
merged 2 commits into from
Nov 13, 2024
Merged

Fix NullPointerException Extracting Class symbols #7934

merged 2 commits into from
Nov 13, 2024

Conversation

jpbempel
Copy link
Member

@jpbempel jpbempel commented Nov 12, 2024 •
edited by jira bot
Loading

What Does This Do

In rare cases, class super name is null (normally only for java.lag.Object). Handle nicely this case.

Motivation

Additional Notes

Contributor Checklist

Jira ticket: DEBUG-3111

@jpbempel
Fix NullPointerException Extracting Class symbols
6ace75e 
In rare cases, class super name is null (normally only for
java.lag.Object). Handle nicely this case.
@jpbempel jpbempel added type: bug comp: debugger Dynamic Instrumentation labels Nov 12, 2024
@jpbempel jpbempel requested a review from a team as a code owner November 12, 2024 13:12
@jpbempel jpbempel requested review from ojung and removed request for a team November 12, 2024 13:12
@pr-commenter
Copy link

pr-commenter bot commented Nov 12, 2024 •
edited
Loading

Debugger benchmarks

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
ci_job_date 1731516082 1731516458
end_time 2024-11-13T16:42:38 2024-11-13T16:48:53
git_branch master jpbempel/fix-symdb-null-super-class
git_commit_sha 8d7866c 299ee1e
start_time 2024-11-13T16:41:23 2024-11-13T16:47:39
See matching parameters
Baseline Candidate
ci_job_id 705686172 705686172
ci_pipeline_id 48922643 48922643
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
git_commit_date 1731515473 1731515473

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 9 metrics, 6 unstable metrics.

See unchanged results
scenario Δ mean agg_http_req_duration_min Δ mean agg_http_req_duration_p50 Δ mean agg_http_req_duration_p75 Δ mean agg_http_req_duration_p99 Δ mean throughput
scenario:noprobe unstable
[-20.588µs; +23.353µs] or [-7.803%; +8.850%]		 unstable
[-29.679µs; +36.380µs] or [-9.840%; +12.061%]		 unstable
[-39.494µs; +49.525µs] or [-12.562%; +15.753%]		 unstable
[-108.783µs; +75.310µs] or [-17.804%; +12.326%]		 same
scenario:basic same same same unstable
[-72.620µs; +29.985µs] or [-12.995%; +5.366%]		 unstable
[-149.964op/s; +149.964op/s] or [-5.849%; +5.849%]
scenario:loop unsure
[-28.184µs; -17.881µs] or [-0.277%; -0.176%]		 unsure
[-65.950µs; -1.374µs] or [-0.637%; -0.013%]		 same same same
Request duration reports for reports 
gantt
    title reports - request duration [CI 0.99] : candidate=None, baseline=None
    dateFormat X
    axisFormat %s
section baseline
noprobe (301.63 µs) : 276, 327
.   : milestone, 302,
basic (302.544 µs) : 293, 312
.   : milestone, 303,
loop (10.352 ms) : 10322, 10382
.   : milestone, 10352,
section candidate
noprobe (304.98 µs) : 269, 341
.   : milestone, 305,
basic (306.121 µs) : 296, 316
.   : milestone, 306,
loop (10.319 ms) : 10289, 10349
.   : milestone, 10319,
Loading
  • baseline results
Scenario Request median duration [CI 0.99]
noprobe 301.63 µs [275.901 µs, 327.358 µs]
basic 302.544 µs [293.17 µs, 311.919 µs]
loop 10.352 ms [10.322 ms, 10.382 ms]
  • candidate results
Scenario Request median duration [CI 0.99]
noprobe 304.98 µs [268.61 µs, 341.35 µs]
basic 306.121 µs [296.179 µs, 316.064 µs]
loop 10.319 ms [10.289 ms, 10.349 ms]

@pr-commenter
Copy link

pr-commenter bot commented Nov 12, 2024 •
edited
Loading

Benchmarks

Startup

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master jpbempel/fix-symdb-null-super-class
git_commit_date 1731513047 1731515473
git_commit_sha 8d7866c 299ee1e
release_version 1.43.0-SNAPSHOT~8d7866c147 1.43.0-SNAPSHOT~299ee1eb2e
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1731517820 1731517820
ci_job_id 705686166 705686166
ci_pipeline_id 48922643 48922643
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
module Agent Agent
parent None None
variant iast iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 56 metrics, 7 unstable metrics.

Startup time reports for insecure-bank 
gantt
    title insecure-bank - global startup overhead: candidate=1.43.0-SNAPSHOT~299ee1eb2e, baseline=1.43.0-SNAPSHOT~8d7866c147

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.085 s) : 0, 1084970
Total [baseline] (8.64 s) : 0, 8640355
Agent [candidate] (1.099 s) : 0, 1098998
Total [candidate] (8.613 s) : 0, 8613096
section iast
Agent [baseline] (1.211 s) : 0, 1210907
Total [baseline] (9.147 s) : 0, 9146587
Agent [candidate] (1.21 s) : 0, 1209822
Total [candidate] (9.151 s) : 0, 9150503
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.21 s) : 0, 1210331
Total [baseline] (9.143 s) : 0, 9143328
Agent [candidate] (1.209 s) : 0, 1208567
Total [candidate] (9.129 s) : 0, 9129423
section iast_TELEMETRY_OFF
Agent [baseline] (1.206 s) : 0, 1206394
Total [baseline] (9.139 s) : 0, 9138705
Agent [candidate] (1.206 s) : 0, 1205959
Total [candidate] (9.143 s) : 0, 9142679
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.085 s -
Agent iast 1.211 s 125.938 ms (11.6%)
Agent iast_HARDCODED_SECRET_DISABLED 1.21 s 125.361 ms (11.6%)
Agent iast_TELEMETRY_OFF 1.206 s 121.425 ms (11.2%)
Total tracing 8.64 s -
Total iast 9.147 s 506.232 ms (5.9%)
Total iast_HARDCODED_SECRET_DISABLED 9.143 s 502.973 ms (5.8%)
Total iast_TELEMETRY_OFF 9.139 s 498.35 ms (5.8%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.099 s -
Agent iast 1.21 s 110.823 ms (10.1%)
Agent iast_HARDCODED_SECRET_DISABLED 1.209 s 109.568 ms (10.0%)
Agent iast_TELEMETRY_OFF 1.206 s 106.96 ms (9.7%)
Total tracing 8.613 s -
Total iast 9.151 s 537.408 ms (6.2%)
Total iast_HARDCODED_SECRET_DISABLED 9.129 s 516.328 ms (6.0%)
Total iast_TELEMETRY_OFF 9.143 s 529.583 ms (6.1%) 
gantt
    title insecure-bank - break down per module: candidate=1.43.0-SNAPSHOT~299ee1eb2e, baseline=1.43.0-SNAPSHOT~8d7866c147

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (687.85 ms) : 0, 687850
BytebuddyAgent [candidate] (698.85 ms) : 0, 698850
GlobalTracer [baseline] (317.136 ms) : 0, 317136
GlobalTracer [candidate] (320.19 ms) : 0, 320190
AppSec [baseline] (54.688 ms) : 0, 54688
AppSec [candidate] (55.171 ms) : 0, 55171
Remote Config [baseline] (687.966 µs) : 0, 688
Remote Config [candidate] (691.752 µs) : 0, 692
Telemetry [baseline] (10.793 ms) : 0, 10793
Telemetry [candidate] (10.088 ms) : 0, 10088
section iast
BytebuddyAgent [baseline] (805.355 ms) : 0, 805355
BytebuddyAgent [candidate] (803.872 ms) : 0, 803872
GlobalTracer [baseline] (305.182 ms) : 0, 305182
GlobalTracer [candidate] (305.602 ms) : 0, 305602
AppSec [baseline] (57.152 ms) : 0, 57152
AppSec [candidate] (57.09 ms) : 0, 57090
Remote Config [baseline] (620.926 µs) : 0, 621
Remote Config [candidate] (613.5 µs) : 0, 614
Telemetry [baseline] (7.506 ms) : 0, 7506
Telemetry [candidate] (7.534 ms) : 0, 7534
IAST [baseline] (21.335 ms) : 0, 21335
IAST [candidate] (21.3 ms) : 0, 21300
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (804.636 ms) : 0, 804636
BytebuddyAgent [candidate] (803.242 ms) : 0, 803242
GlobalTracer [baseline] (305.986 ms) : 0, 305986
GlobalTracer [candidate] (305.358 ms) : 0, 305358
AppSec [baseline] (57.318 ms) : 0, 57318
AppSec [candidate] (56.687 ms) : 0, 56687
Remote Config [baseline] (605.81 µs) : 0, 606
Remote Config [candidate] (604.839 µs) : 0, 605
Telemetry [baseline] (7.426 ms) : 0, 7426
Telemetry [candidate] (7.408 ms) : 0, 7408
IAST [baseline] (20.577 ms) : 0, 20577
IAST [candidate] (21.484 ms) : 0, 21484
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (800.821 ms) : 0, 800821
BytebuddyAgent [candidate] (800.816 ms) : 0, 800816
GlobalTracer [baseline] (305.164 ms) : 0, 305164
GlobalTracer [candidate] (305.227 ms) : 0, 305227
AppSec [baseline] (58.264 ms) : 0, 58264
AppSec [candidate] (57.577 ms) : 0, 57577
Remote Config [baseline] (601.991 µs) : 0, 602
Remote Config [candidate] (618.909 µs) : 0, 619
Telemetry [baseline] (7.44 ms) : 0, 7440
Telemetry [candidate] (7.438 ms) : 0, 7438
IAST [baseline] (20.368 ms) : 0, 20368
IAST [candidate] (20.518 ms) : 0, 20518
Loading
Startup time reports for petclinic 
gantt
    title petclinic - global startup overhead: candidate=1.43.0-SNAPSHOT~299ee1eb2e, baseline=1.43.0-SNAPSHOT~8d7866c147

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.092 s) : 0, 1091715
Total [baseline] (10.479 s) : 0, 10479264
Agent [candidate] (1.093 s) : 0, 1093054
Total [candidate] (10.459 s) : 0, 10459241
section appsec
Agent [baseline] (1.229 s) : 0, 1229013
Total [baseline] (10.761 s) : 0, 10760512
Agent [candidate] (1.22 s) : 0, 1219941
Total [candidate] (10.726 s) : 0, 10726492
section iast
Agent [baseline] (1.211 s) : 0, 1211380
Total [baseline] (10.965 s) : 0, 10964577
Agent [candidate] (1.214 s) : 0, 1214100
Total [candidate] (10.949 s) : 0, 10948686
section profiling
Agent [baseline] (1.282 s) : 0, 1282383
Total [baseline] (10.799 s) : 0, 10798845
Agent [candidate] (1.291 s) : 0, 1290522
Total [candidate] (10.831 s) : 0, 10831186
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.092 s -
Agent appsec 1.229 s 137.298 ms (12.6%)
Agent iast 1.211 s 119.665 ms (11.0%)
Agent profiling 1.282 s 190.668 ms (17.5%)
Total tracing 10.479 s -
Total appsec 10.761 s 281.248 ms (2.7%)
Total iast 10.965 s 485.312 ms (4.6%)
Total profiling 10.799 s 319.58 ms (3.0%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.093 s -
Agent appsec 1.22 s 126.888 ms (11.6%)
Agent iast 1.214 s 121.047 ms (11.1%)
Agent profiling 1.291 s 197.469 ms (18.1%)
Total tracing 10.459 s -
Total appsec 10.726 s 267.25 ms (2.6%)
Total iast 10.949 s 489.444 ms (4.7%)
Total profiling 10.831 s 371.944 ms (3.6%) 
gantt
    title petclinic - break down per module: candidate=1.43.0-SNAPSHOT~299ee1eb2e, baseline=1.43.0-SNAPSHOT~8d7866c147

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (693.638 ms) : 0, 693638
BytebuddyAgent [candidate] (693.159 ms) : 0, 693159
GlobalTracer [baseline] (318.907 ms) : 0, 318907
GlobalTracer [candidate] (318.199 ms) : 0, 318199
AppSec [baseline] (54.684 ms) : 0, 54684
AppSec [candidate] (54.99 ms) : 0, 54990
Remote Config [baseline] (686.45 µs) : 0, 686
Remote Config [candidate] (703.237 µs) : 0, 703
Telemetry [baseline] (9.989 ms) : 0, 9989
Telemetry [candidate] (12.158 ms) : 0, 12158
section appsec
BytebuddyAgent [baseline] (711.482 ms) : 0, 711482
BytebuddyAgent [candidate] (706.727 ms) : 0, 706727
GlobalTracer [baseline] (317.087 ms) : 0, 317087
GlobalTracer [candidate] (314.683 ms) : 0, 314683
AppSec [baseline] (167.169 ms) : 0, 167169
AppSec [candidate] (166.194 ms) : 0, 166194
Remote Config [baseline] (644.885 µs) : 0, 645
Remote Config [candidate] (643.403 µs) : 0, 643
Telemetry [baseline] (8.202 ms) : 0, 8202
Telemetry [candidate] (7.825 ms) : 0, 7825
IAST [baseline] (21.209 ms) : 0, 21209
IAST [candidate] (20.238 ms) : 0, 20238
section iast
BytebuddyAgent [baseline] (805.47 ms) : 0, 805470
BytebuddyAgent [candidate] (809.153 ms) : 0, 809153
GlobalTracer [baseline] (305.695 ms) : 0, 305695
GlobalTracer [candidate] (304.742 ms) : 0, 304742
AppSec [baseline] (57.768 ms) : 0, 57768
AppSec [candidate] (57.425 ms) : 0, 57425
Remote Config [baseline] (625.996 µs) : 0, 626
Remote Config [candidate] (629.379 µs) : 0, 629
Telemetry [baseline] (7.484 ms) : 0, 7484
Telemetry [candidate] (7.502 ms) : 0, 7502
IAST [baseline] (20.595 ms) : 0, 20595
IAST [candidate] (20.809 ms) : 0, 20809
section profiling
BytebuddyAgent [baseline] (681.842 ms) : 0, 681842
BytebuddyAgent [candidate] (686.93 ms) : 0, 686930
GlobalTracer [baseline] (400.958 ms) : 0, 400958
GlobalTracer [candidate] (403.043 ms) : 0, 403043
AppSec [baseline] (55.012 ms) : 0, 55012
AppSec [candidate] (55.001 ms) : 0, 55001
Remote Config [baseline] (674.573 µs) : 0, 675
Remote Config [candidate] (671.305 µs) : 0, 671
Telemetry [baseline] (12.136 ms) : 0, 12136
Telemetry [candidate] (10.682 ms) : 0, 10682
ProfilingAgent [baseline] (92.693 ms) : 0, 92693
ProfilingAgent [candidate] (94.792 ms) : 0, 94792
Profiling [baseline] (92.717 ms) : 0, 92717
Profiling [candidate] (94.816 ms) : 0, 94816
Loading

Load

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
end_time 2024-11-13T16:42:30 2024-11-13T16:49:26
git_branch master jpbempel/fix-symdb-null-super-class
git_commit_date 1731513047 1731515473
git_commit_sha 8d7866c 299ee1e
release_version 1.43.0-SNAPSHOT~8d7866c147 1.43.0-SNAPSHOT~299ee1eb2e
start_time 2024-11-13T16:42:16 2024-11-13T16:49:12
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1731516918 1731516918
ci_job_id 705686167 705686167
ci_pipeline_id 48922643 48922643
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
variant iast iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 13 metrics, 15 unstable metrics.

Request duration reports for insecure-bank 
gantt
    title insecure-bank - request duration [CI 0.99] : candidate=1.43.0-SNAPSHOT~299ee1eb2e, baseline=1.43.0-SNAPSHOT~8d7866c147
    dateFormat X
    axisFormat %s
section baseline
no_agent (376.326 µs) : 356, 396
.   : milestone, 376,
iast (491.28 µs) : 470, 512
.   : milestone, 491,
iast_FULL (650.614 µs) : 629, 672
.   : milestone, 651,
iast_GLOBAL (518.783 µs) : 498, 540
.   : milestone, 519,
iast_HARDCODED_SECRET_DISABLED (491.908 µs) : 471, 513
.   : milestone, 492,
iast_INACTIVE (460.424 µs) : 439, 482
.   : milestone, 460,
iast_TELEMETRY_OFF (489.2 µs) : 467, 511
.   : milestone, 489,
tracing (452.28 µs) : 432, 473
.   : milestone, 452,
section candidate
no_agent (379.35 µs) : 359, 400
.   : milestone, 379,
iast (499.601 µs) : 478, 521
.   : milestone, 500,
iast_FULL (649.716 µs) : 628, 671
.   : milestone, 650,
iast_GLOBAL (523.087 µs) : 502, 544
.   : milestone, 523,
iast_HARDCODED_SECRET_DISABLED (495.429 µs) : 474, 517
.   : milestone, 495,
iast_INACTIVE (450.078 µs) : 429, 471
.   : milestone, 450,
iast_TELEMETRY_OFF (483.782 µs) : 463, 505
.   : milestone, 484,
tracing (462.953 µs) : 442, 484
.   : milestone, 463,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 376.326 µs [356.216 µs, 396.437 µs] -
iast 491.28 µs [470.231 µs, 512.329 µs] 114.954 µs (30.5%)
iast_FULL 650.614 µs [628.823 µs, 672.404 µs] 274.287 µs (72.9%)
iast_GLOBAL 518.783 µs [497.754 µs, 539.812 µs] 142.457 µs (37.9%)
iast_HARDCODED_SECRET_DISABLED 491.908 µs [471.037 µs, 512.779 µs] 115.581 µs (30.7%)
iast_INACTIVE 460.424 µs [439.026 µs, 481.821 µs] 84.097 µs (22.3%)
iast_TELEMETRY_OFF 489.2 µs [466.913 µs, 511.486 µs] 112.873 µs (30.0%)
tracing 452.28 µs [431.658 µs, 472.903 µs] 75.954 µs (20.2%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 379.35 µs [359.053 µs, 399.646 µs] -
iast 499.601 µs [477.894 µs, 521.308 µs] 120.252 µs (31.7%)
iast_FULL 649.716 µs [628.422 µs, 671.01 µs] 270.366 µs (71.3%)
iast_GLOBAL 523.087 µs [501.905 µs, 544.269 µs] 143.738 µs (37.9%)
iast_HARDCODED_SECRET_DISABLED 495.429 µs [474.137 µs, 516.721 µs] 116.079 µs (30.6%)
iast_INACTIVE 450.078 µs [429.1 µs, 471.056 µs] 70.729 µs (18.6%)
iast_TELEMETRY_OFF 483.782 µs [462.587 µs, 504.976 µs] 104.432 µs (27.5%)
tracing 462.953 µs [441.988 µs, 483.917 µs] 83.603 µs (22.0%)
Request duration reports for petclinic 
gantt
    title petclinic - request duration [CI 0.99] : candidate=1.43.0-SNAPSHOT~299ee1eb2e, baseline=1.43.0-SNAPSHOT~8d7866c147
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.337 ms) : 1317, 1357
.   : milestone, 1337,
appsec (1.738 ms) : 1715, 1762
.   : milestone, 1738,
appsec_no_iast (1.73 ms) : 1705, 1755
.   : milestone, 1730,
iast (1.478 ms) : 1456, 1501
.   : milestone, 1478,
profiling (1.494 ms) : 1471, 1517
.   : milestone, 1494,
tracing (1.485 ms) : 1460, 1510
.   : milestone, 1485,
section candidate
no_agent (1.352 ms) : 1333, 1372
.   : milestone, 1352,
appsec (1.75 ms) : 1726, 1775
.   : milestone, 1750,
appsec_no_iast (1.765 ms) : 1741, 1789
.   : milestone, 1765,
iast (1.494 ms) : 1471, 1517
.   : milestone, 1494,
profiling (1.489 ms) : 1466, 1512
.   : milestone, 1489,
tracing (1.487 ms) : 1463, 1511
.   : milestone, 1487,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.337 ms [1.317 ms, 1.357 ms] -
appsec 1.738 ms [1.715 ms, 1.762 ms] 401.055 µs (30.0%)
appsec_no_iast 1.73 ms [1.705 ms, 1.755 ms] 392.414 µs (29.3%)
iast 1.478 ms [1.456 ms, 1.501 ms] 141.178 µs (10.6%)
profiling 1.494 ms [1.471 ms, 1.517 ms] 156.666 µs (11.7%)
tracing 1.485 ms [1.46 ms, 1.51 ms] 147.909 µs (11.1%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.352 ms [1.333 ms, 1.372 ms] -
appsec 1.75 ms [1.726 ms, 1.775 ms] 397.762 µs (29.4%)
appsec_no_iast 1.765 ms [1.741 ms, 1.789 ms] 412.762 µs (30.5%)
iast 1.494 ms [1.471 ms, 1.517 ms] 141.907 µs (10.5%)
profiling 1.489 ms [1.466 ms, 1.512 ms] 136.745 µs (10.1%)
tracing 1.487 ms [1.463 ms, 1.511 ms] 134.31 µs (9.9%)

Dacapo

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master jpbempel/fix-symdb-null-super-class
git_commit_date 1731513047 1731515473
git_commit_sha 8d7866c 299ee1e
release_version 1.43.0-SNAPSHOT~8d7866c147 1.43.0-SNAPSHOT~299ee1eb2e
See matching parameters
Baseline Candidate
application biojava biojava
ci_job_date 1731517424 1731517424
ci_job_id 705686168 705686168
ci_pipeline_id 48922643 48922643
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
variant appsec appsec

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics.

Execution time for tomcat 
gantt
    title tomcat - execution time [CI 0.99] : candidate=1.43.0-SNAPSHOT~299ee1eb2e, baseline=1.43.0-SNAPSHOT~8d7866c147
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.463 ms) : 1451, 1474
.   : milestone, 1463,
appsec (2.335 ms) : 2293, 2376
.   : milestone, 2335,
iast (2.071 ms) : 2018, 2123
.   : milestone, 2071,
iast_GLOBAL (2.116 ms) : 2063, 2169
.   : milestone, 2116,
profiling (1.936 ms) : 1894, 1978
.   : milestone, 1936,
tracing (1.923 ms) : 1883, 1964
.   : milestone, 1923,
section candidate
no_agent (1.457 ms) : 1446, 1469
.   : milestone, 1457,
appsec (2.337 ms) : 2296, 2379
.   : milestone, 2337,
iast (2.07 ms) : 2018, 2123
.   : milestone, 2070,
iast_GLOBAL (2.102 ms) : 2050, 2154
.   : milestone, 2102,
profiling (1.953 ms) : 1909, 1997
.   : milestone, 1953,
tracing (1.911 ms) : 1871, 1951
.   : milestone, 1911,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.463 ms [1.451 ms, 1.474 ms] -
appsec 2.335 ms [2.293 ms, 2.376 ms] 872.211 µs (59.6%)
iast 2.071 ms [2.018 ms, 2.123 ms] 608.23 µs (41.6%)
iast_GLOBAL 2.116 ms [2.063 ms, 2.169 ms] 652.939 µs (44.6%)
profiling 1.936 ms [1.894 ms, 1.978 ms] 473.077 µs (32.3%)
tracing 1.923 ms [1.883 ms, 1.964 ms] 460.451 µs (31.5%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.457 ms [1.446 ms, 1.469 ms] -
appsec 2.337 ms [2.296 ms, 2.379 ms] 879.857 µs (60.4%)
iast 2.07 ms [2.018 ms, 2.123 ms] 612.901 µs (42.1%)
iast_GLOBAL 2.102 ms [2.05 ms, 2.154 ms] 644.704 µs (44.2%)
profiling 1.953 ms [1.909 ms, 1.997 ms] 495.473 µs (34.0%)
tracing 1.911 ms [1.871 ms, 1.951 ms] 453.542 µs (31.1%)
Execution time for biojava 
gantt
    title biojava - execution time [CI 0.99] : candidate=1.43.0-SNAPSHOT~299ee1eb2e, baseline=1.43.0-SNAPSHOT~8d7866c147
    dateFormat X
    axisFormat %s
section baseline
no_agent (15.155 s) : 15155000, 15155000
.   : milestone, 15155000,
appsec (15.22 s) : 15220000, 15220000
.   : milestone, 15220000,
iast (18.538 s) : 18538000, 18538000
.   : milestone, 18538000,
iast_GLOBAL (18.002 s) : 18002000, 18002000
.   : milestone, 18002000,
profiling (15.516 s) : 15516000, 15516000
.   : milestone, 15516000,
tracing (15.063 s) : 15063000, 15063000
.   : milestone, 15063000,
section candidate
no_agent (15.086 s) : 15086000, 15086000
.   : milestone, 15086000,
appsec (15.391 s) : 15391000, 15391000
.   : milestone, 15391000,
iast (18.784 s) : 18784000, 18784000
.   : milestone, 18784000,
iast_GLOBAL (18.335 s) : 18335000, 18335000
.   : milestone, 18335000,
profiling (15.448 s) : 15448000, 15448000
.   : milestone, 15448000,
tracing (15.181 s) : 15181000, 15181000
.   : milestone, 15181000,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 15.155 s [15.155 s, 15.155 s] -
appsec 15.22 s [15.22 s, 15.22 s] 65.0 ms (0.4%)
iast 18.538 s [18.538 s, 18.538 s] 3.383 s (22.3%)
iast_GLOBAL 18.002 s [18.002 s, 18.002 s] 2.847 s (18.8%)
profiling 15.516 s [15.516 s, 15.516 s] 361.0 ms (2.4%)
tracing 15.063 s [15.063 s, 15.063 s] -92.0 ms (-0.6%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 15.086 s [15.086 s, 15.086 s] -
appsec 15.391 s [15.391 s, 15.391 s] 305.0 ms (2.0%)
iast 18.784 s [18.784 s, 18.784 s] 3.698 s (24.5%)
iast_GLOBAL 18.335 s [18.335 s, 18.335 s] 3.249 s (21.5%)
profiling 15.448 s [15.448 s, 15.448 s] 362.0 ms (2.4%)
tracing 15.181 s [15.181 s, 15.181 s] 95.0 ms (0.6%)

evanchooly
evanchooly approved these changes Nov 13, 2024
View reviewed changes
...debugger/src/main/java/com/datadog/debugger/instrumentation/CapturedContextInstrumentor.java Outdated
@@ -1215,7 +1218,10 @@ private static void addInheritedStaticFields(
Limits limits,
List<FieldNode> results,
int fieldCount) {
String superClassName = Strings.getClassName(classNode.superName);
String superClassName =
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ditto above

...debugger/src/main/java/com/datadog/debugger/instrumentation/CapturedContextInstrumentor.java Outdated
@@ -1161,7 +1161,10 @@ private static void addInheritedFields(
Limits limits,
List<FieldNode> results,
int fieldCount) {
String superClassName = Strings.getClassName(classNode.superName);
String superClassName =
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shouldn't this also use SymbolExtractor.extractSuperClass() like below?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

right. Moved extractSuperClass to ASMHelper class and call it from there

@jpbempel jpbempel merged commit 9246b9f into master Nov 13, 2024
102 checks passed
@jpbempel jpbempel deleted the jpbempel/fix-symdb-null-super-class branch November 13, 2024 17:55
@github-actions github-actions bot added this to the 1.43.0 milestone Nov 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@evanchooly evanchooly evanchooly approved these changes

@ojung ojung Awaiting requested review from ojung ojung is a code owner automatically assigned from DataDog/debugger-java

Assignees
No one assigned
Labels
comp: debugger Dynamic Instrumentation type: bug
Projects
None yet
Milestone
1.43.0
Development

Successfully merging this pull request may close these issues.
2 participants
@jpbempel @evanchooly