Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[🍒 7908] Disable Kafka 3.8+ instrumentation by default #7909

Merged
merged 1 commit into from
Nov 7, 2024

Conversation

ygree
Copy link
Contributor

@ygree ygree commented Nov 7, 2024

Backport #7908 to release/v1.42.x

This reverts commit 8c7495a.

(cherry picked from commit ee7f366)
@ygree ygree added the inst: kafka Kafka instrumentation label Nov 7, 2024
@ygree ygree requested review from a team as code owners November 7, 2024 17:19
@ygree ygree enabled auto-merge (squash) November 7, 2024 17:23
@pr-commenter
Copy link

pr-commenter bot commented Nov 7, 2024

Debugger benchmarks

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
ci_job_date 1731000583 1731000959
end_time 2024-11-07T17:30:58 2024-11-07T17:37:14
git_branch master yury.gribkov/backport-pr-7908
git_commit_sha 060ab72 49c9b22
start_time 2024-11-07T17:29:44 2024-11-07T17:36:00
See matching parameters
Baseline Candidate
ci_job_id 699373680 699373680
ci_pipeline_id 48478724 48478724
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
git_commit_date 1730999955 1730999955

Summary

Found 0 performance improvements and 5 performance regressions! Performance is the same for 5 metrics, 5 unstable metrics.

scenario Δ mean agg_http_req_duration_min Δ mean agg_http_req_duration_p50 Δ mean agg_http_req_duration_p75 Δ mean agg_http_req_duration_p99 Δ mean throughput
scenario:loop worse
[+651.026µs; +657.382µs] or [+6.407%; +6.469%]
worse
[+634.583µs; +698.470µs] or [+6.146%; +6.765%]
worse
[+587.438µs; +698.402µs] or [+5.636%; +6.700%]
worse
[+547.382µs; +1038.705µs] or [+5.087%; +9.652%]
worse
[-6.344op/s; -4.864op/s] or [-6.629%; -5.083%]
See unchanged results
scenario Δ mean agg_http_req_duration_min Δ mean agg_http_req_duration_p50 Δ mean agg_http_req_duration_p75 Δ mean agg_http_req_duration_p99 Δ mean throughput
scenario:noprobe unstable
[-21.928µs; +14.681µs] or [-8.362%; +5.599%]
unstable
[-34.619µs; +24.146µs] or [-11.538%; +8.047%]
unstable
[-47.889µs; +33.883µs] or [-15.243%; +10.785%]
unstable
[-100.558µs; +104.818µs] or [-16.533%; +17.233%]
same
scenario:basic same same same unstable
[-64.566µs; +22.296µs] or [-11.832%; +4.086%]
same
Request duration reports for reports
gantt
    title reports - request duration [CI 0.99] : candidate=None, baseline=None
    dateFormat X
    axisFormat %s
section baseline
noprobe (300.047 µs) : 267, 333
.   : milestone, 300,
basic (299.88 µs) : 291, 308
.   : milestone, 300,
loop (10.325 ms) : 10294, 10355
.   : milestone, 10325,
section candidate
noprobe (294.811 µs) : 272, 317
.   : milestone, 295,
basic (299.709 µs) : 292, 307
.   : milestone, 300,
loop (10.991 ms) : 10962, 11020
.   : milestone, 10991,
Loading
  • baseline results
Scenario Request median duration [CI 0.99]
noprobe 300.047 µs [267.422 µs, 332.672 µs]
basic 299.88 µs [291.279 µs, 308.48 µs]
loop 10.325 ms [10.294 ms, 10.355 ms]
  • candidate results
Scenario Request median duration [CI 0.99]
noprobe 294.811 µs [272.303 µs, 317.318 µs]
basic 299.709 µs [292.07 µs, 307.348 µs]
loop 10.991 ms [10.962 ms, 11.02 ms]

@ygree ygree merged commit d302fe3 into release/v1.42.x Nov 7, 2024
92 of 100 checks passed
@ygree ygree deleted the yury.gribkov/backport-pr-7908 branch November 7, 2024 17:51
@github-actions github-actions bot added this to the 1.42.1 milestone Nov 7, 2024
@nayeem-kamal nayeem-kamal changed the title [🍒 7908] Revert "Removed config variable for disabling kafka-clients" [🍒 7908] Disable Kafka 3.8+ instrumentation by default Nov 8, 2024
@nayeem-kamal nayeem-kamal added the tag: breaking change Breaking changes label Nov 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
inst: kafka Kafka instrumentation tag: breaking change Breaking changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants