Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add reactor samples and doc #7906

Merged
merged 3 commits into from
Nov 12, 2024
Merged

Add reactor samples and doc #7906

merged 3 commits into from
Nov 12, 2024

Conversation

amarziali
Copy link
Collaborator

What Does This Do

Add documentation on reactor context propagation and examples.

Motivation

Additional Notes

Contributor Checklist

Jira ticket: [PROJ-IDENT]

@amarziali amarziali requested a review from a team as a code owner November 7, 2024 16:10
@amarziali amarziali added type: documentation inst: reactor Reactor instrumentation labels Nov 7, 2024
@pr-commenter
Copy link

pr-commenter bot commented Nov 7, 2024 •
edited
Loading

Benchmarks

Startup

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master andrea.marziali/reactor-sample
git_commit_date 1731055887 1731057861
git_commit_sha 0424969 25edc27
release_version 1.43.0-SNAPSHOT~04249697bb 1.43.0-SNAPSHOT~25edc278a1
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1731060168 1731060168
ci_job_id 700216189 700216189
ci_pipeline_id 48540464 48540464
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
module Agent Agent
parent None None
variant iast iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 52 metrics, 11 unstable metrics.

Startup time reports for petclinic 
gantt
    title petclinic - global startup overhead: candidate=1.43.0-SNAPSHOT~25edc278a1, baseline=1.43.0-SNAPSHOT~04249697bb

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.078 s) : 0, 1077908
Total [baseline] (10.299 s) : 0, 10298898
Agent [candidate] (1.079 s) : 0, 1079376
Total [candidate] (10.292 s) : 0, 10291724
section appsec
Agent [baseline] (1.211 s) : 0, 1210918
Total [baseline] (10.597 s) : 0, 10596707
Agent [candidate] (1.22 s) : 0, 1219661
Total [candidate] (10.678 s) : 0, 10677985
section iast
Agent [baseline] (1.204 s) : 0, 1204419
Total [baseline] (10.903 s) : 0, 10903353
Agent [candidate] (1.216 s) : 0, 1215762
Total [candidate] (10.871 s) : 0, 10870903
section profiling
Agent [baseline] (1.275 s) : 0, 1274762
Total [baseline] (10.648 s) : 0, 10648479
Agent [candidate] (1.283 s) : 0, 1283295
Total [candidate] (10.771 s) : 0, 10771219
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.078 s -
Agent appsec 1.211 s 133.009 ms (12.3%)
Agent iast 1.204 s 126.51 ms (11.7%)
Agent profiling 1.275 s 196.853 ms (18.3%)
Total tracing 10.299 s -
Total appsec 10.597 s 297.81 ms (2.9%)
Total iast 10.903 s 604.455 ms (5.9%)
Total profiling 10.648 s 349.582 ms (3.4%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.079 s -
Agent appsec 1.22 s 140.285 ms (13.0%)
Agent iast 1.216 s 136.386 ms (12.6%)
Agent profiling 1.283 s 203.919 ms (18.9%)
Total tracing 10.292 s -
Total appsec 10.678 s 386.261 ms (3.8%)
Total iast 10.871 s 579.18 ms (5.6%)
Total profiling 10.771 s 479.495 ms (4.7%) 
gantt
    title petclinic - break down per module: candidate=1.43.0-SNAPSHOT~25edc278a1, baseline=1.43.0-SNAPSHOT~04249697bb

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (684.271 ms) : 0, 684271
BytebuddyAgent [candidate] (686.348 ms) : 0, 686348
GlobalTracer [baseline] (313.737 ms) : 0, 313737
GlobalTracer [candidate] (315.083 ms) : 0, 315083
AppSec [baseline] (54.167 ms) : 0, 54167
AppSec [candidate] (53.897 ms) : 0, 53897
Remote Config [baseline] (680.702 µs) : 0, 681
Remote Config [candidate] (668.962 µs) : 0, 669
Telemetry [baseline] (11.462 ms) : 0, 11462
Telemetry [candidate] (9.769 ms) : 0, 9769
section appsec
BytebuddyAgent [baseline] (701.508 ms) : 0, 701508
BytebuddyAgent [candidate] (706.386 ms) : 0, 706386
GlobalTracer [baseline] (311.507 ms) : 0, 311507
GlobalTracer [candidate] (314.604 ms) : 0, 314604
AppSec [baseline] (165.911 ms) : 0, 165911
AppSec [candidate] (167.639 ms) : 0, 167639
Remote Config [baseline] (637.715 µs) : 0, 638
Remote Config [candidate] (643.919 µs) : 0, 644
Telemetry [baseline] (7.787 ms) : 0, 7787
Telemetry [candidate] (7.467 ms) : 0, 7467
IAST [baseline] (20.039 ms) : 0, 20039
IAST [candidate] (18.518 ms) : 0, 18518
section iast
BytebuddyAgent [baseline] (800.908 ms) : 0, 800908
BytebuddyAgent [candidate] (810.835 ms) : 0, 810835
GlobalTracer [baseline] (303.448 ms) : 0, 303448
GlobalTracer [candidate] (305.268 ms) : 0, 305268
AppSec [baseline] (55.845 ms) : 0, 55845
AppSec [candidate] (56.681 ms) : 0, 56681
Remote Config [baseline] (627.325 µs) : 0, 627
Remote Config [candidate] (597.498 µs) : 0, 597
Telemetry [baseline] (7.501 ms) : 0, 7501
Telemetry [candidate] (7.424 ms) : 0, 7424
IAST [baseline] (22.469 ms) : 0, 22469
IAST [candidate] (21.169 ms) : 0, 21169
section profiling
BytebuddyAgent [baseline] (679.967 ms) : 0, 679967
BytebuddyAgent [candidate] (685.026 ms) : 0, 685026
GlobalTracer [baseline] (397.045 ms) : 0, 397045
GlobalTracer [candidate] (397.865 ms) : 0, 397865
AppSec [baseline] (54.547 ms) : 0, 54547
AppSec [candidate] (54.951 ms) : 0, 54951
Remote Config [baseline] (663.771 µs) : 0, 664
Remote Config [candidate] (685.407 µs) : 0, 685
Telemetry [baseline] (11.207 ms) : 0, 11207
Telemetry [candidate] (13.528 ms) : 0, 13528
ProfilingAgent [baseline] (92.604 ms) : 0, 92604
ProfilingAgent [candidate] (92.272 ms) : 0, 92272
Profiling [baseline] (92.627 ms) : 0, 92627
Profiling [candidate] (92.295 ms) : 0, 92295
Loading
Startup time reports for insecure-bank 
gantt
    title insecure-bank - global startup overhead: candidate=1.43.0-SNAPSHOT~25edc278a1, baseline=1.43.0-SNAPSHOT~04249697bb

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.075 s) : 0, 1075387
Total [baseline] (8.498 s) : 0, 8498282
Agent [candidate] (1.078 s) : 0, 1078029
Total [candidate] (8.545 s) : 0, 8544953
section iast
Agent [baseline] (1.2 s) : 0, 1200311
Total [baseline] (9.081 s) : 0, 9081441
Agent [candidate] (1.205 s) : 0, 1204755
Total [candidate] (9.099 s) : 0, 9098764
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.204 s) : 0, 1204445
Total [baseline] (9.122 s) : 0, 9121816
Agent [candidate] (1.206 s) : 0, 1206358
Total [candidate] (9.076 s) : 0, 9076345
section iast_TELEMETRY_OFF
Agent [baseline] (1.208 s) : 0, 1208252
Total [baseline] (9.119 s) : 0, 9118966
Agent [candidate] (1.2 s) : 0, 1199777
Total [candidate] (9.094 s) : 0, 9094105
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.075 s -
Agent iast 1.2 s 124.925 ms (11.6%)
Agent iast_HARDCODED_SECRET_DISABLED 1.204 s 129.058 ms (12.0%)
Agent iast_TELEMETRY_OFF 1.208 s 132.865 ms (12.4%)
Total tracing 8.498 s -
Total iast 9.081 s 583.159 ms (6.9%)
Total iast_HARDCODED_SECRET_DISABLED 9.122 s 623.534 ms (7.3%)
Total iast_TELEMETRY_OFF 9.119 s 620.685 ms (7.3%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.078 s -
Agent iast 1.205 s 126.726 ms (11.8%)
Agent iast_HARDCODED_SECRET_DISABLED 1.206 s 128.329 ms (11.9%)
Agent iast_TELEMETRY_OFF 1.2 s 121.748 ms (11.3%)
Total tracing 8.545 s -
Total iast 9.099 s 553.812 ms (6.5%)
Total iast_HARDCODED_SECRET_DISABLED 9.076 s 531.392 ms (6.2%)
Total iast_TELEMETRY_OFF 9.094 s 549.153 ms (6.4%) 
gantt
    title insecure-bank - break down per module: candidate=1.43.0-SNAPSHOT~25edc278a1, baseline=1.43.0-SNAPSHOT~04249697bb

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (684.685 ms) : 0, 684685
BytebuddyAgent [candidate] (685.928 ms) : 0, 685928
GlobalTracer [baseline] (313.303 ms) : 0, 313303
GlobalTracer [candidate] (314.919 ms) : 0, 314919
AppSec [baseline] (54.07 ms) : 0, 54070
AppSec [candidate] (53.836 ms) : 0, 53836
Remote Config [baseline] (683.321 µs) : 0, 683
Remote Config [candidate] (673.612 µs) : 0, 674
Telemetry [baseline] (9.084 ms) : 0, 9084
Telemetry [candidate] (9.057 ms) : 0, 9057
section iast
BytebuddyAgent [baseline] (798.239 ms) : 0, 798239
BytebuddyAgent [candidate] (801.383 ms) : 0, 801383
GlobalTracer [baseline] (302.776 ms) : 0, 302776
GlobalTracer [candidate] (303.433 ms) : 0, 303433
AppSec [baseline] (57.212 ms) : 0, 57212
AppSec [candidate] (55.963 ms) : 0, 55963
Remote Config [baseline] (609.384 µs) : 0, 609
Remote Config [candidate] (614.323 µs) : 0, 614
Telemetry [baseline] (7.46 ms) : 0, 7460
Telemetry [candidate] (7.477 ms) : 0, 7477
IAST [baseline] (20.416 ms) : 0, 20416
IAST [candidate] (22.228 ms) : 0, 22228
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (801.435 ms) : 0, 801435
BytebuddyAgent [candidate] (802.171 ms) : 0, 802171
GlobalTracer [baseline] (303.068 ms) : 0, 303068
GlobalTracer [candidate] (303.758 ms) : 0, 303758
AppSec [baseline] (57.547 ms) : 0, 57547
AppSec [candidate] (56.36 ms) : 0, 56360
Remote Config [baseline] (636.319 µs) : 0, 636
Remote Config [candidate] (611.463 µs) : 0, 611
Telemetry [baseline] (7.466 ms) : 0, 7466
Telemetry [candidate] (8.269 ms) : 0, 8269
IAST [baseline] (20.694 ms) : 0, 20694
IAST [candidate] (21.517 ms) : 0, 21517
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (803.12 ms) : 0, 803120
BytebuddyAgent [candidate] (797.117 ms) : 0, 797117
GlobalTracer [baseline] (305.247 ms) : 0, 305247
GlobalTracer [candidate] (303.816 ms) : 0, 303816
AppSec [baseline] (57.848 ms) : 0, 57848
AppSec [candidate] (57.123 ms) : 0, 57123
Remote Config [baseline] (615.503 µs) : 0, 616
Remote Config [candidate] (601.132 µs) : 0, 601
Telemetry [baseline] (7.372 ms) : 0, 7372
Telemetry [candidate] (7.364 ms) : 0, 7364
IAST [baseline] (20.332 ms) : 0, 20332
IAST [candidate] (20.123 ms) : 0, 20123
Loading

Load

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
end_time 2024-11-08T09:35:19 2024-11-08T09:42:13
git_branch master andrea.marziali/reactor-sample
git_commit_date 1731055887 1731057861
git_commit_sha 0424969 25edc27
release_version 1.43.0-SNAPSHOT~04249697bb 1.43.0-SNAPSHOT~25edc278a1
start_time 2024-11-08T09:35:05 2024-11-08T09:41:59
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1731059281 1731059281
ci_job_id 700216190 700216190
ci_pipeline_id 48540464 48540464
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
variant iast iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 17 unstable metrics.

Request duration reports for insecure-bank 
gantt
    title insecure-bank - request duration [CI 0.99] : candidate=1.43.0-SNAPSHOT~25edc278a1, baseline=1.43.0-SNAPSHOT~04249697bb
    dateFormat X
    axisFormat %s
section baseline
no_agent (366.756 µs) : 347, 386
.   : milestone, 367,
iast (488.933 µs) : 467, 511
.   : milestone, 489,
iast_FULL (637.947 µs) : 616, 660
.   : milestone, 638,
iast_GLOBAL (515.331 µs) : 494, 537
.   : milestone, 515,
iast_HARDCODED_SECRET_DISABLED (493.758 µs) : 472, 515
.   : milestone, 494,
iast_INACTIVE (445.658 µs) : 425, 467
.   : milestone, 446,
iast_TELEMETRY_OFF (475.123 µs) : 454, 496
.   : milestone, 475,
tracing (440.421 µs) : 420, 461
.   : milestone, 440,
section candidate
no_agent (365.381 µs) : 346, 385
.   : milestone, 365,
iast (485.305 µs) : 464, 506
.   : milestone, 485,
iast_FULL (640.253 µs) : 619, 662
.   : milestone, 640,
iast_GLOBAL (504.0 µs) : 483, 525
.   : milestone, 504,
iast_HARDCODED_SECRET_DISABLED (483.25 µs) : 462, 504
.   : milestone, 483,
iast_INACTIVE (441.512 µs) : 421, 462
.   : milestone, 442,
iast_TELEMETRY_OFF (473.714 µs) : 452, 495
.   : milestone, 474,
tracing (440.626 µs) : 420, 461
.   : milestone, 441,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 366.756 µs [347.048 µs, 386.465 µs] -
iast 488.933 µs [467.283 µs, 510.583 µs] 122.177 µs (33.3%)
iast_FULL 637.947 µs [616.357 µs, 659.536 µs] 271.19 µs (73.9%)
iast_GLOBAL 515.331 µs [493.864 µs, 536.797 µs] 148.574 µs (40.5%)
iast_HARDCODED_SECRET_DISABLED 493.758 µs [472.078 µs, 515.439 µs] 127.002 µs (34.6%)
iast_INACTIVE 445.658 µs [424.65 µs, 466.666 µs] 78.902 µs (21.5%)
iast_TELEMETRY_OFF 475.123 µs [453.914 µs, 496.333 µs] 108.367 µs (29.5%)
tracing 440.421 µs [419.525 µs, 461.316 µs] 73.665 µs (20.1%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 365.381 µs [346.037 µs, 384.726 µs] -
iast 485.305 µs [464.152 µs, 506.459 µs] 119.924 µs (32.8%)
iast_FULL 640.253 µs [618.845 µs, 661.661 µs] 274.872 µs (75.2%)
iast_GLOBAL 504.0 µs [483.039 µs, 524.96 µs] 138.618 µs (37.9%)
iast_HARDCODED_SECRET_DISABLED 483.25 µs [462.091 µs, 504.408 µs] 117.868 µs (32.3%)
iast_INACTIVE 441.512 µs [420.677 µs, 462.347 µs] 76.131 µs (20.8%)
iast_TELEMETRY_OFF 473.714 µs [452.358 µs, 495.07 µs] 108.333 µs (29.6%)
tracing 440.626 µs [420.09 µs, 461.161 µs] 75.244 µs (20.6%)
Request duration reports for petclinic 
gantt
    title petclinic - request duration [CI 0.99] : candidate=1.43.0-SNAPSHOT~25edc278a1, baseline=1.43.0-SNAPSHOT~04249697bb
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.353 ms) : 1333, 1373
.   : milestone, 1353,
appsec (1.709 ms) : 1686, 1733
.   : milestone, 1709,
appsec_no_iast (1.733 ms) : 1708, 1757
.   : milestone, 1733,
iast (1.492 ms) : 1469, 1515
.   : milestone, 1492,
profiling (1.497 ms) : 1474, 1520
.   : milestone, 1497,
tracing (1.467 ms) : 1442, 1492
.   : milestone, 1467,
section candidate
no_agent (1.332 ms) : 1313, 1351
.   : milestone, 1332,
appsec (1.721 ms) : 1697, 1744
.   : milestone, 1721,
appsec_no_iast (1.714 ms) : 1689, 1739
.   : milestone, 1714,
iast (1.477 ms) : 1454, 1500
.   : milestone, 1477,
profiling (1.503 ms) : 1479, 1527
.   : milestone, 1503,
tracing (1.47 ms) : 1447, 1494
.   : milestone, 1470,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.353 ms [1.333 ms, 1.373 ms] -
appsec 1.709 ms [1.686 ms, 1.733 ms] 356.588 µs (26.4%)
appsec_no_iast 1.733 ms [1.708 ms, 1.757 ms] 380.021 µs (28.1%)
iast 1.492 ms [1.469 ms, 1.515 ms] 139.575 µs (10.3%)
profiling 1.497 ms [1.474 ms, 1.52 ms] 143.843 µs (10.6%)
tracing 1.467 ms [1.442 ms, 1.492 ms] 114.048 µs (8.4%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.332 ms [1.313 ms, 1.351 ms] -
appsec 1.721 ms [1.697 ms, 1.744 ms] 388.877 µs (29.2%)
appsec_no_iast 1.714 ms [1.689 ms, 1.739 ms] 382.354 µs (28.7%)
iast 1.477 ms [1.454 ms, 1.5 ms] 145.284 µs (10.9%)
profiling 1.503 ms [1.479 ms, 1.527 ms] 171.234 µs (12.9%)
tracing 1.47 ms [1.447 ms, 1.494 ms] 138.695 µs (10.4%)

Dacapo

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master andrea.marziali/reactor-sample
git_commit_date 1731055887 1731057861
git_commit_sha 0424969 25edc27
release_version 1.43.0-SNAPSHOT~04249697bb 1.43.0-SNAPSHOT~25edc278a1
See matching parameters
Baseline Candidate
application biojava biojava
ci_job_date 1731059804 1731059804
ci_job_id 700216191 700216191
ci_pipeline_id 48540464 48540464
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
variant appsec appsec

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics.

Execution time for tomcat 
gantt
    title tomcat - execution time [CI 0.99] : candidate=1.43.0-SNAPSHOT~25edc278a1, baseline=1.43.0-SNAPSHOT~04249697bb
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.467 ms) : 1456, 1479
.   : milestone, 1467,
appsec (2.327 ms) : 2285, 2368
.   : milestone, 2327,
iast (2.066 ms) : 2015, 2117
.   : milestone, 2066,
iast_GLOBAL (2.121 ms) : 2069, 2173
.   : milestone, 2121,
profiling (1.935 ms) : 1893, 1977
.   : milestone, 1935,
tracing (1.917 ms) : 1877, 1957
.   : milestone, 1917,
section candidate
no_agent (1.473 ms) : 1462, 1485
.   : milestone, 1473,
appsec (2.342 ms) : 2300, 2384
.   : milestone, 2342,
iast (2.083 ms) : 2031, 2136
.   : milestone, 2083,
iast_GLOBAL (2.117 ms) : 2065, 2170
.   : milestone, 2117,
profiling (1.953 ms) : 1910, 1995
.   : milestone, 1953,
tracing (1.935 ms) : 1894, 1975
.   : milestone, 1935,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.467 ms [1.456 ms, 1.479 ms] -
appsec 2.327 ms [2.285 ms, 2.368 ms] 859.341 µs (58.6%)
iast 2.066 ms [2.015 ms, 2.117 ms] 598.768 µs (40.8%)
iast_GLOBAL 2.121 ms [2.069 ms, 2.173 ms] 653.858 µs (44.6%)
profiling 1.935 ms [1.893 ms, 1.977 ms] 467.824 µs (31.9%)
tracing 1.917 ms [1.877 ms, 1.957 ms] 449.646 µs (30.6%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.473 ms [1.462 ms, 1.485 ms] -
appsec 2.342 ms [2.3 ms, 2.384 ms] 868.815 µs (59.0%)
iast 2.083 ms [2.031 ms, 2.136 ms] 609.68 µs (41.4%)
iast_GLOBAL 2.117 ms [2.065 ms, 2.17 ms] 644.0 µs (43.7%)
profiling 1.953 ms [1.91 ms, 1.995 ms] 479.499 µs (32.5%)
tracing 1.935 ms [1.894 ms, 1.975 ms] 461.416 µs (31.3%)
Execution time for biojava 
gantt
    title biojava - execution time [CI 0.99] : candidate=1.43.0-SNAPSHOT~25edc278a1, baseline=1.43.0-SNAPSHOT~04249697bb
    dateFormat X
    axisFormat %s
section baseline
no_agent (15.012 s) : 15012000, 15012000
.   : milestone, 15012000,
appsec (15.197 s) : 15197000, 15197000
.   : milestone, 15197000,
iast (18.718 s) : 18718000, 18718000
.   : milestone, 18718000,
iast_GLOBAL (18.18 s) : 18180000, 18180000
.   : milestone, 18180000,
profiling (15.166 s) : 15166000, 15166000
.   : milestone, 15166000,
tracing (14.889 s) : 14889000, 14889000
.   : milestone, 14889000,
section candidate
no_agent (15.062 s) : 15062000, 15062000
.   : milestone, 15062000,
appsec (15.197 s) : 15197000, 15197000
.   : milestone, 15197000,
iast (18.857 s) : 18857000, 18857000
.   : milestone, 18857000,
iast_GLOBAL (18.268 s) : 18268000, 18268000
.   : milestone, 18268000,
profiling (15.946 s) : 15946000, 15946000
.   : milestone, 15946000,
tracing (15.411 s) : 15411000, 15411000
.   : milestone, 15411000,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 15.012 s [15.012 s, 15.012 s] -
appsec 15.197 s [15.197 s, 15.197 s] 185.0 ms (1.2%)
iast 18.718 s [18.718 s, 18.718 s] 3.706 s (24.7%)
iast_GLOBAL 18.18 s [18.18 s, 18.18 s] 3.168 s (21.1%)
profiling 15.166 s [15.166 s, 15.166 s] 154.0 ms (1.0%)
tracing 14.889 s [14.889 s, 14.889 s] -123.0 ms (-0.8%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 15.062 s [15.062 s, 15.062 s] -
appsec 15.197 s [15.197 s, 15.197 s] 135.0 ms (0.9%)
iast 18.857 s [18.857 s, 18.857 s] 3.795 s (25.2%)
iast_GLOBAL 18.268 s [18.268 s, 18.268 s] 3.206 s (21.3%)
profiling 15.946 s [15.946 s, 15.946 s] 884.0 ms (5.9%)
tracing 15.411 s [15.411 s, 15.411 s] 349.0 ms (2.3%)

PerfectSlayer
PerfectSlayer approved these changes Nov 8, 2024
View reviewed changes
Copy link
Contributor

@PerfectSlayer PerfectSlayer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's a nice addition.

I wonder if we should use a better tool for this kind of documentation (like asciidoctor, to include code section, test the samples compile and work) and if there is a better place to display it (rather than within our code base) like https://datadoghq.dev/dd-trace-js/ ? But this can be improved later and should not block this PR.

docs/reactor/README.md Outdated Show resolved Hide resolved
docs/reactor/README.md Outdated Show resolved Hide resolved
docs/reactor/README.md Outdated Show resolved Hide resolved
docs/reactor/README.md

The Reactor context propagates bottom up from the first subscriber (last publisher) to the last subscriber (first publisher).
The datadog tracer captures the active span when the subscription happens (i.e. methods like `subcribe` or `block` are called)
and activates them when a publisher emits if there is no an already active span.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if there is no an already active span.

What happens if there is one active?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It let propagate the active one.

docs/reactor/README.md Outdated Show resolved Hide resolved
docs/reactor/README.md Outdated Show resolved Hide resolved
docs/reactor/README.md Outdated Show resolved Hide resolved
docs/reactor/README.md Outdated Show resolved Hide resolved
@amarziali amarziali enabled auto-merge (squash) November 12, 2024 14:18
@amarziali amarziali merged commit 6082863 into master Nov 12, 2024
95 of 99 checks passed
@amarziali amarziali deleted the andrea.marziali/reactor-sample branch November 12, 2024 14:46
@github-actions github-actions bot added this to the 1.43.0 milestone Nov 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PerfectSlayer PerfectSlayer PerfectSlayer approved these changes

Assignees
No one assigned
Labels
inst: reactor Reactor instrumentation type: documentation
Projects
None yet
Milestone
1.43.0
Development

Successfully merging this pull request may close these issues.
2 participants
@amarziali @PerfectSlayer