Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

paranoid exception handling when setting profiling thread context #7903

Merged
merged 1 commit into from
Nov 7, 2024
Merged

paranoid exception handling when setting profiling thread context #7903

merged 1 commit into from
Nov 7, 2024

Conversation

richardstartin
Copy link
Member

@richardstartin richardstartin commented Nov 7, 2024 •
edited by jira bot
Loading

What Does This Do

This handles scenarios where the profiling context may not be able to store the thread context because the user has increased the value of pid_max during the process lifetime.

Motivation

Additional Notes

Contributor Checklist

Jira ticket: PROF-10861

@richardstartin richardstartin requested a review from a team as a code owner November 7, 2024 09:36
@pr-commenter
Copy link

pr-commenter bot commented Nov 7, 2024

Benchmarks

Startup

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master rgs/swallow-profiler-exceptions
git_commit_date 1730965224 1730972109
git_commit_sha 8e1ab2b 00e4e5a
release_version 1.43.0-SNAPSHOT~8e1ab2bcd8 1.43.0-SNAPSHOT~00e4e5a408
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1730974556 1730974556
ci_job_id 698583638 698583638
ci_pipeline_id 48430210 48430210
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
module Agent Agent
parent None None
variant iast iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 54 metrics, 9 unstable metrics.

Startup time reports for insecure-bank 
gantt
    title insecure-bank - global startup overhead: candidate=1.43.0-SNAPSHOT~00e4e5a408, baseline=1.43.0-SNAPSHOT~8e1ab2bcd8

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.081 s) : 0, 1081446
Total [baseline] (8.568 s) : 0, 8568243
Agent [candidate] (1.08 s) : 0, 1079996
Total [candidate] (8.567 s) : 0, 8566956
section iast
Agent [baseline] (1.203 s) : 0, 1202518
Total [baseline] (9.127 s) : 0, 9126826
Agent [candidate] (1.206 s) : 0, 1205606
Total [candidate] (9.155 s) : 0, 9155076
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.206 s) : 0, 1205525
Total [baseline] (9.142 s) : 0, 9141803
Agent [candidate] (1.207 s) : 0, 1207458
Total [candidate] (9.131 s) : 0, 9131225
section iast_TELEMETRY_OFF
Agent [baseline] (1.203 s) : 0, 1202810
Total [baseline] (9.147 s) : 0, 9146946
Agent [candidate] (1.205 s) : 0, 1204632
Total [candidate] (9.153 s) : 0, 9153480
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.081 s -
Agent iast 1.203 s 121.073 ms (11.2%)
Agent iast_HARDCODED_SECRET_DISABLED 1.206 s 124.079 ms (11.5%)
Agent iast_TELEMETRY_OFF 1.203 s 121.364 ms (11.2%)
Total tracing 8.568 s -
Total iast 9.127 s 558.583 ms (6.5%)
Total iast_HARDCODED_SECRET_DISABLED 9.142 s 573.559 ms (6.7%)
Total iast_TELEMETRY_OFF 9.147 s 578.703 ms (6.8%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.08 s -
Agent iast 1.206 s 125.61 ms (11.6%)
Agent iast_HARDCODED_SECRET_DISABLED 1.207 s 127.462 ms (11.8%)
Agent iast_TELEMETRY_OFF 1.205 s 124.636 ms (11.5%)
Total tracing 8.567 s -
Total iast 9.155 s 588.12 ms (6.9%)
Total iast_HARDCODED_SECRET_DISABLED 9.131 s 564.27 ms (6.6%)
Total iast_TELEMETRY_OFF 9.153 s 586.524 ms (6.8%) 
gantt
    title insecure-bank - break down per module: candidate=1.43.0-SNAPSHOT~00e4e5a408, baseline=1.43.0-SNAPSHOT~8e1ab2bcd8

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (686.148 ms) : 0, 686148
BytebuddyAgent [candidate] (686.768 ms) : 0, 686768
GlobalTracer [baseline] (315.627 ms) : 0, 315627
GlobalTracer [candidate] (315.111 ms) : 0, 315111
AppSec [baseline] (54.213 ms) : 0, 54213
AppSec [candidate] (54.027 ms) : 0, 54027
Remote Config [baseline] (671.853 µs) : 0, 672
Remote Config [candidate] (669.115 µs) : 0, 669
Telemetry [baseline] (11.176 ms) : 0, 11176
Telemetry [candidate] (9.762 ms) : 0, 9762
section iast
BytebuddyAgent [baseline] (799.302 ms) : 0, 799302
BytebuddyAgent [candidate] (801.372 ms) : 0, 801372
GlobalTracer [baseline] (304.208 ms) : 0, 304208
GlobalTracer [candidate] (304.499 ms) : 0, 304499
AppSec [baseline] (56.325 ms) : 0, 56325
AppSec [candidate] (57.424 ms) : 0, 57424
Remote Config [baseline] (599.309 µs) : 0, 599
Remote Config [candidate] (614.763 µs) : 0, 615
Telemetry [baseline] (7.386 ms) : 0, 7386
Telemetry [candidate] (7.523 ms) : 0, 7523
IAST [baseline] (21.082 ms) : 0, 21082
IAST [candidate] (20.492 ms) : 0, 20492
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (801.076 ms) : 0, 801076
BytebuddyAgent [candidate] (801.951 ms) : 0, 801951
GlobalTracer [baseline] (304.862 ms) : 0, 304862
GlobalTracer [candidate] (305.457 ms) : 0, 305457
AppSec [baseline] (56.548 ms) : 0, 56548
AppSec [candidate] (57.337 ms) : 0, 57337
Remote Config [baseline] (609.08 µs) : 0, 609
Remote Config [candidate] (641.397 µs) : 0, 641
Telemetry [baseline] (7.468 ms) : 0, 7468
Telemetry [candidate] (7.591 ms) : 0, 7591
IAST [baseline] (21.305 ms) : 0, 21305
IAST [candidate] (20.778 ms) : 0, 20778
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (798.51 ms) : 0, 798510
BytebuddyAgent [candidate] (799.56 ms) : 0, 799560
GlobalTracer [baseline] (304.672 ms) : 0, 304672
GlobalTracer [candidate] (305.031 ms) : 0, 305031
AppSec [baseline] (57.69 ms) : 0, 57690
AppSec [candidate] (57.17 ms) : 0, 57170
Remote Config [baseline] (607.472 µs) : 0, 607
Remote Config [candidate] (606.644 µs) : 0, 607
Telemetry [baseline] (7.481 ms) : 0, 7481
Telemetry [candidate] (8.181 ms) : 0, 8181
IAST [baseline] (20.192 ms) : 0, 20192
IAST [candidate] (20.405 ms) : 0, 20405
Loading
Startup time reports for petclinic 
gantt
    title petclinic - global startup overhead: candidate=1.43.0-SNAPSHOT~00e4e5a408, baseline=1.43.0-SNAPSHOT~8e1ab2bcd8

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.082 s) : 0, 1082049
Total [baseline] (10.359 s) : 0, 10359286
Agent [candidate] (1.08 s) : 0, 1080053
Total [candidate] (10.397 s) : 0, 10396651
section appsec
Agent [baseline] (1.217 s) : 0, 1217337
Total [baseline] (10.667 s) : 0, 10666975
Agent [candidate] (1.214 s) : 0, 1213614
Total [candidate] (10.64 s) : 0, 10639788
section iast
Agent [baseline] (1.209 s) : 0, 1208799
Total [baseline] (10.924 s) : 0, 10924133
Agent [candidate] (1.205 s) : 0, 1205434
Total [candidate] (10.932 s) : 0, 10931825
section profiling
Agent [baseline] (1.285 s) : 0, 1285405
Total [baseline] (10.797 s) : 0, 10797283
Agent [candidate] (1.28 s) : 0, 1280010
Total [candidate] (10.693 s) : 0, 10692811
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.082 s -
Agent appsec 1.217 s 135.288 ms (12.5%)
Agent iast 1.209 s 126.75 ms (11.7%)
Agent profiling 1.285 s 203.356 ms (18.8%)
Total tracing 10.359 s -
Total appsec 10.667 s 307.689 ms (3.0%)
Total iast 10.924 s 564.847 ms (5.5%)
Total profiling 10.797 s 437.997 ms (4.2%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.08 s -
Agent appsec 1.214 s 133.561 ms (12.4%)
Agent iast 1.205 s 125.381 ms (11.6%)
Agent profiling 1.28 s 199.957 ms (18.5%)
Total tracing 10.397 s -
Total appsec 10.64 s 243.136 ms (2.3%)
Total iast 10.932 s 535.173 ms (5.1%)
Total profiling 10.693 s 296.159 ms (2.8%) 
gantt
    title petclinic - break down per module: candidate=1.43.0-SNAPSHOT~00e4e5a408, baseline=1.43.0-SNAPSHOT~8e1ab2bcd8

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (686.503 ms) : 0, 686503
BytebuddyAgent [candidate] (686.065 ms) : 0, 686065
GlobalTracer [baseline] (316.023 ms) : 0, 316023
GlobalTracer [candidate] (316.355 ms) : 0, 316355
AppSec [baseline] (53.936 ms) : 0, 53936
AppSec [candidate] (54.257 ms) : 0, 54257
Remote Config [baseline] (675.04 µs) : 0, 675
Remote Config [candidate] (670.544 µs) : 0, 671
Telemetry [baseline] (11.27 ms) : 0, 11270
Telemetry [candidate] (9.044 ms) : 0, 9044
section appsec
BytebuddyAgent [baseline] (705.739 ms) : 0, 705739
BytebuddyAgent [candidate] (703.04 ms) : 0, 703040
GlobalTracer [baseline] (313.719 ms) : 0, 313719
GlobalTracer [candidate] (313.47 ms) : 0, 313470
AppSec [baseline] (166.124 ms) : 0, 166124
AppSec [candidate] (165.436 ms) : 0, 165436
Remote Config [baseline] (637.411 µs) : 0, 637
Remote Config [candidate] (636.324 µs) : 0, 636
Telemetry [baseline] (7.397 ms) : 0, 7397
Telemetry [candidate] (7.39 ms) : 0, 7390
IAST [baseline] (20.128 ms) : 0, 20128
IAST [candidate] (20.025 ms) : 0, 20025
section iast
BytebuddyAgent [baseline] (804.245 ms) : 0, 804245
BytebuddyAgent [candidate] (800.957 ms) : 0, 800957
GlobalTracer [baseline] (305.068 ms) : 0, 305068
GlobalTracer [candidate] (304.774 ms) : 0, 304774
AppSec [baseline] (56.53 ms) : 0, 56530
AppSec [candidate] (55.686 ms) : 0, 55686
Remote Config [baseline] (611.048 µs) : 0, 611
Remote Config [candidate] (620.999 µs) : 0, 621
Telemetry [baseline] (7.347 ms) : 0, 7347
Telemetry [candidate] (7.397 ms) : 0, 7397
IAST [baseline] (21.354 ms) : 0, 21354
IAST [candidate] (22.343 ms) : 0, 22343
section profiling
BytebuddyAgent [baseline] (686.195 ms) : 0, 686195
BytebuddyAgent [candidate] (682.699 ms) : 0, 682699
GlobalTracer [baseline] (399.55 ms) : 0, 399550
GlobalTracer [candidate] (398.821 ms) : 0, 398821
AppSec [baseline] (54.721 ms) : 0, 54721
AppSec [candidate] (54.695 ms) : 0, 54695
Remote Config [baseline] (684.254 µs) : 0, 684
Remote Config [candidate] (677.598 µs) : 0, 678
Telemetry [baseline] (10.657 ms) : 0, 10657
Telemetry [candidate] (11.874 ms) : 0, 11874
ProfilingAgent [baseline] (94.506 ms) : 0, 94506
ProfilingAgent [candidate] (92.419 ms) : 0, 92419
Profiling [baseline] (94.529 ms) : 0, 94529
Profiling [candidate] (92.444 ms) : 0, 92444
Loading

Load

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
end_time 2024-11-07T09:46:15 2024-11-07T09:53:08
git_branch master rgs/swallow-profiler-exceptions
git_commit_date 1730965224 1730972109
git_commit_sha 8e1ab2b 00e4e5a
release_version 1.43.0-SNAPSHOT~8e1ab2bcd8 1.43.0-SNAPSHOT~00e4e5a408
start_time 2024-11-07T09:46:01 2024-11-07T09:52:54
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1730973537 1730973537
ci_job_id 698583639 698583639
ci_pipeline_id 48430210 48430210
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
variant iast iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 17 unstable metrics.

Request duration reports for insecure-bank 
gantt
    title insecure-bank - request duration [CI 0.99] : candidate=1.43.0-SNAPSHOT~00e4e5a408, baseline=1.43.0-SNAPSHOT~8e1ab2bcd8
    dateFormat X
    axisFormat %s
section baseline
no_agent (364.767 µs) : 345, 385
.   : milestone, 365,
iast (484.383 µs) : 463, 506
.   : milestone, 484,
iast_FULL (639.507 µs) : 618, 661
.   : milestone, 640,
iast_GLOBAL (507.408 µs) : 486, 528
.   : milestone, 507,
iast_HARDCODED_SECRET_DISABLED (498.334 µs) : 477, 520
.   : milestone, 498,
iast_INACTIVE (438.834 µs) : 418, 459
.   : milestone, 439,
iast_TELEMETRY_OFF (474.311 µs) : 453, 496
.   : milestone, 474,
tracing (436.511 µs) : 416, 457
.   : milestone, 437,
section candidate
no_agent (371.114 µs) : 352, 390
.   : milestone, 371,
iast (488.417 µs) : 467, 510
.   : milestone, 488,
iast_FULL (643.075 µs) : 622, 664
.   : milestone, 643,
iast_GLOBAL (515.688 µs) : 494, 538
.   : milestone, 516,
iast_HARDCODED_SECRET_DISABLED (486.14 µs) : 465, 507
.   : milestone, 486,
iast_INACTIVE (445.38 µs) : 424, 467
.   : milestone, 445,
iast_TELEMETRY_OFF (470.283 µs) : 449, 491
.   : milestone, 470,
tracing (441.807 µs) : 421, 463
.   : milestone, 442,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 364.767 µs [344.848 µs, 384.686 µs] -
iast 484.383 µs [463.02 µs, 505.747 µs] 119.617 µs (32.8%)
iast_FULL 639.507 µs [618.346 µs, 660.669 µs] 274.74 µs (75.3%)
iast_GLOBAL 507.408 µs [486.344 µs, 528.473 µs] 142.641 µs (39.1%)
iast_HARDCODED_SECRET_DISABLED 498.334 µs [477.089 µs, 519.58 µs] 133.568 µs (36.6%)
iast_INACTIVE 438.834 µs [418.239 µs, 459.43 µs] 74.067 µs (20.3%)
iast_TELEMETRY_OFF 474.311 µs [452.634 µs, 495.988 µs] 109.544 µs (30.0%)
tracing 436.511 µs [415.765 µs, 457.256 µs] 71.744 µs (19.7%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 371.114 µs [351.76 µs, 390.469 µs] -
iast 488.417 µs [466.591 µs, 510.243 µs] 117.303 µs (31.6%)
iast_FULL 643.075 µs [621.843 µs, 664.306 µs] 271.96 µs (73.3%)
iast_GLOBAL 515.688 µs [493.525 µs, 537.852 µs] 144.574 µs (39.0%)
iast_HARDCODED_SECRET_DISABLED 486.14 µs [464.87 µs, 507.409 µs] 115.025 µs (31.0%)
iast_INACTIVE 445.38 µs [423.868 µs, 466.892 µs] 74.266 µs (20.0%)
iast_TELEMETRY_OFF 470.283 µs [449.163 µs, 491.403 µs] 99.169 µs (26.7%)
tracing 441.807 µs [420.689 µs, 462.925 µs] 70.693 µs (19.0%)
Request duration reports for petclinic 
gantt
    title petclinic - request duration [CI 0.99] : candidate=1.43.0-SNAPSHOT~00e4e5a408, baseline=1.43.0-SNAPSHOT~8e1ab2bcd8
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.348 ms) : 1328, 1367
.   : milestone, 1348,
appsec (1.739 ms) : 1715, 1764
.   : milestone, 1739,
appsec_no_iast (1.717 ms) : 1692, 1741
.   : milestone, 1717,
iast (1.476 ms) : 1454, 1499
.   : milestone, 1476,
profiling (1.499 ms) : 1477, 1522
.   : milestone, 1499,
tracing (1.473 ms) : 1449, 1497
.   : milestone, 1473,
section candidate
no_agent (1.341 ms) : 1322, 1361
.   : milestone, 1341,
appsec (1.719 ms) : 1693, 1744
.   : milestone, 1719,
appsec_no_iast (1.744 ms) : 1720, 1768
.   : milestone, 1744,
iast (1.469 ms) : 1446, 1492
.   : milestone, 1469,
profiling (1.48 ms) : 1458, 1503
.   : milestone, 1480,
tracing (1.483 ms) : 1459, 1507
.   : milestone, 1483,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.348 ms [1.328 ms, 1.367 ms] -
appsec 1.739 ms [1.715 ms, 1.764 ms] 391.526 µs (29.1%)
appsec_no_iast 1.717 ms [1.692 ms, 1.741 ms] 368.989 µs (27.4%)
iast 1.476 ms [1.454 ms, 1.499 ms] 128.773 µs (9.6%)
profiling 1.499 ms [1.477 ms, 1.522 ms] 151.745 µs (11.3%)
tracing 1.473 ms [1.449 ms, 1.497 ms] 125.104 µs (9.3%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.341 ms [1.322 ms, 1.361 ms] -
appsec 1.719 ms [1.693 ms, 1.744 ms] 377.726 µs (28.2%)
appsec_no_iast 1.744 ms [1.72 ms, 1.768 ms] 402.586 µs (30.0%)
iast 1.469 ms [1.446 ms, 1.492 ms] 127.748 µs (9.5%)
profiling 1.48 ms [1.458 ms, 1.503 ms] 139.223 µs (10.4%)
tracing 1.483 ms [1.459 ms, 1.507 ms] 141.831 µs (10.6%)

Dacapo

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master rgs/swallow-profiler-exceptions
git_commit_date 1730965224 1730972109
git_commit_sha 8e1ab2b 00e4e5a
release_version 1.43.0-SNAPSHOT~8e1ab2bcd8 1.43.0-SNAPSHOT~00e4e5a408
See matching parameters
Baseline Candidate
application biojava biojava
ci_job_date 1730974058 1730974058
ci_job_id 698583640 698583640
ci_pipeline_id 48430210 48430210
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
variant appsec appsec

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics.

Execution time for biojava 
gantt
    title biojava - execution time [CI 0.99] : candidate=1.43.0-SNAPSHOT~00e4e5a408, baseline=1.43.0-SNAPSHOT~8e1ab2bcd8
    dateFormat X
    axisFormat %s
section baseline
no_agent (15.382 s) : 15382000, 15382000
.   : milestone, 15382000,
appsec (15.291 s) : 15291000, 15291000
.   : milestone, 15291000,
iast (18.768 s) : 18768000, 18768000
.   : milestone, 18768000,
iast_GLOBAL (18.145 s) : 18145000, 18145000
.   : milestone, 18145000,
profiling (15.548 s) : 15548000, 15548000
.   : milestone, 15548000,
tracing (15.183 s) : 15183000, 15183000
.   : milestone, 15183000,
section candidate
no_agent (15.487 s) : 15487000, 15487000
.   : milestone, 15487000,
appsec (15.369 s) : 15369000, 15369000
.   : milestone, 15369000,
iast (18.928 s) : 18928000, 18928000
.   : milestone, 18928000,
iast_GLOBAL (18.432 s) : 18432000, 18432000
.   : milestone, 18432000,
profiling (15.142 s) : 15142000, 15142000
.   : milestone, 15142000,
tracing (15.459 s) : 15459000, 15459000
.   : milestone, 15459000,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 15.382 s [15.382 s, 15.382 s] -
appsec 15.291 s [15.291 s, 15.291 s] -91.0 ms (-0.6%)
iast 18.768 s [18.768 s, 18.768 s] 3.386 s (22.0%)
iast_GLOBAL 18.145 s [18.145 s, 18.145 s] 2.763 s (18.0%)
profiling 15.548 s [15.548 s, 15.548 s] 166.0 ms (1.1%)
tracing 15.183 s [15.183 s, 15.183 s] -199.0 ms (-1.3%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 15.487 s [15.487 s, 15.487 s] -
appsec 15.369 s [15.369 s, 15.369 s] -118.0 ms (-0.8%)
iast 18.928 s [18.928 s, 18.928 s] 3.441 s (22.2%)
iast_GLOBAL 18.432 s [18.432 s, 18.432 s] 2.945 s (19.0%)
profiling 15.142 s [15.142 s, 15.142 s] -345.0 ms (-2.2%)
tracing 15.459 s [15.459 s, 15.459 s] -28.0 ms (-0.2%)
Execution time for tomcat 
gantt
    title tomcat - execution time [CI 0.99] : candidate=1.43.0-SNAPSHOT~00e4e5a408, baseline=1.43.0-SNAPSHOT~8e1ab2bcd8
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.467 ms) : 1456, 1479
.   : milestone, 1467,
appsec (2.352 ms) : 2309, 2394
.   : milestone, 2352,
iast (2.085 ms) : 2032, 2138
.   : milestone, 2085,
iast_GLOBAL (2.12 ms) : 2068, 2173
.   : milestone, 2120,
profiling (1.937 ms) : 1896, 1979
.   : milestone, 1937,
tracing (1.924 ms) : 1884, 1964
.   : milestone, 1924,
section candidate
no_agent (1.473 ms) : 1462, 1485
.   : milestone, 1473,
appsec (2.35 ms) : 2308, 2392
.   : milestone, 2350,
iast (2.102 ms) : 2048, 2156
.   : milestone, 2102,
iast_GLOBAL (2.135 ms) : 2082, 2188
.   : milestone, 2135,
profiling (1.956 ms) : 1914, 1998
.   : milestone, 1956,
tracing (1.925 ms) : 1886, 1965
.   : milestone, 1925,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.467 ms [1.456 ms, 1.479 ms] -
appsec 2.352 ms [2.309 ms, 2.394 ms] 884.156 µs (60.2%)
iast 2.085 ms [2.032 ms, 2.138 ms] 617.438 µs (42.1%)
iast_GLOBAL 2.12 ms [2.068 ms, 2.173 ms] 652.978 µs (44.5%)
profiling 1.937 ms [1.896 ms, 1.979 ms] 469.94 µs (32.0%)
tracing 1.924 ms [1.884 ms, 1.964 ms] 456.286 µs (31.1%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.473 ms [1.462 ms, 1.485 ms] -
appsec 2.35 ms [2.308 ms, 2.392 ms] 876.808 µs (59.5%)
iast 2.102 ms [2.048 ms, 2.156 ms] 628.789 µs (42.7%)
iast_GLOBAL 2.135 ms [2.082 ms, 2.188 ms] 661.275 µs (44.9%)
profiling 1.956 ms [1.914 ms, 1.998 ms] 482.875 µs (32.8%)
tracing 1.925 ms [1.886 ms, 1.965 ms] 451.892 µs (30.7%)

@richardstartin richardstartin merged commit 99355a3 into master Nov 7, 2024
101 of 102 checks passed
@richardstartin richardstartin deleted the rgs/swallow-profiler-exceptions branch November 7, 2024 10:57
@github-actions github-actions bot added this to the 1.43.0 milestone Nov 7, 2024
jandro996 pushed a commit that referenced this pull request Nov 11, 2024
@richardstartin @jandro996
paranoid exception handling when setting profiling thread context (#7903
da0483a 
)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jbachorik jbachorik jbachorik approved these changes

Assignees
No one assigned
Labels
comp: profiling Profiling type: enhancement
Projects
None yet
Milestone
1.43.0
Development

Successfully merging this pull request may close these issues.
3 participants
@richardstartin @jbachorik @PerfectSlayer