Use telemetry 'is_sensitive' attribute instead of redacting the crash stacktrace #7899
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MattAlp
reviewed
Nov 6, 2024
...ent-crashtracking/src/main/java/com/datadog/crashtracking/parsers/HotspotCrashLogParser.java
Show resolved
Hide resolved
MattAlp
approved these changes
Nov 6, 2024
|
@PerfectSlayer yep, working on it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What Does This Do
Removes the arbitrary redacting of the crash stacktrace
Motivation
No other runtime (but .net) does this. We have a special telemetry attribute which should route the data to an auditable org, removing the needs for redacting.
Additional Notes
The redacted stacktraces turned out to be quite useless for diagnosing the crashes we are receiving from our tracer libraries.
Contributor Checklist
type:and (comp:orinst:) labels in addition to any usefull labelsclose,fixor any linking keywords when referencing an issue.Use
solvesinstead, and assign the PR milestone to the issueJira ticket: PROF-10845